OSSForks/pytorch
1
0
Fork 0
mirror of https://github.com/zebrajr/pytorch.git synced 2025-12-07 12:21:27 +01:00
Code Issues Actions 38 Packages Projects Releases Wiki Activity
85,528 Commits 8,304 Branches 150 Tags 1.5 GiB
afa1eda901
Commit Graph

68 Commits

Author SHA1 Message Date
Xuehai Pan
754fb834db [BE][CI] bump ruff to 0.9.0: string quote styles (#144569) 
Reference: https://docs.astral.sh/ruff/formatter/#f-string-formatting

- Change the outer quotes to double quotes for nested f-strings

```diff
- f'{", ".join(args)}'
+ f"{', '.join(args)}"
```

- Change the inner quotes to double quotes for triple f-strings

```diff
  string = """
-     {', '.join(args)}
+     {", ".join(args)}
  """
```

- Join implicitly concatenated strings

```diff
- string = "short string " "short string " f"{var}"
+ string = f"short string short string {var}"
```

Pull Request resolved: https://github.com/pytorch/pytorch/pull/144569
Approved by: https://github.com/Skylion007
ghstack dependencies: #146509
 2025-02-24 19:56:09 +00:00
Aaron Gokaslan
292af3cc89 [BE][Ez]: ISC001 Auto concatenate implicit one line strings (#146408) 
Apply ruff rule about implicit string concatenation, this autofixes strings that are all the same type and on the same line. These lines are broken up likely as the result of autoformatters in the past. All fixes are automated using the autofixes in ISC001.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/146408
Approved by: https://github.com/justinchuby, https://github.com/janeyx99
 2025-02-04 19:07:04 +00:00
Xuehai Pan
dcc3cf7066 [BE] fix ruff rule E226: add missing whitespace around operator in f-strings (#144415) 
The fixes are generated by:

```bash
ruff check --fix --preview --unsafe-fixes --select=E226 .
lintrunner -a --take "RUFF,PYFMT" --all-files
```

Pull Request resolved: https://github.com/pytorch/pytorch/pull/144415
Approved by: https://github.com/huydhn, https://github.com/Skylion007
 2025-01-08 21:55:00 +00:00
Xuehai Pan
b77406a9ec [BE][CI] bump ruff to 0.8.4 (#143753) 
Changes:

1. Bump `ruff` from 0.7.4 to 0.8.4
2. Change `%`-formatted strings to f-string
3. Change arguments with the `__`-prefix to positional-only arguments with the `/` separator in function signature.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/143753
Approved by: https://github.com/Skylion007
 2024-12-24 12:24:10 +00:00
Sergii Dymchenko
727ee853b4 Apply TorchFix TOR203 fixes (#143691) 
Codemodded via `torchfix . --select=TOR203 --fix`.
This is a step to unblock https://github.com/pytorch/pytorch/pull/141076
Pull Request resolved: https://github.com/pytorch/pytorch/pull/143691
Approved by: https://github.com/malfet
 2024-12-23 18:21:03 +00:00
Tom Ritchford
498a7808ff Fix unused Python variables outside torch/ and test/ (#136359) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/136359
Approved by: https://github.com/albanD
 2024-12-11 17:10:23 +00:00
Xuehai Pan
267f82b860 [BE] Format .ci/ / .github/ / benchmarks/ / functorch/ / tools/ / torchgen/ with ruff format (#132577) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/132577
Approved by: https://github.com/malfet
 2024-10-11 18:30:26 +00:00
Oguz Ulgen
a6985c09cb Add None return type to init -- functorch and torchgen (#132351) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/132351
Approved by: https://github.com/jamesjwu
ghstack dependencies: #132335
 2024-08-01 15:26:45 +00:00
Xuehai Pan
740fb22966 [BE][Easy][4/19] enforce style for empty lines in import segments in functorch/ (#129755) 
See https://github.com/pytorch/pytorch/pull/129751#issue-2380881501. Most changes are auto-generated by linter.

You can review these PRs via:

```bash
git diff --ignore-all-space --ignore-blank-lines HEAD~1
```

Pull Request resolved: https://github.com/pytorch/pytorch/pull/129755
Approved by: https://github.com/zou3519
ghstack dependencies: #129752
 2024-07-18 05:08:03 +00:00
Xuehai Pan
26f4f10ac8 [5/N][Easy] fix typo for usort config in pyproject.toml (kown -> known): sort torch (#127126) 
The `usort` config in `pyproject.toml` has no effect due to a typo. Fixing the typo make `usort` do more and generate the changes in the PR. Except `pyproject.toml`, all changes are generated by `lintrunner -a --take UFMT --all-files`.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/127126
Approved by: https://github.com/kit1980
 2024-05-27 14:49:57 +00:00
PyTorch MergeBot
55c0ab2887 Revert "[5/N][Easy] fix typo for usort config in pyproject.toml (kown -> known): sort torch (#127126)" 
This reverts commit 7763c83af6.

Reverted https://github.com/pytorch/pytorch/pull/127126 on behalf of https://github.com/XuehaiPan due to Broken CI ([comment](https://github.com/pytorch/pytorch/pull/127126#issuecomment-2133044286))
 2024-05-27 09:22:08 +00:00
Xuehai Pan
7763c83af6 [5/N][Easy] fix typo for usort config in pyproject.toml (kown -> known): sort torch (#127126) 
The `usort` config in `pyproject.toml` has no effect due to a typo. Fixing the typo make `usort` do more and generate the changes in the PR. Except `pyproject.toml`, all changes are generated by `lintrunner -a --take UFMT --all-files`.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/127126
Approved by: https://github.com/kit1980
ghstack dependencies: #127122, #127123, #127124, #127125
 2024-05-27 04:22:18 +00:00
Xuehai Pan
a28bfb5ed5 [4/N][Easy] fix typo for usort config in pyproject.toml (kown -> known): sort functorch (#127125) 
The `usort` config in `pyproject.toml` has no effect due to a typo. Fixing the typo make `usort` do more and generate the changes in the PR. Except `pyproject.toml`, all changes are generated by `lintrunner -a --take UFMT --all-files`.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/127125
Approved by: https://github.com/Skylion007
ghstack dependencies: #127122, #127123, #127124
 2024-05-25 22:45:38 +00:00
Igor Sugak
4a17693d19 [CODEMOD][caffe2] replace uses of np.float with np.float64 (#112675) 
Differential Revision: D50752096

Pull Request resolved: https://github.com/pytorch/pytorch/pull/112675
Approved by: https://github.com/Skylion007
 2023-11-03 03:00:51 +00:00
Edward Z. Yang
e6ec0efaf8 Apply UFMT to all non test/torch files (#106205) 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: https://github.com/pytorch/pytorch/pull/106205
Approved by: https://github.com/albanD
 2023-07-29 02:56:24 +00:00
Justin Chu
4cc1745b13 [BE] f-stringify torch/ and scripts (#105538) 
This PR is a follow up on the pyupgrade series to convert more strings to use f-strings using `flynt`.

- https://docs.python.org/3/reference/lexical_analysis.html#f-strings
- https://pypi.org/project/flynt/

Command used:

```
flynt torch/ -ll 120
flynt scripts/ -ll 120
flynt tools/ -ll 120
```

and excluded `collect_env.py`

Pull Request resolved: https://github.com/pytorch/pytorch/pull/105538
Approved by: https://github.com/ezyang, https://github.com/malfet
 2023-07-21 19:35:24 +00:00
Justin Chu
8a688277a2 [BE] Enable ruff's UP rules and autoformat dynamo / functorch and refs (#105432) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/105432
Approved by: https://github.com/ezyang
 2023-07-19 13:48:44 +00:00
Omkar Salpekar
ae1ed27756 [codemod][numpy] replace np.str with str (#103931) 
Summary:
`np.str` is removed from numpy 1.20.0. It was an alias to builtin `str` and it's safe to do the replacement.

The whole changes is mechanical, generated using the following onliner:
```
fbgr -sl 'np\.str\b' | xargs perl -pi -e 's,\bnp\.str\b,str,g'
```

Test Plan: sandcastle

Differential Revision: D46586144

Pull Request resolved: https://github.com/pytorch/pytorch/pull/103931
Approved by: https://github.com/huydhn
 2023-06-21 18:16:42 +00:00
Aaron Gokaslan
5471621497 [BE] Remove unnecessary dict comprehensions (#97116) 
Removes unnecessary dict comprehensions that optimize creation of dicts from iterables

Pull Request resolved: https://github.com/pytorch/pytorch/pull/97116
Approved by: https://github.com/kit1980
 2023-03-20 00:56:57 +00:00
Xuehai Pan
5b1cedacde [BE] [2/3] Rewrite super() calls in functorch and torch (#94588) 
Rewrite Python built-in class `super()` calls. Only non-semantic changes should be applied.

- #94587
- #94588
- #94592

Also, methods with only a `super()` call are removed:

```diff
class MyModule(nn.Module):
-   def __init__(self):
-       super().__init__()
-
    def forward(self, ...):
        ...
```

Some cases that change the semantics should be kept unchanged. E.g.:

f152a79be9/caffe2/python/net_printer.py (L184-L190)

f152a79be9/test/test_jit_fuser_te.py (L2628-L2635)

Pull Request resolved: https://github.com/pytorch/pytorch/pull/94588
Approved by: https://github.com/ezyang, https://github.com/albanD
 2023-02-10 21:16:33 +00:00
Xuehai Pan
a229b4526f [BE] Prefer dash over underscore in command-line options (#94505) 
Preferring dash over underscore in command-line options. Add `--command-arg-name` to the argument parser. The old arguments with underscores `--command_arg_name` are kept for backward compatibility.

Both dashes and underscores are used in the PyTorch codebase. Some argument parsers only have dashes or only have underscores in arguments. For example, the `torchrun` utility for distributed training only accepts underscore arguments (e.g., `--master_port`). The dashes are more common in other command-line tools. And it looks to be the default choice in the Python standard library:

`argparse.BooleanOptionalAction`: 4a9dff0e5a/Lib/argparse.py (L893-L895)

```python
class BooleanOptionalAction(Action):
    def __init__(...):
            if option_string.startswith('--'):
                option_string = '--no-' + option_string[2:]
                _option_strings.append(option_string)
```

It adds `--no-argname`, not `--no_argname`. Also typing `_` need to press the shift or the caps-lock key than `-`.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/94505
Approved by: https://github.com/ezyang, https://github.com/seemethere
 2023-02-09 20:16:49 +00:00
Nikita Shulga
fde220ca44 [BE] Get rid of six in caffe2 code (#93956) 
Mostly `s/string_types/str/` `s/binary_types/bytes/` and `s/text_types/str/`
Also `y.extend([str(x) for x in foo])`->`y.extend(map(str, foo))`
As Python-2 is long dead

Pull Request resolved: https://github.com/pytorch/pytorch/pull/93956
Approved by: https://github.com/albanD, https://github.com/Skylion007
 2023-02-02 22:13:37 +00:00
samdow
39524f20de [functorch] excise remaining functorch imports from examples (#91282) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/91282
Approved by: https://github.com/zou3519
 2023-01-09 14:35:21 +00:00
samdow
071756c9cf [functorch] rewrite examples that use make_functional to use functional_call (#88851) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/88851
Approved by: https://github.com/zou3519
 2023-01-09 14:35:21 +00:00
samdow
162474d7fd [functorch] add new ensembling api, demonstrate in example (#88850) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/88850
Approved by: https://github.com/zou3519
 2023-01-04 00:33:14 +00:00
Sergii Dymchenko
99bd8d12e1 Fix non-existing parameters in docstrings in misc places (#91121) 
This should be the last continuation of https://github.com/pytorch/pytorch/pull/90505

Pull Request resolved: https://github.com/pytorch/pytorch/pull/91121
Approved by: https://github.com/clee2000
 2022-12-20 02:01:37 +00:00
Philip Meier
bc73affdad prepare removal of deprecated functionality in torch.testing (#87969) 
_Redo of #86586 with all BC breaking changes granularly placed into separate commits._

---

Per title. Deprecation happened on Feb 25, 2022 in c6f1bbc0ac, which made it into the 1.12 release. Since it is now 245 days later and the next release will be 1.14, the removals later in the stack comply with the [BC policy](https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#minimizing-the-disruption-of-bc-breaking-changes).
Pull Request resolved: https://github.com/pytorch/pytorch/pull/87969
Approved by: https://github.com/mruberry
 2022-11-02 14:04:48 +00:00
Kazuaki Ishizaki
a3d495bd4e Fix typos under functorch directory (#87663) 
This PR fixes typos in `.md` and `.rst` files under functorch directory

Pull Request resolved: https://github.com/pytorch/pytorch/pull/87663
Approved by: https://github.com/kit1980
 2022-10-25 21:50:02 +00:00
Richard Zou
5e5c319549 Move functorch python bindings to torch/csrc (#85426) 
This moves functorch's python bindings to torch/csrc/functorch/init.cpp.
Coming next is the torchdim move. I didn't do torchdim yet because
moving functorch's python bindings unblocks some other things that I
want to do first.

Test Plan:
- tests
Pull Request resolved: https://github.com/pytorch/pytorch/pull/85426
Approved by: https://github.com/ezyang
 2022-09-22 18:47:12 +00:00
Sergii Dymchenko
591222f5d9 Fix use-dict-literal lint (#83718) 
Fix use-dict-literal pylint suggestions by changing `dict()` to `{}`. This PR should do the change for every Python file except test/jit/test_list_dict.py, where I think the intent is to test the constructor.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/83718
Approved by: https://github.com/albanD
 2022-08-24 00:26:46 +00:00
Richard Zou
f42ed3f98f Turn on linting for functorch (#81987) 
Test Plan:
- wait for CI
Pull Request resolved: https://github.com/pytorch/pytorch/pull/81987
Approved by: https://github.com/samdow
 2022-07-25 14:36:22 +00:00
Richard Zou
d02f085f70 [functorch] Align functorch's flake8 config with pytorch's (pytorch/functorch#963) 2022-07-21 13:41:37 -07:00
SP Liew
b9829fd397 [functorch] fix dp-sgd example (pytorch/functorch#873) 
see [this issue](https://github.com/pytorch/functorch/issues/467)
 2022-07-21 13:41:35 -07:00
Andre
1feff6bb69 [functorch] update compile example imports (pytorch/functorch#834) 2022-07-21 13:41:34 -07:00
Richard Zou
43ae23f5d4 [functorch] Remove erroneous files 2022-07-21 13:41:27 -07:00
Richard Zou
7095647db6 [functorch] Fix some lint issues (pytorch/functorch#606) 2022-07-21 13:41:26 -07:00
Samantha Andow
0af3636257 [functorch] Add Batch Norm module utilities to not track running stats (pytorch/functorch#505) 
* adds converter and tests, show omniglot wrong

* fix example to use batch norm, test to use group norm
 2022-07-21 13:41:25 -07:00
Richard Zou
db8cfb0aff [functorch] Purge some licenses 2022-07-21 13:41:22 -07:00
Richard Zou
10e383b907 [functorch] Excise prototype mentions (pytorch/functorch#478) 2022-07-21 13:41:21 -07:00
Samantha Andow
33cb1967c2 [functorch] fix small issues with examples (pytorch/functorch#464) 2022-07-21 13:41:21 -07:00
Sam Andow
75b08c9bef [functorch] update differential privacy example 2022-07-21 13:41:21 -07:00
Animesh Jain
9157be2b10 [functorch] Cleaning up TVM compiler integration (pytorch/functorch#405) 
* Cleaning up TVM compiler integration

* Linters
 2022-07-21 13:41:19 -07:00
vfdev
c94446a04d [functorch] Fixed python code formatting and added flake8 setup (pytorch/functorch#346) 
* Fixed python code formatting and added flake8 setup

* Fixes config.yaml

* Added missing setup.cfg

* Removed flake8 job from circle ci and setup GHA

* More flake8 fixes

* Fixed test_conv2d

* Fixed failing flake8
 2022-07-21 13:41:17 -07:00
samdow
b25d781d80 [functorch] cleanup unnecessary functions, examples 2022-07-21 13:41:10 -07:00
Bert Maher
033e7109a4 [functorch] Support buffers in compiled_module (pytorch/functorch#147) 
* Support buffers in compiled_module

* Don't compute gradients for inputs that don't require grad

* Add a unit test for batchnorm

* Fix eager compilation tests that change requires_grad

* Create new args for tests without recompilation

* Enable some eager fusion opinfo tests that now work (because we stopped asking for unimplemented derivatives)
 2022-07-21 13:41:06 -07:00
Horace He
90ad67843b [functorch] plumbed partition_fn through compiled_module 2022-07-21 13:41:05 -07:00
Bert Maher
acf0318fa3 [functorch] Remove some commented code (pytorch/functorch#146) 2022-07-21 13:41:05 -07:00
Bert Maher
53c9fdd24b [functorch] Introduce compiled_module for eager compilation of modules (pytorch/functorch#133) 
* Introduce compiled_module for eager compilation of modules

* Make parameters work

Co-authored-by: Horace He <horacehe2007@yahoo.com>
 2022-07-21 13:41:05 -07:00
Horace He
b23c9b907c [functorch] removed unnecessary note 2022-07-21 13:41:03 -07:00
Horace He
7e13e3c6f5 [functorch] added option to skip specialization cache 2022-07-21 13:41:03 -07:00