joncrall
ad782ff7df
Enable xdoctest runner in CI for real this time ( #83816 )
...
Builds on #83317 and enables running the doctests. Just need to figure out what is causing the failures.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/83816
Approved by: https://github.com/ezyang , https://github.com/malfet
2022-12-29 05:32:42 +00:00
Douwe den Blanken
b285f1080f
Fix small typo in comment ( #91247 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/91247
Approved by: https://github.com/albanD
2022-12-21 19:45:39 +00:00
Rohan Varma
9c80f13692
[Resubmit] state_dict_pre_hook ( #90435 )
...
Resubmit of https://github.com/pytorch/pytorch/pull/88541 which got stale.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/90435
Approved by: https://github.com/fegin
2022-12-08 07:54:14 +00:00
Shen Li
f5d18574a3
Allow Module forward-pre and forward hooks to take kwargs ( #89389 )
...
closes #35643
This PR is mostly borrowed from #82042 . Thanks @Padarn for implementing
the first version and debugging into the errors.
Based on the discussion in #82042 this PR adds a with_kwargs
argument to register_forward_pre_hook and register_forward_hook
methods. When the arg is set to true, the provided hook must accept
kwargs args. Under the hook, this PR adds a
`_forward_pre_hooks_with_kwargs` and a `_forward_hook_with_kwargs`
set to keep track of which hooks accept kwargs.
Differential Revision: [D41431111](https://our.internmc.facebook.com/intern/diff/D41431111 )
Pull Request resolved: https://github.com/pytorch/pytorch/pull/89389
Approved by: https://github.com/soulitzer
2022-11-23 02:43:32 +00:00
soulitzer
6b521bbf35
Prevent module full_backward_hook from erroring in double backward ( #88357 )
...
Also clarifies documentation to say "execute if and only if gradients wrt outputs are computed" (previously, "execute every time gradients wrt inputs are computed")
See https://docs.google.com/document/d/1tFZKYdsSzRBJ7Di7SWt8X8fSg-E3eiUPwomMF10UyhM/edit for more details regarding the question: 'should module full_backward_hooks be called every time the gradients wrt module inputs are called, or should module full_backward_hooks only be called when the "backward for the module" have been computed?'
Fixes https://github.com/pytorch/pytorch/issues/88312
Pull Request resolved: https://github.com/pytorch/pytorch/pull/88357
Approved by: https://github.com/albanD
2022-11-16 19:27:30 +00:00
Samantha Andow
87238e6491
[nn] add remove_duplicate flag to named_parameters ( #759 ) ( #88090 )
...
Summary:
X-link: https://github.com/pytorch/torchrec/pull/759
Since the remove_duplicate flag was added to named_buffers in D39493161 (c12f829ccehttps://github.com/pytorch/pytorch/pull/88090
Approved by: https://github.com/albanD
2022-11-09 00:09:20 +00:00
Kazuaki Ishizaki
2ddefbdc3c
Fix typos used in documents under torch directory ( #88300 )
...
This PR fixes typos, in comments of Python files, that are found from a search box at https://pytorch.org/docs/master/search.html
Pull Request resolved: https://github.com/pytorch/pytorch/pull/88300
Approved by: https://github.com/lezcano
2022-11-02 09:38:13 +00:00
Shen Li
82698b8954
Add prepend argument to nn.Module hooks ( #87370 )
...
cc @ezyang @gchanan
Pull Request resolved: https://github.com/pytorch/pytorch/pull/87370
Approved by: https://github.com/soulitzer
2022-10-25 19:18:04 +00:00
Antonio Kim
6b59d9b566
Fix registration hooks ( #87369 )
...
There is a bug in the implementation of the registration hooks introduced in https://github.com/pytorch/pytorch/pull/86148 whereby if the hook returns a tensor, then the short circuiting logic:
```
value = hook(self, name, value) or value
```
Raises an exception
```
RuntimeError: Boolean value of Tensor with more than one value is ambiguous
```
Fixing the logic so that it only checks to see if the value is `None` before overriding
Fixes #85837
CC: @albanD @jbschlosser
Pull Request resolved: https://github.com/pytorch/pytorch/pull/87369
Approved by: https://github.com/albanD
2022-10-21 05:12:25 +00:00
Kshiteej K
54ee95c8ec
[nn] module: full_backward_pre_hook ( #86700 )
...
Fixes https://github.com/pytorch/pytorch/issues/42824
* [x] Test
* [x] Doc
Pull Request resolved: https://github.com/pytorch/pytorch/pull/86700
Approved by: https://github.com/soulitzer
2022-10-13 17:36:39 +00:00
Antonio Kim
09a676f639
Add hooks for register_buffer/module/parameter ( #86148 )
...
As described in the issue, this PR adds hooks to be run when `register_parameter`, `register_buffer` and `register_module` are called.
Fixes #85837
cc @albanD @mruberry @jbschlosser @walterddr @kshitij12345 @saketh-are
Pull Request resolved: https://github.com/pytorch/pytorch/pull/86148
Approved by: https://github.com/albanD
2022-10-12 20:57:22 +00:00
Jerry Zhang
c12f829cce
[nn] Add remove_duplicate flag to named_buffers ( #674 ) ( #85903 )
...
Summary:
X-link: https://github.com/pytorch/torchrec/pull/674
Pull Request resolved: https://github.com/pytorch/pytorch/pull/84984
this is to allow named_buffers to return the same buffer objects with different names multiple times, needed by internal use cases
ghstack-source-id: 168589597
Test Plan:
python test/test_nn.py -k test_buffers_and_named_buffers
Imported from OSS
Reviewed By: albanD
Differential Revision: D39493161
Pull Request resolved: https://github.com/pytorch/pytorch/pull/85903
Approved by: https://github.com/albanD
2022-10-11 18:49:09 +00:00
Weiyi Zheng
b2311192e6
[NN module] speed up _load_from_state_dict ( #85743 )
...
Fixes #61398
The original implementation is very slow when the state_dict.keys() is long. This PR only passes relevant keys to the child module.
existing test passes: `pytest test/test_nn.py -k state_dict`
I couldn't figure out a good way to write a new test for this new behavior. Had a new snippet, but it will be flaky if integrated into the main CI because it's a timing based check.
But I can verify that the test took 30s to run, after this PR it only takes 0.5s.
```python
def test_load_state_dict_large(self):
# construct a module with 4 levels of module, 10 linear each, leads to 10k items in the dictionary
import copy
import time
base_module = nn.Linear(1,1)
model = base_module
for level in range(4):
model = nn.Sequential(*[copy.deepcopy(model) for _ in range(10)])
state_dict = model.state_dict()
self.assertEqual(len(state_dict), 20000)
st = time.time()
model.load_state_dict(state_dict, strict=True)
strict_load_time = time.time() - st
# it took 0.5 seconds to
self.assertLess(strict_load_time, 10)
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/85743
Approved by: https://github.com/albanD
2022-09-28 15:26:03 +00:00
joncrall
b136f3f310
More doctest refinements. ( #83317 )
...
Follow up to #82797
Now that the doctests themselves are in a better state, we should be able to enable xdoctest on the CI so they stay that way.
@ezyang @vadimkantorov
Pull Request resolved: https://github.com/pytorch/pytorch/pull/83317
Approved by: https://github.com/ezyang
2022-08-22 20:07:26 +00:00
Ian Barber
76d5699e13
Fix use-generator lint warnings in module.py ( #83700 )
...
% pylint --disable=all --enable=R1729 torch/nn/modules/module.py
Verified in pylint 2.14.5
--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/83700
Approved by: https://github.com/kit1980 , https://github.com/albanD
2022-08-19 02:51:44 +00:00
joncrall
4618371da5
Integrate xdoctest - Rebased ( #82797 )
...
This is a new version of #15648 based on the latest master branch.
Unlike the previous PR where I fixed a lot of the doctests in addition to integrating xdoctest, I'm going to reduce the scope here. I'm simply going to integrate xdoctest, and then I'm going to mark all of the failing tests as "SKIP". This will let xdoctest run on the dashboards, provide some value, and still let the dashboards pass. I'll leave fixing the doctests themselves to another PR.
In my initial commit, I do the bare minimum to get something running with failing dashboards. The few tests that I marked as skip are causing segfaults. Running xdoctest results in 293 failed, 201 passed tests. The next commits will be to disable those tests. (unfortunately I don't have a tool that will insert the `#xdoctest: +SKIP` directive over every failing test, so I'm going to do this mostly manually.)
Fixes https://github.com/pytorch/pytorch/issues/71105
@ezyang
Pull Request resolved: https://github.com/pytorch/pytorch/pull/82797
Approved by: https://github.com/ezyang
2022-08-12 02:08:01 +00:00
Alfredo Canziani
76953beee3
Update state_dict docs ( #83104 )
...
- Better definition of `state_dict`
- Additional shallow copy warning
Pull Request resolved: https://github.com/pytorch/pytorch/pull/83104
Approved by: https://github.com/jbschlosser
2022-08-10 22:24:10 +00:00
ProGamerGov
357b7d589c
Fix docstring inconsistencies: string -> str, boolean -> bool ( #82410 )
...
### Description
Throughout the PyTorch docs and codebase, the `string` type in docstrings is referred to by two separate names. This leads to inconsistent docs, like you can see here: https://pytorch.org/docs/stable/generated/torch.nn.Conv3d.html#torch.nn.Conv3d
This PR fixes this issue by ensuring that all mentions of the string type in docstrings, are using the same format that Sphinx generates hyperlinks for.
### Testing
No testing should be required for this change
Pull Request resolved: https://github.com/pytorch/pytorch/pull/82410
Approved by: https://github.com/jbschlosser
2022-07-28 21:29:57 +00:00
otaj
db52e4b7d9
Bugfix/weakref ( #80139 )
...
Fixes #78580
I'm back! :)
cc @albanD
Pull Request resolved: https://github.com/pytorch/pytorch/pull/80139
Approved by: https://github.com/albanD
2022-06-28 14:51:42 +00:00
PyTorch MergeBot
9db3c517de
Add __all__ for torch.nn.modules, torch.distributed.elastic, torch.nn.utils submodules ( #80240 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/80240
Approved by: https://github.com/rohan-varma
2022-06-27 17:11:12 +00:00
Saketh Are
817eb94ff4
Speed up module constructor by avoiding module.__setattr__ ( #77098 )
...
Module's overridden `__setattr__` has special handling for parameters, submodules, and buffers, resulting in reduces performance for its default attributes (which are not of those types). Setting them directly results in a significant improvement for module construction speed (~10x).
Pull Request resolved: https://github.com/pytorch/pytorch/pull/77098
Approved by: https://github.com/jbschlosser
2022-06-23 17:15:45 +00:00
Peter Bell
7843a5e882
Move Tensor.grad back into C++
...
`Tensor.grad` was moved to python in #30531 to add a warning. However,
that warning has since been lowered into C++ so this wrapper is no
longer necessary.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/76675
Approved by: https://github.com/albanD
2022-06-10 13:44:45 +00:00
PyTorch MergeBot
d8b80edade
Revert "Use weakref.proxy when saving module to internal dictionaries to not increase refcount ( #76435 )"
...
This reverts commit 1aa3cbb83bhttps://github.com/pytorch/pytorch/pull/76435 on behalf of https://github.com/jbschlosser
2022-05-17 17:51:26 +00:00
Rohan Varma
a275491c6f
[Reland] load_state_dict post hook ( #77392 )
...
Reland of https://github.com/pytorch/pytorch/pull/76823 with fixes to call `__setstate__` for softmax/softmin/logsoftmax as per discussion with @albanD and @jbschlosser. Original description:
Implements `register_load_state_dict_post_hook` API as discussed in https://github.com/pytorch/pytorch/issues/75287 .
Unittests cover:
- Ensuring hooks are called with the correct module
- Hook is called with `IncompatibleKeys` field
- If hook modifies this, load_state_dict returns the modified result
Pull Request resolved: https://github.com/pytorch/pytorch/pull/77392
Approved by: https://github.com/jbschlosser
2022-05-14 06:06:23 +00:00
PyTorch MergeBot
d92b0a51aa
Revert "Load state dict post hook"
...
This reverts commit 56bed0dcfehttps://github.com/pytorch/pytorch/pull/76823 on behalf of https://github.com/rohan-varma
2022-05-12 21:00:49 +00:00
otaj
1aa3cbb83b
Use weakref.proxy when saving module to internal dictionaries to not increase refcount ( #76435 )
...
Fixes #76434
Pull Request resolved: https://github.com/pytorch/pytorch/pull/76435
Approved by: https://github.com/jbschlosser
2022-05-11 18:40:59 +00:00
neverix
87e543da9b
Add load_state_dict error message for non-dicts ( #77197 )
...
Fixes #76886
Pull Request resolved: https://github.com/pytorch/pytorch/pull/77197
Approved by: https://github.com/jbschlosser
2022-05-10 22:11:51 +00:00
Rohan Varma
56bed0dcfe
Load state dict post hook
...
Implements `register_load_state_dict_post_hook` API as discussed in https://github.com/pytorch/pytorch/issues/75287 .
Unittests cover:
- Ensuring hooks are called with the correct module
- Hook is called with `IncompatibleKeys` field
- If hook modifies this, load_state_dict returns the modified result
Pull Request resolved: https://github.com/pytorch/pytorch/pull/76823
Approved by: https://github.com/albanD
2022-05-05 19:27:05 +00:00
lkct
b8776e143f
Fix false DeprecationWarning in Module.state_dict
...
Fixes #75404
TODO:
- [x] add tests
Pull Request resolved: https://github.com/pytorch/pytorch/pull/75507
Approved by: https://github.com/jbschlosser
2022-05-04 20:08:23 +00:00
Michael Suo
fb0f285638
[lint] upgrade mypy to latest version
...
Fixes https://github.com/pytorch/pytorch/issues/75927 .
Had to fix some bugs and add some ignores.
To check if clean:
```
lintrunner --paths-cmd='git grep -Il .' --take MYPY,MYPYSTRICT
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/76753
Approved by: https://github.com/malfet
2022-05-03 20:51:34 +00:00
PyTorch MergeBot
3d7428d9ac
Revert "[lint] upgrade mypy to latest version"
...
This reverts commit 9bf18aab94https://github.com/pytorch/pytorch/pull/76753 on behalf of https://github.com/suo
2022-05-03 20:01:18 +00:00
Michael Suo
9bf18aab94
[lint] upgrade mypy to latest version
...
Fixes https://github.com/pytorch/pytorch/issues/75927 .
Had to fix some bugs and add some ignores.
To check if clean:
```
lintrunner --paths-cmd='git grep -Il .' --take MYPY,MYPYSTRICT
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/76753
Approved by: https://github.com/malfet
2022-05-03 19:43:28 +00:00
lkct
9fae0762b0
fix typing in Module.state_dict and load_state_dict
...
Fixes #72707
Pull Request resolved: https://github.com/pytorch/pytorch/pull/73483
Approved by: https://github.com/albanD , https://github.com/jbschlosser
2022-05-02 17:27:54 +00:00
Zachary Ikpefua
43cc726c22
updated _forward_unim. to include descriptive error
...
Fixes #74303
Added error description for an unimplemented forward function.
_Using torch summary to test the functionality_
Before:
After:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/75148
Approved by: https://github.com/albanD
2022-04-08 20:22:47 +00:00
Anthony Barbier
ce9e27a0fc
Add new keys for Graphcore IPU (DispatchKey / Backend / DeviceType)
...
We need a key to register our out of tree backend: https://github.com/graphcore/poptorch
Pull Request resolved: https://github.com/pytorch/pytorch/pull/74763
Approved by: https://github.com/bdhirsh
2022-04-07 17:18:45 +00:00
Nikita Shulga
21a82fb519
Make torch.nn importable on Python-3.7.0
...
As `typing.OrderedDict` were introduced by Python-3.7.2+, see
https://docs.python.org/3.10/library/typing.html#typing.OrderedDict
Fixes #74087
Pull Request resolved: https://github.com/pytorch/pytorch/pull/74211
Approved by: https://github.com/suo , https://github.com/janeyx99
2022-03-15 06:12:42 +00:00
Eli Uriegas
97ade8c64c
Back out "fix: nn.Module allowing for expected Mixin MRO"
...
Summary:
Original commit changeset: 54741d983477
Original Phabricator Diff: D34822179
(Note: this ignores all push blocking failures!)
Test Plan: good_testplan
Reviewed By: osalpekar
Differential Revision: D34866030
fbshipit-source-id: 852182b90634873e51634228c33adbb72c5111c7
(cherry picked from commit 28f9a000c06f9c8e6477f369407036c9e54aec27)
2022-03-14 17:39:24 +00:00
MattiaSarti
1ac519e6b5
fix: nn.Module allowing for expected Mixin MRO
...
## Description
This pull request solves #74036
## How Functionality Changes Were Tested
Running:
```
from torch import nn
class A:
def __init__(self):
super().__init__()
self.a = True
class B(A, nn.Module):
def __init__(self):
super().__init__()
self.b = True
class C(nn.Module, A):
def __init__(self):
super().__init__()
self.c = True
b = B()
c = C()
print(b.b)
print(b.a)
print(c.c)
print(c.a)
```
- ### Results - Before:
```
>>> from torch import nn
>>>
>>>
>>> class A:
... def __init__(self):
... super().__init__()
... self.a = True
...
>>>
>>> class B(A, nn.Module):
... def __init__(self):
... super().__init__()
... self.b = True
...
>>>
>>> class C(nn.Module, A):
... def __init__(self):
... super().__init__()
... self.c = True
...
>>>
>>> b = B()
>>> c = C()
>>>
>>> print(b.b)
True
>>> print(b.a)
True
>>>
>>> print(c.c)
True
>>> print(c.a)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/pytorch/torch/nn/modules/module.py", line 1188, in __getattr__
raise AttributeError("'{}' object has no attribute '{}'".format(
AttributeError: 'C' object has no attribute 'a'
```
- ### Results - After:
```
>>> from torch import nn
>>>
>>>
>>> class A:
... def __init__(self):
... super().__init__()
... self.a = True
...
>>>
>>> class B(A, nn.Module):
... def __init__(self):
... super().__init__()
... self.b = True
...
>>>
>>> class C(nn.Module, A):
... def __init__(self):
... super().__init__()
... self.c = True
...
>>>
>>> b = B()
>>> c = C()
>>>
>>> print(b.b)
True
>>> print(b.a)
True
>>>
>>> print(c.c)
True
>>> print(c.a)
True
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/74096
Approved by: https://github.com/albanD
2022-03-11 15:32:05 +00:00
Thiago Crepaldi
3c45fc8e20
Fix URL for creating github issues
...
Minor typos for the URL that allows users to create new issues on PyTorch's GH issues page
Pull Request resolved: https://github.com/pytorch/pytorch/pull/73411
2022-02-25 16:19:03 +00:00
lkct
9d6639abcd
Fix nn.Module.state_dict() ( #72780 )
...
Summary:
Fixes https://github.com/pytorch/pytorch/issues/72778
TODO
- [x] Waiting for a conclusion from discussion in the issue.
- [x] Still bugs in handling misplaced args. Need a re-design to cover all corner cases.
TODO changes
- [x] Put deprecated signature to the second.
- [x] Change to kwargs, positional deprecated
- [x] `DeprecationWarning` add comment on why not use it
- [x] Remove unnecessary comments.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/72780
Reviewed By: george-qi
Differential Revision: D34398656
Pulled By: albanD
fbshipit-source-id: e8f2708e3dfd925ff354e098a66905f9775f4e0a
(cherry picked from commit 7f8eaf05fc48b333d22a07af57a7024b8b9ec6bf)
2022-02-23 22:32:06 +00:00
vfdev
af3ca50291
Fixed docstring typo for nn.Module.get_submodule ( #73018 )
...
Summary:
Description:
- Fixed docstring typo for nn.Module.get_submodule
otherwise output is invisible: https://pytorch.org/docs/stable/generated/torch.nn.Module.html#torch.nn.Module.get_submodule
Pull Request resolved: https://github.com/pytorch/pytorch/pull/73018
Reviewed By: davidberard98
Differential Revision: D34310091
Pulled By: jbschlosser
fbshipit-source-id: e35aef2b7479bdd81fb6b7ddd203bd71798769e1
(cherry picked from commit e4944e1f8e
2022-02-17 22:40:18 +00:00
lkct
352eeb2ef9
doc fix nn.Module: docstring should come after class variable ( #72912 )
...
Summary:
Fixes https://github.com/pytorch/pytorch/issues/72862
Pull Request resolved: https://github.com/pytorch/pytorch/pull/72912
Reviewed By: cpuhrsch
Differential Revision: D34286017
Pulled By: jbschlosser
fbshipit-source-id: d172f7600e7f66c30187996ee42c72bf273643cc
(cherry picked from commit d9f9b5b418
2022-02-16 23:10:38 +00:00
Brian Muse
8bf3179f6e
#71946 Remove Python 3.6 references ( #72211 )
...
Summary:
Fixes https://github.com/pytorch/pytorch/issues/71946
This commit removes some bits of code that were hard coded for Python 3.6 support from the `.circleci` and `torch` folders. It should only be merged if https://github.com/pytorch/pytorch/issues/66462 is complete.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/72211
Reviewed By: dagitses, seemethere
Differential Revision: D33982604
Pulled By: musebc
fbshipit-source-id: 8f453bf9909df615addd59538adb369c65484044
(cherry picked from commit 944a9970fe
2022-02-08 03:46:20 +00:00
Horace He
7cdbbfaee2
Revert D33716716: [pytorch][PR] Added remove_duplicate parameter to nn.Module
...
Test Plan: revert-hammer
Differential Revision:
D33716716 (7e8217549f7e8217549fc81d193bf0
2022-02-03 09:04:29 +00:00
Horace He
7e8217549f
Added remove_duplicate parameter to nn.Module ( #39 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/torchrec/pull/39
Pull Request resolved: https://github.com/facebookresearch/torchrec/pull/6
This makes it so that shared parameters get their own entry in `named_parameters`.
More broadly, this makes it so that
```
params_and_buffers = {**mod.named_named_parameters(remove_duplicate=False), **mod.named_buffers(remove_duplicate=False)}
_stateless.functional_call(mod, params_and_buffers, args, kwargs)
```
is identical to calling the original module's forwards pass.
cc pietern mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse SciPioneer H-Huang
Pull Request resolved: https://github.com/pytorch/pytorch/pull/71542
Reviewed By: jbschlosser, albanD
Differential Revision: D33716716
Pulled By: Chillee
fbshipit-source-id: ff1ed9980bd1a3f7ebaf695ee5e401202b543213
(cherry picked from commit d6e3ad3cd0
2022-02-01 18:34:58 +00:00
kshitij12345
0a2cdd18f3
nice error msg from load_state_dict for non-tensor value ( #70596 )
...
Summary:
Fixes https://github.com/pytorch/pytorch/issues/67549
Pull Request resolved: https://github.com/pytorch/pytorch/pull/70596
Reviewed By: anjali411
Differential Revision: D33710750
Pulled By: jbschlosser
fbshipit-source-id: 870b5fafffcd005fd4fcd62f865542739c133805
(cherry picked from commit da374fbc58
2022-01-21 22:02:13 +00:00
Ilya Persky
0460324b9b
Fix docs rendering for nn.Module.named_modules() ( #70491 )
...
Summary:
The documentation rendering for nn.Module.named_modules() is a bit broken, see the description of the last argument [here](https://pytorch.org/docs/stable/generated/torch.nn.Module.html#torch.nn.Module.named_modules ).
This PR fixes that.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/70491
Reviewed By: mikaylagawarecki
Differential Revision: D33349882
Pulled By: albanD
fbshipit-source-id: a46327c12e8114f7ef2055a8518c4ca9d186e669
2021-12-29 10:08:53 -08:00
Mikayla Gawarecki
3fe2ff800c
Module docs update ( #66909 )
...
Summary:
Fixes https://github.com/pytorch/pytorch/issues/37824
{F671745341}
Pull Request resolved: https://github.com/pytorch/pytorch/pull/66909
Reviewed By: anjali411
Differential Revision: D31782046
Pulled By: mikaylagawarecki
fbshipit-source-id: 009d2ea3c8a51a89786ef55bb9e88dc53aa8360f
2021-10-20 08:14:36 -07:00
Jack Kelly
7191dd2613
Update Module docstring for Python 3 ( #65748 )
...
Summary:
In Python 3, we can call `super()` without any arguments.
If I understand correctly, Python 2 is no longer supported by PyTorch, so we can change the documentation to be Python-3 only :)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/65748
Reviewed By: saketh-are
Differential Revision: D31246055
Pulled By: albanD
fbshipit-source-id: 3980def1a556d4bdfa391ea61cb2a65efa20df79
2021-09-29 13:40:15 -07:00
Rodrigo Berriel
b80bdcc73b
Add register_module alias to nn.Module ( #65174 )
...
Summary:
Fixes https://github.com/pytorch/pytorch/issues/60397 . I'm not sure how aliases are supposed to be implemented, but this is the most basic/direct way, IMO. As a side-effect, this implementation results in a "duplicate" doc entry, inheriting the one from `add_module`:
An alternative implementation could be:
```python
def register_module(self, name: str, module: Optional['Module']) -> None:
r"""Alias for :func:`add_module`."""
self.add_module(name, module)
```
which results in this documentation:
Questions:
1. Should I replicate the tests? There are two for `add_module`: [test_add_module_raises_error_if_attr_exists](873255c6d9/test/test_nn.py (L1420-L1434)873255c6d9/test/test_nn.py (L1837-L1855)https://github.com/pytorch/pytorch/blob/master/torch/distributed/nn/api/remote_module.py#L311-L312 ), which raises `NotSupported`, and there is another one in [`ConcreteModuleTypeBuilder`](873255c6d9/torch/_C/__init__.pyi.in (L468)https://github.com/pytorch/pytorch/pull/65174
Reviewed By: soulitzer
Differential Revision: D31089717
Pulled By: jbschlosser
fbshipit-source-id: abd8d14a434fd8c7efa0bd8c242df56da33491e9
2021-09-22 16:37:28 -07:00
