PyTorch MergeBot
93d3bd626e
Revert "[primTorch] Improve narrow and narrow_copy: refs, tests, docs ( #87045 )"
...
This reverts commit aa8279bcb8 .
Reverted https://github.com/pytorch/pytorch/pull/87045 on behalf of https://github.com/izaitsevfb due to BC-breaking change, D41161182
2022-11-09 20:48:32 +00:00
Nikita Karetnikov
aa8279bcb8
[primTorch] Improve narrow and narrow_copy: refs, tests, docs ( #87045 )
...
Fixes #87019 .
Pull Request resolved: https://github.com/pytorch/pytorch/pull/87045
Approved by: https://github.com/mruberry
2022-11-09 09:19:28 +00:00
Kazuaki Ishizaki
2ddefbdc3c
Fix typos used in documents under torch directory ( #88300 )
...
This PR fixes typos, in comments of Python files, that are found from a search box at https://pytorch.org/docs/master/search.html
Pull Request resolved: https://github.com/pytorch/pytorch/pull/88300
Approved by: https://github.com/lezcano
2022-11-02 09:38:13 +00:00
Jing Xu
46ce92713d
fix github bug issue 87552 ( #88059 )
...
Fixes #87552
Pull Request resolved: https://github.com/pytorch/pytorch/pull/88059
Approved by: https://github.com/jgong5 , https://github.com/ngimel
2022-10-31 04:40:54 +00:00
Edward Z. Yang
838b699e10
as_strided_scatter storage offset defaults to None not 0 ( #87481 )
...
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/87481
Approved by: https://github.com/bdhirsh
2022-10-21 20:12:40 +00:00
Mikayla Gawarecki
a77f2a95a7
Improve NestedTensor documentation ( #85186 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/85186
Approved by: https://github.com/cpuhrsch
2022-10-12 22:03:04 +00:00
Pearu Peterson
fc21cc82fc
Enable sparse_dim() and dense_dim() methods for Strided tensors ( #86203 )
...
The reason for enabling sparse/dense_dim() for strided tensors is to have more meaningful error messages:
For instance, compare
```
NotImplementedError: Could not run 'aten::sparse_dim' with arguments from the 'CPU' backend. This could be because the operator doesn't exist for this backend, or was omitted during the selective/custom build process (if using custom build). If you are a Facebook employee using PyTorch on mobile, please visit https://fburl.com/ptmfixes for possible resolutions. 'aten::sparse_dim' is only available for these backends: [SparseCPU, SparseCUDA, SparseMeta, SparseCsrCPU, SparseCsrCUDA, BackendSelect, Python, FuncTorchDynamicLayerBackMode, Functionalize, Named, Conjugate, Negative, ZeroTensor, ADInplaceOrView, AutogradOther, AutogradCPU, AutogradCUDA, AutogradHIP, AutogradXLA, AutogradMPS, AutogradIPU, AutogradXPU, AutogradHPU, AutogradVE, AutogradLazy, AutogradMeta, AutogradPrivateUse1, AutogradPrivateUse2, AutogradPrivateUse3, AutogradNestedTensor, Tracer, AutocastCPU, AutocastCUDA, FuncTorchBatched, FuncTorchVmapMode, Batched, VmapMode, FuncTorchGradWrapper, PythonTLSSnapshot, FuncTorchDynamicLayerFrontMode, PythonDispatcher].
```
[master] vs
```
RuntimeError: addmm: matrices expected, got 0D tensor
```
[this PR] where the latter message gives a hint of which function is to blame for dealing with unexpected inputs.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/86203
Approved by: https://github.com/cpuhrsch
2022-10-06 18:39:22 +00:00
foram-chandra
33404436aa
[doc] Add pin_memory and layout to new_{zeros, ones, full} ( #85605 )
...
Fixes #84986
Besides adding `pin_memory` and `layout`, I have also updated the signature to reflect keyword only arguments.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/85605
Approved by: https://github.com/lezcano , https://github.com/SherlockNoMad
2022-09-25 22:23:23 +00:00
Ivan Yashchuk
539076e2c2
Remove deprecated torch.lstsq ( #70980 )
...
The time has come to remove deprecated linear algebra related functions. This PR removes `torch.lstsq`.
There's a note in `tools/codegen/gen.py` about `lstsq` schema in `native_function.yaml` that I will not remove:
87139d8532/tools/codegen/gen.py (L734-L770)
cc @jianyuh @nikitaved @pearu @mruberry @walterddr @IvanYashchuk @xwang233 @Lezcano
Pull Request resolved: https://github.com/pytorch/pytorch/pull/70980
Approved by: https://github.com/lezcano , https://github.com/kit1980
2022-09-23 00:16:55 +00:00
Mikayla Gawarecki
77f1f98479
Re-introduce torch.Tensor.to_padded_tensor ( #85293 )
...
Differential Revision: [D39629004](https://our.internmc.facebook.com/intern/diff/D39629004 )
Pull Request resolved: https://github.com/pytorch/pytorch/pull/85293
Approved by: https://github.com/cpuhrsch
2022-09-21 18:45:56 +00:00
Sean Ross-Ross
3a51b557ef
Added docs and opinfo for narrow_copy ( #84493 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/84493
Approved by: https://github.com/amjames , https://github.com/ngimel , https://github.com/mruberry
2022-09-19 14:28:25 +00:00
Mikayla Gawarecki
e217b30b0f
Add torch.nested namespace ( #84102 )
...
First step towards #83775
- only `to_padded_tensor` is moved to the nested namespace for now
- following the schema used for `special`, `fft`, `linalg` and other namespaces, nested functions are registered in native_functions.yaml as `nested_{function_name}` and are bound to the desired Python name in
`torch/nested/__init__.py`, and the desired C++ name in `torch/csrc/api/include/torch/nested.h`.
~~**Question**: should we keep the documentation for `Tensor.to_padded_tensor` or can this deleted since it is shared by `torch.nested.to_padded_tensor`?~~
[generated nested docs](https://docs-preview.pytorch.org/84102/nested.html?highlight=nested#module-torch.nested )
Differential Revision: [D39361148](https://our.internmc.facebook.com/intern/diff/D39361148 )
Pull Request resolved: https://github.com/pytorch/pytorch/pull/84102
Approved by: https://github.com/drisspg
2022-09-12 16:31:05 +00:00
Ivan Yashchuk
01c54ad6de
Remove deprecated torch.eig ( #70982 )
...
The time has come to remove deprecated linear algebra related functions. This PR removes `torch.eig`.
cc @jianyuh @nikitaved @pearu @mruberry @walterddr @IvanYashchuk @xwang233 @Lezcano
Pull Request resolved: https://github.com/pytorch/pytorch/pull/70982
Approved by: https://github.com/Lezcano , https://github.com/malfet
2022-09-09 21:31:57 +00:00
PyTorch MergeBot
f534b2c627
Revert "Remove split functional wrapper ( #74727 )"
...
This reverts commit a58876ace7 .
Reverted https://github.com/pytorch/pytorch/pull/74727 on behalf of https://github.com/seemethere due to Fails internal use cases, might extend out to external use cases as well. Need to assess overall impact of this change more widely
2022-08-10 19:45:23 +00:00
Peter Bell
a58876ace7
Remove split functional wrapper ( #74727 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/74727
Approved by: https://github.com/albanD , https://github.com/khabinov
2022-08-10 17:57:48 +00:00
Pearu Peterson
ff5399e528
Revise sparse docs regarding Sparse Compressed tensors ( #82108 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/82108
Approved by: https://github.com/bhosmer
2022-07-29 18:15:09 +00:00
Huy Do
12cb26509a
Apply ufmt to torch internal ( #81643 )
...
This is a big bang PR, merge conflicts are probably expected and will be addressed at merge.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/81643
Approved by: https://github.com/ezyang
2022-07-22 02:19:50 +00:00
PyTorch MergeBot
7f3677d723
Revert "Remove split functional wrapper ( #74727 )"
...
This reverts commit cc3126083e .
Reverted https://github.com/pytorch/pytorch/pull/74727 on behalf of https://github.com/mehtanirav due to Breaking multiple internals builds and tests
2022-07-11 18:29:45 +00:00
Peter Bell
cc3126083e
Remove split functional wrapper ( #74727 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/74727
Approved by: https://github.com/albanD
2022-07-08 19:21:22 +00:00
Teddy Koker
0468dafeaa
Fix Tensor.scatter_add_ doc ( #80223 )
...
Current documentation writes "Adds all values from the tensor `other` into `self`" when the actual argument of the values is named `src`. Fixed by renaming `other` to `src`.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/80223
Approved by: https://github.com/mikaylagawarecki
2022-06-27 19:57:53 +00:00
Peter Bell
7843a5e882
Move Tensor.grad back into C++
...
`Tensor.grad` was moved to python in #30531 to add a warning. However,
that warning has since been lowered into C++ so this wrapper is no
longer necessary.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/76675
Approved by: https://github.com/albanD
2022-06-10 13:44:45 +00:00
vitrioil
ebb7f424b8
Add Tensor.is_cpu ( #78887 )
...
Fixes #76872
Not sure if this is also required.
ac8c6d09d1/torch/csrc/tensor/python_tensor.cpp (L146)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/78887
Approved by: https://github.com/ezyang
2022-06-06 22:01:12 +00:00
Rohit Goswami
3f58dd18dc
ENH: Add a force argument to numpy() ( #78564 )
...
**Reopened** to help with merge issues. See #59790 for full context.
Fixes #20778 . Helps #71688 .
Finalizes @martinPasen's force argument for `Tensor.numpy()`. It is set to False by default. If it's set to True then we:
1. detatch the Tensor, if requires_grad == True
2. move to cpu, if not on cpu already
3. Uses .resolve_conj() if .is_conj() == True
4. Uses .resolve_neg() if .is_neg() == True
cc @albanD
Pull Request resolved: https://github.com/pytorch/pytorch/pull/78564
Approved by: https://github.com/albanD
2022-06-06 14:14:17 +00:00
YifanShenSZ
6ba1d05fa4
to_padded_tensor doc v0 ( #78657 )
...
Fixes #76846
Pull Request resolved: https://github.com/pytorch/pytorch/pull/78657
Approved by: https://github.com/jbschlosser
2022-06-03 14:27:31 +00:00
Thomas J. Fan
3524428fad
DOC Corrects default value for storage_offset in as_strided ( #78202 )
...
Fixes #77730
Pull Request resolved: https://github.com/pytorch/pytorch/pull/78202
Approved by: https://github.com/mruberry
2022-05-31 19:28:36 +00:00
Brian Hirsh
07e4533403
reland of as_strided support for functionalization; introduce as_strided_scatter
...
This reverts commit a95f1edd85 .
Pull Request resolved: https://github.com/pytorch/pytorch/pull/78199
Approved by: https://github.com/ezyang
2022-05-24 22:40:44 +00:00
PyTorch MergeBot
a95f1edd85
Revert "as_strided support for functionalization; introduce as_strided_scatter"
...
This reverts commit 3a921f2d26 .
Reverted https://github.com/pytorch/pytorch/pull/77128 on behalf of https://github.com/suo due to This broke rocm tests on master 3a921f2d26 . rocm tests are no longer run on PRs, you should add a `ciflow/trunk` label if you want to run them
2022-05-24 20:19:12 +00:00
Brian Hirsh
3a921f2d26
as_strided support for functionalization; introduce as_strided_scatter
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/77128
Approved by: https://github.com/ezyang
2022-05-24 18:20:31 +00:00
Alban Desmaison
04ac80c73a
Fix a few issues on assert/double error/legacy constructor ( #77966 )
...
Fixes https://github.com/pytorch/pytorch/issues/77960 , https://github.com/pytorch/pytorch/issues/77957 , https://github.com/pytorch/pytorch/issues/77781
Pull Request resolved: https://github.com/pytorch/pytorch/pull/77966
Approved by: https://github.com/soulitzer , https://github.com/kulinseth
2022-05-20 20:25:12 +00:00
Christian Puhrsch
289192199a
Add to_sparse_bsr ( #77366 )
...
Conversion function of CSR to BSR.
Follow up work includes
- Conversion from strided, COO, CSC, BSC
- autograd
Pull Request resolved: https://github.com/pytorch/pytorch/pull/77366
Approved by: https://github.com/IvanYashchuk , https://github.com/mikaylagawarecki
2022-05-13 20:16:03 +00:00
Mikayla Gawarecki
841c65f499
Unprivate _index_reduce and add documentation
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/76997
Approved by: https://github.com/cpuhrsch
2022-05-13 19:48:38 +00:00
Ivan Yashchuk
890bdf13e1
Remove deprecated torch.solve ( #70986 )
...
The time has come to remove deprecated linear algebra related functions. This PR removes `torch.solve`.
cc @jianyuh @nikitaved @pearu @mruberry @walterddr @IvanYashchuk @xwang233 @Lezcano
Pull Request resolved: https://github.com/pytorch/pytorch/pull/70986
Approved by: https://github.com/Lezcano , https://github.com/albanD
2022-05-10 13:44:07 +00:00
PyTorch MergeBot
0c7c50972b
Revert "Move Tensor.grad back into C++"
...
This reverts commit 3e4bff7285 .
Reverted https://github.com/pytorch/pytorch/pull/76675 on behalf of https://github.com/albanD
2022-05-09 21:08:10 +00:00
PyTorch MergeBot
2c5bf12584
Revert "stft: remove non-center overload and python functional wrapper"
...
This reverts commit d23ecbfc9a .
Reverted https://github.com/pytorch/pytorch/pull/73434 on behalf of https://github.com/albanD
2022-05-09 19:59:46 +00:00
Peter Bell
3e4bff7285
Move Tensor.grad back into C++
...
`Tensor.grad` was moved to python in #30531 to add a warning. However,
that warning has since been lowered into C++ so this wrapper is no
longer necessary.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/76675
Approved by: https://github.com/albanD
2022-05-09 19:58:57 +00:00
Peter Bell
d23ecbfc9a
stft: remove non-center overload and python functional wrapper
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/73434
Approved by: https://github.com/anjali411
2022-05-03 14:30:35 +00:00
PyTorch MergeBot
77f23d6460
Revert "stft: remove non-center overload and python functional wrapper"
...
This reverts commit 6b7d89c4f1 .
Reverted https://github.com/pytorch/pytorch/pull/73434 on behalf of https://github.com/osalpekar
2022-04-23 23:21:27 +00:00
Peter Bell
6b7d89c4f1
stft: remove non-center overload and python functional wrapper
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/73434
Approved by: https://github.com/anjali411
2022-04-23 00:17:01 +00:00
kshitij12345
aa51704ce5
[complex32] add chalf alias for complex32 and chalf method
...
Reference: https://github.com/pytorch/pytorch/issues/74537
Adds chalf alias for complex32 and also adds method `chalf` similar to `cfloat, cdouble`
TODO:
* [x] Add docs
* [x] Add override
Pull Request resolved: https://github.com/pytorch/pytorch/pull/75320
Approved by: https://github.com/anjali411
2022-04-20 23:44:47 +00:00
Anthony Barbier
ce9e27a0fc
Add new keys for Graphcore IPU (DispatchKey / Backend / DeviceType)
...
We need a key to register our out of tree backend: https://github.com/graphcore/poptorch
Pull Request resolved: https://github.com/pytorch/pytorch/pull/74763
Approved by: https://github.com/bdhirsh
2022-04-07 17:18:45 +00:00
Mikayla Gawarecki
11f1fef981
Update documentation for scatter_reduce
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/74608
Approved by: https://github.com/cpuhrsch
2022-04-07 15:41:23 +00:00
Mikayla Gawarecki
e9a8e6f74a
Add include_self flag to scatter_reduce
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/74607
Approved by: https://github.com/cpuhrsch
2022-04-05 16:31:39 +00:00
Mikayla Gawarecki
2bfa018462
[BC-breaking] Use ScatterGatherKernel for scatter_reduce (CPU-only) ( #74226 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/74226
Update signature of `scatter_reduce_` to match `scatter_/scatter_add_`
`Tensor.scatter_reduce_(int64 dim, Tensor index, Tensor src, str reduce)`
- Add new reduction options in ScatterGatherKernel.cpp and update `scatter_reduce` to call into the cpu kernel for `scatter.reduce`
- `scatter_reduce` now has the same shape constraints as `scatter_` and `scatter_add_`
- Migrate `test/test_torch.py:test_scatter_reduce` to `test/test_scatter_gather_ops.py`
Test Plan: Imported from OSS
Reviewed By: ngimel
Differential Revision: D35222842
Pulled By: mikaylagawarecki
fbshipit-source-id: 84930add2ad30baf872c495251373313cb7428bd
(cherry picked from commit 1b45139482e22eb0dc8b6aec2a7b25a4b58e31df)
2022-04-01 05:57:45 +00:00
Christian Puhrsch
807b2e190b
Move to_sparse_csr to C++
...
Allows use of to_sparse_csr from C++
Pull Request resolved: https://github.com/pytorch/pytorch/pull/74294
Approved by: https://github.com/ngimel , https://github.com/malfet
2022-03-23 17:17:45 +00:00
Nikita Shulga
cfb6c942fe
scatter_reduce documentation (#73125 )
...
Summary:
Reland of https://github.com/pytorch/pytorch/issues/68580 (which were milestoned for 1.11) plus partial revert of https://github.com/pytorch/pytorch/pull/72543
Pull Request resolved: https://github.com/pytorch/pytorch/pull/73125
Reviewed By: bdhirsh
Differential Revision: D34355217
Pulled By: malfet
fbshipit-source-id: 325ecdeaf53183d653b44ee5e6e8839ceefd9200
(cherry picked from commit 71db31748a )
2022-02-22 19:33:46 +00:00
Nikita Shulga
cb00d9601c
Revert D33800694: [pytorch][PR] scatter_reduce documentation
...
Test Plan: revert-hammer
Differential Revision:
D33800694 (12a1df27c7 )
Original commit changeset: 2e09492a29ce
Original Phabricator Diff: D33800694 (12a1df27c7 )
fbshipit-source-id: 2a4775c0042551607fe3ab77f5bfe9f2e4b6b78e
(cherry picked from commit 4bd6c0d2bb )
2022-02-15 20:10:26 +00:00
rusty1s
12a1df27c7
scatter_reduce documentation (#68580 )
...
Summary:
Fixes https://github.com/pytorch/pytorch/issues/63780 (part 2)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/68580
Reviewed By: atalman
Differential Revision: D33800694
Pulled By: malfet
fbshipit-source-id: 2e09492a29cef115a7cca7c8209d1dcb6ae24eb9
(cherry picked from commit 696ff75940 )
2022-02-15 19:43:54 +00:00
anjali411
765669e1b9
Update docs for torch.real to indicate that it's supported for real tensors ( #71962 )
...
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/71962
Test Plan: Imported from OSS
Reviewed By: davidberard98
Differential Revision: D33846613
Pulled By: anjali411
fbshipit-source-id: a9782bf4e8a7f3ae1fcd4f7ff558ba80b6af012c
(cherry picked from commit 93ea37800f )
2022-01-28 18:46:40 +00:00
kshitij12345
d3bbb281f3
[numpy] add decimals argument to round ( #66195 )
...
Summary:
Fixes https://github.com/pytorch/pytorch/issues/65908
Added a new overload instead of updating the current signature. (Had issues with JIT and **maybe** it would have been FC breaking)
TODO:
* [x] Don't compute `std::pow(10, decimals)` for each element.
* [x] Update docs (https://docs-preview.pytorch.org/66195/generated/torch.round.html?highlight=round#torch.round )
* [x] Add tests
* ~~Should we try to make it composite?~~
* ~~Should we add specialized test with more values of `decimals` outside of OpInfo with larger range of values in input tensor?~~
cc mruberry rgommers
Pull Request resolved: https://github.com/pytorch/pytorch/pull/66195
Reviewed By: anjali411
Differential Revision: D31821385
Pulled By: mruberry
fbshipit-source-id: 9a03fcb809440f0c83530108284e69c345e1850f
(cherry picked from commit 50b67c6968 )
2022-01-26 17:35:03 +00:00
Khushi Agrawal
1b496cf158
Fixes doc errors in Tensor.triu(), Tensor.tril(), Tensor.ravel(). ( #71057 )
...
Summary:
Hi, PyTorch Team!
I am very much interested in starting up my contribution to PyTorch. I made several contributions in NumPy and CuPy, but this is my first PR towards PyTorch. I aim to contribute more in the upcoming future.
The PR fixes https://github.com/pytorch/pytorch/issues/70972 https://github.com/pytorch/pytorch/issues/70975 .
#### Aim of PR
The functions like `Tensor.ravel`, `Tensor.tril`, `Tensor.tril_`, `Tensor.triu`, and `Tensor.triu_` had a couple of typos in docs. The PR aims to resolve that.
I'm looking forward to your viewpoints. Thanks!
cc: kshitij12345 vadimkantorov Lezcano TestSomething22
cc brianjo mruberry
Pull Request resolved: https://github.com/pytorch/pytorch/pull/71057
Reviewed By: preeti1205
Differential Revision: D33502911
Pulled By: mruberry
fbshipit-source-id: 8ce0b68a29658a5a0be79bc807dfa7d71653532d
2022-01-11 07:34:59 -08:00