ProGamerGov
71d50f4f89
Change docstring type callable to Callable for consistency ( #82487 )
...
### Description
Across PyTorch's docstrings, both `callable` and `Callable` for variable types. The Callable should be capitalized as we are referring to the `Callable` type, and not the Python `callable()` function.
### Testing
There shouldn't be any testing required.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/82487
Approved by: https://github.com/albanD
2022-08-01 17:26:09 +00:00
Shen Li
1022443168
Revert D30279364: [codemod][lint][fbcode/c*] Enable BLACK by default
...
Test Plan: revert-hammer
Differential Revision:
D30279364 (b004307252
2021-08-12 11:45:01 -07:00
Zsolt Dollenstein
b004307252
[codemod][lint][fbcode/c*] Enable BLACK by default
...
Test Plan: manual inspection & sandcastle
Reviewed By: zertosh
Differential Revision: D30279364
fbshipit-source-id: c1ed77dfe43a3bde358f92737cd5535ae5d13c9a
2021-08-12 10:58:35 -07:00
Guilherme Leobas
211f35631f
Add type annotations to _tensorboard_vis.py and hipify_python.py ( #49834 )
...
Summary:
closes gh-49833
Pull Request resolved: https://github.com/pytorch/pytorch/pull/49834
Reviewed By: mruberry
Differential Revision: D25725341
Pulled By: malfet
fbshipit-source-id: 7454c7afe07a3ff829826afe02aba05b7f649d9b
2021-01-04 09:29:51 -08:00
Samuel Marks
e6779d4357
[*.py] Rename "Arguments:" to "Args:" ( #49736 )
...
Summary:
I've written custom parsers and emitters for everything from docstrings to classes and functions. However, I recently came across an issue when I was parsing/generating from the TensorFlow codebase: inconsistent use of `Args:` and `Arguments:` in its docstrings.
```sh
(pytorch#c348fae)$ for name in 'Args:' 'Arguments:'; do
printf '%-10s %04d\n' "$name" "$(rg -IFtpy --count-matches "$name" | paste -s -d+ -- | bc)"; done
Args: 1095
Arguments: 0336
```
It is easy enough to extend my parsers to support both variants, however it looks like `Arguments:` is wrong anyway, as per:
- https://google.github.io/styleguide/pyguide.html#doc-function-args @ [`ddccc0f`](https://github.com/google/styleguide/blob/ddccc0f/pyguide.md )
- https://chromium.googlesource.com/chromiumos/docs/+/master/styleguide/python.md#describing-arguments-in-docstrings @ [`9fc0fc0`](https://chromium.googlesource.com/chromiumos/docs/+/9fc0fc0/styleguide/python.md )
- https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html @ [`c0ae8e3`](https://github.com/sphinx-contrib/napoleon/blob/c0ae8e3/docs/source/example_google.rst )
Therefore, only `Args:` is valid. This PR replaces them throughout the codebase.
PS: For related PRs, see tensorflow/tensorflow/pull/45420
PPS: The trackbacks automatically appearing below are sending the same changes to other repositories in the [PyTorch](https://github.com/pytorch ) organisation.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/49736
Reviewed By: albanD
Differential Revision: D25710534
Pulled By: soumith
fbshipit-source-id: 61e8ff01abb433e9f78185c2d1d0cbd7c22c1619
2020-12-28 09:34:47 -08:00
Akihiro Nitta
f17d7a5556
Fix exception chaining in torch/ ( #43836 )
...
Summary:
## Motivation
Fixes https://github.com/pytorch/pytorch/issues/43770 .
## Description of the change
This PR fixes exception chaining only in files under `torch/` where appropriate.
To fix exception chaining, I used either:
1. `raise new_exception from old_exception` where `new_exception` itself seems not descriptive enough to debug or `old_exception` delivers valuable information.
2. `raise new_exception from None` where raising both of `new_exception` and `old_exception` seems a bit noisy and redundant.
I subjectively chose which one to use from the above options.
## List of lines containing raise in except clause:
I wrote [this simple script](https://gist.github.com/akihironitta/4223c1b32404b36c1b349d70c4c93b4d ) using [ast](https://docs.python.org/3.8/library/ast.html#module-ast ) to list lines where `raise`ing in `except` clause.
- [x] 000739c31a/torch/jit/annotations.py (L35)000739c31a/torch/jit/annotations.py (L150)000739c31a/torch/jit/annotations.py (L158)000739c31a/torch/jit/annotations.py (L231)000739c31a/torch/jit/_trace.py (L432)000739c31a/torch/nn/utils/prune.py (L192)000739c31a/torch/cuda/nvtx.py (L7)000739c31a/torch/utils/cpp_extension.py (L1537)000739c31a/torch/utils/tensorboard/_pytorch_graph.py (L292)000739c31a/torch/utils/data/dataloader.py (L835)000739c31a/torch/utils/data/dataloader.py (L849)000739c31a/torch/utils/data/dataloader.py (L856)000739c31a/torch/testing/_internal/common_utils.py (L186)000739c31a/torch/testing/_internal/common_utils.py (L189)000739c31a/torch/testing/_internal/common_utils.py (L424)000739c31a/torch/testing/_internal/common_utils.py (L1279)000739c31a/torch/testing/_internal/common_utils.py (L1283)000739c31a/torch/testing/_internal/common_utils.py (L1356)000739c31a/torch/testing/_internal/common_utils.py (L1388)000739c31a/torch/testing/_internal/common_utils.py (L1391)000739c31a/torch/testing/_internal/common_utils.py (L1412)000739c31a/torch/testing/_internal/codegen/random_topo_test.py (L310)000739c31a/torch/testing/_internal/codegen/random_topo_test.py (L329)000739c31a/torch/testing/_internal/codegen/random_topo_test.py (L332)000739c31a/torch/testing/_internal/jit_utils.py (L183)000739c31a/torch/testing/_internal/common_nn.py (L4789)000739c31a/torch/onnx/utils.py (L367)000739c31a/torch/onnx/utils.py (L659)000739c31a/torch/onnx/utils.py (L892)000739c31a/torch/onnx/utils.py (L897)000739c31a/torch/serialization.py (L108)000739c31a/torch/serialization.py (L754)000739c31a/torch/distributed/rpc/_testing/faulty_agent_backend_registry.py (L76)000739c31a/torch/distributed/rpc/backend_registry.py (L260)000739c31a/torch/distributed/distributed_c10d.py (L184)000739c31a/torch/_utils_internal.py (L57)000739c31a/torch/hub.py (L494)000739c31a/torch/contrib/_tensorboard_vis.py (L16)000739c31a/torch/distributions/lowrank_multivariate_normal.py (L100)000739c31a/torch/distributions/constraint_registry.py (L142)https://github.com/pytorch/pytorch/pull/43836
Reviewed By: ailzhang
Differential Revision: D23431212
Pulled By: malfet
fbshipit-source-id: 5f7f41b391164a5ad0efc06e55cd58c23408a921
2020-08-31 20:26:23 -07:00
Ralf Gommers
46ed3349f3
Add --check-untyped-defs to mypy.ini and test suite ( #37594 )
...
Summary:
Also move the ignores for imports to the bottom in `mypy.ini`, those are much less interesting - start with the stuff people want to work on.
Second commit tests the instructions: remove an ignore, fix the issue.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/37594
Differential Revision: D21434858
Pulled By: ezyang
fbshipit-source-id: 4f1a6868cdb4cb59d072bcf105f48c3a5ba3ff98
2020-05-07 06:36:01 -07:00
Zachary DeVito
e958ceb5d7
Remove GraphExecutor's python bindings ( #19141 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/19141
ghimport-source-id: 796a41f5514d29959af052fcf5391a2834850a80
Reviewed By: jamesr66a
Differential Revision: D14888702
Pulled By: zdevito
fbshipit-source-id: c280145f08e7bc210434d1c99396a3257b626cf9
2019-04-13 08:42:24 -07:00
Adam Paszke
9232afeffa
Add code for TensorBoard visualization of JIT GraphExecutors ( #8050 )
2018-06-02 20:55:25 +02:00
