Michael Lazos
caa57e4fcd
Add tensor step and capturable support to rmsprop ( #122264 )
...
Towards fixing https://github.com/pytorch/pytorch/issues/115679
Fixes RMSprop step update while compiling
Adds capturable support to RMSprop
Pull Request resolved: https://github.com/pytorch/pytorch/pull/122264
Approved by: https://github.com/janeyx99
2024-03-28 03:39:28 +00:00
Jon Chuang
f74d766632
feat(optim): use has_complex shortcut flag for all applicable optimizers, use _view_as_real auxiliary function ( #110706 )
...
Follow up to: https://github.com/pytorch/pytorch/pull/110607
CC: @lezcano @janeyx99
Pull Request resolved: https://github.com/pytorch/pytorch/pull/110706
Approved by: https://github.com/lezcano
2023-10-31 20:33:03 +00:00
Aaron Gokaslan
8fce9a09cd
[BE]: pyupgrade Python to 3.8 - imports and object inheritance only ( #94308 )
...
Apply parts of pyupgrade to torch (starting with the safest changes).
This PR only does two things: removes the need to inherit from object and removes unused future imports.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/94308
Approved by: https://github.com/ezyang , https://github.com/albanD
2023-02-07 21:10:56 +00:00
fduwjj
1a48ae96ba
[PT-D][Easy] Reformat the optim code within PTD code base ( #90399 )
...
Just run two commands:
```
ufmt format torch/distributed/optim/
ufmt format test/distributed/optim/
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/90399
Approved by: https://github.com/awgu
2022-12-08 06:38:59 +00:00
anjali411
93912b1a73
Add __all__ to torch.distributed submodules ( #80523 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/80523
Approved by: https://github.com/rohan-varma
2022-07-11 06:54:24 +00:00
Rob Zinkov
a1fd5b4273
Adding maximize to RMSprop ( #80326 )
...
Added the maximize flag #68052 to RMSprop optimizer and updates the respective tests.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/80326
Approved by: https://github.com/albanD
2022-07-08 08:04:26 +00:00
Mikayla Gawarecki
ce3094f5f6
Optim foreach cleanup for Rmsprop ( #70482 )
...
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/70482
Test Plan: Imported from OSS
Reviewed By: anjali411
Differential Revision: D33767862
Pulled By: mikaylagawarecki
fbshipit-source-id: 8e2e9c986d5a3774093a79755940372945f1b3a9
(cherry picked from commit baea537277
2022-02-15 18:02:08 +00:00
Andrew Gu
1b1f1e36b4
Add `allow_empty_param_list` to functional optimizers ( #62522 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/62522
Addresses https://github.com/pytorch/pytorch/issues/62481
Test Plan: Imported from OSS
Reviewed By: zou3519
Differential Revision: D30072074
Pulled By: andwgu
fbshipit-source-id: 1a5da21f9636b8d74a6b00c0f029427f0edff0e3
2021-08-09 11:18:56 -07:00
Wanchao Liang
af0f083d42
[dist_optim] fix the bug of none grads on functional optimizers ( #62249 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/62249
parameter and grads passed to torch.optim.functional should always match, we should skip the parameters that have none gradients to avoid the size mismatch
ghstack-source-id: 134452467
Test Plan: test_dist_optim_none_grads
Reviewed By: mrshenli
Differential Revision: D29929653
fbshipit-source-id: 4ca6167fecdfe1db422236655edee3aa59b8b044
2021-07-27 18:10:51 -07:00
Wanchao Liang
4611387608
[optim] take kw-only argument for functional optim APIs ( #56185 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/56185
ghstack-source-id: 126670123
Reviewed By: albanD
Differential Revision: D27802169
fbshipit-source-id: f5e1cb2046dcdeecf5f6b0f70892828bf0adb22f
2021-04-15 20:08:04 -07:00
Vincent Quenneville-Belair
50d903f19f
[optim] make functional api be private ( #51316 ) ( #51665 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/51665
This reverts commit 896f82aa92
2021-02-03 17:59:05 -08:00
Vincent Quenneville-Belair
896f82aa92
[optim] make functional api be private ( #51316 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/51316
Make optim functional API be private until we release with beta
Test Plan: Imported from OSS
Reviewed By: albanD
Differential Revision: D26213469
fbshipit-source-id: b0fd001a8362ec1c152250bcd57c7205ed893107
2021-02-03 09:29:33 -08:00
Wanchao Liang
3f982e56b1
[dist_optim] add distributed functional RMSprop optimizer ( #50619 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/50619
Add TorchScript compatible RMSprop functional optimizer to distributed optimizer
Test Plan: Imported from OSS
Reviewed By: rohan-varma
Differential Revision: D25932775
Pulled By: wanchaol
fbshipit-source-id: bd4854f9f95a740e02a1bebe24f780488460ba4d
2021-01-23 01:04:41 -08:00
