Commit Graph

23 Commits

Author SHA1 Message Date
Aaron Gokaslan
b7b2178204 [BE]: Remove useless lambdas (#113602)
Applies PLW0108 which removes useless lambda calls in Python, the rule is in preview so it is not ready to be enabled by default just yet. These are the autofixes from the rule.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/113602
Approved by: https://github.com/albanD
2023-11-14 20:06:48 +00:00
Nikita Shulga
1906eaf22f [BE] Get rid of future (#92596)
PyTorch has been Python-3.X+ for ages, so it's a shame to still rely on `future.utils` even in a deprecated Caffe2 codebase

For the reference:
https://peps.python.org/pep-0469/#migrating-directly-to-python-3

Pull Request resolved: https://github.com/pytorch/pytorch/pull/92596
Approved by: https://github.com/kit1980, https://github.com/orionr
2023-01-19 08:46:50 +00:00
Bugra Akyildiz
27c7158166 Remove __future__ imports for legacy Python2 supports (#45033)
Summary:
There is a module called `2to3` which you can target for future specifically to remove these, the directory of `caffe2` has the most redundant imports:

```2to3 -f future -w caffe2```

Pull Request resolved: https://github.com/pytorch/pytorch/pull/45033

Reviewed By: seemethere

Differential Revision: D23808648

Pulled By: bugra

fbshipit-source-id: 38971900f0fe43ab44a9168e57f2307580d36a38
2020-09-23 17:57:02 -07:00
Brian Wignall
f326045b37 Fix typos, via a Levenshtein-type corrector (#31523)
Summary:
Should be non-semantic.

Uses https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines to find likely typos, with https://github.com/bwignall/typochecker to help automate the checking.

Uses an updated version of the tool used in https://github.com/pytorch/pytorch/pull/30606 .
Pull Request resolved: https://github.com/pytorch/pytorch/pull/31523

Differential Revision: D19216749

Pulled By: mrshenli

fbshipit-source-id: 7fd489cb9a77cd7e4950c1046f925d57524960ea
2020-01-17 16:03:19 -08:00
Yinghai Lu
f435fb8290 Allow customization of blob node in net_drawer (#16915)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/16915

TSIA

Reviewed By: ipiszy

Differential Revision: D14018010

fbshipit-source-id: df5ccc06fa37f08e7a02a8acc466c4ad47afe04e
2019-02-12 15:02:50 -08:00
Orion Reblitz-Richardson
1d5780d42c Remove Apache headers from source.
* LICENSE file contains details, so removing from individual source files.
2018-03-27 13:10:18 -07:00
Dmytro Dzhulgakov
2972a6ca02 Revert D6026557: [caffe2][PR] Fix "No handlers could be found for logger"
Summary:
This reverts commit 95c634872ac02be721257169e38c8fead04cd66b

bypass-lint

Differential Revision: D6026557

fbshipit-source-id: 663c28583ce3b01070ff5449115ed7e222f71776
2017-10-12 20:21:52 -07:00
Luke Yeager
75bece6ede Fix "No handlers could be found for logger"
Summary: Closes https://github.com/caffe2/caffe2/pull/1316

Differential Revision: D6026557

Pulled By: Yangqing

fbshipit-source-id: 95c634872ac02be721257169e38c8fead04cd66b
2017-10-10 22:32:13 -07:00
Yangqing Jia
8286ce1e3a Re-license to Apache
Summary: Closes https://github.com/caffe2/caffe2/pull/1260

Differential Revision: D5906739

Pulled By: Yangqing

fbshipit-source-id: e482ba9ba60b5337d9165f28f7ec68d4518a0902
2017-09-28 16:22:00 -07:00
Thomas Dudziak
5355634dac Dict fixes/improvements and unittest targets for Python 3 in caffe2 core
Summary: As title

Reviewed By: salexspb

Differential Revision: D5316104

fbshipit-source-id: aee43819d817842e5ce6ba3d045a55b1a2491c30
2017-06-29 17:05:41 -07:00
Luke Yeager
c8f444237f net_drawer: --input is required
Summary:
Before:
```
$ python -m caffe2.python.net_drawer
Traceback (most recent call last):
  File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/data/caffe2/install/caffe2/python/net_drawer.py", line 403, in <module>
    main()
  File "/data/caffe2/install/caffe2/python/net_drawer.py", line 365, in main
    with open(args.input, 'r') as fid:
TypeError: coercing to Unicode: need string or buffer, NoneType found
```
After:
```
$ python -m caffe2.python.net_drawer
usage: net_drawer.py [-h] --input INPUT [--output_prefix OUTPUT_PREFIX]
                     [--minimal] [--minimal_dependency] [--append_output]
                     [--rankdir RANKDIR]
net_drawer.py: error: argument --input is required
```
Closes https://github.com/caffe2/caffe2/pull/479

Differential Revision: D5003898

Pulled By: pietern

fbshipit-source-id: d121c331411ba4bbded81f9658ec787fa2fd3dc1
2017-05-04 11:45:57 -07:00
Aaron Markham
58f7f2b441 doxygen python block added
Summary: Closes https://github.com/caffe2/caffe2/pull/226

Differential Revision: D4793550

Pulled By: JoelMarcey

fbshipit-source-id: cc33e58186304fa8dcac2ee9115dcc271d785b1e
2017-03-29 06:46:16 -07:00
Dmytro Dzhulgakov
535e0e486b Add model graph to dper_example
Summary:
Just the first version displays forward part of the training net. I want to refactor local/distributed code to share graph initialization and then visualize all nets individually.

Graphs don't look pretty because of a lot of DotProducts, we need to refactor it.

Reviewed By: xianjiec

Differential Revision: D4514479

fbshipit-source-id: 156bb07c62118b15022c87f197b5e378a7ef3b9f
2017-02-07 13:03:54 -08:00
Dmytro Dzhulgakov
078a8d10de Move png image to net_drawer and Flow example
Summary:
Making drawing a bit easier

Also adds a Flow example to check that PNG images are nicely rendered in lists.

Reviewed By: kennyhorror

Differential Revision: D4514470

fbshipit-source-id: 35189c4543c31a351c1dbfe804ce25ae14a3a98b
2017-02-06 18:46:48 -08:00
Minsuk (Brian) Kahng
de8cd46416 Caffe2 graph to json for visualization in flow
Summary:
- Writing a Caffe2 computation graph to json for visualization in Flow
- Example use in the Text models workflow: it replaces the existing draw function which produces PNG file
- Visualization: https://our.intern.facebook.com/intern/fblearner/c2graphvis/13215753/
- The visualization uses FBLearnerDAG. Plan to add many visualization-related features.

Reviewed By: Mortimerp9

Differential Revision: D4415299

fbshipit-source-id: 2d641d60177566ed2837fb3750394420690f28de
2017-01-25 19:44:20 -08:00
Yangqing Jia
238ceab825 fbsync. TODO: check if build files need update. 2016-11-15 00:00:46 -08:00
Yangqing Jia
d1e9215184 fbsync 2016-10-07 13:08:53 -07:00
Yangqing Jia
05512d1e10 sync 2016-08-10 11:02:15 -07:00
Yangqing Jia
bcea409c82 sync 2016-07-28 15:06:43 -07:00
Yangqing Jia
6463eebc7b chunky sync - build scripts to be written 2016-07-21 10:16:42 -07:00
Yangqing Jia
559053d3a8 chunky sync 2016-05-13 14:43:48 -07:00
Yangqing Jia
cf7ca23fc1 make caffe2.python build 2016-03-08 16:48:19 -08:00
Yangqing Jia
9ae880bb6f move pycaffe2 to caffe2.python 2016-03-08 15:45:30 -08:00