OSSForks/pytorch
1
0
Fork 0
mirror of https://github.com/zebrajr/pytorch.git synced 2025-12-06 12:20:52 +01:00
Code Issues Actions 38 Packages Projects Releases Wiki Activity
85,088 Commits 8,304 Branches 150 Tags 1.5 GiB
3f4311d589
Commit Graph

1350 Commits

Author SHA1 Message Date
Wang, Chuanqi
3f4311d589 [CD] Upgrade xpu runtime pypi packages version and enable windows kineto again (#148319) 
Fixes https://github.com/pytorch/pytorch/issues/145155

Pull Request resolved: https://github.com/pytorch/pytorch/pull/148319
Approved by: https://github.com/xuhancn, https://github.com/atalman
 2025-03-05 18:39:55 +00:00
atalman
1db3c58fab Remove manylinux 2014 artifacts (#148135) 
1. Switch Magma build to Manylinux 2.28 base
2. Use manylinux 2.28 as default in populate_binary_env.sh
3. Remove manylinux 2014 docker builds
Pull Request resolved: https://github.com/pytorch/pytorch/pull/148135
Approved by: https://github.com/malfet
 2025-02-28 13:43:14 +00:00
Camyll Harajli
b45e6fa707 Cleanup VS 2019 refs in pytorch (#145863) 
Related to: https://github.com/pytorch/pytorch/issues/128835
Follow up on PR: https://github.com/pytorch/pytorch/pull/145319
Pull Request resolved: https://github.com/pytorch/pytorch/pull/145863
Approved by: https://github.com/Skylion007, https://github.com/malfet, https://github.com/huydhn, https://github.com/atalman
 2025-02-10 19:05:35 +00:00
Catherine Lee
67ed47d886 Binary upload checksum (#144887) 
Equivalent to https://github.com/pytorch/test-infra/pull/6172 but for pytorch
Pull Request resolved: https://github.com/pytorch/pytorch/pull/144887
Approved by: https://github.com/atalman
 2025-01-31 17:51:27 +00:00
Camyll Harajli
6c09954a9e Windows builds with VS2022 (#145319) 
[Fixes #ISSUE_NUMBER
](https://github.com/pytorch/pytorch/issues/128835)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/145319
Approved by: https://github.com/huydhn
 2025-01-28 19:07:24 +00:00
PyTorch MergeBot
768ad0886f Revert "Binary upload checksum (#144887)" 
This reverts commit 2efa98d69d.

Reverted https://github.com/pytorch/pytorch/pull/144887 on behalf of https://github.com/atalman due to Broke nightly index ([comment](https://github.com/pytorch/pytorch/pull/144887#issuecomment-2610066277))
 2025-01-23 15:10:42 +00:00
Wang, Chuanqi
0802e78315 [CD] Disable Kineto for XPU Windows CD (#145255) 
Due to issue #145155, disable Kineto for XPU Windows CD temporally.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/145255
Approved by: https://github.com/xuhancn, https://github.com/atalman
 2025-01-23 14:09:52 +00:00
Catherine Lee
2efa98d69d Binary upload checksum (#144887) 
Equivalent to https://github.com/pytorch/test-infra/pull/6172 but for pytorch
Pull Request resolved: https://github.com/pytorch/pytorch/pull/144887
Approved by: https://github.com/atalman
 2025-01-22 20:46:04 +00:00
atalman
519269a415 [BE] - Remove conda test and upload scripts and env variables from Workflows Part 1 (#144870) 
Remove conda test and upload scripts and env variables from Workflows

Related to: https://github.com/pytorch/pytorch/issues/138506
Pull Request resolved: https://github.com/pytorch/pytorch/pull/144870
Approved by: https://github.com/malfet
 2025-01-16 17:20:14 +00:00
Catherine Lee
0dca756832 Revert "Upload METADATA file with whl binaries (#143677)" (#144706) 
This reverts commit 3eb3f4ed55.

Also reverts https://github.com/pytorch/pytorch/pull/144164

Manual revert because the above causes merge conflicts

Reverting in favor of https://github.com/pytorch/test-infra/pull/6159
Pull Request resolved: https://github.com/pytorch/pytorch/pull/144706
Approved by: https://github.com/janeyx99, https://github.com/atalman, https://github.com/malfet
 2025-01-15 17:20:21 +00:00
Wang, Chuanqi
b4b4e57469 [CD] Enable profiling for XPU Windows nightly wheels (#144316) 
PR https://github.com/pytorch/pytorch/pull/144034 added profiling support for torch XPU Windows binary, enable it in PyTorch XPU Windows CD
Works for https://github.com/pytorch/pytorch/issues/114850

Pull Request resolved: https://github.com/pytorch/pytorch/pull/144316
Approved by: https://github.com/xuhancn, https://github.com/atalman
 2025-01-14 19:01:27 +00:00
Catherine Lee
3eb3f4ed55 Upload METADATA file with whl binaries (#143677) 
Upload the metadata file for wheels for pep658 https://peps.python.org/pep-0658/
Using a python script but using bash might be easier...

--

Testing

Example run https://github.com/pytorch/pytorch/actions/runs/12550595201/job/34994883276 without actual upload, just dry run

Lightly tested the script to make sure it uploads to s3, but integration with the bash script + workflow is untested

Pull Request resolved: https://github.com/pytorch/pytorch/pull/143677
Approved by: https://github.com/seemethere
 2025-01-03 00:32:05 +00:00
chuanqiw
438698b20b [CD] Remove redundant triton dependency for xpu wheels (#143839) 
Due to XPU CD wheels enabled pypi dependencies by https://github.com/pytorch/pytorch/pull/141135, so the PYTORCH_EXTRA_INSTALL_REQUIREMENTS has value for XPU CD wheel build.
Works for https://github.com/pytorch/pytorch/issues/139722 and https://github.com/pytorch/pytorch/issues/114850
Fixes #143838

Pull Request resolved: https://github.com/pytorch/pytorch/pull/143839
Approved by: https://github.com/huydhn
 2024-12-30 13:39:06 +00:00
Xuehai Pan
b6bdb67f82 [BE][Easy] use pathlib.Path instead of dirname / ".." / pardir (#129374) 
Changes by apply order:

1. Replace all `".."` and `os.pardir` usage with `os.path.dirname(...)`.
2. Replace nested `os.path.dirname(os.path.dirname(...))` call with `str(Path(...).parent.parent)`.
3. Reorder `.absolute()` ~/ `.resolve()`~ and `.parent`: always resolve the path first.

    `.parent{...}.absolute()` -> `.absolute().parent{...}`

4. Replace chained `.parent x N` with `.parents[${N - 1}]`: the code is easier to read (see 5.)

    `.parent.parent.parent.parent` -> `.parents[3]`

5. ~Replace `.parents[${N - 1}]` with `.parents[${N} - 1]`: the code is easier to read and does not introduce any runtime overhead.~

    ~`.parents[3]` -> `.parents[4 - 1]`~

6. ~Replace `.parents[2 - 1]` with `.parent.parent`: because the code is shorter and easier to read.~

Pull Request resolved: https://github.com/pytorch/pytorch/pull/129374
Approved by: https://github.com/justinchuby, https://github.com/malfet
 2024-12-29 17:23:13 +00:00
PyTorch MergeBot
475656fd9c Revert "[BE][Easy] use pathlib.Path instead of dirname / ".." / pardir (#129374)" 
This reverts commit 2293fe1024.

Reverted https://github.com/pytorch/pytorch/pull/129374 on behalf of https://github.com/malfet due to failing internal ROCM builds with error: ModuleNotFoundError: No module named hipify ([comment](https://github.com/pytorch/pytorch/pull/129374#issuecomment-2562973920))
 2024-12-26 17:32:23 +00:00
PyTorch MergeBot
0ebc6388cf Revert "Exclude py 31.3t triton package from PyTorch 3.13t wheel (#143218)" 
This reverts commit 3bfdf6f063.

Reverted https://github.com/pytorch/pytorch/pull/143218 on behalf of https://github.com/atalman due to this constrain is ignored see https://github.com/pytorch/pytorch/issues/143654 ([comment](https://github.com/pytorch/pytorch/pull/143218#issuecomment-2560208992))
 2024-12-23 19:37:35 +00:00
Xuehai Pan
2293fe1024 [BE][Easy] use pathlib.Path instead of dirname / ".." / pardir (#129374) 
Changes by apply order:

1. Replace all `".."` and `os.pardir` usage with `os.path.dirname(...)`.
2. Replace nested `os.path.dirname(os.path.dirname(...))` call with `str(Path(...).parent.parent)`.
3. Reorder `.absolute()` ~/ `.resolve()`~ and `.parent`: always resolve the path first.

    `.parent{...}.absolute()` -> `.absolute().parent{...}`

4. Replace chained `.parent x N` with `.parents[${N - 1}]`: the code is easier to read (see 5.)

    `.parent.parent.parent.parent` -> `.parents[3]`

5. ~Replace `.parents[${N - 1}]` with `.parents[${N} - 1]`: the code is easier to read and does not introduce any runtime overhead.~

    ~`.parents[3]` -> `.parents[4 - 1]`~

6. ~Replace `.parents[2 - 1]` with `.parent.parent`: because the code is shorter and easier to read.~

Pull Request resolved: https://github.com/pytorch/pytorch/pull/129374
Approved by: https://github.com/justinchuby, https://github.com/malfet
 2024-12-21 22:08:01 +00:00
Nikita Shulga
58627fb6bf [BE] Integrate 5 line build script into template (#143511) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/143511
Approved by: https://github.com/kit1980, https://github.com/atalman, https://github.com/seemethere
ghstack dependencies: #143395
 2024-12-18 23:27:09 +00:00
chuanqiw
a8cc19bb51 [CD] Fix XPU linux CD whl test failure (#143268) 
Follow https://github.com/pytorch/pytorch/pull/142482, refer the original fix PR https://github.com/pytorch/pytorch/pull/130742 and new issue in https://github.com/pytorch/pytorch/actions/runs/12323126436/job/34403681230
Works for https://github.com/pytorch/pytorch/issues/114850

Pull Request resolved: https://github.com/pytorch/pytorch/pull/143268
Approved by: https://github.com/atalman
 2024-12-16 15:00:03 +00:00
atalman
3bfdf6f063 Exclude py 31.3t triton package from PyTorch 3.13t wheel (#143218) 
Follow up after https://github.com/pytorch/pytorch/pull/143162
Include triton only for 3.13 packages not 3.13t
Pull Request resolved: https://github.com/pytorch/pytorch/pull/143218
Approved by: https://github.com/kit1980
 2024-12-14 00:12:45 +00:00
Andrey Talman
04bb82f097 Linux Wheels: Remove triton dependency python < 3.13 constraint (#143162) 
We do build pytorch-triton package for python 3.13 : https://github.com/pytorch/pytorch/actions/runs/12304476674/job/34344764271
Hence constraint is no longer needed.
This stack enabled torch.compile for Python 3.13 : https://github.com/pytorch/pytorch/pull/141264
Pull Request resolved: https://github.com/pytorch/pytorch/pull/143162
Approved by: https://github.com/kit1980
 2024-12-13 15:08:44 +00:00
atalman
f57606ab85 Migrate smoke tests to pytorch/pytorch (#142482) 
Related to https://github.com/pytorch/builder/issues/2054
This should fix nightly xpu failure: https://github.com/pytorch/pytorch/actions/runs/12251477588/job/34180135207 and rocm failure: https://github.com/pytorch/pytorch/actions/runs/12251477588/job/34182185374 due to missing : `` /builder/check_binary.sh``

Builder Scripts revision: 3468139e81
Pull Request resolved: https://github.com/pytorch/pytorch/pull/142482
Approved by: https://github.com/chuanqi129, https://github.com/kit1980, https://github.com/malfet, https://github.com/jeffdaily, https://github.com/huydhn
 2024-12-10 20:43:36 +00:00
Nikita Shulga
960a81fdcd [EZ] Delete unsued binary_macos_test.sh (#142382) 
According to https://github.com/search?type=code&q=binary_macos_test.sh+repo%3Apytorch%2Fpytorch (and grep in the repo) it's not used anywhere

Pull Request resolved: https://github.com/pytorch/pytorch/pull/142382
Approved by: https://github.com/atalman
ghstack dependencies: #142276, #142277
 2024-12-09 19:37:56 +00:00
Nikita Shulga
0610b9730e Do not use builder repo for MacOS builds (#142277) 
Added c7564f31f7/wheel/build_wheel.sh to `.ci/wheel/` folder

Commented out call to 39532891a0/run_tests.sh, because since 2018 this script just checked that tests folder is there and exited, as there are no way to run all pytorch tests in single shard, see this logic:
```bash
#!/bin/bash
set -eux -o pipefail

# Essentially runs pytorch/test/run_test.py, but keeps track of which tests to
# skip in a centralized place.
#
# TODO Except for a few tests, this entire file is a giant TODO. Why are these
# tests # failing?
# TODO deal with Windows

# This script expects to be in the pytorch root folder
if [[ ! -d 'test' || ! -f 'test/run_test.py' ]]; then
    echo "builder/test.sh expects to be run from the Pytorch root directory " \
         "but I'm actually in $(pwd)"
    exit 2
fi

# Allow master skip of all tests
if [[ -n "${SKIP_ALL_TESTS:-}" ]]; then
    exit 0
fi
```

https://github.com/pytorch/pytorch/pull/123390 is a misread attempt to interpret above-mentioned logic, as run_tests will be skipped if `${SKIP_ALL_TESTS}` is a non-empty string
Pull Request resolved: https://github.com/pytorch/pytorch/pull/142277
Approved by: https://github.com/huydhn, https://github.com/atalman
ghstack dependencies: #142276
 2024-12-09 18:33:58 +00:00
atalman
ef26f1c57e Migrate windows build scripts from builder to pytorch (#142156) 
Move builder windows build scripts to pytorch/pytorch
Remove builder checkout during windows build
Pending remove windows build scripts https://github.com/pytorch/builder/tree/main/windows

Pull Request resolved: https://github.com/pytorch/pytorch/pull/142156
Approved by: https://github.com/malfet, https://github.com/chuanqi129
 2024-12-08 21:43:59 +00:00
Nikita Shulga
c6e18a1ed1 [EZ] Remove unused binary_linux_build.sh (#142276) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/142276
Approved by: https://github.com/huydhn
 2024-12-07 00:48:56 +00:00
atalman
920e4364b7 [BE] Remove "$PACKAGE_TYPE" == 'conda' logic from build scripts (#142019) 
Please see: https://github.com/pytorch/pytorch/issues/138506
Pull Request resolved: https://github.com/pytorch/pytorch/pull/142019
Approved by: https://github.com/huydhn, https://github.com/malfet
 2024-12-04 16:05:43 +00:00
chuanqiw
a23ac6f8bd [CD] Enable pypi dependencies both for XPU linux and Windows whls (#141135) 
Enable xpu runtime pypi packages as dependencies of XPU CD wheels both for Linux and Windows.
Fixes https://github.com/pytorch/pytorch/issues/135867
Works for https://github.com/pytorch/pytorch/issues/139722 and https://github.com/pytorch/pytorch/issues/114850
Pull Request resolved: https://github.com/pytorch/pytorch/pull/141135
Approved by: https://github.com/atalman
 2024-11-29 21:35:07 +00:00
Huy Do
bae9510307 Fix pytorch-triton nightly checksum shorthash (#141410) 
Binary build is failing in trunk after https://github.com/pytorch/pytorch/pull/139206 lands, for example, https://github.com/pytorch/pytorch/actions/runs/11981181986/job/33410250461#step:17:539.  It's a bit tricky to spot the issue but the difference is between `3.2.0+35c6c7c628` set by PyTorch and `3.2.0+git35c6c7c6` from triton (look closely one has the length of 10, the other of 8 characters)

Triton now has its own nightly build logic in https://github.com/triton-lang/triton/pull/4812 that takes only 8 characters by default while the original logic from PT took 10. So, PT nightly couldn't find the dependency.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/141410
Approved by: https://github.com/seemethere, https://github.com/malfet
 2024-11-23 04:56:40 +00:00
PyTorch MergeBot
66f2550328 Revert "Fix pytorch-triton nightly checksum shorthand (#141410)" 
This reverts commit 9f8a19172d.

Reverted https://github.com/pytorch/pytorch/pull/141410 on behalf of https://github.com/huydhn due to There is still a small tweak that I need to do 35c6c7c628 is now git35c6c7c6 so a prefix is needed, going to revert and reland this ([comment](https://github.com/pytorch/pytorch/pull/141410#issuecomment-2495291851))
 2024-11-23 04:16:39 +00:00
Huy Do
9f8a19172d Fix pytorch-triton nightly checksum shorthand (#141410) 
Binary build is failing in trunk after https://github.com/pytorch/pytorch/pull/139206 lands, for example, https://github.com/pytorch/pytorch/actions/runs/11981181986/job/33410250461#step:17:539.  It's a bit tricky to spot the issue but the difference is between `3.2.0+35c6c7c628` set by PyTorch and `3.2.0+git35c6c7c6` from triton (look closely one has the length of 10, the other of 8 characters)

Triton now has its own nightly build logic in https://github.com/triton-lang/triton/pull/4812 that takes only 8 characters by default while the original logic from PT took 10. So, PT nightly couldn't find the dependency.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/141410
Approved by: https://github.com/seemethere, https://github.com/malfet
 2024-11-23 03:25:52 +00:00
chuanqiw
1bdb9ddc70 [CD] Upgrade XPU support packages version to 2025.0 (#140373) 
Depends on https://github.com/pytorch/pytorch/pull/139775
Works for https://github.com/pytorch/pytorch/issues/139722 and https://github.com/pytorch/pytorch/issues/114850

Pull Request resolved: https://github.com/pytorch/pytorch/pull/140373
Approved by: https://github.com/atalman, https://github.com/malfet
 2024-11-19 05:16:46 +00:00
Max Ren
cca34be584 Update XNNPACK Version (#139913) 
Updating XNNPACK Version to 4ea82e595b36106653175dcb04b2aa532660d0d8

submodule update
Pull Request resolved: https://github.com/pytorch/pytorch/pull/139913
Approved by: https://github.com/digantdesai, https://github.com/huydhn
 2024-11-18 18:16:31 +00:00
atalman
078dca1ce8 Aarch64 binary builds - fix passing env_file to Docker (#138588) 
Aarch64 builds skipped the logic of sourcing binary env file. And as a result PYTORCH_EXTRA_INSTALL_REQUIREMENTS passed to Aarch64 builds have not included triton dependency constraint. This PR makes sure Aarch64 builds follow same path as our regular manywheel builds.

To work around this issue we had to inject triton in aarrch64 builds for release 2.5, which is not ideal: https://github.com/pytorch/builder/pull/2011
Pull Request resolved: https://github.com/pytorch/pytorch/pull/138588
Approved by: https://github.com/jeanschmidt, https://github.com/malfet
 2024-10-22 19:04:19 +00:00
atalman
63bbf712d8 Add py3.13t linux wheel build (#137127) 
Builder PR required: https://github.com/pytorch/builder/pull/2001
Test PR: https://github.com/pytorch/pytorch/pull/136490/

Pull Request resolved: https://github.com/pytorch/pytorch/pull/137127
Approved by: https://github.com/albanD
 2024-10-03 13:13:48 +00:00
PyTorch MergeBot
4559cddaf9 Revert "Add py3.13t linux wheel build (#137127)" 
This reverts commit 6b7adc1214.

Reverted https://github.com/pytorch/pytorch/pull/137127 on behalf of https://github.com/jovianjaison due to Sorry for reverting your changes but 2 jobs are failing ([comment](https://github.com/pytorch/pytorch/pull/137127#issuecomment-2389250791))
 2024-10-02 17:44:42 +00:00
atalman
6b7adc1214 Add py3.13t linux wheel build (#137127) 
Builder PR required: https://github.com/pytorch/builder/pull/2001
Test PR: https://github.com/pytorch/pytorch/pull/136490/

Pull Request resolved: https://github.com/pytorch/pytorch/pull/137127
Approved by: https://github.com/albanD
 2024-10-02 11:59:33 +00:00
Julia Guo
60a097a071 [CD] Update binary_linux_test.sh to include calling builder smoke test (#133869) 
Run smoke test

Fixes #1969

Pull Request resolved: https://github.com/pytorch/pytorch/pull/133869
Approved by: https://github.com/atalman

Co-authored-by: Andrey Talman <atalman@fb.com>
 2024-09-06 13:27:24 +00:00
Jack Taylor
034717a029 [ROCm] remove triton-rocm commit pin and merge pins with triton.txt (#133438) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133438
Approved by: https://github.com/jithunnair-amd, https://github.com/malfet

Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
 2024-09-05 20:36:45 +00:00
chuanqiw
67208f08bd [CD] Enable XPU nightly build on Windows (#134312) 
Depends on https://github.com/pytorch/builder/pull/1975 land. Works for https://github.com/pytorch/pytorch/issues/114850
Pull Request resolved: https://github.com/pytorch/pytorch/pull/134312
Approved by: https://github.com/atalman
 2024-09-04 14:46:36 +00:00
PyTorch MergeBot
a1ba8e61d1 Revert "[ROCm] remove triton-rocm commit pin and merge pins with triton.txt (#133438)" 
This reverts commit 5e8bf29148.

Reverted https://github.com/pytorch/pytorch/pull/133438 on behalf of https://github.com/ZainRizvi due to This still breaks linux binary builds. Added the appropriate labels to ensure tests can pass. See [GH job link](https://github.com/pytorch/pytorch/actions/runs/10626427003/job/29460479554) [HUD commit link](5e8bf29148) ([comment](https://github.com/pytorch/pytorch/pull/133438#issuecomment-2322246198))
 2024-08-30 20:00:41 +00:00
Jack Taylor
5e8bf29148 [ROCm] remove triton-rocm commit pin and merge pins with triton.txt (#133438) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133438
Approved by: https://github.com/jithunnair-amd, https://github.com/malfet

Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
 2024-08-30 03:38:35 +00:00
Wang, Chuanqi
b417e32da2 [CD] fix xpu nightly wheel test env (#134395) (#134464) 
Due to the https://github.com/pytorch/builder/pull/1972 landed, it will source xpu env duplicated in nightly wheel test.
Works for https://github.com/pytorch/pytorch/issues/114850

Realnd of #134395 to be landed with pytorchmergebot
Pull Request resolved: https://github.com/pytorch/pytorch/pull/134464
Approved by: https://github.com/jeanschmidt

Co-authored-by: Wang, Chuanqi <chuanqi.wang@intel.com>
 2024-08-26 15:35:48 +00:00
Andrey Talman
be96ccf77c Revert "[CD] fix xpu nightly wheel test env (#134395)" (#134461) 
This reverts commit 96738c9d75.

Merged without pytorchmergebot command by mistake

Pull Request resolved: https://github.com/pytorch/pytorch/pull/134461
Approved by: https://github.com/jeanschmidt
 2024-08-26 13:40:17 +00:00
Wang, Chuanqi
96738c9d75
[CD] fix xpu nightly wheel test env (#134395) 2024-08-26 08:53:15 -04:00
PyTorch MergeBot
4648848696 Revert "[ROCm] remove triton-rocm commit pin and merge pins with triton.txt (#133438)" 
This reverts commit f71c3d265a.

Reverted https://github.com/pytorch/pytorch/pull/133438 on behalf of https://github.com/jeanschmidt due to seems to have introduced breakages in linux binary builds ([comment](https://github.com/pytorch/pytorch/pull/133438#issuecomment-2308787310))
 2024-08-25 11:20:30 +00:00
Jack Taylor
f71c3d265a [ROCm] remove triton-rocm commit pin and merge pins with triton.txt (#133438) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133438
Approved by: https://github.com/jithunnair-amd, https://github.com/malfet
 2024-08-24 18:26:49 +00:00
chuanqiw
6590f4fb0e [CD] Enable python 3.13 for xpu nightly build (#133670) 
Enable python 3.13 for XPU nightly build, it depends on https://github.com/pytorch/pytorch/pull/133454 land. Also update the xpu nightly wheel test env.

Works for https://github.com/pytorch/pytorch/issues/114850
Fixes #130543
Pull Request resolved: https://github.com/pytorch/pytorch/pull/133670
Approved by: https://github.com/atalman, https://github.com/malfet
 2024-08-20 15:05:20 +00:00
albanD
eb146b10db Only depend on sympy 1.12 for conda (no 3.13 there anyways) (#131355) 
Fixing nightly after https://github.com/pytorch/pytorch/pull/130895
Pull Request resolved: https://github.com/pytorch/pytorch/pull/131355
Approved by: https://github.com/atalman
 2024-07-23 12:19:58 +00:00
Xuehai Pan
f0075c179b Pin sympy >= 1.13.0 (#130895) 
------

The opposite of #130836. Pin `sympy >= 1.13.0` for Python >= 3.9 and `sympy == 1.12.1` for Python 3.8.

- #130836

See the PR description of #130836 for more details.

`sympy` 1.13.0 introduces some breaking changes which break our tests. More specifically:

- Ref [Backwards compatibility breaks and deprecations](https://github.com/sympy/sympy/wiki/release-notes-for-1.13.0#backwards-compatibility-breaks-and-deprecations)

> BREAKING CHANGE: Float and Integer/Rational no longer compare equal with a == b. From now on Float(2.0) != Integer(2). Previously expressions involving Float would compare unequal e.g. x*2.0 != x*2 but an individual Float would compare equal to an Integer. In SymPy 1.7 a Float will always compare unequal to an Integer even if they have the same "value". Use sympy.numbers.int_valued(number) to test if a number is a concrete number with no decimal part. ([#25614](https://github.com/sympy/sympy/pull/25614) by [@smichr](https://github.com/smichr))

`sympy >= 1.13.0` is required to enable Python 3.13 support. This should be part of #130689.

- #130689

Pull Request resolved: https://github.com/pytorch/pytorch/pull/130895
Approved by: https://github.com/ezyang
 2024-07-20 00:59:24 +00:00