Commit Graph

6 Commits

Author SHA1 Message Date
Kazuaki Ishizaki
105ef68f72 Fix typos under torch/fx directory (#97596)
This PR fixes typos in comments and messages of `.py` files under `torch/fx` directory

Pull Request resolved: https://github.com/pytorch/pytorch/pull/97596
Approved by: https://github.com/dagitses, https://github.com/kit1980
2023-04-10 21:57:36 +00:00
Aaron Gokaslan
597b558c51 [BE]: Update flake8 and plugins and fix bugs (#97795)
Update flake8 and flake8-plugins in lintrunner to a modern version. Enables more checks and makes flake8 checks significantly faster. Added a few additional rule ignores that will need to be fixed in the future.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/97795
Approved by: https://github.com/alexsio27444, https://github.com/janeyx99, https://github.com/ezyang
2023-03-28 23:51:55 +00:00
Aaron Gokaslan
67d9790985 [BE] Apply almost all remaining flake8-comprehension checks (#94676)
Applies the remaining flake8-comprehension fixes and checks. This changes replace all remaining unnecessary generator expressions with list/dict/set comprehensions which are more succinct, performant, and better supported by our torch.jit compiler. It also removes useless generators such as 'set(a for a in b)`, resolving it into just the set call.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/94676
Approved by: https://github.com/ezyang
2023-02-12 01:01:25 +00:00
Shangdi Yu
c52ee6dc0a CSE Pass and common pass Tests (#81742)
Test cases for CSE Pass and common passes
Pull Request resolved: https://github.com/pytorch/pytorch/pull/81742
Approved by: https://github.com/SherlockNoMad
2022-07-22 03:45:09 +00:00
Shangdi Yu
7c5dac5228 Dialect agnostic CSE Pass (#81530)
Fixes comments in https://github.com/pytorch/pytorch/pull/81512

- banned ops is an input to the pass
- update the fx/readme.md to include this file for better discoverability
- use make_fx in torch repo
Pull Request resolved: https://github.com/pytorch/pytorch/pull/81530
Approved by: https://github.com/SherlockNoMad
2022-07-20 00:56:41 +00:00
Shangdi Yu
938643b8bc CSE_Pass (#81512)
Migrate the CSE pass in functorch to pytorch

Pull Request resolved: https://github.com/pytorch/pytorch/pull/81512
Approved by: https://github.com/angelayi
2022-07-15 02:32:48 +00:00