Kazuaki Ishizaki
105ef68f72
Fix typos under torch/fx directory ( #97596 )
...
This PR fixes typos in comments and messages of `.py` files under `torch/fx` directory
Pull Request resolved: https://github.com/pytorch/pytorch/pull/97596
Approved by: https://github.com/dagitses , https://github.com/kit1980
2023-04-10 21:57:36 +00:00
Mostafa Elhoushi
139413078f
[FX] make ASTReriter patch wrapped functions properly ( #62987 )
...
Summary:
reference the same global namespace (instead of copying it) in ASTRewriter to patch wrapped functions properly
Fixes #{62071}
Pull Request resolved: https://github.com/pytorch/pytorch/pull/62987
Test Plan:
To test it you may write this snippet and ensure the results are as shown in the comments:
```
import torch
import torch.fx
torch.fx.wrap
def to_be_wrapped(x):
return torch.relu(x)
class Foo(torch.nn.Module):
def forward(self, x):
return to_be_wrapped(x)
traced = torch.fx.symbolic_trace(Foo())
print(traced.graph)
"""
graph():
%x : [#users=1] = placeholder[target=x]
%to_be_wrapped : [#users=1] = call_function[target=__main__.to_be_wrapped](args = (%x,), kwargs = {})
return to_be_wrapped
"""
from torch.fx.experimental.rewriter import RewritingTracer
rt = RewritingTracer()
graph = rt.trace(Foo())
print(graph)
"""
### AFTER FIX (CORRECT):
graph():
%x : [#users=1] = placeholder[target=x]
%to_be_wrapped : [#users=1] = call_function[target=__main__.to_be_wrapped](args = (%x,), kwargs = {})
return to_be_wrapped
### BEFORE FIX (WRONG):
graph():
%x : [#users=1] = placeholder[target=x]
%relu : [#users=1] = call_function[target=torch.relu](args = (%x,), kwargs = {})
return relu
"""
```
Reviewed By: ansley
Differential Revision: D30396176
Pulled By: mostafaelhoushi
fbshipit-source-id: f61eddf32e9ef42b5f5c3ce21d559945214ee833
2021-08-18 15:03:57 -07:00
Zhengxu Chen
e62189ad69
[jit] Better checking for overload function declarations. ( #59956 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/59956
Issue #50175 . Basically two things need to be checked and are lacking currently:
1. Overload declarations should always have a single `pass` statement as the body.
2. There should be always an implementation provided for decls which doesn't
have the torch.jit._overload decorator. So in this case we need to check
whether we are actually compiling a function body with decorator ahead.
Test Plan:
python test/test_jit.py TestScript.test_function_overloads
Imported from OSS
Reviewed By: gmagogsfm
Differential Revision: D29106555
fbshipit-source-id: 2d9d7df2fb51ab6db0e1b726f9644e4cfbf733d6
2021-08-05 14:21:48 -07:00
Zeina Migeed
6f1455440b
task 3: typecheck ( #60805 )
...
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/60805
Test Plan: Imported from OSS
Reviewed By: jamesr66a, VitalyFedyunin
Differential Revision: D29522885
Pulled By: migeed-z
fbshipit-source-id: 559a8a495a16e517af77fd5a0785a82e1ebb3bd7
2021-07-06 23:51:49 -07:00
Zeina Migeed
98119bfce9
task 2: ast rewrite ( #60622 )
...
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/60622
Test Plan: Imported from OSS
Reviewed By: jamesr66a
Differential Revision: D29493747
Pulled By: migeed-z
fbshipit-source-id: 684fcdfd3dd441e72c77bb7a4d64c18b9849a198
2021-07-06 20:15:30 -07:00
James Reed
7b73fdf597
[FX] Fix retracing wrapped functions ( #58061 )
...
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/58061
Test Plan: Imported from OSS
Reviewed By: yuhc
Differential Revision: D28358801
Pulled By: jamesr66a
fbshipit-source-id: c7c9a8a80e5bfe1eb1f6d2cf858ac7e57153a860
2021-05-17 19:50:16 -07:00
Ansley Ussery
d8bb932245
Support AST rewriting for submodules ( #52297 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/52297
Before, an `nn.Module` with submodules would fail AST rewriting with `TypeError: 'RewrittenModule' object does not support item assignment`. (Try the `test_ast_rewriter_reassigns_submodules` test case on `master`.) This PR fixes the issue as well as adding additional test cases
Test Plan: Imported from OSS
Reviewed By: pbelevich
Differential Revision: D26483820
Pulled By: ansley
fbshipit-source-id: 757e898dc2b0a67daf2bd039d555b85f4e443322
2021-02-17 09:08:07 -08:00
Horace He
d4d5f8569f
[FX] Fix mypy error in FX for rewriter ( #51740 )
...
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/51740
Reviewed By: jamesr66a
Differential Revision: D26261009
Pulled By: Chillee
fbshipit-source-id: ce97316aede5509fc8ed90b4eb6b758e2bc1fa7a
2021-02-04 13:15:51 -08:00
Vasiliy Kuznetsov
ee995d33bd
rename torch.Assert to torch._assert ( #47763 ) ( #47972 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/47972
Changing the name due to the discussion in
https://github.com/pytorch/pytorch/pull/47399 .
Test Plan:
```
python test/test_utils.py TestAssert.test_assert_true
python test/test_fx.py TestFX.test_symbolic_trace_assert
python test/test_fx_experimental.py
```
Reviewed By: supriyar
Differential Revision: D24974298
Pulled By: vkuzo
fbshipit-source-id: 24ded93a7243ec79a0375f4eae8a3db9b787f857
2020-11-16 11:43:27 -08:00
Richard Zou
e5da3b6097
Revert D24891767: rename torch.Assert to torch._assert
...
Test Plan: revert-hammer
Differential Revision:
D24891767 (a8ca042ec0
2020-11-13 08:35:05 -08:00
Vasiliy Kuznetsov
a8ca042ec0
rename torch.Assert to torch._assert ( #47763 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/47763
Changing the name due to the discussion in
https://github.com/pytorch/pytorch/pull/47399 .
Test Plan:
```
python test/test_utils.py TestAssert.test_assert_true
python test/test_fx.py TestFX.test_symbolic_trace_assert
python test/test_fx_experimental.py
```
Imported from OSS
Reviewed By: ezyang
Differential Revision: D24891767
fbshipit-source-id: 01c7a5acd83bf9c962751552780930c242134dd2
2020-11-12 23:59:34 -08:00
Ansley Ussery
dec1c36487
Create prototype for AST rewriter ( #47216 )
...
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/47216
Test Plan: Imported from OSS
Reviewed By: glaringlee
Differential Revision: D24687539
Pulled By: ansley
fbshipit-source-id: 421108d066ff93ee18f4312ee67c287ca1cef881
2020-11-03 19:21:58 -08:00
Natalia Gimelshein
317b78d56e
Revert D24665950: Create prototype for AST rewriter
...
Test Plan: revert-hammer
Differential Revision:
D24665950 (54feb00bbd
2020-10-31 18:07:10 -07:00
Ansley Ussery
54feb00bbd
Create prototype for AST rewriter ( #46410 )
...
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/46410
Test Plan: Imported from OSS
Reviewed By: SplitInfinity
Differential Revision: D24665950
Pulled By: ansley
fbshipit-source-id: b72110436126a24ddc294b8ee7b3f691281c1f1b
2020-10-31 10:51:17 -07:00
