Commit Graph

12 Commits

Author SHA1 Message Date
Shashank Chaudhry
06d1be2447 [NOOP][clangformat][codemod] Enable CLANGFORMAT for caffe2/caffe2/* (#67624)
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/67624

Test Plan: Visual inspection. Sandcastle.

Reviewed By: malfet

Differential Revision: D31986628

fbshipit-source-id: c872bded7325997a2945dbf5d4d052628dcb3659
2021-11-02 22:14:04 -07:00
Stiopa Koltsov
547346d663 [caffe2] Fix -Wundef
Summary:
* `#if` with some undefined name is a warning when `-Wundef` is specified (which is in ovrsource for example)
* identifiers starting with two underscores are [reserved for compiler internals](https://en.cppreference.com/w/cpp/language/identifiers)

Test Plan: CI

Reviewed By: ezyang

Differential Revision: D27318070

fbshipit-source-id: 4989fc6a3bf3c176eddd7c25aca47414e4973edd
2021-03-31 22:24:30 -07:00
James Donald
7f485121a6 Avoid MSVC _cvtsh_ss() workaround with clang-cl (#29726)
Summary:
We (me fnabulsi bmcdb) have a handful of fixes used locally to build and run with clang-cl. I am aware of https://github.com/pytorch/pytorch/issues/8784 but it has not been touched in almost a year.

It may be more practical to upstream the non-controversial fixes piecewise. For example, this one.

Here, the dummy version of `_cvtsh_ss` for MSVC is not required (and hence causes conflicts) when using clang-cl so can be #ifdef'd out.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/29726

Differential Revision: D18478120

Pulled By: ezyang

fbshipit-source-id: cdcd94251e68347446f2ad1ac5a0e71089f7d0ab
2019-11-13 12:49:13 -08:00
Jongsoo Park
1d522598fb use fp16<->fp32 intrinsic (#17496)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/17496

As title.

Reviewed By: hyuen

Differential Revision: D14222907

fbshipit-source-id: d5d6c032e725ca8b52aca2be7401ec3c59f6a242
2019-03-07 02:23:07 -08:00
Tongliang Liao
55511004d1 Resolve errors in perfkernel for Windows (#16031)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/16031

1. MSVC only has _mm_prefetch(const char*, int). Fixed in both python codegen and C++ files.
2. uint32_t in "cvtsh_ss_bugfix.h" requires "#include <cstdint>".
3. Some files use gflags headers. Add dependency via c10.
4. Isolate arch flags with interface library and private compile options.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/15753

Reviewed By: dskhudia

Differential Revision: D13636233

Pulled By: jspark1105

fbshipit-source-id: cdcbd4240e07b749554a2a5676c11af88f23c31d
2019-01-16 21:51:00 -08:00
Orion Reblitz-Richardson
1d5780d42c Remove Apache headers from source.
* LICENSE file contains details, so removing from individual source files.
2018-03-27 13:10:18 -07:00
Pieter Noordhuis
cdd48a8575 Fix typo in clang ifdef to fix clang 3.9 build
Summary:
This prevented building with clang 3.9.
Closes https://github.com/caffe2/caffe2/pull/1565

Differential Revision: D6472567

Pulled By: pietern

fbshipit-source-id: 361c3f9e85237ca0328e12eb23309bc4a3e11556
2017-12-03 22:51:45 -08:00
Pieter Noordhuis
335c7dc681 Fix perfkernel compile error on clang 3.8
Summary:
Closes #1483.
Closes https://github.com/caffe2/caffe2/pull/1489

Reviewed By: bddppq

Differential Revision: D6376107

Pulled By: pietern

fbshipit-source-id: 892f74d67629609ed82c991cfd94508cf8e23c29
2017-11-20 16:17:51 -08:00
caozhong
e8abfd359a Limit this fix to apple clang only
Summary:
Use "__apple_build_version__" macro to distinguish Apple's Clang while brew installed LLVM will compile caffe2 without trouble.
Closes https://github.com/caffe2/caffe2/pull/1461

Differential Revision: D6316861

Pulled By: Yangqing

fbshipit-source-id: f7a08cdd8822b197a93aa11dc8f28ef5cd738eee
2017-11-13 14:33:30 -08:00
Yangqing Jia
8286ce1e3a Re-license to Apache
Summary: Closes https://github.com/caffe2/caffe2/pull/1260

Differential Revision: D5906739

Pulled By: Yangqing

fbshipit-source-id: e482ba9ba60b5337d9165f28f7ec68d4518a0902
2017-09-28 16:22:00 -07:00
Jammy Zhou
b96c4e714b Fix build failure on MacOS X with clang-800.0.42.1
Summary:
Signed-off-by: Jammy Zhou <jammy.zhou@gmail.com>
Closes https://github.com/caffe2/caffe2/pull/1047

Differential Revision: D5583196

Pulled By: Yangqing

fbshipit-source-id: 7fe782b6caa14074573fbdacd68f50e16fb85e3f
2017-08-08 18:49:27 -07:00
Yangqing Jia
0b50e078d1 add proper build support for perfkernels
Summary: Closes https://github.com/caffe2/caffe2/pull/972

Differential Revision: D5506606

Pulled By: Yangqing

fbshipit-source-id: d9327e08fc1726bf9b20a8668d06a5be179f45d4
2017-08-02 23:17:04 -07:00