cyy
f150f96255
[Reland] increase clang-tidy coverage in torch/csrc ( #108875 )
...
Reland PR #103058 since there was a time gap between this PR and other PRs in terms of torch/csrc modifications
Pull Request resolved: https://github.com/pytorch/pytorch/pull/108875
Approved by: https://github.com/Skylion007
2023-09-12 00:54:53 +00:00
PyTorch MergeBot
fa8bfe5ca2
Revert "increase clang-tidy coverage in torch/csrc ( #103058 )"
...
This reverts commit cdf7f3e780https://github.com/pytorch/pytorch/pull/103058 on behalf of https://github.com/atalman due to Sorry for reverting your change, breaks lint ([comment](https://github.com/pytorch/pytorch/pull/103058#issuecomment-1711906915 ))
2023-09-08 16:07:41 +00:00
cyy
cdf7f3e780
increase clang-tidy coverage in torch/csrc ( #103058 )
...
Fixes #ISSUE_NUMBER
Pull Request resolved: https://github.com/pytorch/pytorch/pull/103058
Approved by: https://github.com/Skylion007
2023-09-08 15:07:32 +00:00
Aaron Gokaslan
a34a9c3471
Perf: Apply more clang-tidy fixups to torch headers ( #91445 )
...
Applies so more fixes to headers that may have been missed before for performance optimization.cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @EikanWang @ezyang since this more in the series of the clang-tidy fixup
This is PR fixes 3 main issues:
1. Use emplacement more in headers
1. Avoid unnecessary copies and use const ref when possible
1. Default any special functions when possible to make them potentially trivial and more readable.
1. There is also one change in this PR that tries to prevent unnecessary math promotion, the rest of these changes are in another PR
Pull Request resolved: https://github.com/pytorch/pytorch/pull/91445
Approved by: https://github.com/ezyang
2022-12-29 23:43:45 +00:00
Kurt Mohler
23bdb570cf
Reland: Enable dim=None for torch.sum ( #79881 )
...
Part of #29137
Reland of #75845
Pull Request resolved: https://github.com/pytorch/pytorch/pull/79881
Approved by: https://github.com/albanD , https://github.com/kulinseth
2022-07-09 00:54:42 +00:00
PyTorch MergeBot
ee6ebfc06b
Revert "Enable dim=None for torch.sum ( #75845 )"
...
This reverts commit e79a51f7dbhttps://github.com/pytorch/pytorch/pull/75845 on behalf of https://github.com/malfet due to Breaks MacOS builds, see e79a51f7db
2022-06-16 22:01:41 +00:00
Kurt Mohler
e79a51f7db
Enable dim=None for torch.sum ( #75845 )
...
Part of #29137
Pull Request resolved: https://github.com/pytorch/pytorch/pull/75845
Approved by: https://github.com/ezyang
2022-06-16 20:17:07 +00:00
Kurt Mohler
5375b2e994
Resolve int[]? arguments to new OptionalIntArrayRef class
...
This PR uses the `OptionalArrayRef` template class that was drafted in #64084 .
Fixes #44409
Pull Request resolved: https://github.com/pytorch/pytorch/pull/70864
Approved by: https://github.com/ezyang
2022-03-26 01:45:50 +00:00
