Commit Graph

6 Commits

Author SHA1 Message Date
Nikita Shulga
2418b94576
Rename default branch to main (#99210)
Mostly `s/@master/@main` in numerous `.yml` files.

Keep `master` in `weekly.yml` as it refers to `xla` repo and in `test_trymerge.py` as it refers to a branch PR originates from.
2023-04-16 18:48:14 -07:00
Huy Do
4c0dce50fd [BE] Apply ufmt to run_test and GitHub Python util scripts (#97588)
This has been bugging me for a while as I'm working on these Python scripts and they are not tracked by ufmt linter.  So I add these script into that linter.

```
[[linter]]
code = 'UFMT'
include_patterns = [
    '.github/**/*.py',
    'test/run_test.py',
```

This change should just work and not break anything as ufmt (black + usort) linter is very safe to use for standalone util scripts.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/97588
Approved by: https://github.com/kit1980
2023-03-26 04:52:55 +00:00
Catherine Lee
1c30268ff1 Update rockset version (#94005)
upgrading rockset to 1.0.3

the diff looks like it gets rid of dependency on six but i think python-dateutils still uses it but is better about downloading it
Pull Request resolved: https://github.com/pytorch/pytorch/pull/94005
Approved by: https://github.com/huydhn
2023-02-03 21:38:35 +00:00
Zain Rizvi
9470059766 Allow viable/strict promotion even if periodic or docker-release-builds jobs are failing (#86827)
Allow `viable/strict` promotion even if `periodic` or `docker-release-builds` jobs are failing

**Why?** Those jobs only run occasionally and for all we know the current viable/strict commit may already include the errors that the above cron based workflows may have later detected.  Blocking the viable/strict upgrade because of these scheduled jobs doesn't really offer any value, it just leads to people getting older PRs when they try to fork off of viable/strict without guaranteeing an improvement in test quality

Though frankly, the current situation is worse than that.

Assume the branch history looks like A -> B

A is the current `viable/strict` commit
B is a commit that failed some `periodic` test, so `viable/strict` wasn't upgraded to B

Now lets say there's a commit C that gets merged. C neither contains a fix for the failing periodic build, nor does a scheduled periodic workflow run against C. The branch becomes A -> B -> C

In the above scenario, today we will promote `viable/strict` to C since there was no failing workflow there!!! Even though it didn't actually fix what was broken with B!

In short, avoiding the upgrade to B really doesn't make any sense today and we shouldn't do it.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/86827
Approved by: https://github.com/janeyx99
2022-10-13 00:38:48 +00:00
Zain Rizvi
c08cbfccd9 Let retried jobs advance viable/strict (#86821)
Today, even if we retry a failed workflow it succeeds on the retry, viable/strict doesn't advance forward.

Success on retry is proof that the error wasn't with the current commit and that we should in fact promote viable/strict. This PR points to an updated rockset query which will only look at the success status of the most recent job in each workflow

Here's the query edited:

Original query:
https://console.rockset.com/lambdas/details/commons.commit_jobs_batch_query/versions/15aba20837ae9d75?tab=sql

Updated query: https://console.rockset.com/lambdas/details/commons.commit_jobs_batch_query/versions/8003fdfd18b64696?tab=sql

Testing:
Tested the old and new query against commits known to have succeeded on retry
Pull Request resolved: https://github.com/pytorch/pytorch/pull/86821
Approved by: https://github.com/huydhn, https://github.com/malfet
2022-10-12 20:43:42 +00:00
swang392
19bdc4f007 updated file names for viable-strict script (#82414)
### Description
Renamed the file the retrieves the latest green commit for viable/strict promotion. The previous name, `print_latest_commit` did not relate to its actual function.

### Testing
All of the test cases in `test_fetch_latest_green_commit` pass, nothing else should be affected

Pull Request resolved: https://github.com/pytorch/pytorch/pull/82414
Approved by: https://github.com/clee2000
2022-07-29 15:23:35 +00:00