2 Commits

Author	SHA1	Message	Date
Nikita Shulga	058f43fc51	Fix torch.version.debug generation (#47006) ... Summary: argparser type bool returns True for any argument passed as input Use `distutils.util.strtobool` which returns 0 for input values like "0", "no", "n", "f", "false" and 1 for "1", "yes", "y", "t", "true" Fixes https://github.com/pytorch/pytorch/issues/46973 and https://github.com/pytorch/pytorch/issues/47003 Pull Request resolved: https://github.com/pytorch/pytorch/pull/47006 Reviewed By: samestep Differential Revision: D24598193 Pulled By: malfet fbshipit-source-id: e8f6688d6883011f301b49a0f03c452c611f7001	2020-10-28 12:48:30 -07:00
Michael Suo	161490d441	Move torch/version.py generation to cmake (#44577) ... Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/44577 I would like to to move this to cmake so that I can depend on it happening from other parts of the build. This PR pulls out the logic for determining the version string and writing the version file into its own module. `setup.py` still receives the version string and uses it as before, but now the code for writing out `torch/version.py` lives in a custom command in torch/CMakeLists.txt I noticed a small inconsistency in how version info is populated. `TORCH_BUILD_VERSION` is populated from `setup.py` at configuration time, while `torch/version.py` is written at build time. So if, e.g. you configured cmake on a certain git rev, then built it in on another, the two versions would be inconsistent. This does not appear to matter, so I opted to preserve the existing behavior. Test Plan: Imported from OSS Reviewed By: bertmaher Differential Revision: D23734781 Pulled By: suo fbshipit-source-id: 4002c9ec8058503dc0550f8eece2256bc98c03a4	2020-09-16 15:49:22 -07:00