7 Commits

Author	SHA1	Message	Date
Xuehai Pan	0dae2ba5bd	[2/N][Easy] fix typo for usort config in pyproject.toml (kown -> known): sort caffe2 (#127123) ... The `usort` config in `pyproject.toml` has no effect due to a typo. Fixing the typo make `usort` do more and generate the changes in the PR. Except `pyproject.toml`, all changes are generated by `lintrunner -a --take UFMT --all-files`. Pull Request resolved: https://github.com/pytorch/pytorch/pull/127123 Approved by: https://github.com/Skylion007 ghstack dependencies: #127122	2024-05-25 18:26:34 +00:00
Justin Chu	4cc1745b13	[BE] f-stringify torch/ and scripts (#105538) ... This PR is a follow up on the pyupgrade series to convert more strings to use f-strings using `flynt`. - https://docs.python.org/3/reference/lexical_analysis.html#f-strings - https://pypi.org/project/flynt/ Command used: ``` flynt torch/ -ll 120 flynt scripts/ -ll 120 flynt tools/ -ll 120 ``` and excluded `collect_env.py` Pull Request resolved: https://github.com/pytorch/pytorch/pull/105538 Approved by: https://github.com/ezyang, https://github.com/malfet	2023-07-21 19:35:24 +00:00
Justin Chu	161e931156	[ONNX] Modernize python syntax (#77935) ... Use pyupgrade(https://github.com/asottile/pyupgrade) and flynt to modernize python syntax ```sh pyupgrade --py36-plus --keep-runtime-typing torch/onnx/**/*.py pyupgrade --py36-plus --keep-runtime-typing test/onnx/**/*.py flynt torch/onnx/ --line-length 120 ``` - Use f-strings for string formatting - Use the new `super()` syntax for class initialization - Use dictionary / set comprehension Pull Request resolved: https://github.com/pytorch/pytorch/pull/77935 Approved by: https://github.com/BowenBao	2022-05-24 22:52:37 +00:00
Justin Chu	5dd1c67776	[ONNX] Format ONNX python with black ... Format all onnx python code with black and isort with ```sh isort torch/onnx/ test/onnx black torch/onnx/ test/onnx ``` Updated lintrunner config to include these paths. Pull Request resolved: https://github.com/pytorch/pytorch/pull/76754 Approved by: https://github.com/suo, https://github.com/BowenBao	2022-05-05 00:19:22 +00:00
BowenBao	0a6828a306	[ONNX] use consistent quoting for string literals (#57757) (#58695) ... Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/58695 As PEP8 says: "Pick a rule and stick to it." [1] [1] https://www.python.org/dev/peps/pep-0008/#string-quotes Test Plan: Imported from OSS Reviewed By: driazati Differential Revision: D28714811 Pulled By: SplitInfinity fbshipit-source-id: c95103aceb1725c17c034dc6fc8216627f189548 Co-authored-by: Gary Miguel <garymiguel@microsoft.com>	2021-05-27 12:06:42 -07:00
Samuel Marks	e6779d4357	[*.py] Rename "Arguments:" to "Args:" (#49736) ... Summary: I've written custom parsers and emitters for everything from docstrings to classes and functions. However, I recently came across an issue when I was parsing/generating from the TensorFlow codebase: inconsistent use of `Args:` and `Arguments:` in its docstrings. ```sh (pytorch#c348fae)$ for name in 'Args:' 'Arguments:'; do printf '%-10s %04d\n' "$name" "$(rg -IFtpy --count-matches "$name" | paste -s -d+ -- | bc)"; done Args: 1095 Arguments: 0336 ``` It is easy enough to extend my parsers to support both variants, however it looks like `Arguments:` is wrong anyway, as per: - https://google.github.io/styleguide/pyguide.html#doc-function-args @ [`ddccc0f`](https://github.com/google/styleguide/blob/ddccc0f/pyguide.md) - https://chromium.googlesource.com/chromiumos/docs/+/master/styleguide/python.md#describing-arguments-in-docstrings @ [`9fc0fc0`](https://chromium.googlesource.com/chromiumos/docs/+/9fc0fc0/styleguide/python.md) - https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html @ [`c0ae8e3`](https://github.com/sphinx-contrib/napoleon/blob/c0ae8e3/docs/source/example_google.rst) Therefore, only `Args:` is valid. This PR replaces them throughout the codebase. PS: For related PRs, see tensorflow/tensorflow/pull/45420 PPS: The trackbacks automatically appearing below are sending the same changes to other repositories in the [PyTorch](https://github.com/pytorch) organisation. Pull Request resolved: https://github.com/pytorch/pytorch/pull/49736 Reviewed By: albanD Differential Revision: D25710534 Pulled By: soumith fbshipit-source-id: 61e8ff01abb433e9f78185c2d1d0cbd7c22c1619	2020-12-28 09:34:47 -08:00
bddppq	141d81d095	Move ONNX integration tests from onnx-fb-universe to PyTorch repo (#7397) ... * Move ONNX integration tests from onnx-fb-universe to PyTorch repo * Switch to use torchvision * Delete single rnn operator tests, they have been covered in e2e tests in test_caffe2.py * Mirror the fix in onnx-fb-universe to bypass cuda check 667326d84b	2018-05-11 15:05:18 -07:00