cyy
|
bfeb45e46b
|
[17/N] Fix clang-tidy warnings in jit (#132753)
Follows #132604
Pull Request resolved: https://github.com/pytorch/pytorch/pull/132753
Approved by: https://github.com/Skylion007
|
2024-08-07 03:47:54 +00:00 |
|
cyy
|
77f2883c41
|
[Reland2] fix missing-prototypes warnings in torch_cpu (Part 4) (#102228)
This PR relands the changes introduced in PR https://github.com/pytorch/pytorch/pull/100849. The old PR turnd nnc_* functions into static. We now add declarations for them and hope that inter builds will pass.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/102228
Approved by: https://github.com/albanD
|
2023-06-02 22:04:44 +00:00 |
|
PyTorch MergeBot
|
32ce06a5ab
|
Revert "[Reland] fix missing-prototypes warnings in torch_cpu (Part 4) (#101949)"
This reverts commit 4f2c007a1b.
Reverted https://github.com/pytorch/pytorch/pull/101949 on behalf of https://github.com/osalpekar due to As noted in @izaitsevfb's comment, we are still seeing linker errors, this time due to `nnc_prepacked_linear_clamp_run` being made a static function. ([comment](https://github.com/pytorch/pytorch/pull/101949#issuecomment-1560226880))
|
2023-05-23 22:53:47 +00:00 |
|
cyy
|
4f2c007a1b
|
[Reland] fix missing-prototypes warnings in torch_cpu (Part 4) (#101949)
This PR relands the changes introduced in PR #100849. The old PR turnd nnc_aten_embedding into a static function, however, it is actually used in torch/csrc/jit/tensorexpr/operators/misc.cpp.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/101949
Approved by: https://github.com/albanD
|
2023-05-22 10:53:07 +00:00 |
|
PyTorch MergeBot
|
498c34e8e8
|
Revert " fix missing-prototypes warnings in torch_cpu (Part 4) (#100849)"
This reverts commit c2f28d1c1d.
Reverted https://github.com/pytorch/pytorch/pull/100849 on behalf of https://github.com/izaitsevfb due to fails internal Meta builds, including fbcode and android, see D46009888: ld.lld: error: undefined symbol: nnc_aten_embedding ([comment](https://github.com/pytorch/pytorch/pull/100849#issuecomment-1555105800))
|
2023-05-19 19:05:15 +00:00 |
|
cyy
|
c2f28d1c1d
|
fix missing-prototypes warnings in torch_cpu (Part 4) (#100849)
This PR fixes more missing-prototypes violations in the torch_cpu source following PRs #100053, #100147 and #100245
Pull Request resolved: https://github.com/pytorch/pytorch/pull/100849
Approved by: https://github.com/albanD
|
2023-05-18 03:49:45 +00:00 |
|
Mikhail Zolotukhin
|
85c056a508
|
[JIT] Add EliminateExceptions pass. (#54730)
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/54730
Test Plan: Imported from OSS
Reviewed By: Krovatkin
Differential Revision: D27343165
Pulled By: ZolotukhinM
fbshipit-source-id: 1574e7aad4d527c4caf74383335265c9bffc7640
|
2021-03-30 13:56:54 -07:00 |
|