PyTorch MergeBot
a58a565819
Revert "[Environment Variable][6/N] Use thread-safe getenv functions ( #140200 )"
...
This reverts commit 7d4f5f7508https://github.com/pytorch/pytorch/pull/140200 on behalf of https://github.com/ezyang due to One of these diffs had incorrect downstream optional handling, we must reaudit all of these diffs ([comment](https://github.com/pytorch/pytorch/pull/140200#issuecomment-2473956859 ))
2024-11-13 15:33:23 +00:00
cyy
7d4f5f7508
[Environment Variable][6/N] Use thread-safe getenv functions ( #140200 )
...
Fixes #ISSUE_NUMBER
Pull Request resolved: https://github.com/pytorch/pytorch/pull/140200
Approved by: https://github.com/ezyang
2024-11-09 15:05:51 +00:00
cyy
efca51e171
[8/N] Fix clang-tidy warnings in jit ( #131997 )
...
Follows #131996
Pull Request resolved: https://github.com/pytorch/pytorch/pull/131997
Approved by: https://github.com/Skylion007
2024-07-29 12:40:42 +00:00
cyy
ac603bc2f8
[Reland] Eliminate invocations of c10::stoi,c10::stod,c10::stoull,c10::stoll ( #109566 )
...
This is reland of #87603 with definitions of c10::stoXX kept for further investigation.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/109566
Approved by: https://github.com/huydhn
2023-09-19 07:15:25 +00:00
PyTorch MergeBot
4d44d8c00a
Revert "Eliminate c10::stoi,c10::stod,c10::stoull,c10::stoll ( #109179 )"
...
This reverts commit 852f1b8417https://github.com/pytorch/pytorch/pull/109179 on behalf of https://github.com/huydhn due to Sorry for reverting your change but this is breaking periodic buck build, so please fix the issue and reland the change https://github.com/pytorch/pytorch/actions/runs/6207458526/job/16852695272 ([comment](https://github.com/pytorch/pytorch/pull/109179#issuecomment-1724168571 ))
2023-09-18 18:41:12 +00:00
cyy
852f1b8417
Eliminate c10::stoi,c10::stod,c10::stoull,c10::stoll ( #109179 )
...
We can remove these functions in favor of std ones.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/109179
Approved by: https://github.com/colesbury
2023-09-16 07:22:50 +00:00
cyy
77f2883c41
[Reland2] fix missing-prototypes warnings in torch_cpu (Part 4) ( #102228 )
...
This PR relands the changes introduced in PR https://github.com/pytorch/pytorch/pull/100849 . The old PR turnd nnc_* functions into static. We now add declarations for them and hope that inter builds will pass.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/102228
Approved by: https://github.com/albanD
2023-06-02 22:04:44 +00:00
PyTorch MergeBot
32ce06a5ab
Revert "[Reland] fix missing-prototypes warnings in torch_cpu (Part 4) ( #101949 )"
...
This reverts commit 4f2c007a1bhttps://github.com/pytorch/pytorch/pull/101949 on behalf of https://github.com/osalpekar due to As noted in @izaitsevfb's comment, we are still seeing linker errors, this time due to `nnc_prepacked_linear_clamp_run` being made a static function. ([comment](https://github.com/pytorch/pytorch/pull/101949#issuecomment-1560226880 ))
2023-05-23 22:53:47 +00:00
cyy
4f2c007a1b
[Reland] fix missing-prototypes warnings in torch_cpu (Part 4) ( #101949 )
...
This PR relands the changes introduced in PR #100849 . The old PR turnd nnc_aten_embedding into a static function, however, it is actually used in torch/csrc/jit/tensorexpr/operators/misc.cpp.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/101949
Approved by: https://github.com/albanD
2023-05-22 10:53:07 +00:00
PyTorch MergeBot
498c34e8e8
Revert " fix missing-prototypes warnings in torch_cpu (Part 4) ( #100849 )"
...
This reverts commit c2f28d1c1dhttps://github.com/pytorch/pytorch/pull/100849 on behalf of https://github.com/izaitsevfb due to fails internal Meta builds, including fbcode and android, see D46009888: ld.lld: error: undefined symbol: nnc_aten_embedding ([comment](https://github.com/pytorch/pytorch/pull/100849#issuecomment-1555105800 ))
2023-05-19 19:05:15 +00:00
cyy
c2f28d1c1d
fix missing-prototypes warnings in torch_cpu (Part 4) ( #100849 )
...
This PR fixes more missing-prototypes violations in the torch_cpu source following PRs #100053 , #100147 and #100245
Pull Request resolved: https://github.com/pytorch/pytorch/pull/100849
Approved by: https://github.com/albanD
2023-05-18 03:49:45 +00:00
Aaron Gokaslan
0247ed27cc
Apply Clang-Tidy readability-container-size-empty ( #93236 )
...
Not only is this change usually shorter and more readable, it also can yield better performance. size() is not always a constant time operation (such as on LinkedLists), but empty() always is.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/93236
Approved by: https://github.com/malfet
2023-01-29 23:28:19 +00:00
Tugsbayasgalan Manlaibaatar
559e2d8816
Implement optimization bisect ( #49031 )
...
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/49031
Test Plan: Imported from OSS
Reviewed By: nikithamalgifb
Differential Revision: D25691790
Pulled By: tugsbayasgalan
fbshipit-source-id: a9c4ff1142f8a234a4ef5b1045fae842c82c18bf
2021-01-11 12:25:28 -08:00
