Aaron Orenstein
00ffeca1b1
PEP585 update - torch/distributed ( #145164 )
...
See #145101 for details.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/145164
Approved by: https://github.com/bobrenjc93
2025-01-21 04:23:29 +00:00
PyTorch MergeBot
6374332d33
Revert "PEP585 update - torch/distributed ( #145164 )"
...
This reverts commit 6cb186e279https://github.com/pytorch/pytorch/pull/145164 on behalf of https://github.com/huydhn due to Sorry for reverting your change but it is failing an inductor test ([comment](https://github.com/pytorch/pytorch/pull/145164#issuecomment-2602875679 ))
2025-01-20 16:46:46 +00:00
Aaron Orenstein
6cb186e279
PEP585 update - torch/distributed ( #145164 )
...
See #145101 for details.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/145164
Approved by: https://github.com/bobrenjc93
2025-01-20 00:19:01 +00:00
bobrenjc93
08be9ec312
Migrate from Tuple -> tuple in torch/distributed ( #144258 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/144258
Approved by: https://github.com/aorenste
2025-01-10 08:34:54 +00:00
Yifu Wang
3d26c08dda
Fix unintended deprecation warning in torch.distributed.optim ( #140889 )
...
We have a deprecation warning for scripted functional optimizer at module level in `torch/distributed/optim/__init__.py`. However, not all optimizers exposed by the module are scripted functional optimizers, causing some false deprecation warning (e.g. https://github.com/pytorch/pytorch/issues/139661 ).
This PR moves the deprecation warning to the `__init__` functions of the deprecated scripted functional optimizers.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/140889
Approved by: https://github.com/d4l3k , https://github.com/kwen2501 , https://github.com/XilunWu
2024-11-18 02:34:51 +00:00
Xuehai Pan
3b798df853
[BE][Easy] enable UFMT for torch/distributed/{fsdp,optim,rpc}/ ( #128869 )
...
Part of #123062
- #123062
Pull Request resolved: https://github.com/pytorch/pytorch/pull/128869
Approved by: https://github.com/fegin
ghstack dependencies: #128868
2024-06-18 21:49:08 +00:00
Aaron Orenstein
7c12cc7ce4
Flip default value for mypy disallow_untyped_defs [6/11] ( #127843 )
...
See #127836 for details.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/127843
Approved by: https://github.com/oulgen
ghstack dependencies: #127842
2024-06-08 18:49:29 +00:00
Michael Lazos
16771747c2
Add tensor step and capturable support to rprop ( #122261 )
...
Towards fixing https://github.com/pytorch/pytorch/issues/115679
Fixes Rprop step update while compiling
Also adds capturable support + testing
Pull Request resolved: https://github.com/pytorch/pytorch/pull/122261
Approved by: https://github.com/janeyx99
2024-03-28 23:31:18 +00:00
Jon Chuang
f74d766632
feat(optim): use has_complex shortcut flag for all applicable optimizers, use _view_as_real auxiliary function ( #110706 )
...
Follow up to: https://github.com/pytorch/pytorch/pull/110607
CC: @lezcano @janeyx99
Pull Request resolved: https://github.com/pytorch/pytorch/pull/110706
Approved by: https://github.com/lezcano
2023-10-31 20:33:03 +00:00
Aaron Gokaslan
8fce9a09cd
[BE]: pyupgrade Python to 3.8 - imports and object inheritance only ( #94308 )
...
Apply parts of pyupgrade to torch (starting with the safest changes).
This PR only does two things: removes the need to inherit from object and removes unused future imports.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/94308
Approved by: https://github.com/ezyang , https://github.com/albanD
2023-02-07 21:10:56 +00:00
fduwjj
1a48ae96ba
[PT-D][Easy] Reformat the optim code within PTD code base ( #90399 )
...
Just run two commands:
```
ufmt format torch/distributed/optim/
ufmt format test/distributed/optim/
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/90399
Approved by: https://github.com/awgu
2022-12-08 06:38:59 +00:00
Rob Zinkov
ff75562cff
Adding maximize to rprop ( #81864 )
...
Added the maximize flag #68052 to rprop optimizer and updates the respective tests.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/81864
Approved by: https://github.com/albanD
2022-08-16 08:19:46 +00:00
anjali411
93912b1a73
Add __all__ to torch.distributed submodules ( #80523 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/80523
Approved by: https://github.com/rohan-varma
2022-07-11 06:54:24 +00:00
PyTorch MergeBot
0b8a5ca01b
Revert "Adding maximize to rprop ( #80335 )"
...
This reverts commit 495aa9bc3ahttps://github.com/pytorch/pytorch/pull/80335 on behalf of https://github.com/albanD due to Broke rocm and windows test
2022-07-08 13:34:02 +00:00
Rob Zinkov
495aa9bc3a
Adding maximize to rprop ( #80335 )
...
Added the maximize flag #68052 to rprop optimizer and updates the respective tests.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/80335
Approved by: https://github.com/albanD
2022-07-08 08:04:38 +00:00
Mikayla Gawarecki
dff58d519f
Optim foreach cleanup for Rprop ( #70483 )
...
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/70483
Test Plan: Imported from OSS
Reviewed By: anjali411
Differential Revision: D33767866
Pulled By: mikaylagawarecki
fbshipit-source-id: ffc5ae68eeea8fa09385862b853b731554b77bcb
(cherry picked from commit 3a0fe29580
2022-02-15 18:02:08 +00:00
Andrew Gu
1b1f1e36b4
Add `allow_empty_param_list` to functional optimizers ( #62522 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/62522
Addresses https://github.com/pytorch/pytorch/issues/62481
Test Plan: Imported from OSS
Reviewed By: zou3519
Differential Revision: D30072074
Pulled By: andwgu
fbshipit-source-id: 1a5da21f9636b8d74a6b00c0f029427f0edff0e3
2021-08-09 11:18:56 -07:00
Wanchao Liang
af0f083d42
[dist_optim] fix the bug of none grads on functional optimizers ( #62249 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/62249
parameter and grads passed to torch.optim.functional should always match, we should skip the parameters that have none gradients to avoid the size mismatch
ghstack-source-id: 134452467
Test Plan: test_dist_optim_none_grads
Reviewed By: mrshenli
Differential Revision: D29929653
fbshipit-source-id: 4ca6167fecdfe1db422236655edee3aa59b8b044
2021-07-27 18:10:51 -07:00
Wanchao Liang
4611387608
[optim] take kw-only argument for functional optim APIs ( #56185 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/56185
ghstack-source-id: 126670123
Reviewed By: albanD
Differential Revision: D27802169
fbshipit-source-id: f5e1cb2046dcdeecf5f6b0f70892828bf0adb22f
2021-04-15 20:08:04 -07:00
Wanchao Liang
dd090e72b2
[dist_optim] add distributed functional rprop optimizer ( #55834 )
...
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/55834
ghstack-source-id: 126325536
Reviewed By: rohan-varma
Differential Revision: D27703878
fbshipit-source-id: 5c8ec9a4ccb4442b2b51d48d75ea5cd506179f14
2021-04-15 15:19:44 -07:00
