mirror of
https://github.com/zebrajr/pytorch.git
synced 2025-12-06 12:20:52 +01:00
master
155 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Yuanyuan Chen
|
f91899ca6c |
[2/N] Add strict parameter to Python zip calls (#166257)
This PR adds `strict=True/False` to zip calls in test utils. strict=True is passed when possible. Pull Request resolved: https://github.com/pytorch/pytorch/pull/166257 Approved by: https://github.com/janeyx99 |
||
|
PyTorch MergeBot
|
f60751024e |
Revert "[2/N] Add strict parameter to Python zip calls (#166257)"
This reverts commit |
||
|
Yuanyuan Chen
|
39e5cdddf7 |
[2/N] Add strict parameter to Python zip calls (#166257)
This PR adds `strict=True/False` to zip calls in test utils. strict=True is passed when possible. Pull Request resolved: https://github.com/pytorch/pytorch/pull/166257 Approved by: https://github.com/janeyx99 |
||
|
Maggie Moss
|
84b14f3a10 |
Fix error suppression syntax in utils and nn (#166242)
Fixes syntax for pyrefly : ignores so they only ignore a specific category. No functional changes pyrefly check lintrunner Pull Request resolved: https://github.com/pytorch/pytorch/pull/166242 Approved by: https://github.com/oulgen, https://github.com/cyyever |
||
|
KarhouTam
|
bf5aeb3148 |
[torch/utils][Code Clean] Clean asserts in hipify/, jit/, model_dump and tensorboard of torch/utils (#165311)
Including: - `torch/utils/hipify/` - `torch/utils/jit/` - `torch/utils/model_dump/` - `torch/utils/tensorboard/` Fixes part of #164878 Pull Request resolved: https://github.com/pytorch/pytorch/pull/165311 Approved by: https://github.com/albanD |
||
|
Yuanyuan Chen
|
70925bdf82 |
[1/N] Use "is" in python type comparison (#165037)
It generally recommended to use `is/is not` to compare types. Therefore this series of changes apply this suggestion in the code base, and it aims to finally enabling related linter checks. Pull Request resolved: https://github.com/pytorch/pytorch/pull/165037 Approved by: https://github.com/mlazos |
||
|
Maggie Moss
|
c855f8632e |
Pyrefly suppressions 7/n (#164913)
Adds suppressions to pyrefly will typecheck clean: https://github.com/pytorch/pytorch/issues/163283 Almost there! Test plan: dmypy restart && python3 scripts/lintrunner.py -a pyrefly check step 1: delete lines in the pyrefly.toml file from the project-excludes field step 2: run pyrefly check step 3: add suppressions, clean up unused suppressions before: https://gist.github.com/maggiemoss/4b3bf2037014e116bc00706a16aef199 after: INFO 0 errors (6,884 ignored) Pull Request resolved: https://github.com/pytorch/pytorch/pull/164913 Approved by: https://github.com/oulgen |
||
|
Maggie Moss
|
086dec3235 |
Pyrefly suppressions 6/n (#164877)
Adds suppressions to pyrefly will typecheck clean: https://github.com/pytorch/pytorch/issues/163283 Almost there! Test plan: dmypy restart && python3 scripts/lintrunner.py -a pyrefly check step 1: delete lines in the pyrefly.toml file from the project-excludes field step 2: run pyrefly check step 3: add suppressions, clean up unused suppressions before: https://gist.github.com/maggiemoss/4b3bf2037014e116bc00706a16aef199 after: INFO 0 errors (5,064 ignored) Only four directories left to enable Pull Request resolved: https://github.com/pytorch/pytorch/pull/164877 Approved by: https://github.com/oulgen |
||
|
Yuanyuan Chen
|
f7ab8a2710 |
[1/N] Fix ruff warnings (#164333)
Fixes #ISSUE_NUMBER Pull Request resolved: https://github.com/pytorch/pytorch/pull/164333 Approved by: https://github.com/albanD |
||
|
Clark Kang
|
6d64bc3990 |
[data foundation][vizard] Prevent checking the device type of numpy object in Tensorboard logger (#162888)
Summary: The check is introduced in D82262053 - `scalar_value` could be a numpy object - Move the check of `device.type` into `make_np` method where it happens only when it's a `torch.Tensor`. Test Plan: ``` vizard launch -j 1x8 --launch=flow --config-path=pkg://vizard_projects.image_classification.configs --config-name=resnet50 ++flow.secure_group=ml_sensors ++flow.entitlement=ai_frameworks_pnb ++max_train_steps_per_epoch=10 ++max_epochs=5 ++log_every_n_steps=10 ++profiler=null ++max_eval_steps_per_epoch=10 ``` Rollback Plan: Differential Revision: D82383428 Pull Request resolved: https://github.com/pytorch/pytorch/pull/162888 Approved by: https://github.com/xush6528 |
||
|
Xuehai Pan
|
d40aaa42ee |
[BE][16/16] fix typos in torch/ (torch/utils/) (#156606)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/156606 Approved by: https://github.com/albanD ghstack dependencies: #156318, #156320, #156602, #156604 |
||
|
Bob Ren
|
7709ff5512 |
[remove untyped defs] batch 1 (#157011)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/157011 Approved by: https://github.com/Skylion007 |
||
|
Anthony Shoumikhin
|
e2f9759bd0 |
Fix broken URLs (#152237)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/152237 Approved by: https://github.com/huydhn, https://github.com/malfet |
||
|
Matthew Hoffman
|
1ae7cc41ca |
Define __all__ for torch.utils.tensorboard (#147550)
Fixes the issue: ```python import torch.utils.tensorboard torch.utils.tensorboard.FileWriter # pyright: "FileWriter" is not exported from module "torch.utils.tensorboard" torch.utils.tensorboard.RecordWriter # pyright: "RecordWriter" is not exported from module "torch.utils.tensorboard" torch.utils.tensorboard.SummaryWriter # pyright: "SummaryWriter" is not exported from module "torch.utils.tensorboard" ``` The [docs page for `torch.utils.tensorboard`](https://pytorch.org/docs/stable/tensorboard.html) Pull Request resolved: https://github.com/pytorch/pytorch/pull/147550 Approved by: https://github.com/albanD |
||
|
Aaron Orenstein
|
2f9d378f7b |
PEP585 update - torch/utils (#145201)
See #145101 for details. Pull Request resolved: https://github.com/pytorch/pytorch/pull/145201 Approved by: https://github.com/bobrenjc93 |
||
|
bobrenjc93
|
af823bd526 |
remove allow-untyped-defs from utils/tensorboard/_convert_np.py (#143918)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/143918 Approved by: https://github.com/Skylion007 |
||
|
Alex Kiefer
|
2f1191fb6a |
Corrected metadata variable names (#142342)
Fixes #142341 Pull Request resolved: https://github.com/pytorch/pytorch/pull/142342 Approved by: https://github.com/janeyx99 |
||
|
Aaron Gokaslan
|
12e95aa4ee |
[BE]: Apply PERF401 autofixes from ruff (#140980)
* Automatically applies ruff rule 401. Turns loops into equivalent list comprehensions which are faster and do not leak the scope of the loop variables. * list comprehensions not only often have better typing, but are 50+% faster than for loops on overhead. They also preserve length information etc and are better for the interpreter to optimize. * Manually went back and made mypy happy after the change. * Also fixed style lints in files covered by flake8 but not by pyfmt Pull Request resolved: https://github.com/pytorch/pytorch/pull/140980 Approved by: https://github.com/justinchuby, https://github.com/malfet |
||
|
Tom Ritchford
|
c0582fd0f8 |
Remove unused Python variables in torch/[b-z]* (#136963)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/136963 Approved by: https://github.com/ezyang |
||
|
Ramana Sundararaman
|
be4b7e8131 |
Param fixes in docstring (#136097)
Fixes wrong param names in docstrings. cc: @kit1980 Pull Request resolved: https://github.com/pytorch/pytorch/pull/136097 Approved by: https://github.com/ezyang |
||
|
Igor Sugak
|
bce52d0b60 |
[CODEMOD][caffe2] use npt.NDArray instead of np.ndarray in type annotations (#136288)
Summary: To facilitate PSS-2 upgrade, this uses `ndt.NDArray` instead of `nd.ndarray` in type annotations. In Numpy-1.19 (PSS-1) it's an alias to `nd.ndarray` -- a noop. In Numpy-1.24, `ndt.NDArray` a proper generic type, and without this change uses of `nd.ndarray` generate this Pyre type error: ```counterexample Invalid type parameters [24]: Generic type `np.ndarray` expects 2 type parameters. ``` Test Plan: Sandcastle plus visual inspection Differential Revision: D62977370 Pull Request resolved: https://github.com/pytorch/pytorch/pull/136288 Approved by: https://github.com/kit1980 |
||
|
Aaron Orenstein
|
57536286e2 |
Flip default value for mypy disallow_untyped_defs [10/11] (#127847)
See #127836 for details. Pull Request resolved: https://github.com/pytorch/pytorch/pull/127847 Approved by: https://github.com/oulgen ghstack dependencies: #127842, #127843, #127844, #127845, #127846 |
||
|
Aaron Gokaslan
|
95b2766864 |
[BE][Ez]: Use NotADirectoryError in tensorboard writer (#126534)
Slightly improve exception typing for tensorboard wrriter Pull Request resolved: https://github.com/pytorch/pytorch/pull/126534 Approved by: https://github.com/ezyang |
||
|
Aaron Gokaslan
|
34910f87f0 |
[BE]: Update ruff to v0.4.4 (#125031)
Update ruff version to 0.4.2. This version mostly has bugfixes for the new parser and also updates the f-string rule to be able to apply more fixes. Pull Request resolved: https://github.com/pytorch/pytorch/pull/125031 Approved by: https://github.com/albanD, https://github.com/malfet |
||
|
cyy
|
45628e3b66 |
Remove Caffe2 python (#125143)
This PR tries to decompose https://github.com/pytorch/pytorch/pull/122527 into a smaller one. Caffe2 python build scripts were removed and some tensorboard code using Caffe2 was removed too. To be noted, this was inspired and is co-dev with @r-barnes. Pull Request resolved: https://github.com/pytorch/pytorch/pull/125143 Approved by: https://github.com/r-barnes, https://github.com/albanD |
||
|
Aaron Gokaslan
|
8cad88e1f3 |
[BE]: Improve exception typing. Remove NOQAs (#125535)
Improve some exception typing Pull Request resolved: https://github.com/pytorch/pytorch/pull/125535 Approved by: https://github.com/albanD |
||
|
Nikita Shulga
|
de5d689cf9 |
[EZ] Update pillow to 10.3.0 (#124614)
As older versions as subject to [CVE-2024-28219](https://nvd.nist.gov/vuln/detail/CVE-2024-28219), although it's not super important from CI PoV Modernize `torch/utils/tensorboard/summary.py` to use Pillow-9+ APIs (is this file even used for anything anymore?) Pull Request resolved: https://github.com/pytorch/pytorch/pull/124614 Approved by: https://github.com/Skylion007, https://github.com/ZainRizvi |
||
|
Aaron Gokaslan
|
c5fafe9f48 |
[BE]: TRY002 - Ban raising vanilla exceptions (#124570)
Adds a ruff lint rule to ban raising raw exceptions. Most of these should at the very least be runtime exception, value errors, type errors or some other errors. There are hundreds of instance of these bad exception types already in the codebase, so I have noqa'd most of them. Hopefully this error code will get commiters to rethink what exception type they should raise when they submit a PR. I also encourage people to gradually go and fix all the existing noqas that have been added so they can be removed overtime and our exception typing can be improved. Pull Request resolved: https://github.com/pytorch/pytorch/pull/124570 Approved by: https://github.com/ezyang |
||
|
Aaron Gokaslan
|
29cc293725 |
[BE]: FURB142 - Remove set mutations. Use set update (#124551)
Uses set mutation methods instead of manually reimplementing (update, set_difference etc). Pull Request resolved: https://github.com/pytorch/pytorch/pull/124551 Approved by: https://github.com/ezyang |
||
|
Matěj Kripner
|
bd59e1113d |
Improve docstring for tensorboard add_embedding() (#120408)
Fixes missing parameter documentation (`metadata_header`). Fixes a typo. Adds a note explaining a somewhat confusing behavior of Tensorboard Projector where categorical values with more than 50 unique values are not permitted to be used for coloring. This was not documented anywhere. The confusion caused https://github.com/tensorflow/tensorboard/issues/61. Pull Request resolved: https://github.com/pytorch/pytorch/pull/120408 Approved by: https://github.com/albanD |
||
|
Vikram Srivastava
|
bcf35c6ae6 |
[tensorboard] Handle bfloat16 type in add_histogram (#120087)
Summary: add_histogram fails for this data type. Updating conversion code to handle it. Stack trace for the failure - ` [trainer0]Traceback (most recent call last): [trainer0] File "<torch_package_0>.tensorboard/logging/summary_v2.py", line 203, in unscriptable_record_summary [trainer0] unscriptable_histogram(name, t, step, ranks) [trainer0] File "<torch_package_0>.tensorboard/logging/fx_v1.py", line 146, in unscriptable_histogram [trainer0] Adhoc.writer().add_histogram(tag, x, step.int()) [trainer0] File "/tmp/aienv/images/aienv_image_09slg3j1/torch/utils/tensorboard/writer.py", line 40, in wrapper [trainer0] resp = super_method(*args, **kwargs) [trainer0] File "/tmp/aienv/images/aienv_image_09slg3j1/torch/utils/tensorboard/writer_oss.py", line 526, in add_histogram [trainer0] histogram(tag, values, bins, max_bins=max_bins), global_step, walltime [trainer0] File "/tmp/aienv/images/aienv_image_09slg3j1/torch/utils/tensorboard/summary.py", line 482, in histogram [trainer0] values = make_np(values) [trainer0] File "/tmp/aienv/images/aienv_image_09slg3j1/torch/utils/tensorboard/_convert_np.py", line 23, in make_np [trainer0] return _prepare_pytorch(x) [trainer0] File "/tmp/aienv/images/aienv_image_09slg3j1/torch/utils/tensorboard/_convert_np.py", line 30, in _prepare_pytorch [trainer0] x = x.detach().cpu().numpy() [trainer0]TypeError: Got unsupported ScalarType BFloat16 ` Test Plan: Updated unit test that was failing before but passes after this change. Reviewed By: hamzajzmati, jcarreiro Differential Revision: D53841197 Pull Request resolved: https://github.com/pytorch/pytorch/pull/120087 Approved by: https://github.com/jcarreiro, https://github.com/yanboliang |
||
|
Catherine Lee
|
4f5785b6b3 |
Enable possibly-undefined error code (#118533)
Fixes https://github.com/pytorch/pytorch/issues/118129 Suppressions automatically added with ``` import re with open("error_file.txt", "r") as f: errors = f.readlines() error_lines = {} for error in errors: match = re.match(r"(.*):(\d+):\d+: error:.*\[(.*)\]", error) if match: file_path, line_number, error_type = match.groups() if file_path not in error_lines: error_lines[file_path] = {} error_lines[file_path][int(line_number)] = error_type for file_path, lines in error_lines.items(): with open(file_path, "r") as f: code = f.readlines() for line_number, error_type in sorted(lines.items(), key=lambda x: x[0], reverse=True): code[line_number - 1] = code[line_number - 1].rstrip() + f" # type: ignore[{error_type}]\n" with open(file_path, "w") as f: f.writelines(code) ``` Signed-off-by: Edward Z. Yang <ezyang@meta.com> Co-authored-by: Catherine Lee <csl@fb.com> Pull Request resolved: https://github.com/pytorch/pytorch/pull/118533 Approved by: https://github.com/Skylion007, https://github.com/zou3519 |
||
|
PyTorch MergeBot
|
40ece2e579 |
Revert "Enable possibly-undefined error code (#118533)"
This reverts commit
|
||
|
Edward Z. Yang
|
4f13f69a45 |
Enable possibly-undefined error code (#118533)
Fixes https://github.com/pytorch/pytorch/issues/118129 Suppressions automatically added with ``` import re with open("error_file.txt", "r") as f: errors = f.readlines() error_lines = {} for error in errors: match = re.match(r"(.*):(\d+):\d+: error:.*\[(.*)\]", error) if match: file_path, line_number, error_type = match.groups() if file_path not in error_lines: error_lines[file_path] = {} error_lines[file_path][int(line_number)] = error_type for file_path, lines in error_lines.items(): with open(file_path, "r") as f: code = f.readlines() for line_number, error_type in sorted(lines.items(), key=lambda x: x[0], reverse=True): code[line_number - 1] = code[line_number - 1].rstrip() + f" # type: ignore[{error_type}]\n" with open(file_path, "w") as f: f.writelines(code) ``` Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: https://github.com/pytorch/pytorch/pull/118533 Approved by: https://github.com/Skylion007, https://github.com/zou3519 |
||
|
Sacha
|
bc0d8649a4 |
Fix missing dependency in torch.utils.tensorboard (#115598)
Fixes #114591 Version package was removed in this pull request: #114108 but is still used in `torch.utils.tensorboard` causing import errors. The fix removes the import and uses a simpler check. Pull Request resolved: https://github.com/pytorch/pytorch/pull/115598 Approved by: https://github.com/malfet |
||
|
Aaron Gokaslan
|
ee5d981249 |
[BE]: Enable RUFF PERF402 and apply fixes (#115505)
* Enable PERF402. Makes code more efficient and succinct by removing useless list copies that could be accomplished either via a list constructor or extend call. All test cases have noqa added since performance is not as sensitive in that folder. Pull Request resolved: https://github.com/pytorch/pytorch/pull/115505 Approved by: https://github.com/malfet |
||
|
albanD
|
296c9e3ce7 |
upgrade lintrunner to the lowest supported versions on python 3.12 (#113562)
As per title, the current versions fail to install on 3.12. The failures are related to https://github.com/numpy/numpy/issues/25147 They are fixed by adding manual annotations for the code in PyTorch and ignoring them on caffe2 as discussed with @malfet. Pull Request resolved: https://github.com/pytorch/pytorch/pull/113562 Approved by: https://github.com/malfet |
||
|
ChanBong
|
2ea3d64f47 |
fix docstring issues in torch.utils.tensorboard (#113336)
Fixes #112637 Fixed all the issues listed. ### Error Counts |File | Count Before | Count now| |---- | ---- | ---- | |`torch/utils/tensorboard/_proto_graph.py` | 9 | 0| |`torch/utils/tensorboard/_pytorch_graph.py` | 27 | 14| |`torch/utils/tensorboard/_utils.py` | 5 | 2| |`torch/utils/tensorboard/summary.py` | 27 | 12| |`torch/utils/tensorboard/writer.py` | 42 | 4| |`torch/utils/tensorboard/_caffe2_graph.py` | 19 | 0| |`torch/utils/hipify/constants.py` | 2 | 0| Pull Request resolved: https://github.com/pytorch/pytorch/pull/113336 Approved by: https://github.com/ezyang |
||
|
NVS Abhilash
|
f58ecd4823 |
docs: fix docstrings for datapipes and other (#112765)
Fixes #112636 Before: 265 ``` torch/utils/data/datapipes/dataframe/structures.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/dataframe/structures.py:8 in public class `DataChunkDF`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/dataframe/structures.py:8 in public class `DataChunkDF`: D208: Docstring is over-indented torch/utils/data/datapipes/dataframe/structures.py:8 in public class `DataChunkDF`: D400: First line should end with a period (not ',') torch/utils/data/datapipes/dataframe/structures.py:13 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/dataframe/structures.py:17 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/datapipe.py:43 in public class `IterDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/datapipe.py:119 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:122 in public method `__getattr__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:135 in public method `register_function`: D102: Missing docstring in public method torch/utils/data/datapipes/datapipe.py:139 in public method `register_datapipe_as_function`: D102: Missing docstring in public method torch/utils/data/datapipes/datapipe.py:161 in public method `__getstate__`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/datapipe.py:161 in public method `__getstate__`: D401: First line should be in imperative mood; try rephrasing (found 'This') torch/utils/data/datapipes/datapipe.py:171 in public method `__reduce_ex__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:180 in public method `set_getstate_hook`: D102: Missing docstring in public method torch/utils/data/datapipes/datapipe.py:186 in public method `set_reduce_ex_hook`: D102: Missing docstring in public method torch/utils/data/datapipes/datapipe.py:191 in public method `__repr__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:197 in public method `__str__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:203 in public method `__dir__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:208 in public method `reset`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/datapipe.py:208 in public method `reset`: D400: First line should end with a period (not ',') torch/utils/data/datapipes/datapipe.py:217 in public class `DFIterDataPipe`: D101: Missing docstring in public class torch/utils/data/datapipes/datapipe.py:223 in public class `MapDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/datapipe.py:261 in public method `__getattr__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:274 in public method `register_function`: D102: Missing docstring in public method torch/utils/data/datapipes/datapipe.py:278 in public method `register_datapipe_as_function`: D102: Missing docstring in public method torch/utils/data/datapipes/datapipe.py:293 in public method `__getstate__`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/datapipe.py:293 in public method `__getstate__`: D401: First line should be in imperative mood; try rephrasing (found 'This') torch/utils/data/datapipes/datapipe.py:303 in public method `__reduce_ex__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:312 in public method `set_getstate_hook`: D102: Missing docstring in public method torch/utils/data/datapipes/datapipe.py:318 in public method `set_reduce_ex_hook`: D102: Missing docstring in public method torch/utils/data/datapipes/datapipe.py:323 in public method `__repr__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:329 in public method `__str__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:335 in public method `__dir__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:392 in public class `DataChunk`: D101: Missing docstring in public class torch/utils/data/datapipes/datapipe.py:393 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/datapipe.py:397 in public method `as_str`: D102: Missing docstring in public method torch/utils/data/datapipes/datapipe.py:401 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:404 in public method `raw_iterator`: D102: Missing docstring in public method torch/utils/data/datapipes/iter/callable.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/callable.py:23 in public class `MapperIterDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/iter/callable.py:23 in public class `MapperIterDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/iter/callable.py:63 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/callable.py:121 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/callable.py:125 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/callable.py:173 in public class `CollatorIterDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/iter/callable.py:213 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/combinatorics.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/combinatorics.py:18 in public class `SamplerIterDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/iter/combinatorics.py:29 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/combinatorics.py:44 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combinatorics.py:47 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combinatorics.py:56 in public class `ShufflerIterDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/iter/combinatorics.py:56 in public class `ShufflerIterDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/iter/combinatorics.py:56 in public class `ShufflerIterDataPipe`: D400: First line should end with a period (not 'r') torch/utils/data/datapipes/iter/combinatorics.py:94 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/combinatorics.py:114 in public method `set_shuffle`: D102: Missing docstring in public method torch/utils/data/datapipes/iter/combinatorics.py:118 in public method `set_seed`: D102: Missing docstring in public method torch/utils/data/datapipes/iter/combinatorics.py:122 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combinatorics.py:137 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combinatorics.py:142 in public method `reset`: D102: Missing docstring in public method torch/utils/data/datapipes/iter/combinatorics.py:150 in public method `__getstate__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combinatorics.py:165 in public method `__setstate__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combinatorics.py:179 in public method `__del__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combining.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/combining.py:26 in public class `ConcaterIterDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/iter/combining.py:26 in public class `ConcaterIterDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/iter/combining.py:26 in public class `ConcaterIterDataPipe`: D400: First line should end with a period (not 'l') torch/utils/data/datapipes/iter/combining.py:44 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/combining.py:51 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combining.py:55 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combining.py:64 in public class `ForkerIterDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/iter/combining.py:92 in public method `__new__`: D102: Missing docstring in public method torch/utils/data/datapipes/iter/combining.py:108 in private class `_ContainerTemplate`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/iter/combining.py:108 in private class `_ContainerTemplate`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/iter/combining.py:108 in private class `_ContainerTemplate`: D400: First line should end with a period (not 'd') torch/utils/data/datapipes/iter/combining.py:126 in private method `get_length_by_instance`: D200: One-line docstring should fit on one line with quotes (found 3) torch/utils/data/datapipes/iter/combining.py:126 in private method `get_length_by_instance`: D400: First line should end with a period (not '`') torch/utils/data/datapipes/iter/combining.py:136 in private class `_ForkerIterDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/iter/combining.py:136 in private class `_ForkerIterDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/iter/combining.py:136 in private class `_ForkerIterDataPipe`: D400: First line should end with a period (not 's') torch/utils/data/datapipes/iter/combining.py:275 in private class `_ChildDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/iter/combining.py:275 in private class `_ChildDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/iter/combining.py:275 in private class `_ChildDataPipe`: D400: First line should end with a period (not 's') torch/utils/data/datapipes/iter/combining.py:320 in private method `_set_main_datapipe_valid_iterator_id`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/iter/combining.py:343 in private method `_check_valid_iterator_id`: D200: One-line docstring should fit on one line with quotes (found 3) torch/utils/data/datapipes/iter/combining.py:351 in public class `DemultiplexerIterDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/iter/combining.py:351 in public class `DemultiplexerIterDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/iter/combining.py:351 in public class `DemultiplexerIterDataPipe`: D400: First line should end with a period (not 'n') torch/utils/data/datapipes/iter/combining.py:384 in public method `__new__`: D102: Missing docstring in public method torch/utils/data/datapipes/iter/combining.py:399 in private class `_DemultiplexerIterDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/iter/combining.py:399 in private class `_DemultiplexerIterDataPipe`: D400: First line should end with a period (not 's') torch/utils/data/datapipes/iter/combining.py:534 in public class `MultiplexerIterDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/iter/combining.py:534 in public class `MultiplexerIterDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/iter/combining.py:534 in public class `MultiplexerIterDataPipe`: D400: First line should end with a period (not ',') torch/utils/data/datapipes/iter/combining.py:549 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/combining.py:553 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combining.py:566 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combining.py:572 in public method `reset`: D102: Missing docstring in public method torch/utils/data/datapipes/iter/combining.py:575 in public method `__getstate__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combining.py:585 in public method `__setstate__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combining.py:593 in public method `__del__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combining.py:599 in public class `ZipperIterDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/iter/combining.py:599 in public class `ZipperIterDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/iter/combining.py:615 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/combining.py:622 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combining.py:626 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/filelister.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/filelister.py:15 in public class `FileListerIterDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/iter/filelister.py:36 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/filelister.py:58 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/filelister.py:62 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/fileopener.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/fileopener.py:15 in public class `FileOpenerIterDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/iter/fileopener.py:15 in public class `FileOpenerIterDataPipe`: D400: First line should end with a period (not 'm') torch/utils/data/datapipes/iter/fileopener.py:42 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/fileopener.py:66 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/fileopener.py:69 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/grouping.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/grouping.py:31 in public class `BatcherIterDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/iter/grouping.py:31 in public class `BatcherIterDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/iter/grouping.py:31 in public class `BatcherIterDataPipe`: D400: First line should end with a period (not 's') torch/utils/data/datapipes/iter/grouping.py:55 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/grouping.py:68 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/grouping.py:79 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/grouping.py:91 in public class `UnBatcherIterDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/iter/grouping.py:91 in public class `UnBatcherIterDataPipe`: D400: First line should end with a period (not 'l') torch/utils/data/datapipes/iter/grouping.py:112 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/grouping.py:118 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/grouping.py:143 in public class `GrouperIterDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/iter/grouping.py:143 in public class `GrouperIterDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/iter/grouping.py:143 in public class `GrouperIterDataPipe`: D400: First line should end with a period (not ',') torch/utils/data/datapipes/iter/grouping.py:185 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/grouping.py:233 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/grouping.py:257 in public method `reset`: D102: Missing docstring in public method torch/utils/data/datapipes/iter/grouping.py:261 in public method `__getstate__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/grouping.py:278 in public method `__setstate__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/grouping.py:294 in public method `__del__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/routeddecoder.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/routeddecoder.py:19 in public class `RoutedDecoderIterDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/iter/routeddecoder.py:19 in public class `RoutedDecoderIterDataPipe`: D400: First line should end with a period (not 'a') torch/utils/data/datapipes/iter/routeddecoder.py:37 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/routeddecoder.py:53 in public method `add_handler`: D102: Missing docstring in public method torch/utils/data/datapipes/iter/routeddecoder.py:56 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/routeddecoder.py:62 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/selecting.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/selecting.py:21 in public class `FilterIterDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/iter/selecting.py:46 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/selecting.py:70 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/sharding.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/sharding.py:17 in public class `SHARDING_PRIORITIES`: D101: Missing docstring in public class torch/utils/data/datapipes/iter/sharding.py:30 in public class `ShardingFilterIterDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/iter/sharding.py:30 in public class `ShardingFilterIterDataPipe`: D400: First line should end with a period (not 's') torch/utils/data/datapipes/iter/sharding.py:39 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/sharding.py:47 in public method `apply_sharding`: D102: Missing docstring in public method torch/utils/data/datapipes/iter/sharding.py:74 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/sharding.py:79 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/streamreader.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/streamreader.py:10 in public class `StreamReaderIterDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/iter/streamreader.py:10 in public class `StreamReaderIterDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/iter/streamreader.py:10 in public class `StreamReaderIterDataPipe`: D400: First line should end with a period (not 'l') torch/utils/data/datapipes/iter/streamreader.py:27 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/streamreader.py:31 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/utils.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/utils.py:9 in public class `IterableWrapperIterDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/iter/utils.py:29 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/utils.py:33 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/utils.py:49 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/callable.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/map/callable.py:14 in public function `default_fn`: D103: Missing docstring in public function torch/utils/data/datapipes/map/callable.py:20 in public class `MapperMapDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/map/callable.py:20 in public class `MapperMapDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/map/callable.py:45 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/map/callable.py:55 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/callable.py:58 in public method `__getitem__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/combinatorics.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/map/combinatorics.py:15 in public class `ShufflerIterDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/map/combinatorics.py:55 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/map/combinatorics.py:68 in public method `set_shuffle`: D102: Missing docstring in public method torch/utils/data/datapipes/map/combinatorics.py:72 in public method `set_seed`: D102: Missing docstring in public method torch/utils/data/datapipes/map/combinatorics.py:76 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/combinatorics.py:85 in public method `reset`: D102: Missing docstring in public method torch/utils/data/datapipes/map/combinatorics.py:92 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/combinatorics.py:95 in public method `__getstate__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/combinatorics.py:110 in public method `__setstate__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/combining.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/map/combining.py:12 in public class `ConcaterMapDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/map/combining.py:12 in public class `ConcaterMapDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/map/combining.py:34 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/map/combining.py:43 in public method `__getitem__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/combining.py:52 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/combining.py:58 in public class `ZipperMapDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/map/combining.py:58 in public class `ZipperMapDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/map/combining.py:76 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/map/combining.py:85 in public method `__getitem__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/combining.py:94 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/grouping.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/map/grouping.py:12 in public class `BatcherMapDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/map/grouping.py:12 in public class `BatcherMapDataPipe`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/map/grouping.py:12 in public class `BatcherMapDataPipe`: D400: First line should end with a period (not 's') torch/utils/data/datapipes/map/grouping.py:34 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/map/grouping.py:47 in public method `__getitem__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/grouping.py:60 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/utils.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/map/utils.py:9 in public class `SequenceWrapperMapDataPipe`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/map/utils.py:32 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/map/utils.py:45 in public method `__getitem__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/utils.py:48 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/utils/common.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/utils/common.py:26 in public function `validate_input_col`: D400: First line should end with a period (not 'n') torch/utils/data/datapipes/utils/common.py:26 in public function `validate_input_col`: D401: First line should be in imperative mood (perhaps 'Check', not 'Checks') torch/utils/data/datapipes/utils/common.py:127 in private function `_check_unpickable_fn`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/utils/common.py:127 in private function `_check_unpickable_fn`: D400: First line should end with a period (not 'g') torch/utils/data/datapipes/utils/common.py:127 in private function `_check_unpickable_fn`: D401: First line should be in imperative mood (perhaps 'Check', not 'Checks') torch/utils/data/datapipes/utils/common.py:156 in public function `match_masks`: D103: Missing docstring in public function torch/utils/data/datapipes/utils/common.py:170 in public function `get_file_pathnames_from_root`: D103: Missing docstring in public function torch/utils/data/datapipes/utils/common.py:207 in public function `get_file_binaries_from_pathnames`: D103: Missing docstring in public function torch/utils/data/datapipes/utils/common.py:220 in public function `validate_pathname_binary_tuple`: D103: Missing docstring in public function torch/utils/data/datapipes/utils/common.py:290 in public class `StreamWrapper`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/utils/common.py:290 in public class `StreamWrapper`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/utils/common.py:290 in public class `StreamWrapper`: D400: First line should end with a period (not 'y') torch/utils/data/datapipes/utils/common.py:298 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/utils/common.py:315 in public method `close_streams`: D200: One-line docstring should fit on one line with quotes (found 3) torch/utils/data/datapipes/utils/common.py:331 in public method `__getattr__`: D105: Missing docstring in magic method torch/utils/data/datapipes/utils/common.py:335 in public method `close`: D102: Missing docstring in public method torch/utils/data/datapipes/utils/common.py:351 in public method `autoclose`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/utils/common.py:351 in public method `autoclose`: D400: First line should end with a period (not 's') torch/utils/data/datapipes/utils/common.py:359 in public method `__dir__`: D105: Missing docstring in magic method torch/utils/data/datapipes/utils/common.py:364 in public method `__del__`: D105: Missing docstring in magic method torch/utils/data/datapipes/utils/common.py:368 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/utils/common.py:371 in public method `__next__`: D105: Missing docstring in magic method torch/utils/data/datapipes/utils/common.py:374 in public method `__repr__`: D105: Missing docstring in magic method torch/utils/data/datapipes/utils/common.py:380 in public method `__getstate__`: D105: Missing docstring in magic method torch/utils/data/datapipes/utils/common.py:383 in public method `__setstate__`: D105: Missing docstring in magic method torch/utils/data/datapipes/utils/decoder.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/utils/decoder.py:31 in public function `basichandlers`: D103: Missing docstring in public function torch/utils/data/datapipes/utils/decoder.py:87 in public function `handle_extension`: D202: No blank lines allowed after function docstring (found 1) torch/utils/data/datapipes/utils/decoder.py:87 in public function `handle_extension`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/utils/decoder.py:87 in public function `handle_extension`: D401: First line should be in imperative mood (perhaps 'Return', not 'Returns') torch/utils/data/datapipes/utils/decoder.py:115 in public class `ImageHandler`: D204: 1 blank line required after class docstring (found 0) torch/utils/data/datapipes/utils/decoder.py:115 in public class `ImageHandler`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/utils/decoder.py:139 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/utils/decoder.py:143 in public method `__call__`: D102: Missing docstring in public method torch/utils/data/datapipes/utils/decoder.py:187 in public function `imagehandler`: D103: Missing docstring in public function torch/utils/data/datapipes/utils/decoder.py:194 in public function `videohandler`: D103: Missing docstring in public function torch/utils/data/datapipes/utils/decoder.py:215 in public function `audiohandler`: D103: Missing docstring in public function torch/utils/data/datapipes/utils/decoder.py:236 in public class `MatHandler`: D101: Missing docstring in public class torch/utils/data/datapipes/utils/decoder.py:237 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/utils/decoder.py:247 in public method `__call__`: D102: Missing docstring in public method torch/utils/data/datapipes/utils/decoder.py:253 in public function `mathandler`: D103: Missing docstring in public function torch/utils/data/datapipes/utils/decoder.py:261 in public function `extension_extract_fn`: D103: Missing docstring in public function torch/utils/data/datapipes/utils/decoder.py:270 in public class `Decoder`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/utils/decoder.py:276 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/utils/decoder.py:282 in public method `add_handler`: D102: Missing docstring in public method torch/utils/data/datapipes/utils/decoder.py:292 in public method `decode1`: D102: Missing docstring in public method torch/utils/data/datapipes/utils/decoder.py:309 in public method `decode`: D102: Missing docstring in public method torch/utils/data/datapipes/utils/decoder.py:326 in public method `__call__`: D102: Missing docstring in public method torch/utils/data/datapipes/utils/snapshot.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/utils/snapshot.py:11 in private function `_simple_graph_snapshot_restoration`: D205: 1 blank line required between summary line and description (found 0) torch/utils/data/datapipes/utils/snapshot.py:11 in private function `_simple_graph_snapshot_restoration`: D400: First line should end with a period (not ',') torch/utils/data/datapipes/utils/snapshot.py:11 in private function `_simple_graph_snapshot_restoration`: D401: First line should be in imperative mood; try rephrasing (found 'This') torch/utils/tensorboard/_convert_np.py:1 at module level: D200: One-line docstring should fit on one line with quotes (found 3) torch/utils/tensorboard/_convert_np.py:9 in public function `make_np`: D205: 1 blank line required between summary line and description (found 0) torch/utils/tensorboard/_convert_np.py:9 in public function `make_np`: D400: First line should end with a period (not ':') 265 ``` After: 166 ``` torch/utils/data/datapipes/dataframe/structures.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/dataframe/structures.py:10 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/dataframe/structures.py:14 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/datapipe.py:120 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:123 in public method `__getattr__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:136 in public method `register_function`: D102: Missing docstring in public method torch/utils/data/datapipes/datapipe.py:140 in public method `register_datapipe_as_function`: D102: Missing docstring in public method torch/utils/data/datapipes/datapipe.py:173 in public method `__reduce_ex__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:182 in public method `set_getstate_hook`: D102: Missing docstring in public method torch/utils/data/datapipes/datapipe.py:188 in public method `set_reduce_ex_hook`: D102: Missing docstring in public method torch/utils/data/datapipes/datapipe.py:193 in public method `__repr__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:199 in public method `__str__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:205 in public method `__dir__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:221 in public class `DFIterDataPipe`: D101: Missing docstring in public class torch/utils/data/datapipes/datapipe.py:266 in public method `__getattr__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:279 in public method `register_function`: D102: Missing docstring in public method torch/utils/data/datapipes/datapipe.py:283 in public method `register_datapipe_as_function`: D102: Missing docstring in public method torch/utils/data/datapipes/datapipe.py:309 in public method `__reduce_ex__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:318 in public method `set_getstate_hook`: D102: Missing docstring in public method torch/utils/data/datapipes/datapipe.py:324 in public method `set_reduce_ex_hook`: D102: Missing docstring in public method torch/utils/data/datapipes/datapipe.py:329 in public method `__repr__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:335 in public method `__str__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:341 in public method `__dir__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:398 in public class `DataChunk`: D101: Missing docstring in public class torch/utils/data/datapipes/datapipe.py:399 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/datapipe.py:403 in public method `as_str`: D102: Missing docstring in public method torch/utils/data/datapipes/datapipe.py:407 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/datapipe.py:410 in public method `raw_iterator`: D102: Missing docstring in public method torch/utils/data/datapipes/iter/callable.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/callable.py:65 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/callable.py:123 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/callable.py:127 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/callable.py:216 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/combinatorics.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/combinatorics.py:30 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/combinatorics.py:45 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combinatorics.py:48 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combinatorics.py:97 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/combinatorics.py:117 in public method `set_shuffle`: D102: Missing docstring in public method torch/utils/data/datapipes/iter/combinatorics.py:121 in public method `set_seed`: D102: Missing docstring in public method torch/utils/data/datapipes/iter/combinatorics.py:125 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combinatorics.py:140 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combinatorics.py:145 in public method `reset`: D102: Missing docstring in public method torch/utils/data/datapipes/iter/combinatorics.py:153 in public method `__getstate__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combinatorics.py:168 in public method `__setstate__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combinatorics.py:182 in public method `__del__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combining.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/combining.py:46 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/combining.py:53 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combining.py:57 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combining.py:95 in public method `__new__`: D102: Missing docstring in public method torch/utils/data/datapipes/iter/combining.py:388 in public method `__new__`: D102: Missing docstring in public method torch/utils/data/datapipes/iter/combining.py:556 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/combining.py:560 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combining.py:573 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combining.py:579 in public method `reset`: D102: Missing docstring in public method torch/utils/data/datapipes/iter/combining.py:582 in public method `__getstate__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combining.py:592 in public method `__setstate__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combining.py:600 in public method `__del__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combining.py:624 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/combining.py:631 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/combining.py:635 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/filelister.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/filelister.py:37 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/filelister.py:59 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/filelister.py:63 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/fileopener.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/fileopener.py:41 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/fileopener.py:65 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/fileopener.py:68 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/grouping.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/grouping.py:57 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/grouping.py:70 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/grouping.py:81 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/grouping.py:115 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/grouping.py:121 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/grouping.py:190 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/grouping.py:238 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/grouping.py:262 in public method `reset`: D102: Missing docstring in public method torch/utils/data/datapipes/iter/grouping.py:266 in public method `__getstate__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/grouping.py:283 in public method `__setstate__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/grouping.py:299 in public method `__del__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/routeddecoder.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/routeddecoder.py:38 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/routeddecoder.py:54 in public method `add_handler`: D102: Missing docstring in public method torch/utils/data/datapipes/iter/routeddecoder.py:57 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/routeddecoder.py:63 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/selecting.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/selecting.py:47 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/selecting.py:71 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/sharding.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/sharding.py:17 in public class `SHARDING_PRIORITIES`: D101: Missing docstring in public class torch/utils/data/datapipes/iter/sharding.py:40 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/sharding.py:48 in public method `apply_sharding`: D102: Missing docstring in public method torch/utils/data/datapipes/iter/sharding.py:75 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/sharding.py:80 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/streamreader.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/streamreader.py:29 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/streamreader.py:33 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/utils.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/iter/utils.py:30 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/iter/utils.py:34 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/iter/utils.py:50 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/callable.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/map/callable.py:14 in public function `default_fn`: D103: Missing docstring in public function torch/utils/data/datapipes/map/callable.py:47 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/map/callable.py:57 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/callable.py:60 in public method `__getitem__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/combinatorics.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/map/combinatorics.py:56 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/map/combinatorics.py:69 in public method `set_shuffle`: D102: Missing docstring in public method torch/utils/data/datapipes/map/combinatorics.py:73 in public method `set_seed`: D102: Missing docstring in public method torch/utils/data/datapipes/map/combinatorics.py:77 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/combinatorics.py:86 in public method `reset`: D102: Missing docstring in public method torch/utils/data/datapipes/map/combinatorics.py:93 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/combinatorics.py:96 in public method `__getstate__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/combinatorics.py:111 in public method `__setstate__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/combining.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/map/combining.py:36 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/map/combining.py:45 in public method `__getitem__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/combining.py:54 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/combining.py:80 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/map/combining.py:89 in public method `__getitem__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/combining.py:98 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/grouping.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/map/grouping.py:36 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/map/grouping.py:49 in public method `__getitem__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/grouping.py:62 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/utils.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/map/utils.py:33 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/map/utils.py:46 in public method `__getitem__`: D105: Missing docstring in magic method torch/utils/data/datapipes/map/utils.py:49 in public method `__len__`: D105: Missing docstring in magic method torch/utils/data/datapipes/utils/common.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/utils/common.py:157 in public function `match_masks`: D103: Missing docstring in public function torch/utils/data/datapipes/utils/common.py:171 in public function `get_file_pathnames_from_root`: D103: Missing docstring in public function torch/utils/data/datapipes/utils/common.py:208 in public function `get_file_binaries_from_pathnames`: D103: Missing docstring in public function torch/utils/data/datapipes/utils/common.py:221 in public function `validate_pathname_binary_tuple`: D103: Missing docstring in public function torch/utils/data/datapipes/utils/common.py:300 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/utils/common.py:331 in public method `__getattr__`: D105: Missing docstring in magic method torch/utils/data/datapipes/utils/common.py:335 in public method `close`: D102: Missing docstring in public method torch/utils/data/datapipes/utils/common.py:356 in public method `__dir__`: D105: Missing docstring in magic method torch/utils/data/datapipes/utils/common.py:361 in public method `__del__`: D105: Missing docstring in magic method torch/utils/data/datapipes/utils/common.py:365 in public method `__iter__`: D105: Missing docstring in magic method torch/utils/data/datapipes/utils/common.py:368 in public method `__next__`: D105: Missing docstring in magic method torch/utils/data/datapipes/utils/common.py:371 in public method `__repr__`: D105: Missing docstring in magic method torch/utils/data/datapipes/utils/common.py:377 in public method `__getstate__`: D105: Missing docstring in magic method torch/utils/data/datapipes/utils/common.py:380 in public method `__setstate__`: D105: Missing docstring in magic method torch/utils/data/datapipes/utils/decoder.py:1 at module level: D100: Missing docstring in public module torch/utils/data/datapipes/utils/decoder.py:31 in public function `basichandlers`: D103: Missing docstring in public function torch/utils/data/datapipes/utils/decoder.py:141 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/utils/decoder.py:145 in public method `__call__`: D102: Missing docstring in public method torch/utils/data/datapipes/utils/decoder.py:189 in public function `imagehandler`: D103: Missing docstring in public function torch/utils/data/datapipes/utils/decoder.py:196 in public function `videohandler`: D103: Missing docstring in public function torch/utils/data/datapipes/utils/decoder.py:217 in public function `audiohandler`: D103: Missing docstring in public function torch/utils/data/datapipes/utils/decoder.py:238 in public class `MatHandler`: D101: Missing docstring in public class torch/utils/data/datapipes/utils/decoder.py:239 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/utils/decoder.py:249 in public method `__call__`: D102: Missing docstring in public method torch/utils/data/datapipes/utils/decoder.py:255 in public function `mathandler`: D103: Missing docstring in public function torch/utils/data/datapipes/utils/decoder.py:263 in public function `extension_extract_fn`: D103: Missing docstring in public function torch/utils/data/datapipes/utils/decoder.py:279 in public method `__init__`: D107: Missing docstring in __init__ torch/utils/data/datapipes/utils/decoder.py:285 in public method `add_handler`: D102: Missing docstring in public method torch/utils/data/datapipes/utils/decoder.py:295 in public method `decode1`: D102: Missing docstring in public method torch/utils/data/datapipes/utils/decoder.py:312 in public method `decode`: D102: Missing docstring in public method torch/utils/data/datapipes/utils/decoder.py:329 in public method `__call__`: D102: Missing docstring in public method torch/utils/data/datapipes/utils/snapshot.py:1 at module level: D100: Missing docstring in public module 166 ``` Pull Request resolved: https://github.com/pytorch/pytorch/pull/112765 Approved by: https://github.com/ejguan |
||
|
Adam J. Stewart
|
0347b36b52 |
SummaryWriter.add_figure: add type hints (#110021)
Discovered a bug in our code that could have been prevented by type hints, so I added them 😄 Pull Request resolved: https://github.com/pytorch/pytorch/pull/110021 Approved by: https://github.com/ezyang |
||
|
Matthew Hoffman
|
098d62d278 |
Add global_step parameter to SummaryWriter.add_hparams (#109572)
Fixes #37738 where all hparam metrics can only be plotted at step 0. This is basically just a resubmission of #50653. before: <img width="345" alt="Screenshot 2023-09-18 at 8 09 13 PM" src="https://github.com/pytorch/pytorch/assets/27844407/89ebb327-9d0f-4e4e-a77a-27067a9d4ca0"> after: <img width="346" alt="Screenshot 2023-09-18 at 7 56 52 PM" src="https://github.com/pytorch/pytorch/assets/27844407/059e0465-c6bf-47fe-974b-2175e57aa62d"> @ngimel @J0Nreynolds @ezyang @albanD Pull Request resolved: https://github.com/pytorch/pytorch/pull/109572 Approved by: https://github.com/ezyang |
||
|
Jason Carreiro
|
fa62308673 |
[tensorboard] Fix TensorBoard summary encoding for torch.bfloat16 tensors (#108351)
Summary:
The `tensor_proto` function in the TensorBoard summary writer code doesn't correctly encode `torch.bfloat16` tensors; it tries to use a data type of `DT_BFLOAT` when creating the protobuf, but `DT_BFLOAT` is not a valid enum value (see `types.proto`). The correct value to use when encoding tensors of this type is `DT_BLOAT16`. This diff updates the type map in the summary code to use the correct type.
While fixing this error, I also noticed the wrong field of the protobuf was being used when encoding tensors of this type; per the docs in the proto file, the DT_HALF and DT_BFLOAT16 types should use the `half_val` field, not `float_val`. Since this might confuse folks trying to read this data from storage in the future, I've updated the code to correctly use to `half_val` field for these cases. Note that there's no real size advantage from doing this, since both the `half_val` and `float_val` fields are 32 bits long.
Test Plan:
Added a parameterized unit test that tests encoding tensors with `torch.half`, `torch.float16`, and `torch.bfloat16` data types.
# Before this change
The test fails with an `ValueError` due to the incorrect enum label:
```
======================================================================
ERROR: test_bfloat16_tensor_proto (test_tensorboard.TestTensorProtoSummary)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/data/users/jcarreiro/fbsource/buck-out/v2/gen/fbcode/f88b3f368c9334db/caffe2/test/__tensorboard__/tensorboard#link-tree/torch/testing/_internal/common_utils.py", line 2382, in wrapper
method(*args, **kwargs)
File "/data/users/jcarreiro/fbsource/buck-out/v2/gen/fbcode/f88b3f368c9334db/caffe2/test/__tensorboard__/tensorboard#link-tree/test_tensorboard.py", line 871, in test_bfloat16_tensor_proto
tensor_proto(
File "/data/users/jcarreiro/fbsource/buck-out/v2/gen/fbcode/f88b3f368c9334db/caffe2/test/__tensorboard__/tensorboard#link-tree/torch/utils/tensorboard/summary.py", line 400, in tensor_proto
tensor_proto = TensorProto(**tensor_proto_args)
ValueError: unknown enum label "DT_BFLOAT"
To execute this test, run the following from the base repo dir:
python test/__tensorboard__/tensorboard#link-tree/test_tensorboard.py -k test_bfloat16_tensor_proto
This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
----------------------------------------------------------------------
```
# After this change
The test passes.
Reviewed By: tanvigupta17
Differential Revision: D48828958
Pull Request resolved: https://github.com/pytorch/pytorch/pull/108351
Approved by: https://github.com/hamzajzmati, https://github.com/XilunWu
|
||
|
Aaron Gokaslan
|
6d43c89f37 |
[BE]: Update Ruff to 0.0.280 (#105724)
Removes unusued loop values in python dictionary iteration. Automated fix from Ruff master Pull Request resolved: https://github.com/pytorch/pytorch/pull/105724 Approved by: https://github.com/ezyang, https://github.com/janeyx99 |
||
|
Justin Chu
|
4cc1745b13 |
[BE] f-stringify torch/ and scripts (#105538)
This PR is a follow up on the pyupgrade series to convert more strings to use f-strings using `flynt`. - https://docs.python.org/3/reference/lexical_analysis.html#f-strings - https://pypi.org/project/flynt/ Command used: ``` flynt torch/ -ll 120 flynt scripts/ -ll 120 flynt tools/ -ll 120 ``` and excluded `collect_env.py` Pull Request resolved: https://github.com/pytorch/pytorch/pull/105538 Approved by: https://github.com/ezyang, https://github.com/malfet |
||
|
Justin Chu
|
abc1cadddb |
[BE] Enable ruff's UP rules and autoformat utils/ (#105424)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/105424 Approved by: https://github.com/ezyang, https://github.com/malfet |
||
|
Seth Sangsu Lee
|
d855c6c7de |
[PyTorch-TB] Write full tensor as tensor proto (#105186)
Write full tensor as tensor proto Pull Request resolved: https://github.com/pytorch/pytorch/pull/105186 Approved by: https://github.com/atalman |
||
|
PyTorch MergeBot
|
d35137cc37 |
Revert "[PyTorch TB] Write raw tensor as tensor_proto (#104908)"
This reverts commit
|
||
|
Sangsu Lee
|
dceae41c29 |
[PyTorch TB] Write raw tensor as tensor_proto (#104908)
This is the first diff to support logging of raw tensors for [TensorBoard Intermediate Logging](https://www.internalfb.com/intern/wiki/TensorBoard/Intermediate_Logging/) Ultimately, we aim to support the feature where store full tensor is stored as a tensor protobuf to TB. Protobuf contains shape, dtype, and elements of the given tensor. 1. add `tensor_proto()` to `summary.py` which takes a tensor and convert to protobuf 2. add `add_tensor()` to `writer.py` 3. formatting changes introduced by `arc lint` ------------- Differential Revision: [D47302017](https://our.internmc.facebook.com/intern/diff/D47302017/) Pull Request resolved: https://github.com/pytorch/pytorch/pull/104908 Approved by: https://github.com/kunalb |
||
|
Sangsu Lee
|
603a777b09 |
[PyTorch TB] Refactor formatting (#105027)
This is the first diff to support logging of raw tensors for [TensorBoard Intermediate Logging](https://www.internalfb.com/intern/wiki/TensorBoard/Intermediate_Logging/) Ultimately, we aim to support the feature where store full tensor is stored as a tensor protobuf to TB. Protobuf contains shape, dtype, and elements of the given tensor. This diff only contains formatting changes. ------------- Differential Revision: [D47302017](https://our.internmc.facebook.com/intern/diff/D47302017/) Pull Request resolved: https://github.com/pytorch/pytorch/pull/105027 Approved by: https://github.com/kunalb |
||
|
Aaron Gokaslan
|
616208b4fe |
[BE]: Cleanup deprecated stdlib imports (UP006,UP035) (#101361)
Automated fix to cleanup some deprecated/useless python imports. Pull Request resolved: https://github.com/pytorch/pytorch/pull/101361 Approved by: https://github.com/zou3519 |