Commit Graph

3 Commits

Author SHA1 Message Date
cyy
0c0d8c8ff0 [1/N] Fix extra warnings brought by clang-tidy-17 (#137407)
Before we can use clang-tidy-17
Pull Request resolved: https://github.com/pytorch/pytorch/pull/137407
Approved by: https://github.com/Skylion007, https://github.com/aaronenyeshi
2024-10-07 17:53:59 +00:00
cyy
1157b4393b Add const reference and std::move in opportunities detected by clang-tidy (#105815)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/105815
Approved by: https://github.com/Skylion007
2023-07-25 12:28:14 +00:00
Salil Desai
8c80a4684b [Vulkan + Profiler] Report Vulkan Events to Profiler in QueryPool (#90670)
@bypass-github-export-checks

With this change, we see Vulkan events reported on the generated chrometrace with proper names and durations.

However, their start/end times are not yet synced with the cpu event timeline, and their parent/child relationships are not established properly. These concerns will be addressed in future diffs

Differential Revision: [D39834807](https://our.internmc.facebook.com/intern/diff/D39834807/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39834807/)!
Pull Request resolved: https://github.com/pytorch/pytorch/pull/90670
Approved by: https://github.com/kimishpatel
2022-12-19 19:56:28 +00:00