Commit Graph

7 Commits

Author SHA1 Message Date
cyy
c764ef6d53 [9/N] Fix clang-tidy warnings in jit (#132010)
Follows  #131997

Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/132010
Approved by: https://github.com/Skylion007
2024-07-29 18:38:35 +00:00
John Clow
ce53baf573 Merging the implementations of ClearProfiling (#67575)
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/67575

Test Plan: Imported from OSS

Reviewed By: albanD

Differential Revision: D32497548

Pulled By: Gamrix

fbshipit-source-id: fb656b017d405487e25bd2407b069a702769659f
2021-11-29 19:48:56 -08:00
Alban Desmaison
0c8569bec9 Revert D32175959: Merging the implementations of ClearProfiling
Test Plan: revert-hammer

Differential Revision:
D32175959 (f1754319e3)

Original commit changeset: b335dacce709

fbshipit-source-id: 23d1f75d47f15effc9806bd6e5228007d521b0b3
2021-11-05 07:03:18 -07:00
John Clow
f1754319e3 Merging the implementations of ClearProfiling (#67575)
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/67575

Test Plan: Imported from OSS

Reviewed By: malfet

Differential Revision: D32175959

Pulled By: Gamrix

fbshipit-source-id: b335dacce709a64e3d5779f9c6e9569f86e10748
2021-11-04 19:02:08 -07:00
Scott Wolchok
2d885ab73d [jit] Reduce refcounting of Types (#65345)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/65345

FooType::get() can return a const reference. Inconveniently, converting shared_ptr<FooType> to shared_ptr<Type> requires a copy & refcount bump, so to properly take advantage of this in unshapedType() we need to take a const Type& in isSubtypeOf(), which is good practice anyway -- don't require a shared_ptr if you don't need to take ownership.
ghstack-source-id: 140044165

Test Plan:
CI

perf says c10::unshapedType time decreased from 2.8% to 2.2% during static runtime startup, though I expect this to be generally beneficial.

Reviewed By: hlu1

Differential Revision: D31027361

fbshipit-source-id: 676feb81db9f74ad7b8651d8774f4ecb4cfa6ab8
2021-10-08 09:03:04 -07:00
Andres Suarez
8530c65e25 [codemod][fbcode/caffe2] Apply clang-format update fixes
Test Plan: Sandcastle and visual inspection.

Reviewed By: igorsugak

Differential Revision: D25849205

fbshipit-source-id: ef664c1ad4b3ee92d5c020a5511b4ef9837a09a0
2021-01-09 14:37:36 -08:00
Nick Korovaiko
767ea03b22 Clear profiling information timely and appropriately (#35814)
Summary:
Clear profiling information before it gets used by passes before guard insertion.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/35814

Differential Revision: D20800599

Pulled By: Krovatkin

fbshipit-source-id: 978d71c22e1880dc888e7e75e7c25501c573333f
2020-04-02 19:14:56 -07:00