Jason Ansel
78bcfcf870
[fx] Optimize torch.fx.Node.replace_all_uses_with ( #165889 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165889
Approved by: https://github.com/aorenste
2025-10-25 03:44:41 +00:00
Jason Ansel
3c3b278872
[reland][fx] Move Node._prepend/Node._remove_from_list to C++ ( #165882 )
...
Relands #148261 that was reverted by #150542
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165882
Approved by: https://github.com/ezyang
2025-10-21 19:43:55 +00:00
Yuanyuan Chen
07bb097698
Fix clang-tidy bugprone* warnings ( #148529 )
...
Fixes #ISSUE_NUMBER
Pull Request resolved: https://github.com/pytorch/pytorch/pull/148529
Approved by: https://github.com/ezyang
2025-06-23 23:09:56 +00:00
Jason Ansel
d41c22b578
Revert "[fx] Move Node._prepend/Node._remove_from_list to C++ ( #148261 )" ( #150542 )
...
Reverts #148261 due to possible memory leak
This reverts commit 5d4e7d58b4https://github.com/pytorch/pytorch/pull/150542
Approved by: https://github.com/clee2000
2025-04-03 21:15:38 +00:00
cyy
8fa81a6066
Enable misc-use-internal-linkage check and apply fixes ( #148948 )
...
Enables clang-tidy rule [`misc-use-internal-linkage`](https://clang.llvm.org/extra/clang-tidy/checks/misc/use-internal-linkage.html ). This new check was introduced in Clang-Tidy 18 and is available due to recent update of Clang-Tidy 19.
The check marks functions and variables used only in the translation unit as static. Therefore undesired symbols are not leaked into other units, more link time optimisations are possible and the resulting binaries may be smaller.
The detected violations were mostly fixed by using static. In other cases, the symbols were indeed consumed by others files, then their declaring headers were included. Still some declarations were wrong and have been fixed.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/148948
Approved by: https://github.com/Skylion007
2025-03-12 14:22:56 +00:00
Jason Ansel
5d4e7d58b4
[fx] Move Node._prepend/Node._remove_from_list to C++ ( #148261 )
...
Microbenchmarking `fx.symbolic_trace(lambda x: functools.reduce(operator.add, [x, *range(100000)]))`, before:
```
24303536 function calls (23503339 primitive calls) in 10.726 seconds
```
after:
```
20003454 function calls (19203257 primitive calls) in 8.936 seconds
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/148261
Approved by: https://github.com/oulgen
ghstack dependencies: #148243 , #148260
2025-03-10 16:06:11 +00:00
Jason Ansel
bf752c36da
[fx] Move Node._update_args_kwargs to C++ ( #148260 )
...
Microbenchmarking `fx.symbolic_trace(lambda x: functools.reduce(operator.add, [x, *range(100000)]))`, before:
```
25203549 function calls (24403352 primitive calls) in 12.090 seconds
```
after:
```
24303536 function calls (23503339 primitive calls) in 10.726 seconds
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/148260
Approved by: https://github.com/oulgen
ghstack dependencies: #148243
2025-03-10 16:06:02 +00:00
Jason Ansel
bec7bdad47
[fx] Move map_aggregate to C++ ( #148243 )
...
Microbenchmarking `fx.symbolic_trace(lambda x: functools.reduce(operator.add, [x, *range(100000)]))`, before:
```
30603618 function calls (29403419 primitive calls) in 13.744 seconds
```
after:
```
25203549 function calls (24403352 primitive calls) in 12.090 seconds
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/148243
Approved by: https://github.com/oulgen
2025-03-10 16:05:53 +00:00
PyTorch MergeBot
92beda54c8
Revert "[fx] Move map_aggregate to C++ ( #148243 )"
...
This reverts commit edaff88f69https://github.com/pytorch/pytorch/pull/148243 on behalf of https://github.com/jovianjaison due to breaking internal builds [T216910920] ([comment](https://github.com/pytorch/pytorch/pull/148243#issuecomment-2698724058 ))
2025-03-04 19:40:21 +00:00
PyTorch MergeBot
17d003fe75
Revert "[fx] Move Node._update_args_kwargs to C++ ( #148260 )"
...
This reverts commit 0135f57f4ahttps://github.com/pytorch/pytorch/pull/148260 on behalf of https://github.com/jovianjaison due to breaking internal builds [T216910920] ([comment](https://github.com/pytorch/pytorch/pull/148243#issuecomment-2698724058 ))
2025-03-04 19:40:21 +00:00
PyTorch MergeBot
97b9e68bc6
Revert "[fx] Move Node._prepend/Node._remove_from_list to C++ ( #148261 )"
...
This reverts commit 29c2de9ae1https://github.com/pytorch/pytorch/pull/148261 on behalf of https://github.com/jovianjaison due to breaking internal builds [T216910920] ([comment](https://github.com/pytorch/pytorch/pull/148243#issuecomment-2698724058 ))
2025-03-04 19:40:21 +00:00
Jason Ansel
29c2de9ae1
[fx] Move Node._prepend/Node._remove_from_list to C++ ( #148261 )
...
Microbenchmarking `fx.symbolic_trace(lambda x: functools.reduce(operator.add, [x, *range(100000)]))`, before:
```
24303536 function calls (23503339 primitive calls) in 10.726 seconds
```
after:
```
20003454 function calls (19203257 primitive calls) in 8.936 seconds
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/148261
Approved by: https://github.com/oulgen
ghstack dependencies: #148243 , #148260
2025-03-02 22:42:31 +00:00
Jason Ansel
0135f57f4a
[fx] Move Node._update_args_kwargs to C++ ( #148260 )
...
Microbenchmarking `fx.symbolic_trace(lambda x: functools.reduce(operator.add, [x, *range(100000)]))`, before:
```
25203549 function calls (24403352 primitive calls) in 12.090 seconds
```
after:
```
24303536 function calls (23503339 primitive calls) in 10.726 seconds
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/148260
Approved by: https://github.com/oulgen
ghstack dependencies: #148243
2025-03-02 22:42:31 +00:00
Jason Ansel
edaff88f69
[fx] Move map_aggregate to C++ ( #148243 )
...
Microbenchmarking `fx.symbolic_trace(lambda x: functools.reduce(operator.add, [x, *range(100000)]))`, before:
```
30603618 function calls (29403419 primitive calls) in 13.744 seconds
```
after:
```
25203549 function calls (24403352 primitive calls) in 12.090 seconds
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/148243
Approved by: https://github.com/oulgen
2025-03-02 22:42:31 +00:00
Xuehai Pan
8962610247
[BE][clang-format] make macro PyObject_HEAD_INIT(type) and PyVarObject_HEAD_INIT(type, size) have its own line ( #136949 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/136949
Approved by: https://github.com/albanD , https://github.com/eqy
ghstack dependencies: #136945
2024-10-02 18:39:22 +00:00
Xuehai Pan
89c37be6b7
[BE][clang-format] make macro PyObject_HEAD have its own line ( #136945 )
...
Pull Request resolved: https://github.com/pytorch/pytorch/pull/136945
Approved by: https://github.com/albanD
2024-10-02 18:39:21 +00:00
Oguz Ulgen
5b5d269d34
Speed up fx graph iteration by implementing it in C++ ( #128288 )
...
Before this change
```
python benchmarks/dynamo/microbenchmarks/fx_microbenchmarks.py
iterating over 100000000 FX nodes took 19.5s (5132266 nodes/s)
```
After this change
```
python benchmarks/dynamo/microbenchmarks/fx_microbenchmarks.py
iterating over 100000000 FX nodes took 3.4s (29114001 nodes/s)
```
5.7x improvement
Differential Revision: [D58343997](https://our.internmc.facebook.com/intern/diff/D58343997 )
Pull Request resolved: https://github.com/pytorch/pytorch/pull/128288
Approved by: https://github.com/jansel , https://github.com/albanD
2024-06-11 05:48:31 +00:00
