OSSForks/pytorch
1
0
Fork 0
mirror of https://github.com/zebrajr/pytorch.git synced 2025-12-06 12:20:52 +01:00
Code Issues Actions 38 Packages Projects Releases Wiki Activity
95,310 Commits 8,304 Branches 150 Tags 1.5 GiB
master
Commit Graph

5616 Commits

Author SHA1 Message Date
PyTorch MergeBot
2699f5410b Revert "[xpu][feature] Integrate OneDNN SDPA training forward/backward into XPU OVERRIDEABLE Backend (#162454)" 
This reverts commit fd68d409ad.

Reverted https://github.com/pytorch/pytorch/pull/162454 on behalf of https://github.com/atalman due to internal build failure ([comment](https://github.com/pytorch/pytorch/pull/162454#issuecomment-3475009089))
 2025-10-31 21:58:52 +00:00
Parshant Sharma
9970fb97ff Fix Tril Triu SymInt (#166627) 
Fixes #165613

### Summary:

- This MR fixes an issue where `torch.tril `and `torch.triu` with dynamic diagonal values cause torch.export to incorrectly infer unnecessary constraints between dynamic dimensions.
-  Ensured proper SymInt type annotations for diagonal parameter
-  Updated C++ implementation to correctly handle SymInt diagonal values.

### Impacts:
module: dynamic shapes

Pull Request resolved: https://github.com/pytorch/pytorch/pull/166627
Approved by: https://github.com/ezyang, https://github.com/Skylion007
 2025-10-31 21:53:20 +00:00
Xuehai Pan
69be99ee51 Remove manually synced arch versions in tools/nightly.py (#166616) 
Discussed with @atalman offline. To reduce duplicate changes and reduce the number of files to change when updating arch versions.

------

Pull Request resolved: https://github.com/pytorch/pytorch/pull/166616
Approved by: https://github.com/ezyang
 2025-10-31 15:11:28 +00:00
fengqing.lu
fd68d409ad [xpu][feature] Integrate OneDNN SDPA training forward/backward into XPU OVERRIDEABLE Backend (#162454) 
This is the second PR split from https://github.com/pytorch/pytorch/pull/156272

Pull Request resolved: https://github.com/pytorch/pytorch/pull/162454
Approved by: https://github.com/guangyey, https://github.com/EikanWang, https://github.com/drisspg
 2025-10-31 11:20:38 +00:00
Maggie Moss
80ba6e458f Add warning when users have incomplete setup for type checking (#166603) 
Looking for feedback on this approach.
Received user reports of spurious pyrefly errors for users using hg instead of git. I think this was due to the fact that when using a venv and git, `make setup-env` installs requirements and pulls from a nightly torch wheel, which is needed for pyrefly to type check properly.

Initial documentation for `make setup-env` I found here: https://github.com/pytorch/pytorch/blob/main/CONTRIBUTING.md#developing-pytorch

Testing:
```
hg clone --git ssh://git@github.com/pytorch/pytorch.git
conda create -n pytorch_env python=3.10 # (or manually create venv instead of using script)
cd pytorch
pip install -r requirements.txt
pip install -r requirements-build.txt
lintrunner init
# check how many pyrefly errors - 15,709 errors (11,693 ignored)
lintrunner # confirm error message / warning appears
>>> General linter failure:
  Warning (PYREFLY) nightly-wheel-not-run
    pytorch-nightly.pth not found. You may need to run make setup-env or make
    setup-env-conda to install nightly binaries and type stubs.
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/166603
Approved by: https://github.com/aorenste
 2025-10-30 20:37:44 +00:00
Yuanyuan Chen
52db60170d Enable verify_dynamo on Python 3.13 (#166497) 
Dynamo now supports Python 3.13.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/166497
Approved by: https://github.com/Lucaskabela, https://github.com/williamwen42
 2025-10-30 19:52:32 +00:00
Ivan Zaitsev
3d4ca228be Remove METADATA.bzl files (#166574) 
(meta-internal, should not be synced)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/166574
Approved by: https://github.com/bigfootjon
 2025-10-29 23:17:41 +00:00
Tushar Jain
48c3b71ecc transform fr traces for ft (#166149) 
Summary:
- the ranks in the default pg config are local ranks
- however fr trace analysis requires them to be global ranks
- so we transform the local ranks to global ranks before the analysis kicks in based on a cli flag

Pull Request resolved: https://github.com/pytorch/pytorch/pull/166149
Approved by: https://github.com/fduwjj
 2025-10-29 20:44:48 +00:00
bobrenjc93
8af9ed0824 [torchfuzz] split, chunk, stack, cat, expand, gather, cumsum, clamp, index_select, split (#166221) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/166221
Approved by: https://github.com/pianpwk
ghstack dependencies: #166187, #166188, #166220, #166189, #166190
 2025-10-28 01:21:07 +00:00
bobrenjc93
7045aab143 [torchfuzz] add mhaf operator (#166190) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/166190
Approved by: https://github.com/pianpwk
ghstack dependencies: #166187, #166188, #166220, #166189
 2025-10-28 01:21:07 +00:00
bobrenjc93
7ae8aaf4c0 [torchfuzz] add sdpa operator (#166189) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/166189
Approved by: https://github.com/pianpwk
ghstack dependencies: #166187, #166188, #166220
 2025-10-28 01:20:58 +00:00
bobrenjc93
f2450798cd [torchfuzz] make pointwise subclasses defined torch_op_name (#166220) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/166220
Approved by: https://github.com/pianpwk
ghstack dependencies: #166187, #166188
 2025-10-28 01:08:34 +00:00
bobrenjc93
0ae3e30621 [torchfuzz] fix group norm operator (#166188) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/166188
Approved by: https://github.com/pianpwk
ghstack dependencies: #166187
 2025-10-28 00:11:04 +00:00
bobrenjc93
47f50cfd45 [torchfuzz] check in more ignore regexes (#166187) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/166187
Approved by: https://github.com/pianpwk
 2025-10-27 23:58:54 +00:00
Maggie Moss
5121499f6b Fix pyrefly ignore syntax in /tools/... (#166240) 
Second PR for this - only adjusts the syntax used for the ignores so the suppressions hide only one category of pyrefly errors.

test:
pyrefly check
lintrunner

Pull Request resolved: https://github.com/pytorch/pytorch/pull/166240
Approved by: https://github.com/oulgen
 2025-10-26 04:20:16 +00:00
Maggie Moss
c7eee49525 Fix pyrefly ignores 1/n (#166239) 
First diff adjusting the syntax for pyrefly: ignore suppressions so they only hide one class of type error.

Test:
lintrunner
pyrefly check

Pull Request resolved: https://github.com/pytorch/pytorch/pull/166239
Approved by: https://github.com/oulgen
 2025-10-26 00:44:10 +00:00
Aaron Orenstein
b55b779ad3 Add file size limits to linters and refactor grep_linter (#166202) 
- Add 1GB file size limits to grep_linter, newlines_linter, codespell_linter
- Refactor grep_linter
  - process files once instead of per-line
  - Extract allowlist check to separate function
  - Add 512KB limit for computing replacements, 100 match limit per file
  - Detect duplicate arguments
- Fix .lintrunner.toml: RAWCUDADEVICE used --pattern twice
Pull Request resolved: https://github.com/pytorch/pytorch/pull/166202
Approved by: https://github.com/Skylion007
 2025-10-25 14:57:19 +00:00
Catherine Lee
32ac38f85d [lint] workflow consistency linter to look at all files instead of just changed files (#165171) 
As in title

If you change only one workflow file, lintrunner (default arg, also the one in CI since it only inputs changed files) won't look at other files in the repo, but the sync-tag might come from those other files

This makes it so that it looks at all workflow files so it will catch those failures

Also change output line so it prints which file + which job it is different from

Pros:
catches errors

Cons:
unusual behavior (getting around what lintrunner says the linter should run on)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165171
Approved by: https://github.com/malfet, https://github.com/izaitsevfb, https://github.com/atalman
 2025-10-24 21:43:18 +00:00
Simon Layton
0b58d87aec [Submodule] Bump FBGEMM to latest (#165544) 
Summary:

* FBGEMM submodule updated to main
* CMake updated to reflect necessary changes
* Notably pulls in NVFP4 grouped gemm kernels

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Signed-off-by: Simon Layton <simonlayton@meta.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165544
Approved by: https://github.com/cyyever, https://github.com/jeffdaily
 2025-10-22 20:57:15 +00:00
PyTorch MergeBot
05b2e02cb4 Revert "[lint] workflow consistency linter to look at all files instead of just changed files (#165171)" 
This reverts commit c746feb86a.

Reverted https://github.com/pytorch/pytorch/pull/165171 on behalf of https://github.com/clee2000 due to broke lint [GH job link](https://github.com/pytorch/pytorch/actions/runs/18723760085/job/53402955955) [HUD commit link](c746feb86a) ([comment](https://github.com/pytorch/pytorch/pull/165171#issuecomment-3433501457))
 2025-10-22 17:47:29 +00:00
Catherine Lee
c746feb86a [lint] workflow consistency linter to look at all files instead of just changed files (#165171) 
As in title

If you change only one workflow file, lintrunner (default arg, also the one in CI since it only inputs changed files) won't look at other files in the repo, but the sync-tag might come from those other files

This makes it so that it looks at all workflow files so it will catch those failures

Pros:
catches errors

Cons:
unusual behavior (getting around what lintrunner says the linter should run on)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165171
Approved by: https://github.com/malfet
 2025-10-22 16:57:59 +00:00
Yuanyuan Chen
f9953e0f61 Enable PLC0414 on ruff (#165828) 
This PR enables `PLC0414` that fixes redundant import aliases.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165828
Approved by: https://github.com/albanD
 2025-10-22 04:56:52 +00:00
inventshah
715449ca76 [MPS] Fix parity between CPU and MPS on singular matrices in linalg.lu_factor (#165871) 
Fixes #165870. Follow up from #165254.

This PR [a] removes the MPS specific version of `lu_factor` in favor of the version in BatchedLinearAlgebra.cpp which uses `lu_factor_ex`, and [b] updates `lu_factor_ex` error codes to match expectations.

When `lu_factor` was first implemented for MPS (#99269), it bypassed the implementation in BatchedLinearAlgebra.cpp since we did not have `lu_factor_ex`. Since #144651 implements `lu_factor_ex`, we can now remove the MPS specific wrapper.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165871
Approved by: https://github.com/kulinseth, https://github.com/albanD
 2025-10-22 02:48:40 +00:00
Tushar Jain
d1269a0434 update fr trace analysis (#165994) 
Summary:
- allow empty entries from ranks
- allow not all ranks to provide dump

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/pytorch/pull/165994).
* #165638
* #165640
* #165642
* __->__ #165994
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165994
Approved by: https://github.com/fduwjj
 2025-10-21 19:14:33 +00:00
Maggie Moss
0be0de4ffa Add type suppressions to _inductor/runtime (#165918) 
Original PR that did this was reverted due to merge conflicts.

Trying it again

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165918
Approved by: https://github.com/oulgen
 2025-10-21 02:54:22 +00:00
PyTorch MergeBot
0da1f911dc Revert "[Submodule] Bump FBGEMM to latest (#165544)" 
This reverts commit 23417ae50f.

Reverted https://github.com/pytorch/pytorch/pull/165544 on behalf of https://github.com/clee2000 due to failing in internal D84996252, probably needs some sort of update to fbgemm internally? ([comment](https://github.com/pytorch/pytorch/pull/165544#issuecomment-3422993703))
 2025-10-20 17:06:07 +00:00
Yuanyuan Chen
3255e7872b Enable all flake8-logging-format rules (#164655) 
These rules are enabled by removing existing suppressions.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/164655
Approved by: https://github.com/janeyx99, https://github.com/mlazos
 2025-10-19 00:59:28 +00:00
Maggie Moss
f02e3947f6 Expand type checking to mypy strict files (#165697) 
Expands Pyrefly type checking to check the files outlined in the mypy-strict.ini configuration file:

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165697
Approved by: https://github.com/ezyang
 2025-10-18 04:34:45 +00:00
Simon Layton
23417ae50f [Submodule] Bump FBGEMM to latest (#165544) 
Summary:

* FBGEMM submodule updated to main
* CMake updated to reflect necessary changes
* Notably pulls in NVFP4 grouped gemm kernels

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Signed-off-by: Simon Layton <simonlayton@meta.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165544
Approved by: https://github.com/cyyever, https://github.com/jeffdaily
 2025-10-18 03:58:08 +00:00
bobrenjc93
7dabfb07cb [torchfuzz] add support for --stop-at-first-failure flag (#165529) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165529
Approved by: https://github.com/pianpwk
ghstack dependencies: #164749
 2025-10-17 02:18:07 +00:00
bobrenjc93
d0add0be43 [torchfuzz] check in some more ignore regexes (#164749) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164749
Approved by: https://github.com/pianpwk
 2025-10-17 02:18:07 +00:00
Shangdi Yu
d82527b32a [Windows] Add AOTI cross-compilation CI (#165573) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165573
Approved by: https://github.com/malfet
ghstack dependencies: #165560
 2025-10-17 01:05:35 +00:00
Yuanyuan Chen
b2953f5643 [9/N] Apply ruff UP035 rule (#165515) 
This is follow-up of #165214 to continue applying ruff UP035 rule to the code base.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165515
Approved by: https://github.com/Lucaskabela
 2025-10-17 00:09:51 +00:00
Maggie Moss
d795fb225a [RFC] Add pyrefly to lintrunner (#165179) 
This will add pyrefly to lint runner as a warning only - and allow us to collect feedback about the tool before switching to pyrefly as the main type checker.

References the steps outlined here: : https://github.com/pytorch/pytorch/issues/163283:

test plan:
`lintrunner init`
`lintrunner`
confirm when pyrefly errors are present results look like: https://gist.github.com/maggiemoss/e6cb2d015dd1ded560ae1329098cf33f

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165179
Approved by: https://github.com/ezyang
 2025-10-16 20:07:09 +00:00
Catherine Lee
ffc7552e01 See if we can handle uploading all test data (#165484) 
Fixes #ISSUE_NUMBER

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165484
Approved by: https://github.com/izaitsevfb
 2025-10-15 19:57:41 +00:00
can-gaa-hou
2c600bb665 [torchfuzz] fix some errors when walkthroughing README.md (#165225) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/165225
Approved by: https://github.com/soulitzer
 2025-10-13 17:17:50 +00:00
Yuanyuan Chen
8de85896e0 Enable ruff rule E721 (#165162) 
`E721` checks for object type comparisons using == and other comparison operators. This is useful because it is recommended to use `is` for type comparisons.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165162
Approved by: https://github.com/Skylion007
 2025-10-13 01:48:55 +00:00
PyTorch MergeBot
816fb7f48d Revert "Enable ruff rule E721 (#165162)" 
This reverts commit 9e7c19f72b.

Reverted https://github.com/pytorch/pytorch/pull/165162 on behalf of https://github.com/pytorch-auto-revert due to Reverted automatically by pytorch's autorevert, to avoid this behaviour add the tag autorevert: disable ([comment](https://github.com/pytorch/pytorch/pull/165162#issuecomment-3393328271))
 2025-10-11 13:25:40 +00:00
Yuanyuan Chen
9e7c19f72b Enable ruff rule E721 (#165162) 
`E721` checks for object type comparisons using == and other comparison operators. This is useful because it is recommended to use `is` for type comparisons.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165162
Approved by: https://github.com/Skylion007
 2025-10-11 06:43:53 +00:00
can-gaa-hou
af42256db4 Fix missing brackets (#165138) 
As stated in the title.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/165138
Approved by: https://github.com/Aidyn-A, https://github.com/Skylion007
 2025-10-10 17:23:31 +00:00
Yuanyuan Chen
a029675f6f More ruff SIM fixes (#164695) 
This PR applies ruff `SIM` rules to more files. Most changes are about simplifying `dict.get` because `None` is already the default value.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/164695
Approved by: https://github.com/ezyang
 2025-10-09 03:24:50 +00:00
Mikayla Gawarecki
f37a6523ef Move version.h to torch/headeronly (#164381) 
Differential Revision: [D83685392](https://our.internmc.facebook.com/intern/diff/D83685392)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164381
Approved by: https://github.com/janeyx99
 2025-10-07 17:47:30 +00:00
bobrenjc93
4bcc05777e [torchfuzz] synthesize inputs for data dependent ops (#164716) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164716
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432, #164434, #164514, #164646, #164647, #164649, #164687, #164688, #164693, #164694, #164715
 2025-10-07 05:40:32 +00:00
bobrenjc93
2a6cdba6e5 [torchfuzz] various edge case fixes (#164715) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164715
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432, #164434, #164514, #164646, #164647, #164649, #164687, #164688, #164693, #164694
 2025-10-07 05:30:46 +00:00
bobrenjc93
53f6cc7529 [torchfuzz] make ops_fuzzer deterministic (#164694) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164694
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432, #164434, #164514, #164646, #164647, #164649, #164687, #164688, #164693
 2025-10-07 05:30:46 +00:00
bobrenjc93
ac901bf79a [torchfuzz] consolidate on a base implementation of args_codegen (#164693) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164693
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432, #164434, #164514, #164646, #164647, #164649, #164687, #164688
 2025-10-07 05:20:28 +00:00
bobrenjc93
c965d6dbb2 [torchfuzz] move into experimental dir (#164688) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164688
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432, #164434, #164514, #164646, #164647, #164649, #164687
 2025-10-07 05:09:08 +00:00
bobrenjc93
ac08556f67 [torchfuzz] support more unbacked functions (#164687) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164687
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432, #164434, #164514, #164646, #164647, #164649
 2025-10-07 05:00:03 +00:00
bobrenjc93
5fe7f29b9e [torchfuzz] add support for operator weights (#164649) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164649
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432, #164434, #164514, #164646, #164647
 2025-10-07 05:00:03 +00:00
bobrenjc93
ded099ecbf [torchfuzz] don't use the first gpu in multi process fuzzer (#164647) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/164647
Approved by: https://github.com/pianpwk
ghstack dependencies: #164432, #164434, #164514, #164646
 2025-10-07 04:59:56 +00:00