OSSForks/pytorch
1
0
Fork 0
mirror of https://github.com/zebrajr/pytorch.git synced 2025-12-07 00:21:07 +01:00
Code Issues Actions 38 Packages Projects Releases Wiki Activity
95,310 Commits 8,304 Branches 150 Tags 1.5 GiB
master
Commit Graph

31 Commits

Author SHA1 Message Date
Michael Lazos
450517f346 [Dynamo][Hierarchical Compile] Flatten tuple inputs for regions (#158812) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/158812
Approved by: https://github.com/anijain2305
ghstack dependencies: #158810, #158811
 2025-08-18 18:03:11 +00:00
Michael Lazos
fb7e60ba7a [Dynamo][Hierarchical Compile] Flatten tuple outputs in graph dedupe pass (#158811) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/158811
Approved by: https://github.com/anijain2305
ghstack dependencies: #158810
 2025-08-16 04:45:31 +00:00
Michael Lazos
34ec5ed275 [Dynamo][Hierarchical Compile] Allow parameters to be propagated to submodules (#157979) 
Fixes issue with HF Gen AI models where we mark a param as static and a get_attr node gets put in the region.

The effect of this is lifting get_attr nodes to be inputs.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/157979
Approved by: https://github.com/williamwen42
 2025-08-13 09:12:10 +00:00
Michael Lazos
a415c9831f [Hierarchical Compile] Replace tracing alias and mutation check with dynamo impl (#152570) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/152570
Approved by: https://github.com/anijain2305
ghstack dependencies: #152389, #152505, #152410, #152506
 2025-05-13 12:17:59 +00:00
Michael Lazos
57dafb90ef [Hierarchical Compile] Take into account mutation deps in cycle detection (#152506) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/152506
Approved by: https://github.com/anijain2305
ghstack dependencies: #152389, #152505, #152410
 2025-05-13 12:17:59 +00:00
Michael Lazos
118192011e [Hierarchical Compile] Add mutation dependencies to topological sorting (#152410) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/152410
Approved by: https://github.com/anijain2305
ghstack dependencies: #152389, #152505
 2025-05-13 12:17:59 +00:00
Michael Lazos
3592cb52d9 [Hierarchical Compilation] Use universal flatten APIs (#152505) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/152505
Approved by: https://github.com/anijain2305
ghstack dependencies: #152389
 2025-05-13 12:17:59 +00:00
PyTorch MergeBot
78d752e96a Revert "[Hierarchical Compilation] Use universal flatten APIs (#152505)" 
This reverts commit f9e3a9058e.

Reverted https://github.com/pytorch/pytorch/pull/152505 on behalf of https://github.com/jeanschmidt due to [TENTATIVE] reverting to check if reverting this stack partially caused the introduction of https://github.com/pytorch/pytorch/actions/runs/14966121510/job/42049638969#step:22:875 ([comment](https://github.com/pytorch/pytorch/pull/152505#issuecomment-2872869990))
 2025-05-12 14:48:08 +00:00
PyTorch MergeBot
47df195065 Revert "[Hierarchical Compile] Add mutation dependencies to topological sorting (#152410)" 
This reverts commit bc8b305eb8.

Reverted https://github.com/pytorch/pytorch/pull/152410 on behalf of https://github.com/jeanschmidt due to Breaking internal signal citadel-fbcode-test-mode-opt-for-pt2_stack_for_internal-linux-0 please see diff [D74531503](https://www.internalfb.com/diff/D74531503) for more details ([comment](https://github.com/pytorch/pytorch/pull/152410#issuecomment-2871168679))
 2025-05-12 07:15:09 +00:00
PyTorch MergeBot
0e36887209 Revert "[Hierarchical Compile] Take into account mutation deps in cycle detection (#152506)" 
This reverts commit 779e647999.

Reverted https://github.com/pytorch/pytorch/pull/152506 on behalf of https://github.com/jeanschmidt due to Breaking internal signal citadel-fbcode-test-mode-opt-for-pt2_stack_for_internal-linux-0 please see diff [D74531503](https://www.internalfb.com/diff/D74531503) for more details ([comment](https://github.com/pytorch/pytorch/pull/152410#issuecomment-2871168679))
 2025-05-12 07:15:09 +00:00
PyTorch MergeBot
53ebcabb52 Revert "[Hierarchical Compile] Replace tracing alias and mutation check with dynamo impl (#152570)" 
This reverts commit 50df08eb5e.

Reverted https://github.com/pytorch/pytorch/pull/152570 on behalf of https://github.com/jeanschmidt due to Breaking internal signal citadel-fbcode-test-mode-opt-for-pt2_stack_for_internal-linux-0 please see diff [D74531503](https://www.internalfb.com/diff/D74531503) for more details ([comment](https://github.com/pytorch/pytorch/pull/152410#issuecomment-2871168679))
 2025-05-12 07:15:09 +00:00
PyTorch MergeBot
aa7fe6af41 Revert "[Dynamo] Optimize dedupe region ancestor tracking (#152589)" 
This reverts commit b5f1345f72.

Reverted https://github.com/pytorch/pytorch/pull/152589 on behalf of https://github.com/jeanschmidt due to Breaking internal signal citadel-fbcode-test-mode-opt-for-pt2_stack_for_internal-linux-0 please see diff [D74531503](https://www.internalfb.com/diff/D74531503) for more details ([comment](https://github.com/pytorch/pytorch/pull/152410#issuecomment-2871168679))
 2025-05-12 07:15:09 +00:00
Michael Lazos
b5f1345f72 [Dynamo] Optimize dedupe region ancestor tracking (#152589) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/152589
Approved by: https://github.com/anijain2305
ghstack dependencies: #152389, #152505, #152410, #152506, #152570, #152572
 2025-05-10 08:27:56 +00:00
Michael Lazos
50df08eb5e [Hierarchical Compile] Replace tracing alias and mutation check with dynamo impl (#152570) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/152570
Approved by: https://github.com/anijain2305
ghstack dependencies: #152389, #152505, #152410, #152506
 2025-05-10 08:27:45 +00:00
Michael Lazos
779e647999 [Hierarchical Compile] Take into account mutation deps in cycle detection (#152506) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/152506
Approved by: https://github.com/anijain2305
ghstack dependencies: #152389, #152505, #152410
 2025-05-10 08:27:31 +00:00
Michael Lazos
bc8b305eb8 [Hierarchical Compile] Add mutation dependencies to topological sorting (#152410) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/152410
Approved by: https://github.com/anijain2305
ghstack dependencies: #152389, #152505
 2025-05-10 08:27:19 +00:00
Michael Lazos
f9e3a9058e [Hierarchical Compilation] Use universal flatten APIs (#152505) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/152505
Approved by: https://github.com/anijain2305
ghstack dependencies: #152389
 2025-05-10 08:27:07 +00:00
Animesh Jain
9e3fc41060 [invoke_subgraph] rename identifiers to prevent python mangling (#152581) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/152581
Approved by: https://github.com/BoyuanFeng, https://github.com/zou3519
ghstack dependencies: #152547
 2025-05-02 06:46:05 +00:00
Animesh Jain
4649fd17b0 [invoke_subgraph] Unpacked operands (#152547) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/152547
Approved by: https://github.com/ydwu4, https://github.com/zou3519
 2025-05-02 05:44:46 +00:00
Animesh Jain
f2a89b802d [invoke_subgraph] Cache on tangent metadata and retrace if needed (#152357) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/152357
Approved by: https://github.com/zou3519, https://github.com/bdhirsh
 2025-04-30 23:49:17 +00:00
Animesh Jain
d620fefb2c [invoke_subgraph] Use backward identifier for min-cut parititioning (#152207) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/152207
Approved by: https://github.com/zou3519, https://github.com/bdhirsh
 2025-04-30 14:34:56 +00:00
Michael Lazos
a09a3f4c30 [Hierarchical compile] Ensure output nodes are sorted last (#151295) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/151295
Approved by: https://github.com/anijain2305
ghstack dependencies: #151293, #151294
 2025-04-22 05:13:07 +00:00
Michael Lazos
283884b224 [Hierarchical Compile] Handle autocast ctx manager (#151294) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/151294
Approved by: https://github.com/anijain2305
ghstack dependencies: #151293
 2025-04-22 05:13:07 +00:00
Animesh Jain
173f126068 [invoke_subgraph] Preserve node meta (#150782) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/150782
Approved by: https://github.com/bdhirsh
ghstack dependencies: #150666
 2025-04-08 16:57:39 +00:00
Michael Lazos
0d44a8aea1 [Hierarchical Compile] Apply deduplication after output node creation (#150306) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/150306
Approved by: https://github.com/anijain2305
ghstack dependencies: #150303, #150304, #150305
 2025-04-01 20:54:18 +00:00
Michael Lazos
a2300aff94 [Hierarchical Compile] Add cycle detection function for debug (#150304) 
Remove print

Pull Request resolved: https://github.com/pytorch/pytorch/pull/150304
Approved by: https://github.com/anijain2305
ghstack dependencies: #150303
 2025-04-01 20:54:10 +00:00
Animesh Jain
d43c6f0033 [invoke_subgraph] Run joint passes on the hop graphs (#139325) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/139325
Approved by: https://github.com/bdhirsh, https://github.com/zou3519
ghstack dependencies: #147559
 2025-03-03 23:38:14 +00:00
Michael Lazos
5c3996cab2 [Dynamo] topologically sort duplicated graph regions (#143523) 
Ensure regions are topologically sorted

Pull Request resolved: https://github.com/pytorch/pytorch/pull/143523
Approved by: https://github.com/williamwen42
 2024-12-19 00:43:48 +00:00
Michael Lazos
4eafbe5288 [Dynamo] Flatten slices during graph deduplication (#143522) 
I encountered this issue while debugging torchtune - overall we need to make sure to not miss nodes that are slice arguments.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/143522
Approved by: https://github.com/williamwen42
 2024-12-18 23:12:34 +00:00
Tom Ritchford
d25e6e623f Fix unused Python variables in test/[a-d]* (#134665) 
Pull Request resolved: https://github.com/pytorch/pytorch/pull/134665
Approved by: https://github.com/albanD
 2024-12-13 22:13:12 +00:00
Michael Lazos
c31543c7ae [Dynamo] Initial deduplication pass impl (#141383) 
This PR implements the deduplication pass (blocked by config currently) for dynamo where identical regions from https://github.com/pytorch/pytorch/pull/141381 are replaced with a common subgraph.

The two phases of deduplication are explained below.

**Subgraph creation**:
Subgraph creation works by taking one representative region from each region group and creating a subgraph from it, which will then be used to replace all regions in the group. This is implemented by first copying all nodes of the region to the new subgraph and then finding all inputs which are not within the region and creating placeholders for them. For the outputs, all regions in a region group need to be scanned to ensure the largest set of outputs is found, and then an output node is created which returns a tuple of all outputs.

**Graph replacement**:
To replace each region with the extracted subgraph, the node index in the region and argument index within the node's flattened args and kwargs are recorded once during subgraph creation. This allows us to determine which (external to the region) nodes and in which order these nodes are passed as inputs. For the outputs, getitem nodes are created for each output, and all nodes in the region with external outputs are replaced by the proper getitem node. Finally, all original nodes are erased (there should be no uses of these left in the graph).

Pull Request resolved: https://github.com/pytorch/pytorch/pull/141383
Approved by: https://github.com/zou3519
ghstack dependencies: #141381, #141382
 2024-12-11 02:22:21 +00:00