Commit Graph

7 Commits

Author SHA1 Message Date
Nikita Shulga
8db42e7688 [EZ][GHF] Rephrase cancelled message (#124947)
To encourage people to reissue the command if merge timed out

Pull Request resolved: https://github.com/pytorch/pytorch/pull/124947
Approved by: https://github.com/kit1980, https://github.com/clee2000
2024-04-25 22:24:08 +00:00
Jane (Yuan) Xu
350fb16f47 Add space to merge cancel comment (#107603)
Minor QoL improvement
Pull Request resolved: https://github.com/pytorch/pytorch/pull/107603
Approved by: https://github.com/kit1980, https://github.com/ZainRizvi
2023-08-21 21:43:15 +00:00
Huy Do
4c0dce50fd [BE] Apply ufmt to run_test and GitHub Python util scripts (#97588)
This has been bugging me for a while as I'm working on these Python scripts and they are not tracked by ufmt linter.  So I add these script into that linter.

```
[[linter]]
code = 'UFMT'
include_patterns = [
    '.github/**/*.py',
    'test/run_test.py',
```

This change should just work and not break anything as ufmt (black + usort) linter is very safe to use for standalone util scripts.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/97588
Approved by: https://github.com/kit1980
2023-03-26 04:52:55 +00:00
Ning Xu
5ba4dafccd Retry Merge: extract utils from check labels ptr (#94899)
Fixes #88098

This is the rebased and retry merging branch of the reverted PR: https://github.com/pytorch/pytorch/pull/94597

Pull Request resolved: https://github.com/pytorch/pytorch/pull/94899
Approved by: https://github.com/kit1980
2023-03-01 20:40:30 +00:00
PyTorch MergeBot
7c3fc2c7f0 Revert "Issue-88098: extract utils from check labels (#94597)"
This reverts commit 2c76838d7f.

Reverted https://github.com/pytorch/pytorch/pull/94597 on behalf of https://github.com/jeanschmidt due to reverting due internal breakages https://fburl.com/sandcastle/3ukij9xp
2023-02-13 20:19:50 +00:00
Ning Xu
2c76838d7f Issue-88098: extract utils from check labels (#94597)
Fixes #88098

This is a mirror of the same PR (https://github.com/Goldspear/pytorch/pull/2) that has been reviewed in my fork (due to it's a stacked PR).

======================
## Context

This is the 2nd of the 3 PRs to address issue-88098.

## What Changed
1. Extract comment related utils from trymerge.py to github_utils.py
2. Extract label related utils from trymerge.py and check_labels.py to label_utils.py

## Tests
* pytorch-dummy repo [trymerge run ](https://github.com/Goldspear/pytorch-dummy/actions/runs/4118944174)merged the test PR [OK](https://github.com/Goldspear/pytorch-dummy/pull/2).

## Note to Reviewers
Due to higher degree of complexity involved to extract GitHubPR class, it's worth having a separate issue to handle that part of refactoring. This issue only focusing on refactoring where necessary to ship the functional diff.

* 1st PR: https://github.com/pytorch/pytorch/pull/94179
* 2nd PR: this one
* 3rd PR: https://github.com/Goldspear/pytorch/pull/3

Pull Request resolved: https://github.com/pytorch/pytorch/pull/94597
Approved by: https://github.com/ZainRizvi
2023-02-12 12:18:53 +00:00
zengk95
91766360b1 [mergebot] Post PR Comment on cancel (#82744)
### Description
<!-- What did you change and why was it needed? -->
When someone cancels a PR merge, it's not apparent that it's canceled unless the user clicks into that job. In this PR, we add a message if the pr gets canceled.

The only thing is the user will not receive  a comment if the PR is canceled immediately since posting the message requires that the checkout be finished.
### Issue
<!-- Link to Issue ticket or RFP -->
n/a

### Testing
<!-- How did you test your change? -->
Tested it on canary https://github.com/pytorch/pytorch-canary/pull/132
Pull Request resolved: https://github.com/pytorch/pytorch/pull/82744
Approved by: https://github.com/huydhn, https://github.com/seemethere
2022-08-22 20:17:43 +00:00