Commit Graph

1371 Commits

Author SHA1 Message Date
Nikita Shulga
ca2a23c243 [BE][CI] Move more builds from 3.7 to 3.8 (#92928)
Part of https://github.com/pytorch/pytorch/issues/80513

Pull Request resolved: https://github.com/pytorch/pytorch/pull/92928
Approved by: https://github.com/weiwangmeta, https://github.com/ZainRizvi
2023-01-26 18:13:16 +00:00
Jithun Nair
22b6a5fda9 Update base docker image tags for ROCm CI (#90694)
to make them agnostic of ubuntu version, ROCm version and python minor version.

This should help avoid frequent updates to the docker image tags when upgrading ROCm version in PyTorch CI, which has creation of new ECR tags as a blocking step.

Reference: https://github.com/pytorch/pytorch/pull/88297#issuecomment-1307873280

The BUILD_ENVIRONMENT flag will continue to specify the exact versions for the above, in case it is needed for debug. @malfet @seemethere Hope that's not going away, otherwise we might have a harder time debugging issues where we need to figure out these environment details.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/90694
Approved by: https://github.com/malfet
2023-01-26 02:00:15 +00:00
Nikita Shulga
b0f5e15c4c [CI] Enable Python-3.11 in smoke CPU testing (#92787)
Add bionic-py3.11-clang9,  and move vulkan testing to it. Test only fx and jit for the time being (will add more in followup PRs)

Do not install numba, is it's not yet available for python-3.11

Change installed mkl version as the one installed before was incompatible with numpy

TODO: Remove `-c malfet` when required packages become available on default conda channel, namely `numpy`, `setuptools`, `coverage`, `mypy-exensions`, `typing-extensions`, `psutils` and `pyyaml`

Pull Request resolved: https://github.com/pytorch/pytorch/pull/92787
Approved by: https://github.com/albanD
2023-01-24 22:34:35 +00:00
pbialecki
9bfd1357d5 Add CUDA 11.8 CI workflows (#92137)
Fixes #92090
CC @atalman
Pull Request resolved: https://github.com/pytorch/pytorch/pull/92137
Approved by: https://github.com/atalman
2023-01-23 21:03:53 +00:00
Nikita Shulga
3643d5deed Move ASAN and ONNX to Python 3.9 and 3.8 (#92712)
As 3.7 is getting deprecated
Pull Request resolved: https://github.com/pytorch/pytorch/pull/92712
Approved by: https://github.com/weiwangmeta, https://github.com/kit1980, https://github.com/seemethere
2023-01-23 20:55:57 +00:00
Nikita Shulga
71b1051230 [Docker] Factor GHCR push into its own step (#92832)
As I had a really hard time figuring out what is failing in https://github.com/pytorch/pytorch/actions/runs/3987520975/jobs/6837450121

Together with https://github.com/pytorch/pytorch/pull/92816 it will ensure, that even if ghcr upload fails, CI will continue to work

Per @ZainRizvi suggestion added retry logic for the upload step

Test plan: push temp change(0fe7f8c2ed)  to validate that this portion of the workflow actually doing the job
Pull Request resolved: https://github.com/pytorch/pytorch/pull/92832
Approved by: https://github.com/weiwangmeta, https://github.com/ZainRizvi
2023-01-23 19:43:52 +00:00
Aaron Gokaslan
36ba2ce546 [BE]: remove old dataclasses install from CI (#92763)
Saw some places we missed some old requirements that are no longer necessary (dataclasses and future). Testing to see if all the CIs still work. We don't need dataclasses anymore now that we are on Python >= 3.7

Pull Request resolved: https://github.com/pytorch/pytorch/pull/92763
Approved by: https://github.com/ezyang
2023-01-23 18:23:44 +00:00
PyTorch MergeBot
9c6433ce48 Revert "Move ASAN and ONNX to Python 3.9 and 3.8 (#92712)"
This reverts commit b5f614c4cd.

Reverted https://github.com/pytorch/pytorch/pull/92712 on behalf of https://github.com/ezyang due to Docker build didn't succeed on master, rolling back so we can try again
2023-01-23 16:02:46 +00:00
Nikita Shulga
b5f614c4cd Move ASAN and ONNX to Python 3.9 and 3.8 (#92712)
As 3.7 is getting deprecated
Pull Request resolved: https://github.com/pytorch/pytorch/pull/92712
Approved by: https://github.com/weiwangmeta, https://github.com/kit1980, https://github.com/seemethere
2023-01-23 14:46:02 +00:00
albanD
2f6a975f25 Remove cffi dependency as it doesn't look like we're using it (#92738)
Maybe this will go horribly wrong in CI but works fine without it locally!

Pull Request resolved: https://github.com/pytorch/pytorch/pull/92738
Approved by: https://github.com/kit1980, https://github.com/seemethere
2023-01-22 15:03:52 +00:00
Nikita Shulga
bea0b5ba73 [BE] Delete unused docker configs (#92711)
CUDA-10.2 is long gone and CUDA-11.3+clang build is replaced by cuda-11.6+clang10 jammy build
Pull Request resolved: https://github.com/pytorch/pytorch/pull/92711
Approved by: https://github.com/weiwangmeta
2023-01-21 16:42:28 +00:00
Nikita Shulga
97f34e367d Run CI in a new environment (#92378)
Needed to be able to install newer Python versions (Python-3.11 in this case),  which do not have numerous packages that default environment must have

In addition, fix weird incursion of `conda-forge` by torch-deploy test.

Reincarnation of an old https://github.com/pytorch/pytorch/pull/66530

Pull Request resolved: https://github.com/pytorch/pytorch/pull/92378
Approved by: https://github.com/kit1980
2023-01-19 14:24:30 +00:00
Nikita Shulga
1906eaf22f [BE] Get rid of future (#92596)
PyTorch has been Python-3.X+ for ages, so it's a shame to still rely on `future.utils` even in a deprecated Caffe2 codebase

For the reference:
https://peps.python.org/pep-0469/#migrating-directly-to-python-3

Pull Request resolved: https://github.com/pytorch/pytorch/pull/92596
Approved by: https://github.com/kit1980, https://github.com/orionr
2023-01-19 08:46:50 +00:00
Nikita Shulga
388d79ccda [CI] valgrind 3.16.1->3.20.0 (#92552)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/92552
Approved by: https://github.com/clee2000, https://github.com/huydhn
2023-01-19 00:42:50 +00:00
Nikita Shulga
74bc894ede [BE] Delete unused args during docker build (#92396)
Such as `TRAVIS_DL_URL_PREFIX`, `JENKINS_UID`/`JENKINS_GID` and `EC2`

Pull Request resolved: https://github.com/pytorch/pytorch/pull/92396
Approved by: https://github.com/huydhn, https://github.com/janeyx99
2023-01-18 15:41:00 +00:00
Jeff Daily
7ff97d2e95 update .circleci/docker/common/install_cmake.sh for centos (#91647)
Otherwise .circleci/docker/common/install_cmake.sh fails for centos due to use of apt-get instead of yum.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/91647
Approved by: https://github.com/malfet
2023-01-05 00:43:10 +00:00
Catherine Lee
31a699934b Remove CircleCI ios PR jobs (#91638)
We added this because we wanted to burn our extra CIrcleCI credits, but now that it's the next year, those should be gone.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/91638
Approved by: https://github.com/huydhn, https://github.com/seemethere, https://github.com/malfet
2023-01-04 00:27:49 +00:00
joncrall
ad782ff7df Enable xdoctest runner in CI for real this time (#83816)
Builds on #83317 and enables running the doctests. Just need to figure out what is causing the failures.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/83816
Approved by: https://github.com/ezyang, https://github.com/malfet
2022-12-29 05:32:42 +00:00
Edward Z. Yang
ca39c5b04e Fix conda install on distributions with strict POSIX sh (#91371)
See also https://github.com/conda/conda/issues/10431

Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/91371
Approved by: https://github.com/albanD
2022-12-28 00:25:03 +00:00
PyTorch MergeBot
67c53d50e5 Revert "Fix conda install on distributions with strict POSIX sh (#91371)"
This reverts commit 57dcd93c41.

Reverted https://github.com/pytorch/pytorch/pull/91371 on behalf of https://github.com/kit1980 due to trunk / cuda11.6-py3.10-gcc7-sm86 / test (slow, 1, 2, linux.g5.4xlarge.nvidia.gpu) started to fail after this PR with mypy error
2022-12-27 19:51:59 +00:00
Edward Z. Yang
57dcd93c41 Fix conda install on distributions with strict POSIX sh (#91371)
See also https://github.com/conda/conda/issues/10431

Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/91371
Approved by: https://github.com/albanD
2022-12-26 02:39:08 +00:00
Huy Do
df46ba4026 Use python 3.9 for iOS build and test (#91366)
Since yesterday, Miniconda3-latest-MacOSX-x86_64.sh has changed to python 3.10 as the default, and it breaks iOS workflow:

* Breaking with python 3.10 https://github.com/pytorch/pytorch/actions/runs/3763269382/jobs/6396697341
* Working with python 3.9 https://github.com/pytorch/pytorch/actions/runs/3761903011/jobs/6394085845

Fun fact, both examples above come from the same commit f471770fd4 (one was in periodic, the other was in trunk)

Miniconda3-py39_4.12.0-MacOSX-x86_64.sh is the same miniconda installation that we use in https://github.com/pytorch/test-infra/tree/main/.github/actions/setup-miniconda

Note: @remidomingues is trying to add cache support for iOS in on https://github.com/pytorch/pytorch/pull/91359.  The PR is still under review.  But once that is merged, this issue won't happen again.  So this is a temporary fix to keep trunk green.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/91366
Approved by: https://github.com/atalman
2022-12-23 22:08:25 +00:00
Radek Bartoň
5725a44080 Remove Windows compilation dependencies installation from CI/CD scripts (#89909)
They should be already installed in the runner VM.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/89909
Approved by: https://github.com/huydhn
2022-12-23 17:40:19 +00:00
pbialecki
2d68cc4bc2 Add cu118 workflows (#90826)
CC @atalman @malfet

Pull Request resolved: https://github.com/pytorch/pytorch/pull/90826
Approved by: https://github.com/atalman
2022-12-20 14:34:18 +00:00
atalman
3bd37ff2d5 Removing invalid git option when updating submodules (#91132)
Same as this: https://github.com/pytorch/builder/pull/1246
Related to following git commit: 51243f9f0f
Which makes jobs = 0 invalid.

Nightlies for MacOS are failing because of this issue: https://github.com/pytorch/pytorch/actions/runs/3729522653/jobs/6325523414

Pull Request resolved: https://github.com/pytorch/pytorch/pull/91132
Approved by: https://github.com/kit1980, https://github.com/huydhn, https://github.com/malfet, https://github.com/seemethere
2022-12-20 02:17:02 +00:00
Jithun Nair
e8e591b72f Upgrade CI to ROCm5.3 (#88297)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/88297
Approved by: https://github.com/malfet
2022-12-14 05:09:56 +00:00
PyTorch MergeBot
af4735d3ad Revert "Upgrade CI to ROCm5.3 (#88297)"
This reverts commit 181a82ffd2.

Reverted https://github.com/pytorch/pytorch/pull/88297 on behalf of https://github.com/IvanYashchuk due to Tests are unnecessarily skipped on all platforms
2022-12-13 12:23:44 +00:00
Jithun Nair
181a82ffd2 Upgrade CI to ROCm5.3 (#88297)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/88297
Approved by: https://github.com/malfet
2022-12-13 04:50:06 +00:00
Nikita Shulga
6fb79b7004 Bump version: 1.14.0->2.0.0 (#90491)
Except for the usual location, had to update the version in one of ONNX expect patterns, namely here: 43660051d8/test/onnx/expect/TestOperators.test_avg_pool2d.expect (L3)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/90491
Approved by: https://github.com/jansel, https://github.com/albanD
2022-12-09 01:08:08 +00:00
Nikita Shulga
36ac095ff8 Migrate PyTorch to C++17 (#85969)
With CUDA-10.2 gone we can finally do it!

This PR mostly contains build system related changes, invasive functional ones are to be followed.
Among many expected tweaks to the build system, here are few unexpected ones:
 - Force onnx_proto project to be updated to C++17 to avoid `duplicate symbols` error when compiled by gcc-7.5.0, as storage rule for `constexpr` changed in C++17, but gcc does not seem to follow it
 - Do not use `std::apply` on CUDA but rely on the built-in variant, as it results in test failures when CUDA runtime picks host rather than device function when `std::apply` is invoked from CUDA code.
 - `std::decay_t` -> `::std::decay_t` and `std::move`->`::std::move` as VC++ for some reason claims that `std` symbol is ambigious
 - Disable use of `std::aligned_alloc` on Android, as its `libc++` does not implement it.

Some prerequisites:
 - https://github.com/pytorch/pytorch/pull/89297
 - https://github.com/pytorch/pytorch/pull/89605
 - https://github.com/pytorch/pytorch/pull/90228
 - https://github.com/pytorch/pytorch/pull/90389
 - https://github.com/pytorch/pytorch/pull/90379
 - https://github.com/pytorch/pytorch/pull/89570
 - https://github.com/facebookincubator/gloo/pull/336
 - https://github.com/facebookincubator/gloo/pull/343
 - 919676fb32

Fixes https://github.com/pytorch/pytorch/issues/56055

Pull Request resolved: https://github.com/pytorch/pytorch/pull/85969
Approved by: https://github.com/ezyang, https://github.com/kulinseth
2022-12-08 02:27:48 +00:00
Nikita Shulga
59101b6fe4 Fix binary iOS uploads (#90058)
curl on CircleCI MacOS runners does not support `--retry-all-errors`
Should fix https://app.circleci.com/pipelines/github/pytorch/pytorch/618606/workflows/6f104c19-3a3a-479d-a686-4961ddd87657/jobs/17233205
Yet another fallback of https://github.com/pytorch/pytorch/pull/89157

Pull Request resolved: https://github.com/pytorch/pytorch/pull/90058
Approved by: https://github.com/jeanschmidt
2022-12-02 14:28:19 +00:00
Nikita Shulga
d94f5c784c Fix binary testing if torchtrition is mandatory (#90017)
Prep-change for a builder, where torchtrition is installed from custom nightly downloads repo

Pull Request resolved: https://github.com/pytorch/pytorch/pull/90017
Approved by: https://github.com/seemethere
2022-12-02 01:05:01 +00:00
Nikita Shulga
6e8e7b9407 Fix binary ios builds (#89929)
curl on CircleCI MacOS runners does not support `--retry-all-errors`

Should fix https://app.circleci.com/pipelines/github/pytorch/pytorch/616842/workflows/5d1162c8-eeae-4627-a1b2-17b493b15b59/jobs/17230369?invite=true#step-105-62

Cleanup after https://github.com/pytorch/pytorch/pull/89157 that were missed by https://github.com/pytorch/pytorch/pull/89298

Pull Request resolved: https://github.com/pytorch/pytorch/pull/89929
Approved by: https://github.com/seemethere, https://github.com/atalman
2022-11-30 18:25:47 +00:00
Nikita Shulga
3ad2a032f4 Update default cmake to 3.18 (#89570)
Set `cmake.dir` to `/usr/local` in `.circleci/scripts/build_android_gradle.sh `
Prep change for raising compiler standard to C++17: cmake-3.18 is the first one to support CUDA17 language

Pull Request resolved: https://github.com/pytorch/pytorch/pull/89570
Approved by: https://github.com/atalman
2022-11-23 23:23:26 +00:00
Fuzzkatt
ef8b91fec7 enable previously failing UCC distributed_test.py tests (#89023)
Enables previously failing UCC distributed_test.py tests that are now fixed due to either ProcessGroupUCC barrier blocking fix (https://github.com/pytorch/pytorch/pull/86961) or UCC-side timeout error handling fix:  (https://github.com/openucx/ucc/pull/679/files). Bump upstream UCC version to build UCC with timeout error handling fix merged in.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/89023
Approved by: https://github.com/kwen2501, https://github.com/malfet
2022-11-22 19:05:56 +00:00
Zain Rizvi
ab75982d3a Always retry curl downloads (#89157)
Modify our curl commands so that they always retry downloads.

By default, curl only retries what it considers to be "transient" errors, based on the server's response. However, curl's estimate of what's transient is very conservative.  By adding the --retry-all-errors parameter we'll always retry curl commands.

In particular, I'm hoping this mitigates errors where curl fails with the below error ([logs](https://github.com/pytorch/pytorch/actions/runs/3468758110/jobs/5794939941))
`curl: (35) OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to ossci-linux.s3.amazonaws.com:443`

Some of the modified downloads didn't even have retries, so I added them in

More details: https://everything.curl.dev/usingcurl/downloads/retry
Pull Request resolved: https://github.com/pytorch/pytorch/pull/89157
Approved by: https://github.com/kit1980, https://github.com/malfet
2022-11-18 07:03:24 +00:00
John Detloff
65bcd1f880 Add previously deleted circleci readme back to repo (#85598)
This readme was deleted here: https://github.com/pytorch/pytorch/pull/73224 I chatted with the author, who doesn't remember exactly why it was deleted but suspects it was due either to out of date contents or because of the upcoming migration to github actions.

With that said, we have references to this readme through our circleci directory, and since we do still have a lot of circleci workflows I feel this readme still adds a lot of value. (I recently did some CI tasks that required me to dig this readme up in order to solve a problem).

I recommend we restore this file with a warning that its contents may be out of date, until our CircleCI workflows are entirely migrated to Github Actions

Pull Request resolved: https://github.com/pytorch/pytorch/pull/85598
Approved by: https://github.com/clee2000, https://github.com/malfet
2022-11-18 03:17:37 +00:00
Huy Do
251fdda77b Add pytest-flakefinder as a test dependency (#89103)
This is used to re-run tests multiple times to determine their flakiness status. The way re-run is handled in https://github.com/pytorch/pytorch/pull/88646 only applies to unittest

Per their documentation, `pytest-repeat` doesn't work with `unittest.Testcase` it seems, so trying https://github.com/dropbox/pytest-flakefinder instead
Pull Request resolved: https://github.com/pytorch/pytorch/pull/89103
Approved by: https://github.com/clee2000
2022-11-17 01:45:50 +00:00
Huy Do
c407a7b203 Upgrade Linux NVIDIA driver to the latest prod version (#88517)
The driver (515.76) is downloaded from https://www.nvidia.com/en-us/drivers/unix. This should help address the issue with A10G GPU on G5 runners according to NVIDIA. This is to address https://github.com/pytorch/pytorch/issues/88352

Pull Request resolved: https://github.com/pytorch/pytorch/pull/88517
Approved by: https://github.com/ZainRizvi
2022-11-07 17:26:28 +00:00
Jithun Nair
4faf086e5f Update build scripts for ninja and ROCm5.3 install (#87505)
cc @jeffdaily @sunway513 @ROCmSupport
Pull Request resolved: https://github.com/pytorch/pytorch/pull/87505
Approved by: https://github.com/seemethere
2022-10-28 22:05:12 +00:00
Nikita Shulga
e2bbc0a134 [BE] Move remaining workflows off Xenial (#87834)
Both BE and prerequisite for moving our CI/CD to C++17 compiler (gcc-5.4
is not fully C++17 compliant)

Pull Request resolved: https://github.com/pytorch/pytorch/pull/87834
Approved by: https://github.com/weiwangmeta, https://github.com/kit1980, https://github.com/huydhn
2022-10-27 15:38:48 +00:00
Nikita Shulga
53c640a528 [CI] Delete nnpack installation from conda (#87813)
Not sure why it was there to begin with and I really hope none of our CI depend on the package that was last updated 5 years ago, see https://anaconda.org/killeent/nnpack

Pull Request resolved: https://github.com/pytorch/pytorch/pull/87813
Approved by: https://github.com/atalman, https://github.com/kit1980, https://github.com/ZainRizvi
2022-10-26 21:51:13 +00:00
Pruthvi Madugundu
c2ef5c4f7e [ROCm] Move ROCm CI build to python 3.8 version (#86677)
Currently it is python 3.7 want to upgrade to python 3.8
Pull Request resolved: https://github.com/pytorch/pytorch/pull/86677
Approved by: https://github.com/malfet
2022-10-26 15:34:38 +00:00
Huy Do
1655b47a38 Add some common tools to docker base (#86993)
I always need to install these 2 tools whenever I use Docker manually to debug build and test issues:

* unzip is to extracted the zipped artifacts from PyTorch CI
* gdb is to do you know what :)

IMO, it makes sense to have them as part of the container image

Pull Request resolved: https://github.com/pytorch/pytorch/pull/86993
Approved by: https://github.com/ZainRizvi
2022-10-24 22:44:44 +00:00
Catherine Lee
fbe256cb1e cpp docs push fix (#87614)
currently failing with
```
To https://github.com/pytorch/cppdocs
 + 2825b2745bb...80ec4daa657 HEAD -> pytorchbot/temp-branch-cpp (forced update)
Branch 'master' set up to track remote branch 'pytorchbot/temp-branch-cpp' from 'origin'.
++ sleep 30
++ git push -u origin
fatal: The upstream branch of your current branch does not match
the name of your current branch.  To push to the upstream branch
on the remote, use

    git push origin HEAD:pytorchbot/temp-branch-cpp

To push to the branch of the same name on the remote, use

    git push origin HEAD

```

just checked the settings, master of pytorch/cppdocs does not have easy cla as a required check, so we don't need the temp branch
Pull Request resolved: https://github.com/pytorch/pytorch/pull/87614
Approved by: https://github.com/huydhn
2022-10-24 20:21:16 +00:00
Catherine Lee
5c4a2e679b fix docs push (#87498)
push docs to temp branch first then push to actual branch to satisfy CLA check in branch protections
Pull Request resolved: https://github.com/pytorch/pytorch/pull/87498
Approved by: https://github.com/malfet
2022-10-21 22:53:35 +00:00
Huy Do
e6bc8f415b [BE] Move conda cmake installation to Docker (#87309)
This is parts of the effort to consolidate pip and conda installation in the CI to improve our CI reliability.  This moves conda cmake installation to Docker in those use cases that require it:

* Ubuntu bionic and focal

On the other hand:
* XLA doesn't seem to need conda cmake anymore (Build and test successfully)
* Centos is not in used anywhere in the CI
Pull Request resolved: https://github.com/pytorch/pytorch/pull/87309
Approved by: https://github.com/ZainRizvi, https://github.com/malfet
2022-10-20 02:13:11 +00:00
PyTorch MergeBot
31edccf6c7 Revert "Temporarily disable ios jobs (#87186)"
This reverts commit d29dc2b72a.

Reverted https://github.com/pytorch/pytorch/pull/87186 on behalf of https://github.com/huydhn due to Official conda channel is back and conda-forge has been reverted
2022-10-18 21:03:23 +00:00
Catherine Lee
223ad9bc9e [ci] remove circleci mac jobs (#87225)
mac jobs are run on every pr after approval, so these are redundant
ios jobs can stay until the end of the year because they are on periodic and not run on every pr
Pull Request resolved: https://github.com/pytorch/pytorch/pull/87225
Approved by: https://github.com/malfet, https://github.com/ZainRizvi, https://github.com/janeyx99
2022-10-18 20:57:57 +00:00
PyTorch MergeBot
afa5086078 Revert "Install blas from conda-forge (#87150)"
This reverts commit f02f0e3ad1.

Reverted https://github.com/pytorch/pytorch/pull/87150 on behalf of https://github.com/huydhn due to Conda issue has been resolved upstream https://github.com/pytorch/pytorch/issues/87148
2022-10-18 20:54:06 +00:00
Huy Do
d29dc2b72a Temporarily disable ios jobs (#87186)
While investigating segfault issue:

* https://app.circleci.com/pipelines/github/pytorch/pytorch/584349/workflows/6c68b0ce-023e-4f62-83bf-e77962daf8ad/jobs/17180595
* https://github.com/pytorch/pytorch/actions/runs/3269860268/jobs/5377851127

This might be related to the use of conda-forge in https://github.com/pytorch/pytorch/issues/87148, i.e. conda-forge pulls in different version of some dependencies and breaks thing.  If that's the case, we could not revert conda-forge change yet because the checksum issue hasn't been fixed upstream yet (Test PR https://github.com/pytorch/pytorch/pull/87185)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/87186
Approved by: https://github.com/ZainRizvi, https://github.com/malfet
2022-10-18 15:27:27 +00:00
Huy Do
f02f0e3ad1 Install blas from conda-forge (#87150)
Mitigate https://github.com/pytorch/pytorch/issues/87148

### Testing

On AWS (m1, linux)

* Run `conda install blas:openblas`, it should failed with `ChecksumMismatchError`:

```
ChecksumMismatchError: Conda detected a mismatch between the expected content and downloaded content
for url 'https://repo.anaconda.com/pkgs/main/linux-64/blas-1.0-openblas.conda'.
  download saved to: /tmp/debug/pkgs/blas-1.0-openblas.conda
  expected sha256: c85b5d0a336b5be0f415c71fd7fe2eca59e09f42221bfa684aafef5510ba5487
  actual sha256: 5dc5483db0d9785b19e021cee418a8ee03e0ff0e5ebd0b75af4927746604e187
```

* Run ` conda install -c conda-forge blas:openblas` works

Pull Request resolved: https://github.com/pytorch/pytorch/pull/87150
Approved by: https://github.com/kit1980
2022-10-18 00:11:37 +00:00
Catherine Lee
d023e83933 handle libomp update on circleci (#86979)
libomp got an update and now its keg only

reverts https://github.com/pytorch/pytorch/pull/86940
Pull Request resolved: https://github.com/pytorch/pytorch/pull/86979
Approved by: https://github.com/huydhn, https://github.com/malfet
2022-10-17 21:03:42 +00:00
Catherine Lee
ae45dab57e disable failing circleci test jobs (#86940)
should revert later when fixed
Pull Request resolved: https://github.com/pytorch/pytorch/pull/86940
Approved by: https://github.com/huydhn, https://github.com/ZainRizvi
2022-10-13 21:27:52 +00:00
atalman
3af0eafea6 Release 1.13: Bump nightly version 1.13->1.14 (#86296)
Release 1.13:  Bump nightly version 1.13->1.14

Pull Request resolved: https://github.com/pytorch/pytorch/pull/86296
Approved by: https://github.com/seemethere, https://github.com/malfet
2022-10-06 23:26:58 +00:00
Richard Zou
e01d616ba9 Re-introduce the functorch docs build (#85838) (#86125)
We deleted it when merging functorch into pytorch. This PR makes a new
functorch docs build.

The docs are relatively simple:
- cd into `functorch/docs` and run `make html` to build the docs.
- docs should get pushed to the pytorch/functorch repo's gh-pages
branch.

The long term plan is:
- one day, the functorch APIs will just be torch.* APIs, at which point
we can fold all of the functorch docs into the regular PyTorch docs
- When that happens, the functorch examples and tutorials (that are on
the functorch docs site) can be moved to the pytorch examples and
pytorch tutorials.

Test Plan:
- check docs preview
- watch this PR after it goes in

Differential Revision: [D40026222](https://our.internmc.facebook.com/intern/diff/D40026222)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/86125
Approved by: https://github.com/atalman, https://github.com/malfet
2022-10-03 19:09:53 +00:00
PyTorch MergeBot
5fa840103b Revert "Re-introduce the functorch docs build (#85838)"
This reverts commit 0449cf0c9e.

Reverted https://github.com/pytorch/pytorch/pull/85838 on behalf of https://github.com/atalman due to Break internal build
2022-10-03 16:08:18 +00:00
John Detloff
06868004b7 Remove codesigning from ios circleci workflows (#85630)
This PR is a follow up to https://github.com/pytorch/pytorch/pull/85597 which removes codesigning from our github action workflows. This is a synonymous change to our circleci workflows. Since we only run TestApp on simulator we don't need to have this codesigning logic. (And more pressingly, these dev cert is expiring at the end of the month and we don't have a replacement)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/85630
Approved by: https://github.com/atalman, https://github.com/malfet
2022-09-29 19:49:11 +00:00
Richard Zou
0449cf0c9e Re-introduce the functorch docs build (#85838)
We deleted it when merging functorch into pytorch. This PR makes a new
functorch docs build.

The docs are relatively simple:
- cd into `functorch/docs` and run `make html` to build the docs.
- docs should get pushed to the pytorch/functorch repo's gh-pages
branch.

The long term plan is:
- one day, the functorch APIs will just be torch.* APIs, at which point
we can fold all of the functorch docs into the regular PyTorch docs
- When that happens, the functorch examples and tutorials (that are on
the functorch docs site) can be moved to the pytorch examples and
pytorch tutorials.

Test Plan:
- check docs preview
- watch this PR after it goes in
Pull Request resolved: https://github.com/pytorch/pytorch/pull/85838
Approved by: https://github.com/malfet
2022-09-29 17:47:49 +00:00
Jane Xu
3cdf621fe5 Add opt-einsum to CI (#85574)
Depends on https://github.com/pytorch/pytorch/pull/84890.

This PR adds opt_einsum to CI, enabling path optimization for the multi-input case. It also updates the installation sites to install torch with einsum, but those are mostly to make sure it would work on the user's end (as opt-einsum would have already been installed in the docker or in prior set up steps).

This PR also updates the windows build_pytorch.bat script to use the same bdist_wheel and install commands as on Linux, replacing the `setup.py install` that'll become deprecated.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/85574
Approved by: https://github.com/huydhn, https://github.com/soulitzer
2022-09-29 14:28:55 +00:00
Jithun Nair
976e2a3502 Separate magma installation for ROCm into its own file (#85567)
This aligns it with the builder repo scripts structure:
https://github.com/pytorch/builder/blob/main/common/install_rocm_magma.sh
https://github.com/pytorch/builder/blob/main/common/install_rocm.sh
Pull Request resolved: https://github.com/pytorch/pytorch/pull/85567
Approved by: https://github.com/jeffdaily, https://github.com/huydhn
2022-09-29 13:31:41 +00:00
atalman
1418a663b1 Fix upload condition pypi-cudnn build (#85799)
Fix upload condition pypi-cudnn build
We excute this in sh and looks like the condition with "==" is not getting triggered.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/85799
Approved by: https://github.com/DanilBaibak, https://github.com/jeanschmidt, https://github.com/seemethere
2022-09-28 22:27:52 +00:00
Catherine Lee
8bb69a007f reenable circleci mac jobs (#85824)
undo https://github.com/pytorch/pytorch/pull/84438 and see if its green now
Pull Request resolved: https://github.com/pytorch/pytorch/pull/85824
Approved by: https://github.com/huydhn, https://github.com/malfet
2022-09-28 20:44:49 +00:00
atalman
879ae45230 Increase timeout and retry count conda upload (#85802)
Increase timeout and retry count conda upload. We are keep seeing conda upload failures even with 2 min timeout.
Hence increasing timeout to 5min and retry to 5 times

Pull Request resolved: https://github.com/pytorch/pytorch/pull/85802
Approved by: https://github.com/datumbox
2022-09-28 20:34:13 +00:00
dependabot[bot]
0d86dfccf8 Bump protobuf from 3.20.1 to 3.20.2 in /.circleci/docker (#85572)
Bumps [protobuf](https://github.com/protocolbuffers/protobuf) from 3.20.1 to 3.20.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/protocolbuffers/protobuf/releases">protobuf's releases</a>.</em></p>
<blockquote>
<h2>Protocol Buffers v3.20.2</h2>
<h1>C++</h1>
<ul>
<li>Reduce memory consumption of MessageSet parsing</li>
<li>This release addresses a <a href="https://github.com/protocolbuffers/protobuf/security/advisories/GHSA-8gq9-2x98-w8hf">Security Advisory for C++ and Python users</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="a20c65f2cd"><code>a20c65f</code></a> Updating changelog</li>
<li><a href="c49fe79af9"><code>c49fe79</code></a> Updating version.json and repo version numbers to: 20.2</li>
<li><a href="806d7e4ce6"><code>806d7e4</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/10544">#10544</a> from deannagarcia/3.20.x</li>
<li><a href="ae718b3902"><code>ae718b3</code></a> Add missing includes</li>
<li><a href="b4c395aaed"><code>b4c395a</code></a> Apply patch</li>
<li><a href="6439c5c013"><code>6439c5c</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/10531">#10531</a> from protocolbuffers/deannagarcia-patch-7</li>
<li><a href="22c79e6e4c"><code>22c79e6</code></a> Update version.json</li>
<li><a href="c1a2d2ec29"><code>c1a2d2e</code></a> Fix python release on macos (<a href="https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/10512">#10512</a>)</li>
<li><a href="a826282e15"><code>a826282</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/10505">#10505</a> from deannagarcia/3.20.x</li>
<li><a href="7639a710e1"><code>7639a71</code></a> Add version file</li>
<li>Additional commits viewable in <a href="https://github.com/protocolbuffers/protobuf/compare/v3.20.1...v3.20.2">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=protobuf&package-manager=pip&previous-version=3.20.1&new-version=3.20.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/pytorch/pytorch/network/alerts).

</details>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/85572
Approved by: https://github.com/malfet
2022-09-25 16:23:21 +00:00
Catherine Lee
49e10c1598 [ci] test_ops in parallel, ci tests log to file (#85528)
part one of splitting up https://github.com/pytorch/pytorch/pull/84961 into (probably 2) parts

contains
* logging to file
* testing test_ops in parallel
Pull Request resolved: https://github.com/pytorch/pytorch/pull/85528
Approved by: https://github.com/huydhn
2022-09-23 20:45:20 +00:00
atalman
52a8be523c Adjust retry time for conda upload (#85545)
Adjusting retry times for conda upload.
Refer to this failure: https://github.com/pytorch/pytorch/actions/runs/3110932965/jobs/5043384691

```
Error:  ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))
+ sleep 1
......
Error:  ('file osx-arm64/pytorch-1.13.0.dev20220923-py3.9_0.tar.bz2 already exists or being uploaded for package pytorch version 1.13.0.dev20220923. if your previous upload failed, please wait 2 minutes before trying again', 409)
```

Pull Request resolved: https://github.com/pytorch/pytorch/pull/85545
Approved by: https://github.com/datumbox
2022-09-23 20:28:36 +00:00
Catherine Lee
92a942100a disable circleci jobs b/c they are flaky (#85508)
should undo this when theyre ok again
Pull Request resolved: https://github.com/pytorch/pytorch/pull/85508
Approved by: https://github.com/kit1980, https://github.com/ZainRizvi
2022-09-22 22:05:55 +00:00
atalman
e342976907 Adding conda retry upload to mitigate connection reset errors (#85407)
Adding conda retry upload to mitigate connection reset errors

Mitigate errors like this:
https://github.com/pytorch/pytorch/actions/runs/3095808905/jobs/5012840560

```
Uploading file "pytorch-nightly/pytorch/1.13.0.dev20220921/linux-64/pytorch-1.13.0.dev20220921-py3.9_cuda11.6_cudnn8.3.2_0.tar.bz2"

  0%|          | 0.00/1.24G [00:00<?, ?B/s]
100%|██████████| 1.24G/1.24G [00:00<00:00, 2.08GB/s]
100%|██████████| 1.24G/1.24G [00:04<00:00, 271MB/s]
Error:  ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))
Error: Process completed with exit code 1.
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/85407
Approved by: https://github.com/weiwangmeta, https://github.com/malfet, https://github.com/seemethere
2022-09-22 17:33:59 +00:00
PyTorch MergeBot
3dce26635f Revert "test in parallel at file granularity (#84961)"
This reverts commit 8107666c6a.

Reverted https://github.com/pytorch/pytorch/pull/84961 on behalf of https://github.com/clee2000 due to makes test_forward_ad_nn_functional_max_unpool2d_cuda_float32 flakily unexpectedly pass
2022-09-21 20:21:25 +00:00
Catherine Lee
8107666c6a test in parallel at file granularity (#84961)
run tests in parallel at the test file granularity

runs 3 files in parallel using multiprocessing pool, output goes to a file, which is then printed when the test finishes.  Some tests cannot be run in parallel (usually due to lacking memory), so we run those after.  Sharding is changed to attempt to mask large files with other large files/run them on the same shard.

test_ops* gets a custom handler to run it because it is simply too big (2hrs on windows) and linalg_cholesky fails (I would really like a solution to this if possible, but until then we use the custom handler).

reduces cuda tests by a lot, reduces total windows test time by ~1hr

Ref. https://github.com/pytorch/pytorch/issues/82894
Pull Request resolved: https://github.com/pytorch/pytorch/pull/84961
Approved by: https://github.com/huydhn
2022-09-21 16:58:11 +00:00
atalman
eb94df28c7 Use pip install cu117 (#85097)
Creates new wheel workflow specific to CUDA 11.7 that does not bundle the cudnn and cublas.

Workflow:
https://github.com/pytorch/pytorch/actions/runs/3094622781

New Package:
manywheel-py3_10-cuda11_7-with-pypi-cudnn | 843 MB

Old Package:
manywheel-py3_10-cuda11_7 | 1.65 GB

Testing workflow:

[manywheel-py3_7-cuda11_7-with-pypi-cudnn-build / build](https://github.com/pytorch/pytorch/actions/runs/3091145546/jobs/5000867662#logs):
```
Bundling without cudnn and cublas.
+ DEPS_LIST=("/usr/local/cuda/lib64/libcudart.so.11.0" "/usr/local/cuda/lib64/libnvToolsExt.so.1" "/usr/local/cuda/lib64/libnvrtc.so.11.2" "/usr/local/cuda/lib64/libnvrtc-builtins.so.11.7" "$LIBGOMP_PATH")
+ DEPS_SONAME=("libcudart.so.11.0" "libnvToolsExt.so.1" "libnvrtc.so.11.2" "libnvrtc-builtins.so.11.7" "libgomp.so.1")
.....
pytorch_extra_install_requirements: nvidia-cuda-runtime-cu11, nvidia-cudnn-cu11, nvidia-cublas-cu11
```

[manywheel-py3_7-cuda11_7-build / build](https://github.com/pytorch/pytorch/actions/runs/3091145546/jobs/5000863250#logs)

```
Bundling with cudnn and cublas.
+ DEPS_LIST=("/usr/local/cuda/lib64/libcudart.so.11.0" "/usr/local/cuda/lib64/libnvToolsExt.so.1" "/usr/local/cuda/lib64/libnvrtc.so.11.2" "/usr/local/cuda/lib64/libnvrtc-builtins.so.11.7" "/usr/local/cuda/lib64/libcudnn_adv_infer.so.8" "/usr/local/cuda/lib64/libcudnn_adv_train.so.8" "/usr/local/cuda/lib64/libcudnn_cnn_infer.so.8" "/usr/local/cuda/lib64/libcudnn_cnn_train.so.8" "/usr/local/cuda/lib64/libcudnn_ops_infer.so.8" "/usr/local/cuda/lib64/libcudnn_ops_train.so.8" "/usr/local/cuda/lib64/libcudnn.so.8" "/usr/local/cuda/lib64/libcublas.so.11" "/usr/local/cuda/lib64/libcublasLt.so.11" "$LIBGOMP_PATH")
+ DEPS_SONAME=("libcudart.so.11.0" "libnvToolsExt.so.1" "libnvrtc.so.11.2" "libnvrtc-builtins.so.11.7" "libcudnn_adv_infer.so.8" "libcudnn_adv_train.so.8" "libcudnn_cnn_infer.so.8" "libcudnn_cnn_train.so.8" "libcudnn_ops_infer.so.8" "libcudnn_ops_train.so.8" "libcudnn.so.8" "libcublas.so.11" "libcublasLt.so.11" "libgomp.so.1")
```

cc: @malfet @ptrblck
Pull Request resolved: https://github.com/pytorch/pytorch/pull/85097
Approved by: https://github.com/malfet
2022-09-21 16:30:25 +00:00
atalman
54c46e4f90 Upgrade to CUDNN version for cuda 11.7 (#84964)
Upgrade to CUDNN version to 8.5 for cuda 11.7.
This is reland of: https://github.com/pytorch/pytorch/pull/84859
Issues in periodic build fshould be fixed by : https://github.com/pytorch/pytorch/pull/84943
Pull Request resolved: https://github.com/pytorch/pytorch/pull/84964
Approved by: https://github.com/ZainRizvi
2022-09-14 12:06:15 +00:00
Jithun Nair
b4a881afac [ROCm] Remove gfx900 from base docker build and Pytorch build scripts (#80015)
CI doesn't have any MI25s anymore. Should improve docker and Pytorch build times in CI for ROCm.

Will take out of Draft mode after https://github.com/pytorch/pytorch/pull/79596 is merged

Pull Request resolved: https://github.com/pytorch/pytorch/pull/80015
Approved by: https://github.com/jeffdaily, https://github.com/malfet
2022-09-13 20:43:44 +00:00
PyTorch MergeBot
8c2da0616c Revert "Upgrade to CUDNN version for cuda 11.7 (#84859)"
This reverts commit 9064bf2c72.

Reverted https://github.com/pytorch/pytorch/pull/84859 on behalf of https://github.com/atalman due to Reverting broke periodic tests
2022-09-13 16:46:24 +00:00
atalman
9064bf2c72 Upgrade to CUDNN version for cuda 11.7 (#84859)
Upgrade to CUDNN version for cuda 11.7

Pull Request resolved: https://github.com/pytorch/pytorch/pull/84859
Approved by: https://github.com/malfet
2022-09-12 17:09:05 +00:00
Xiang Gao
08c4f8c7a7 ProcessGroupUCC tests (#83285)
- [x] Direct dependency on UCX is completely removed, UCC active set API always enabled
- [x] Remove `TORCH_UCC_PROFILING_ENABLE`, always enable profiling
- [x] Fixes profiling of `recv` and `all_gather`
- [x] Use the NCCL TL of UCC on CUDA, as  the UCP TL is not well supported on CUDA

Most tests are passing, but there are a few skipped tests:
- `scatter` and `gather` are not supported by the UCP TL of UCC on CPU tensors
- A few flaky tests in PyTorch's CI environment
- Profiler-related failures, some of them will be fixed by @Fuzzkatt in https://github.com/pytorch/pytorch/pull/84368

After this PR is merged, I will continue to work on these skipped failures.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/83285
Approved by: https://github.com/vtlam, https://github.com/malfet, https://github.com/kwen2501
2022-09-10 10:56:05 +00:00
Catherine Lee
aec76e391f circleci - add master back, retry checkout for ios (#84443)
add master back so its easier to determine when something started failing

retry checkout for ios, based on the provided circleci checkout but with a lot of stuff removed
Pull Request resolved: https://github.com/pytorch/pytorch/pull/84443
Approved by: https://github.com/janeyx99
2022-09-06 21:32:05 +00:00
Catherine Lee
9bcad063d8 disable ios on circleci b/c failing (#84438)
reenable when fixed

cause is likely: https://status.circleci.com/incidents/lbhyrt87g89r

examples of failures: https://app.circleci.com/pipelines/github/pytorch/pytorch/559778/workflows/e17e6b96-649e-4e49-b9f1-c0b1ecd96e02/jobs/17073870

something related to ssh

started around 12 hours ago?
Pull Request resolved: https://github.com/pytorch/pytorch/pull/84438
Approved by: https://github.com/ZainRizvi
2022-09-01 19:53:36 +00:00
Nikita Shulga
e8885a872c [CI] Move bazel from 11.3 to 11.6 (#84314)
In process of doing so have to:
- Delete `/usr/local/cuda-11.6/cuda-11.6` symlink to self, otherwise Bazel builds fail with
```
ERROR: circular symlinks detected
[start of symlink cycle]
/usr/local/cuda-11.6/cuda-11.6
[end of symlink cycle]
```
- Add `-DCUB_WRAPPED_NAMESPACE=at_cuda_detail"` to `COMMON_COPTS` if building with CUDA, to mimic the behaviour in
4b8ae04788/cmake/Dependencies.cmake (L1664-L1668)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/84314
Approved by: https://github.com/ngimel, https://github.com/atalman
2022-08-31 23:02:42 +00:00
Catherine Lee
af741e821b no ios arm builds on circleci (#84299)
Get rid of ios arm builds on circleci b/c most people dont have these permissions and they make the job show up as failing/red.

Next step is to see if we can do only builds since they might not require credentials
Pull Request resolved: https://github.com/pytorch/pytorch/pull/84299
Approved by: https://github.com/janeyx99, https://github.com/malfet
2022-08-30 22:45:15 +00:00
Catherine Lee
7a14c56bee only run the circleci mac/ios jobs on prs (#84227)
as in title, since they were being run on nightly when they dont need to be (and they were failing), also dont run on master b/c the github actions version already exists for that
Pull Request resolved: https://github.com/pytorch/pytorch/pull/84227
Approved by: https://github.com/seemethere, https://github.com/janeyx99, https://github.com/huydhn, https://github.com/malfet
2022-08-30 03:53:18 +00:00
Catherine Lee
582c0833d5 mac circleci workflows (#82780)
Add mac and ios workflows to circleci so they can be run on pull

m1 tests not included because circleci doesnt have machines

Unsure how to get certain environment variables (specifically for arm64 ios builds that require env vars like `IOS_SIGN_KEY_2022` and `IOS_DEV_TEAM_ID` that are stored in the org-member context which is not accessible by everyone.

doc regarding env vars https://docs.google.com/document/d/1J_3Z9sfu2vlHMF1fjdJfeTuxPXC6dgqJs7aU0KpYSBU/edit#

Pull Request resolved: https://github.com/pytorch/pytorch/pull/82780
Approved by: https://github.com/malfet, https://github.com/huydhn
2022-08-26 18:48:48 +00:00
Xiang Gao
a4a55f5ea6 New TORCH_UCC_BLOCKING_WAIT env variable (#81791)
Cherry-pick of https://github.com/facebookresearch/torch_ucc/pull/95.

I recommend waiting until https://github.com/pytorch/pytorch/pull/81583 is merged first, so the CI is checking if this PR compiles correctly.

Marking this as a draft for now, will change to "ready for review" once https://github.com/pytorch/pytorch/pull/81583 merged.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/81791
Approved by: https://github.com/kwen2501
2022-08-25 21:33:17 +00:00
Jane Xu
1eff853fdc Pin conda to 4.13.0 (#83991)
Recent update to conda 4.14.0 caused breakages in our docker builds:
754d7f05b6

This pins to prevent the errors:
```
Traceback (most recent call last):
2022-08-24T16:20:49.2412247Z   File "/opt/conda/lib/python3.9/site-packages/conda/exceptions.py", line 1125, in __call__
2022-08-24T16:20:49.2413036Z   File "/opt/conda/lib/python3.9/site-packages/conda/cli/main.py", line 86, in main_subshell
2022-08-24T16:20:49.2413615Z   File "/opt/conda/lib/python3.9/site-packages/conda/cli/conda_argparse.py", line 93, in do_call
2022-08-24T16:20:49.2414282Z   File "/opt/conda/lib/python3.9/site-packages/conda/notices/core.py", line 75, in wrapper
2022-08-24T16:20:49.2415036Z   File "/opt/conda/lib/python3.9/site-packages/conda/notices/core.py", line 39, in display_notices
2022-08-24T16:20:49.2415853Z   File "/opt/conda/lib/python3.9/site-packages/conda/notices/http.py", line 36, in get_notice_responses
2022-08-24T16:20:49.2416661Z   File "/opt/conda/lib/python3.9/site-packages/conda/notices/http.py", line 39, in <genexpr>
2022-08-24T16:20:49.2417399Z   File "/opt/conda/lib/python3.9/concurrent/futures/_base.py", line 609, in result_iterator
2022-08-24T16:20:49.2418145Z   File "/opt/conda/lib/python3.9/concurrent/futures/_base.py", line 446, in result
2022-08-24T16:20:49.2418831Z   File "/opt/conda/lib/python3.9/concurrent/futures/_base.py", line 391, in __get_result
2022-08-24T16:20:49.2419543Z   File "/opt/conda/lib/python3.9/concurrent/futures/thread.py", line 58, in run
2022-08-24T16:20:49.2420292Z   File "/opt/conda/lib/python3.9/site-packages/conda/notices/http.py", line 42, in <lambda>
2022-08-24T16:20:49.2421070Z   File "/opt/conda/lib/python3.9/site-packages/conda/notices/cache.py", line 37, in wrapper
2022-08-24T16:20:49.2421712Z   File "/opt/conda/lib/python3.9/site-packages/conda/notices/http.py", line 58, in get_channel_notice_response
2022-08-24T16:20:49.2422258Z   File "/opt/conda/lib/python3.9/site-packages/requests/sessions.py", line 600, in get
2022-08-24T16:20:49.2422801Z   File "/opt/conda/lib/python3.9/site-packages/requests/sessions.py", line 587, in request
2022-08-24T16:20:49.2423226Z   File "/opt/conda/lib/python3.9/site-packages/requests/sessions.py", line 701, in send
2022-08-24T16:20:49.2423634Z   File "/opt/conda/lib/python3.9/site-packages/requests/adapters.py", line 460, in send
2022-08-24T16:20:49.2424239Z   File "/opt/conda/lib/python3.9/site-packages/requests/adapters.py", line 263, in cert_verify
2022-08-24T16:20:49.2424731Z OSError: Could not find a suitable TLS CA certificate bundle, invalid path: /opt/conda/lib/python3.9/site-packages/certifi/cacert.pem
2022-08-24T16:20:49.2424967Z
2022-08-24T16:20:49.2425110Z During handling of the above exception, another exception occurred:
2022-08-24T16:20:49.2425279Z
2022-08-24T16:20:49.2425377Z Traceback (most recent call last):
2022-08-24T16:20:49.2425610Z   File "/opt/conda/bin/conda", line 13, in <module>
2022-08-24T16:20:49.2425845Z     sys.exit(main())
2022-08-24T16:20:49.2426176Z   File "/opt/conda/lib/python3.9/site-packages/conda/cli/main.py", line 129, in main
2022-08-24T16:20:49.2426614Z   File "/opt/conda/lib/python3.9/site-packages/conda/exceptions.py", line 1413, in conda_exception_handler
2022-08-24T16:20:49.2427054Z   File "/opt/conda/lib/python3.9/site-packages/conda/exceptions.py", line 1128, in __call__
2022-08-24T16:20:49.2427555Z   File "/opt/conda/lib/python3.9/site-packages/conda/exceptions.py", line 1170, in handle_exception
2022-08-24T16:20:49.2427995Z   File "/opt/conda/lib/python3.9/site-packages/conda/exceptions.py", line 1181, in handle_unexpected_exception
2022-08-24T16:20:49.2428471Z   File "/opt/conda/lib/python3.9/site-packages/conda/exceptions.py", line 1251, in print_unexpected_error_report
2022-08-24T16:20:49.2428873Z ModuleNotFoundError: No module named 'conda.cli.main_info'
2022-08-24T16:20:55.5428691Z The command '/bin/sh -c bash ./install_conda.sh && rm install_conda.sh' returned a non-zero code: 1
```
Pull Request resolved: https://github.com/pytorch/pytorch/pull/83991
Approved by: https://github.com/malfet
2022-08-24 21:22:14 +00:00
joncrall
b136f3f310 More doctest refinements. (#83317)
Follow up to #82797

Now that the doctests themselves are in a better state, we should be able to enable xdoctest on the CI so they stay that way.

@ezyang @vadimkantorov
Pull Request resolved: https://github.com/pytorch/pytorch/pull/83317
Approved by: https://github.com/ezyang
2022-08-22 20:07:26 +00:00
joncrall
4618371da5 Integrate xdoctest - Rebased (#82797)
This is a new version of #15648 based on the latest master branch.

Unlike the previous PR where I fixed a lot of the doctests in addition to integrating xdoctest, I'm going to reduce the scope here. I'm simply going to integrate xdoctest, and then I'm going to mark all of the failing tests as "SKIP". This will let xdoctest run on the dashboards, provide some value, and still let the dashboards pass. I'll leave fixing the doctests themselves to another PR.

In my initial commit, I do the bare minimum to get something running with failing dashboards. The few tests that I marked as skip are causing segfaults. Running xdoctest results in 293 failed, 201 passed tests. The next commits will be to disable those tests. (unfortunately I don't have a tool that will insert the `#xdoctest: +SKIP` directive over every failing test, so I'm going to do this mostly manually.)

Fixes https://github.com/pytorch/pytorch/issues/71105

@ezyang
Pull Request resolved: https://github.com/pytorch/pytorch/pull/82797
Approved by: https://github.com/ezyang
2022-08-12 02:08:01 +00:00
Xiang Gao
cda210e23b UCC PG build in CI (#81583)
- Modifies the current cmake build definitions to use `find_package` to find UCX and UCC installed in the system
- Install UCX and UCC in CUDA dockers
- Build PyTorch with `USE_UCC=1` in pipelines
- Currently, we are not running unit tests with the UCC PG. Those tests will be added in future PRs.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/81583
Approved by: https://github.com/vtlam, https://github.com/malfet
2022-08-10 00:23:47 +00:00
pbialecki
b4f7e22640 Enable periodic builds for CUDA 11.7 (#81688)
CC @atalman
Pull Request resolved: https://github.com/pytorch/pytorch/pull/81688
Approved by: https://github.com/atalman
2022-08-10 00:03:51 +00:00
Peter Bell
efd8e083bf Add pre-compiled headers to one of the CI runners (#77351)
Pre-compiled headers currently aren't tested in CI.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/77351
Approved by: https://github.com/janeyx99
2022-08-05 19:34:53 +00:00
atalman
5aef03513f Bumping nvidia docker version and using python 3.10 for cuda11.7 (#82472)
### Description
CUDA 11.7 Requires Driver update : https://docs.nvidia.com/cuda/cuda-toolkit-release-notes/index.html
This is only Linux update, will require followup PR for Windows update.

This should resolve this error:
https://github.com/pytorch/pytorch/runs/7478454141?check_suite_focus=true

On this PR: https://github.com/pytorch/pytorch/pull/81688
```
nvidia-container-cli: requirement error: unsatisfied condition: cuda>=11.7, please update your driver to a newer version, or use an earlier cuda container: unknown.
```

### Testing
IN CI

Pull Request resolved: https://github.com/pytorch/pytorch/pull/82472
Approved by: https://github.com/DanilBaibak, https://github.com/malfet
2022-08-02 16:00:19 +00:00
atalman
c94706c011 Fix docker build error related to libc6 (#82476)
### Description
We have following failure in libc6 on postnightly builds:
https://github.com/pytorch/pytorch/runs/7579216955?check_suite_focus=true

```
The following packages have unmet dependencies:
 libc6-i386 : Depends: libc6 (= 2.35-0ubuntu3) but 2.35-0ubuntu3.1 is to be installed
E: Unable to correct problems, you have held broken packages.
```

### Testing
In CI

Pull Request resolved: https://github.com/pytorch/pytorch/pull/82476
Approved by: https://github.com/DanilBaibak, https://github.com/malfet
2022-08-01 14:07:25 +00:00
Nikita Shulga
d80fe49de0 [Reland] Add py-3.10 config (#82329)
This is a re-land of #81372 and #81233 with the exception that it does not force the range-checks on older Python runtime versions and as such should not affect the internal workloads, which were the reason for revert, see https://github.com/pytorch/pytorch/pull/81372#issuecomment-1187516464

- [Py3.10] Allow floats to be imported as Long (#81372)
- [CI] Move CUDA-11.6 to Python-3.10 configuration (#81233)
- Don't do anything about range checks for pre-py3.10
Pull Request resolved: https://github.com/pytorch/pytorch/pull/82329
Approved by: https://github.com/kit1980
2022-07-27 20:22:47 +00:00
Sim Sun
487c0e1181 [pytorch] Bump SoLoader version to 0.10.4 (#81946)
Test Plan: sandcastle CI.

Differential Revision: D38056789

Pull Request resolved: https://github.com/pytorch/pytorch/pull/81946
Approved by: https://github.com/kit1980
2022-07-27 18:16:29 +00:00
Sergii Dymchenko
8e926ff49e Change ADD to COPY in Dockerfiles (#82151)
Docker docs says "For other items (files, directories) that do not require ADD’s tar auto-extraction capability, you should always use COPY": https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#add-or-copy

I've found this by running https://github.com/hadolint/hadolint

This is a follow-up after https://github.com/pytorch/pytorch/pull/81944
Pull Request resolved: https://github.com/pytorch/pytorch/pull/82151
Approved by: https://github.com/huydhn, https://github.com/jeffdaily, https://github.com/ZainRizvi
2022-07-27 01:43:23 +00:00
Sergii Dymchenko
2bae67fcf8 Fix "Failed to fetch https://github.com/rust-lang/crates.io-index" (#82171)
https://github.com/pytorch/pytorch/issues/82174
Pull Request resolved: https://github.com/pytorch/pytorch/pull/82171
Approved by: https://github.com/seemethere
2022-07-26 19:39:04 +00:00
Sergii Dymchenko
0c8a1c4d85 Really check GRADLE_OFFLINE (#81954)
Without "$", the condition is a literal string and always true.

I've found this using https://github.com/koalaman/shellcheck
Pull Request resolved: https://github.com/pytorch/pytorch/pull/81954
Approved by: https://github.com/linbinyu
2022-07-25 22:17:51 +00:00
Jithun Nair
1e8ef8cb20 [ROCm] Update CI docker images and jobs to rocm5.2 (#81168)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/81168
Approved by: https://github.com/janeyx99
2022-07-23 05:29:55 +00:00
Sergii Dymchenko
a7d7f6d856 Change ADD to COPY (#81944)
Docker docs says "For other items (files, directories) that do not require ADD’s tar auto-extraction capability, you should always use COPY": https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#add-or-copy

I've found this by running https://github.com/hadolint/hadolint

If this goes well, I'll change other files too.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/81944
Approved by: https://github.com/huydhn
2022-07-22 02:35:46 +00:00
Catherine Lee
06a0cfc0ea pytest to run test_ops, test_ops_gradients, test_ops_jit in non linux cuda environments (#79898)
This PR uses pytest to run test_ops, test_ops_gradients, and test_ops_jit in parallel in non linux cuda environments to decrease TTS.  I am excluding linux cuda because running in parallel results in errors due to running out of memory

Notes:
* update hypothesis version for compatability with pytest
* use rerun-failures to rerun tests (similar to flaky tests, although these test files generally don't have flaky tests)
  * reruns are denoted by a rerun tag in the xml.  Failed reruns also have the failure tag.  Successes (meaning that the test is flaky) do not have the failure tag.
* see https://docs.google.com/spreadsheets/d/1aO0Rbg3y3ch7ghipt63PG2KNEUppl9a5b18Hmv2CZ4E/edit#gid=602543594 for info on speedup (or slowdown in the case of slow tests)
  * expecting windows tests to decrease by 60 minutes total
* slow test infra is expected to stay the same - verified by running pytest and unittest on the same job and check the number of skipped/run tests
* test reports to s3 changed - add entirely new table to keep track of invoking_file times
Pull Request resolved: https://github.com/pytorch/pytorch/pull/79898
Approved by: https://github.com/malfet, https://github.com/janeyx99
2022-07-19 19:50:57 +00:00
PyTorch MergeBot
c96485804f Revert "[CI] Move CUDA-11.6 to Python-3.10 configuration (#81233)"
This reverts commit 7ccf693cf6.

Reverted https://github.com/pytorch/pytorch/pull/81233 on behalf of https://github.com/janeyx99 due to this should have been reverted along with 81372 for breaking internal builds
2022-07-18 17:15:50 +00:00
pbialecki
99c464ae26 Add CUDA 11.7 workflows (#81095)
Ref https://github.com/pytorch/builder/issues/1042

CC @atalman

Pull Request resolved: https://github.com/pytorch/pytorch/pull/81095
Approved by: https://github.com/atalman
2022-07-18 09:03:03 +00:00
Nikita Shulga
7ccf693cf6 [CI] Move CUDA-11.6 to Python-3.10 configuration (#81233)
Second attempt of landing the change after https://github.com/pytorch/pytorch/pull/66530

Skip nan hashes comparison validation in `jit/test_hash.py`, as it behaves differently in 3.10 vs other pythons
Skip tensor_fx assert tests
Skip initializing uint8 tensors from negative values in `TestScript.test_torch_tensor_as_tensor`

Final step in closing https://github.com/pytorch/pytorch/issues/66424

Pull Request resolved: https://github.com/pytorch/pytorch/pull/81233
Approved by: https://github.com/seemethere
2022-07-16 20:41:04 +00:00
Richard Zou
b294efc99b Install networkx when testing functorch (#81403)
networkx is a required testing dependency. We're working on getting rid
of the dependency though (because ultimately we don't want PyTorch to
take a dependency on it).

Test Plan:
- wait for the functorch test shard in pytorch CI
Pull Request resolved: https://github.com/pytorch/pytorch/pull/81403
Approved by: https://github.com/ezyang, https://github.com/malfet
2022-07-15 03:43:24 +00:00
pbialecki
12c30a8250 Add linux cuda 11.7 workflows (#81089)
Ref https://github.com/pytorch/builder/issues/1042

CC @atalman
Pull Request resolved: https://github.com/pytorch/pytorch/pull/81089
Approved by: https://github.com/atalman
2022-07-13 18:09:37 +00:00
Nikita Shulga
33a419dbd0 [CI][BE] Move repeated deps to CONDA_COMMON_DEPS variable (#77923)
Also, pin mkl dependencies and delete Python-3.6 clause

Pull Request resolved: https://github.com/pytorch/pytorch/pull/77923
Approved by: https://github.com/atalman, https://github.com/seemethere
2022-07-11 13:31:20 +00:00
Nikita Shulga
3c2199b159 Update CUDA version in CI to 11.6.2 (#80378)
We really should converge ways we setup CUDA

Pull Request resolved: https://github.com/pytorch/pytorch/pull/80378
Approved by: https://github.com/atalman
2022-07-10 14:19:46 +00:00
Jithun Nair
8a5d9843ff Update ROCm base docker images to focal (ubuntu20.04) (attempt #2) (#81031)
Re-attempting after original PR https://github.com/pytorch/pytorch/pull/79596 was reverted due to causing ROCm build failures
Pull Request resolved: https://github.com/pytorch/pytorch/pull/81031
Approved by: https://github.com/jeffdaily, https://github.com/malfet
2022-07-08 16:01:40 +00:00
DanilBaibak
91220799e8 Added logic for pushing docker images to ghcr.io (#80950)
Fixes https://github.com/pytorch/pytorch/issues/79323
Pull Request resolved: https://github.com/pytorch/pytorch/pull/80950
Approved by: https://github.com/malfet, https://github.com/seemethere
2022-07-07 10:58:14 +00:00
Michael Suo
07e41652c4 [ci] simplify sccache stats uploading (#80806)
We had some manualy parsing to turn the `sccache --show-stats` output
into json. Turns out sccache has an option for that already!
Pull Request resolved: https://github.com/pytorch/pytorch/pull/80806
Approved by: https://github.com/janeyx99
2022-07-07 05:12:20 +00:00
PyTorch MergeBot
6b5bab17d6 Revert "Update ROCm base docker images to focal (ubuntu20.04) (#79596)"
This reverts commit 8302bbe408.

Reverted https://github.com/pytorch/pytorch/pull/79596 on behalf of https://github.com/malfet due to Jeff asked for it
2022-07-06 22:10:21 +00:00
Jithun Nair
8302bbe408 Update ROCm base docker images to focal (ubuntu20.04) (#79596)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/79596
Approved by: https://github.com/malfet
2022-07-06 21:41:29 +00:00
Eli Uriegas
1947175495 ci: Skip docker push for most builds (#80402)
Skips docker push unless explicitly called out in the inputs for the
calculate-docker-image step.

Also skips the push if the image already exists on ECR due to our
immutable image tags

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/80402
Approved by: https://github.com/janeyx99, https://github.com/malfet
2022-06-30 17:05:45 +00:00
Edward Z. Yang
f3a5e364a0 Add dynamo test configuration (#80342)
This test configuration runs PyTorch's test suite under torchdynamo.
Once stabilized, we will make this default and remove this particular
CI job.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Pull Request resolved: https://github.com/pytorch/pytorch/pull/80342
Approved by: https://github.com/anijain2305
2022-06-27 18:31:03 +00:00
Yi Zhang
c2e9f7a8eb update sccache_bucket in binary build (#80014)
Fixes #76838

Changed `SCCACHE_BUCKET,` we could see Cache hits changes in [Windows binary wheel build](https://github.com/pytorch/pytorch/runs/6999041728?check_suite_focus=true)
```
2022-06-22T06:33:53.3118307Z Compile requests                   5750
2022-06-22T06:33:53.3125700Z Compile requests executed          5738
2022-06-22T06:33:53.3125926Z Cache hits                         5691
2022-06-22T06:33:53.3126134Z Cache hits (C/C++)                 5691
2022-06-22T06:33:53.3126321Z Cache misses                         37
```

It's an old [Windows binary wheel build](https://github.com/pytorch/pytorch/runs/6921337789?check_suite_focus=true) . We could find there was very few Cache hits.

I don't know the difference between `ossci-compiler-cache-windows` and `ossci-compiler-cache`
But it's inconsistent with yml files.
(https://github.com/pytorch/pytorch/search?q=ossci-compiler-cache)
bc82a5f79c/.github/workflows/_win-build.yml (L69)

Pull Request resolved: https://github.com/pytorch/pytorch/pull/80014
Approved by: https://github.com/seemethere
2022-06-22 23:20:23 +00:00
Sergii Dymchenko
581e846d9d Migrate pull off linux-xenial-py3_7-clang7-onnx (#79489)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/79489
Approved by: https://github.com/malfet
2022-06-22 19:17:38 +00:00
Nirav Mehta
163fc0e752 Create a new Ubunutu 22.04 (jammy) build for platform010 (take 2) (#79945)
###  Motivation

In order to match the internal platform010 builds, we are creating a new config to run on PRs that uses compiler and package versions >= used in platform010. Here are the versions used in the new build

- Ubuntu 22.04 (Jammy-Jellyfish)
- Clang-12
- Python 3.8
- CUDA 11.6

### Summary of Changes

- As `nvidia/docker` images only support Cuda 11.7 with Ubuntu 22.04, we are starting with base Ubuntu 22.04 docker images, and then installing Cuda 11.6

- Fetching `install_cuda.sh` from `pytorch/builder` repo in order to install Cuda using `wget`

- `libssl-dev` has been upgraded to libssl3 in Ubuntu 22.04. Instead, we are using `include` and `lib` folders downloaded with `Openssl1.1.1`

- `Clang-12` requires `libomp-12-dev` to work with `OpenMP` which is added to the `install_base.sh` file.

- Minor fixes to handle compilation errors generated when using `clang-12`.
      - In `pow_test.cpp` adding a `static_cast` to input of `sqrt` method
      - In `vec512_qint.h`, explicitly defining `copy-assignment` operator as its implicit definition is deprecated due to
         user-declared `copy-constructor` in C++11
Pull Request resolved: https://github.com/pytorch/pytorch/pull/79945
Approved by: https://github.com/seemethere, https://github.com/kit1980
2022-06-21 21:45:03 +00:00
PyTorch MergeBot
dee43798d7 Revert "Create a new Ubunutu 22.04 (jammy) build for platform010 (#77591)"
This reverts commit 71d82917f4.

Reverted https://github.com/pytorch/pytorch/pull/77591 on behalf of https://github.com/zengk95 due to this is breaking linux slow test on trunk
2022-06-18 00:10:06 +00:00
Nirav Mehta
71d82917f4 Create a new Ubunutu 22.04 (jammy) build for platform010 (#77591)
###  Motivation

In order to match the internal platform010 builds, we are creating a new config to run on PRs that uses compiler and package versions >= used in platform010. Here are the versions used in the new build

- Ubuntu 22.04 (Jammy-Jellyfish)
- Clang-12
- Python 3.8
- CUDA 11.6

### Summary of Changes

- As `nvidia/docker` images only support Cuda 11.7 with Ubuntu 22.04, we are starting with base Ubuntu 22.04 docker images, and then installing Cuda 11.6

- Fetching `install_cuda.sh` from `pytorch/builder` repo in order to install Cuda using `wget`

- `libssl-dev` has been upgraded to libssl3 in Ubuntu 22.04. Instead, we are using `include` and `lib` folders downloaded with `Openssl1.1.1`

- `Clang-12` requires `libomp-12-dev` to work with `OpenMP` which is added to the `install_base.sh` file.

- Minor fixes to handle compilation errors generated when using `clang-12`.
      - In `pow_test.cpp` adding a `static_cast` to input of `sqrt` method
      - In `vec512_qint.h`, explicitly defining `copy-assignment` operator as its implicit definition is deprecated due to
         user-declared `copy-constructor` in C++11

Pull Request resolved: https://github.com/pytorch/pytorch/pull/77591
Approved by: https://github.com/seemethere, https://github.com/atalman
2022-06-17 21:02:53 +00:00
atalman
64f3742b2b Use cuda instead of cudatoolkit for cuda 11.6 (#77164)
Remove cudatoolkit dependency and as a resuld remove conda-forge depencency

Please refer to following job for cuda 11.6 workflow:
https://pipelines.actions.githubusercontent.com/serviceHosts/7d146c05-69c3-4c20-a0e7-818111670117/_apis/pipelines/1/runs/1996311/signedlogcontent/624?urlExpires=2022-05-11T15%3A20%3A49.2066302Z&urlSigningMethod=HMACV1&urlSignature=%2FxavsXyw5%2F0DCx%2FTGXrsP2kIM15TUELebxUOxRnE7%2B8%3D

Test PR: https://github.com/pytorch/pytorch/pull/79706
Pull Request resolved: https://github.com/pytorch/pytorch/pull/77164
Approved by: https://github.com/malfet
2022-06-17 15:33:21 +00:00
Sergii Dymchenko
4824222472 Migrate pull off linux-xenial-py3_7-clang7-asan (#79087)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/79087
Approved by: https://github.com/seemethere, https://github.com/malfet
2022-06-14 02:38:21 +00:00
Michael Suo
4b5647f068 [deploy] move deps installation to docker image
Pull Request resolved: https://github.com/pytorch/pytorch/pull/79386

Approved by: https://github.com/janeyx99
2022-06-13 17:18:45 +00:00
Michael Suo
c978b609f7 [ci] remove IN_CI env var
The conventional env var to set is CI. Both circle and GHA set it, so
IN_CI is unnecessary

Pull Request resolved: https://github.com/pytorch/pytorch/pull/79229

Approved by: https://github.com/janeyx99
2022-06-11 17:16:30 +00:00
Jane Xu
cde0cefa1c [CI] Remove broken upload binary size step (#79282)
Looking at our logs, I noticed that this step has been failing for I don't know how long. If it's gone unnoticed and no one has really cared to look at these stats, we should just stop reporting.

Failing regular build size upload: https://github.com/pytorch/pytorch/runs/6833171493?check_suite_focus=true
Failing android build size upload: https://github.com/pytorch/pytorch/runs/6832343869?check_suite_focus=true
Pull Request resolved: https://github.com/pytorch/pytorch/pull/79282
Approved by: https://github.com/suo, https://github.com/malfet
2022-06-10 16:00:26 +00:00
Michael Suo
0117fb7600 [ci] remove IS_GHA env var
This is unnecessary, GitHub automatically populates a `GITHUB_ACTION`
env var:
https://docs.github.com/en/actions/learn-github-actions/environment-variables#default-environment-variables

For docker, this env var is automatically propagated through our use of `--env-file`.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/79219

Approved by: https://github.com/seemethere
2022-06-10 15:29:20 +00:00
PyTorch MergeBot
338bfe6315 Revert "[ci] remove IS_GHA env var"
This reverts commit 1a2d95c68a.

Reverted https://github.com/pytorch/pytorch/pull/79219 on behalf of https://github.com/malfet due to Broke binary jobs see 1a2d95c68a
2022-06-10 00:05:40 +00:00
Michael Suo
1a2d95c68a [ci] remove IS_GHA env var
This is unnecessary, GitHub automatically populates a `GITHUB_ACTION`
env var:
https://docs.github.com/en/actions/learn-github-actions/environment-variables#default-environment-variables

For docker, this env var is automatically propagated through our use of `--env-file`.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/79219

Approved by: https://github.com/kit1980, https://github.com/malfet, https://github.com/seemethere
2022-06-09 23:32:25 +00:00
Edward Z. Yang
e0d78950f0 Upgrade mypy to 0.960
Signed-off-by: Edward Z. Yang <ezyangfb.com>

Pull Request resolved: https://github.com/pytorch/pytorch/pull/78804

Approved by: https://github.com/janeyx99
2022-06-03 20:24:37 +00:00
Sergii Dymchenko
9229749f62 Cleanup unused CircleCI binary jobs (#78596)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/78596
Approved by: https://github.com/seemethere
2022-06-01 05:47:01 +00:00
Sergii Dymchenko
f733fa0b13 Remove gcc5.4 from docker/build.sh (#78405)
This is no longer used by the workflows.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/78405
Approved by: https://github.com/malfet
2022-05-31 22:00:57 +00:00
Sergii Dymchenko
7f12b0c5b2 Remove gcc5.4 jobs from CircleCI config (#78555)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/78555
Approved by: https://github.com/malfet
2022-05-31 21:58:39 +00:00
Eli Uriegas
12f911d5e2 ci: Re-build when docker images aren't available
Adds a failsafe for when docker images aren't available at your base at
the expense of TTS. Also adds the ability to set force_push and note
about what to do when TTS gets out of hand because docker images are
always re-building.

Signed-off-by: Eli Uriegas <eliuriegasfb.com>

Pull Request resolved: https://github.com/pytorch/pytorch/pull/78186

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Approved by: https://github.com/janeyx99
2022-05-31 19:41:31 +00:00
Nikita Shulga
6b4ffa14df [Docker] Pin protobuf to 3.20.1 (#78369)
To protect CI from sudden version updates, that are not compatible with other packages

Fixes https://github.com/pytorch/pytorch/issues/78362

Pull Request resolved: https://github.com/pytorch/pytorch/pull/78369
Approved by: https://github.com/suo, https://github.com/atalman
2022-05-26 19:05:59 +00:00
Sergii Dymchenko
59d29bfd52 Remove code for circleci from binary_populate_env.sh (#78321)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/78321
Approved by: https://github.com/malfet
2022-05-26 06:26:35 +00:00
swang392
2ac09cc6ce changed install_katex.sh to install_docs_reqs.sh, added install doxygen (#77907)
Fixes #77399

Increase CI stability by migrating a dependency to Docker to minimize risk of failure in installation. Installing doxygen in install_docs_reqs.sh instead of the cpp docs script.

**Test Plan**: cpp docs build passes
Pull Request resolved: https://github.com/pytorch/pytorch/pull/77907
Approved by: https://github.com/seemethere, https://github.com/janeyx99
2022-05-24 14:05:21 +00:00
Eli Uriegas
a645abd5aa Update nightlies from 1.12 -> 1.13
Signed-off-by: Eli Uriegas <eliuriegasfb.com>

Pull Request resolved: https://github.com/pytorch/pytorch/pull/77984

Approved by: https://github.com/atalman
2022-05-20 17:59:17 +00:00
Nikita Shulga
5e0589ca20 [CI] Do not use conda-forge for Python-3.9 configs (#77873)
All dependencies has long been available in conda
Pull Request resolved: https://github.com/pytorch/pytorch/pull/77873
Approved by: https://github.com/seemethere, https://github.com/atalman
2022-05-19 20:25:52 +00:00
Sergii Dymchenko
007cc731ce Move pull linux-docs job to Ubuntu 20.04 (#77700)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/77700
Approved by: https://github.com/janeyx99
2022-05-19 16:42:44 +00:00
Peter Bell
5cdf79fddc Bump minimum CMake version to 3.13
Pull Request resolved: https://github.com/pytorch/pytorch/pull/76312

Approved by: https://github.com/malfet
2022-05-19 15:38:55 +00:00
Nikita Shulga
6aea0b1073 [CI] Make install_user.sh compatible with Focal (#77622)
By adding explicit `/etc/shadow` entry

Also, add test that it works, by running `sudo -v` as user `jenkins`

Pull Request resolved: https://github.com/pytorch/pytorch/pull/77622
Approved by: https://github.com/kit1980
2022-05-17 03:03:56 +00:00
Nikita Shulga
4596ecb4d2 [BE] Move numba pinned version to requirements-ci.txt
Specify different pinned versions for older vs newer python runtime

Pull Request resolved: https://github.com/pytorch/pytorch/pull/77476

Approved by: https://github.com/mehtanirav
2022-05-17 00:30:32 +00:00
Nikita Shulga
1db1337473 [BE][CI] Add pip_install macro
Replaces repeated `as_jenkins pip install --progress-bar off` with call
to `pip_install` macro

Pull Request resolved: https://github.com/pytorch/pytorch/pull/77475

Approved by: https://github.com/kit1980, https://github.com/seemethere
2022-05-16 17:05:48 +00:00
atalman
8a6856ae3a Fix docker builds, cleanup cuda 115 (#77086)
Fix docker builds and cleanup cuda 115
This PR should resolve most of the issues with pytorch postnightly branch: https://hud.pytorch.org/hud/pytorch/pytorch/postnightly

Pull Request resolved: https://github.com/pytorch/pytorch/pull/77086
Approved by: https://github.com/seemethere
2022-05-09 23:49:52 +00:00
Eli Uriegas
d21154b098 [be] ci: Remove unused promote workflow
This workflow was originally created to prmoote binaries but never
actually ended up being used since we kept the promotion process manual
to reduce the security risks.

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Fixes #ISSUE_NUMBER

Pull Request resolved: https://github.com/pytorch/pytorch/pull/76908
Approved by: https://github.com/janeyx99, https://github.com/mehtanirav
2022-05-06 17:19:55 +00:00
anjali411
b204ad863f Revert "Revert "Allow specifying tags for aten operators in native_functions.yaml""
This reverts commit ea44645c9a.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/76456

Approved by: https://github.com/osalpekar
2022-04-28 02:04:57 +00:00
Pruthvi Madugundu
e549e97484 Upgrade CI to ROCm 5.1
Pull Request resolved: https://github.com/pytorch/pytorch/pull/76365
Approved by: https://github.com/seemethere, https://github.com/jeffdaily
2022-04-28 00:02:07 +00:00
Kulin Seth
54c75e1e8f Add "mps" device to PyTorch framework.
Remove the "mlc" device for Mac platforms.

This commit will be followed up with:

* adding MPS runtime components
* PyTorch ops for MPS device

Fixes #ISSUE_NUMBER

Pull Request resolved: https://github.com/pytorch/pytorch/pull/76291
Approved by: https://github.com/albanD
2022-04-27 19:21:57 +00:00
Edward Yang
36420b5e8c Rename tools/codegen to torchgen (#76275)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/76275

In preparation for addressing
https://github.com/pytorch/pytorch/issues/73212

Diff was generated with:

```
git mv tools/codegen torchgen
git grep -l 'tools.codegen' | xargs sed -i 's/tools.codegen/torchgen/g'
sed -i "s/\${TOOLS_PATH}\/codegen/\${TORCH_ROOT}\/torchgen/g" caffe2/CMakeLists.txt
```

and a manual edits to:

* tools/test/test_gen_backend_stubs.py
* torchgen/build.bzl
* torchgen/gen_backend_stubs.py

aka this diff:

```
 diff --git a/tools/test/test_gen_backend_stubs.py b/tools/test/test_gen_backend_stubs.py
index 3dc26c6d2d..104054575e 100644
 --- a/tools/test/test_gen_backend_stubs.py
+++ b/tools/test/test_gen_backend_stubs.py
@@ -9,7 +9,7 @@ from torchgen.gen_backend_stubs import run
 from torchgen.gen import _GLOBAL_PARSE_NATIVE_YAML_CACHE  # noqa: F401

 path = os.path.dirname(os.path.realpath(__file__))
-gen_backend_stubs_path = os.path.join(path, '../torchgen/gen_backend_stubs.py')
+gen_backend_stubs_path = os.path.join(path, '../../torchgen/gen_backend_stubs.py')

 # gen_backend_stubs.py is an integration point that is called directly by external backends.
 # The tests here are to confirm that badly formed inputs result in reasonable error messages.
 diff --git a/torchgen/build.bzl b/torchgen/build.bzl
index ed04e35a43..d00078a3cf 100644
 --- a/torchgen/build.bzl
+++ b/torchgen/build.bzl
@@ -1,6 +1,6 @@
 def define_targets(rules):
     rules.py_library(
-        name = "codegen",
+        name = "torchgen",
         srcs = rules.glob(["**/*.py"]),
         deps = [
             rules.requirement("PyYAML"),
@@ -11,6 +11,6 @@ def define_targets(rules):

     rules.py_binary(
         name = "gen",
-        srcs = [":codegen"],
+        srcs = [":torchgen"],
         visibility = ["//visibility:public"],
     )
 diff --git a/torchgen/gen_backend_stubs.py b/torchgen/gen_backend_stubs.py
index c1a672a655..beee7a15e0 100644
 --- a/torchgen/gen_backend_stubs.py
+++ b/torchgen/gen_backend_stubs.py
@@ -474,7 +474,7 @@ def run(
 ) -> None:

     # Assumes that this file lives at PYTORCH_ROOT/torchgen/gen_backend_stubs.py
-    pytorch_root = pathlib.Path(__file__).parent.parent.parent.absolute()
+    pytorch_root = pathlib.Path(__file__).parent.parent.absolute()
     template_dir = os.path.join(pytorch_root, "aten/src/ATen/templates")

     def make_file_manager(install_dir: str) -> FileManager:
```

run_all_fbandroid_tests

Test Plan: sandcastle

Reviewed By: albanD, ngimel

Differential Revision: D35770317

fbshipit-source-id: 153ac4a7fef15b1e750812a90bfafdbc8f1ebcdf
(cherry picked from commit c6d485d1d4648fa1c8a4c14c5bf3d8e899b9b4dd)
2022-04-25 01:38:06 +00:00
Edward Z. Yang
ee955b8bb9 Cannibalize noarch CI job into crossref CI job
crossref is a new strategy for performing tests when you want
to run a normal PyTorch API call, separately run some variation of
the API call (e.g., same thing but all the arguments are meta tensors)
and then cross-reference the results to see that they are consistent.
Any logic you add to CrossRefMode will get run on *every* PyTorch API
call that is called in the course of PyTorch's test suite.  This can
be a good choice for correctness testing if OpInfo testing is not
exhaustive enough.

For now, the crossref test doesn't do anything except verify that
we can validly push a mode onto the torch function mode stack for all
functions.

Signed-off-by: Edward Z. Yang <ezyangfb.com>

Pull Request resolved: https://github.com/pytorch/pytorch/pull/75988

Approved by: https://github.com/seemethere
2022-04-20 11:56:25 +00:00
Alban Desmaison
bd7e99cbb9 Fix doc build
Regression introduced in https://github.com/pytorch/pytorch/pull/73224
The caller for this script has never been updated to pass in main: 2ecc59086a/.github/workflows/_docs.yml (L81-L85)

So this change made it so that all PR doc is built as-if it was a release (for example https://github.com/pytorch/pytorch/runs/6031182009?check_suite_focus=true) and so the coverage test for the doc didn't run for a month :(
Pull Request resolved: https://github.com/pytorch/pytorch/pull/75997
Approved by: https://github.com/musebc, https://github.com/seemethere
2022-04-19 04:07:47 +00:00
Nikita Shulga
80ea6955af Add cuda-11.3+clang9 build workflow (take 2)
To be able to detect unused captures in GPU code lambdas (as gcc does not support this diagnostic)

Remove unused opts lambda capture in `ProcessGroupMPI.cpp` and `Distributions.cu`

Fix sign-compare in nvfuser benchmark and ignore signed unsigned comparison in nvfuser tests
Fixes https://github.com/pytorch/pytorch/issues/75475 by aliasing CMAKE_CUDA_HOST_COMPILER to C_COMPILER when clang is used
Pull Request resolved: https://github.com/pytorch/pytorch/pull/75293
Approved by: https://github.com/atalman, https://github.com/seemethere
2022-04-11 17:13:01 +00:00
PyTorch MergeBot
8fe43d76d5 Revert "Add cuda-11.3+clang9 build workflow"
This reverts commit 709fcc862e.

Reverted https://github.com/pytorch/pytorch/pull/75293 on behalf of https://github.com/janeyx99
2022-04-11 15:24:59 +00:00
Nikita Shulga
709fcc862e Add cuda-11.3+clang9 build workflow
To be able to detect unused captures in GPU code lambdas (as gcc does not support this diagnostic)

Remove unused opts lambda capture in `ProcessGroupMPI.cpp` and `Distributions.cu`

Fix sign-compare in nvfuser benchmark and ignore signed unsigned comparison in nvfuser tests
Fixes https://github.com/pytorch/pytorch/issues/75475 by aliasing CMAKE_CUDA_HOST_COMPILER to C_COMPILER when clang is used
Pull Request resolved: https://github.com/pytorch/pytorch/pull/75293
Approved by: https://github.com/atalman, https://github.com/seemethere
2022-04-11 14:10:57 +00:00
Andrey Talman
e7f4f5dd9b CUDA 11.6 workflows (#75518)
Summary:
Adding CUDA 11.6 workflows .
Please note we still depend on conda-forge for cuda 11.6.
Issue created to remove conda-forge dependency: [75532](https://github.com/pytorch/pytorch/issues/75532)

Pull Request resolved: https://github.com/pytorch/pytorch/pull/75518

Reviewed By: janeyx99

Differential Revision: D35516057

Pulled By: atalman

fbshipit-source-id: 44a3a0f8954d98adca2280b2e9f203267ebe98cd
(cherry picked from commit 97a4e52ecee8540453e2871714275796dc1c4abb)
2022-04-11 14:05:41 +00:00
Andrey Talman
622cff3e95 Cuda 11.6 Disable failing tests (#75420)
Summary:
This mitigates number of issues with CUDA 11.6 update and updates Linux driver .

New issues discovered
#[75391](https://github.com/pytorch/pytorch/issues/75391)
#[75375](https://github.com/pytorch/pytorch/issues/75375)

Old issue present since 11.3
#[57482](https://github.com/pytorch/pytorch/issues/57482)
#[70111](https://github.com/pytorch/pytorch/issues/70111)

These changes already testsed WIP PR:
#[75337](https://github.com/pytorch/pytorch/pull/75337)

Pull Request resolved: https://github.com/pytorch/pytorch/pull/75420

Reviewed By: seemethere

Differential Revision: D35481973

Pulled By: atalman

fbshipit-source-id: 4db00c646e2df4f8650404763963c3b215110f1f
(cherry picked from commit 518e19dc361b43273f5bd6bdfff942614e8466f5)
2022-04-07 22:43:15 +00:00
pbialecki
14baca38c5 [WIP] enable cu116 builds
Enable and test CUDA11.6 builds

Pull Request resolved: https://github.com/pytorch/pytorch/pull/75092
Approved by: https://github.com/atalman
2022-04-06 17:23:09 +00:00
Nikita Shulga
623f939704 [GHA] Do not chown for linux CI
Set `jenkins` userid in container to be identical to `ec2-user` id (i.e.
1000)

This should eliminate unnecessary chowns back and forth

Fixes https://github.com/pytorch/pytorch/issues/64856
Pull Request resolved: https://github.com/pytorch/pytorch/pull/75114
Approved by: https://github.com/janeyx99
2022-04-01 22:34:25 +00:00
mikey dagitses
60729d02f1 remove unused nn_path from generate_code (#74563)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/74563

This is used inconsistently in all the generate_code program
invocations. Nevertheless, nothing consumes this flag, so we can
safely remove it.

This was removed in #25353.
ghstack-source-id: 152249818

Test Plan: Should be a no-op, rely on CI.

Reviewed By: malfet

Differential Revision: D35053096

fbshipit-source-id: 3ad19e83ca14649b514dc163c3caff6cbd118e14
(cherry picked from commit a43f05bb43553249caac3c3479986cbc45d286ae)
2022-03-31 18:35:30 +00:00
Jithun Nair
dfe6e88adc Upgrade CI to ROCm5.0
cc @jaglinux @pruthvistony @arindamroy-eng @kyleczh

Depends on https://github.com/pytorch/pytorch/pull/73906

Fixes https://github.com/pytorch/pytorch/issues/65884 as well
Pull Request resolved: https://github.com/pytorch/pytorch/pull/73105
Approved by: https://github.com/osalpekar, https://github.com/malfet
2022-03-30 02:58:23 +00:00
PyTorch MergeBot
ea44645c9a Revert "Allow specifying tags for aten operators in native_functions.yaml"
This reverts commit 1dab71ab25.

Reverted https://github.com/pytorch/pytorch/pull/72549 on behalf of https://github.com/malfet
2022-03-28 18:04:38 +00:00
anjali411
1dab71ab25 Allow specifying tags for aten operators in native_functions.yaml
Pull Request resolved: https://github.com/pytorch/pytorch/pull/72549

Approved by: https://github.com/ezyang
2022-03-25 21:17:52 +00:00
atalman
ca96d1d447 Use nvidia cuda image without cudnn for cudnn 8 and up
Use nvidia cuda image without cudnn for cudnn 8 and up.
We want to decouple the CUDA and cudnn versions so that we can evolve these version separately.
We want to use cudnn 8.3.2 for following CUDA versions 11.3, 11.5 and 11.6.
We are using Official Nvidia Cuda ubuntu image. And installing cudnn 8.3.2 on top of it.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/74545
Approved by: https://github.com/malfet
2022-03-25 12:18:42 +00:00
kstant0725
ff58899b5e Pull request to run CI for #72556 (#73404)
Summary:
This PR moves the Dockerfile conda dependencies into a requirements-ci.txt (and begins the requirements file for other parts of CI as well).  Packages are listed alphabetically in the requirements-ci.txt.  Uncommented packages before the mkl package have been tested and confirmed to work on all platforms.  Commented out packages before mkl have broken at least one platform and so have been comment out.  There appears to be some randomness with certain platforms not passing tests so it might be good to run a number of tests for the same configuration to confirm if it is indeed these commented out packages that cause the errors.

Remaining is to test all commented out packages to ensure they work on all platforms.  This will likely involve repeat runs of the same configurations to ensure it is indeed the packages that break the platforms and not random errors.

This PR makes progress on task https://github.com/pytorch/pytorch/issues/72556

Pull Request resolved: https://github.com/pytorch/pytorch/pull/73404

Reviewed By: janeyx99

Differential Revision: D34730797

Pulled By: kstant0725

fbshipit-source-id: 3e4b171720fa33b604cebb9c6101d38ba11f2f8b
(cherry picked from commit 99cc445aadb95f92f6ef040f2d4b7c6c6d5b7f8b)
2022-03-24 18:04:08 +00:00
Nikita Shulga
6fceada3f3 Adjust binary_linux_test.sh to support reruns
When GitHub workflow is re-run, multiple build artifacts can be available after re-run to  test (for example, see [this](https://github.com/pytorch/pytorch/runs/5614756780?check_suite_focus=true#step:15:622) workflow for example)
Pick the latest one

Pull Request resolved: https://github.com/pytorch/pytorch/pull/74511
Approved by: https://github.com/suo
2022-03-22 13:21:26 +00:00
Pruthvi Madugundu
8a9d481bc6 [ROCm] Update the magma commit
- This move later magma commit, fixes many memory leaks which
  were found while running linalg UT on ROCm 5.0 release.

Please review
@jeffdaily @seemethere @jithunnair-amd
Pull Request resolved: https://github.com/pytorch/pytorch/pull/74493
Approved by: https://github.com/seemethere
2022-03-21 22:23:01 +00:00
PyTorch MergeBot
ba280b59c8 Revert "[ROCm] Update the magma commit"
This reverts commit 9425eba784.

Reverted https://github.com/pytorch/pytorch/pull/73906 on behalf of https://github.com/seemethere
2022-03-21 20:12:22 +00:00
Pruthvi Madugundu
9425eba784 [ROCm] Update the magma commit
- This move later magma commit, fixes many memory leaks which
  were found while running linalg UT on ROCm 5.0 release. These memory issues were exposed by the PR https://github.com/pytorch/pytorch/pull/66933

cc @jeffdaily @jithunnair-amd
Pull Request resolved: https://github.com/pytorch/pytorch/pull/73906
Approved by: https://github.com/jithunnair-amd, https://github.com/seemethere, https://github.com/malfet, https://github.com/osalpekar
2022-03-21 19:26:39 +00:00
Maksim Dmitriyevich Podkorytov
e8023c94aa Pin unittest-xml-reporting to freeze printing test summary logic
In PR https://github.com/pytorch/pytorch/pull/74254 I mitigate issue https://github.com/pytorch/pytorch/issues/69014 by changing internals of unittest-xml-runner package, so that skip reason is printed in the summary. The package version is pinned to avoid breaking if unittest-xml-runner implementation details change. unittest-xml-runner==2.0.0 introduces testinfo property that is necessary so it should be the earliest version that works. unittest-xml-runner==3.2.0 is the current latest version

Please merge before https://github.com/pytorch/pytorch/pull/74254
Pull Request resolved: https://github.com/pytorch/pytorch/pull/74330
Approved by: https://github.com/janeyx99
2022-03-17 22:23:55 +00:00
Nikita Shulga
80e0d8a8fb Move AndroidNightly to GHA
And revert "[CircleCI] Re-enable nightly android builds"

Pull Request resolved: https://github.com/pytorch/pytorch/pull/74243
Approved by: https://github.com/seemethere
2022-03-17 14:32:39 +00:00
Brian Muse
4646caede9 Update circleci pipelines to support both master and main branches.
Fixes #71806

Pull Request resolved: https://github.com/pytorch/pytorch/pull/73224
Approved by: https://github.com/janeyx99, https://github.com/seemethere, https://github.com/malfet
2022-03-15 18:43:49 +00:00
Nikita Shulga
41b86f4099 [CircleCI] Delete MacOS binary smoke tests
As they never fail and not much different than regular builds

Fixes #ISSUE_NUMBER

Pull Request resolved: https://github.com/pytorch/pytorch/pull/73949
Approved by: https://github.com/seemethere
2022-03-08 22:41:16 +00:00
Eli Uriegas
11231b0f93 ci: Migrate windows conda to GHA
Signed-off-by: Eli Uriegas <eliuriegasfb.com>

Pull Request resolved: https://github.com/pytorch/pytorch/pull/73262

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Approved by: https://github.com/malfet, https://github.com/atalman
2022-03-08 19:55:37 +00:00
PyTorch MergeBot
be4bcf8fdf Revert "ci: Migrate windows conda to GHA"
This reverts commit 2acf9c74f3.

Reverted https://github.com/pytorch/pytorch/pull/73262 on behalf of https://github.com/malfet
2022-03-08 01:30:37 +00:00
Eli Uriegas
2acf9c74f3 ci: Migrate windows conda to GHA
Signed-off-by: Eli Uriegas <eliuriegasfb.com>

Pull Request resolved: https://github.com/pytorch/pytorch/pull/73262

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Approved by: https://github.com/malfet
2022-03-07 19:39:50 +00:00
Nikita Shulga
9929a9fc8f [GHA] Migrate win/linux binary-smoke workflows from CircleCI
Partially fixes https://github.com/pytorch/pytorch/issues/72956
Pull Request resolved: https://github.com/pytorch/pytorch/pull/73788
Approved by: https://github.com/seemethere
2022-03-07 15:22:23 +00:00
PyTorch MergeBot
ea698c148a Revert "[GHA] Migrate win/linux binary-smoke workflows from CircleCI"
This reverts commit 486bd9f306.

Reverted https://github.com/pytorch/pytorch/pull/73788 on behalf of https://github.com/malfet
2022-03-06 19:07:04 +00:00
Nikita Shulga
486bd9f306 [GHA] Migrate win/linux binary-smoke workflows from CircleCI
Partially fixes https://github.com/pytorch/pytorch/issues/72956
Pull Request resolved: https://github.com/pytorch/pytorch/pull/73788
Approved by: https://github.com/seemethere
2022-03-06 17:08:08 +00:00
Nikita Shulga
bebfdca093 Re-enable Windows debug libtorch
Get rid of `BUILD_FOR_SYSTEM` environment variable
Pass `libtorch_config` environment variable for Windows builds

Fixes https://github.com/pytorch/pytorch/issues/73068

Pull Request resolved: https://github.com/pytorch/pytorch/pull/73805
Approved by: https://github.com/seemethere
2022-03-04 23:49:07 +00:00
Andrey Talman
197764b35d Remove cuda 11.1 references (#73514)
Summary:
Fixes : https://github.com/pytorch/pytorch/issues/73377

We've migrated to CUDA-11.3 as default toolkit in 1.9, it's time to stop builds (especially considering forward-compatibility guarantee across CUDA-11.x drivers)

Hence we are removing CUDA 11.1 support. We should also cleanup old cuda related code from our builder and pytorch repo making scripts a little more clean.

We have code that references cuda 9.2 , 10.1 , 11.0, 11.1, 11.2 and none of these are currently use

Pull Request resolved: https://github.com/pytorch/pytorch/pull/73514

Reviewed By: janeyx99

Differential Revision: D34551989

Pulled By: atalman

fbshipit-source-id: 9ceaaa9b25ad49689986f4b29a26d20370d9d011
(cherry picked from commit fe109c62daf429e9053c03f6e374568ba23cd041)
2022-03-01 16:37:37 +00:00
Digant Desai
b2054d3025 Prepare for an update to the XNNPACK submodule (#72642)
Summary:
- Target Sha1: ae108ef49aa5623b896fc93d4298c49d1750d9ba
- Make USE_XNNPACK a dependent option on cmake minimum version 3.12
- Print USE_XNNPACK under cmake options summary, and print the
  availability from collet_env.py
- Skip XNNPACK based tests when XNNPACK is not available
    - Add SkipIfNoXNNPACK wrapper to skip tests
- Update cmake version for xenial-py3.7-gcc5.4 image to 3.12.4
    - This is required for the backwards compatibility test.
      The PyTorch op schema is XNNPACK dependent. See,
      aten/src/ATen/native/xnnpack/RegisterOpContextClass.cpp for
      example. The nightly version is assumed to have USE_XNNPACK=ON,
      so with this change we ensure that the test build can also
      have XNNPACK.
- HACK: skipping test_xnnpack_integration tests on ROCM

Pull Request resolved: https://github.com/pytorch/pytorch/pull/72642

Reviewed By: kimishpatel

Differential Revision: D34456794

Pulled By: digantdesai

fbshipit-source-id: 85dbfe0211de7846d8a84321b14fdb061cd6c037
(cherry picked from commit 6cf48e7b64d6979962d701b5d493998262cc8bfa)
2022-02-25 00:39:15 +00:00
Eli Uriegas
67cb0f2a03 ci: Remove CUDA 11.1 binary builds
These builds weren't advertised on our websites and we've confirmed that
CUDA 11.3 binaries are forwards compatible with CUDA 11.1 drivers.

Signed-off-by: Eli Uriegas <eliuriegasfb.com>

Pull Request resolved: https://github.com/pytorch/pytorch/pull/73376
2022-02-24 20:34:47 +00:00
Yi Zhang
3f7c17a2b9 set SCCACHE_IGNORE_SERVER_IO_ERROR=1
https://github.com/mozilla/sccache/pull/1090 has been accepted by Mozilla.
It will take effect after updating the sccache binaries in S3

Note: last sccache.exe is sccache-20200507.exe
![image](https://user-images.githubusercontent.com/16190118/154428837-d3a092e1-21aa-436d-97e0-541fd7110165.png)

Pull Request resolved: https://github.com/pytorch/pytorch/pull/72795
2022-02-24 18:27:34 +00:00
Peter Bell
facd6f0bea Unpin librosa and update SciPy pin (#72834)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/72834

This removes the upper bound to librosa's pin and updates the scipy
pin since librosa 0.9 requires SciPy 1.2 or newer.

Test Plan: Imported from OSS

Reviewed By: ngimel

Differential Revision: D34386898

Pulled By: mruberry

fbshipit-source-id: db654bd337b474cd5a2ff8dbb9a659ed272728cf
(cherry picked from commit 4790e8180c)
2022-02-23 02:31:42 +00:00
Nikita Shulga
99427654aa Use "large" macos for binary builds
Hopefully it will fix the timeout

Pull Request resolved: https://github.com/pytorch/pytorch/pull/73089
2022-02-18 17:54:47 +00:00
Yeounoh Chung
443a337e14 Create a CI workflow for XLA tests using the XLA test image (#72496)
Summary:
This PR resolves https://github.com/pytorch/pytorch/issues/72693

Pull Request resolved: https://github.com/pytorch/pytorch/pull/72496

Reviewed By: H-Huang

Differential Revision: D34255441

Pulled By: seemethere

fbshipit-source-id: fdfd54fbd59ef7266a78c9f729c1d5b6ed25e9d6
(cherry picked from commit ba14f0ee6c)
2022-02-16 18:03:43 +00:00
Nikita Shulga
3493646f76 [CircleCI] Re-enable nightly android builds
A stop-gap measure to re-enable publishing of Android maven packages by
CI, see https://github.com/pytorch/pytorch/issues/72902

Pull Request resolved: https://github.com/pytorch/pytorch/pull/72903
2022-02-16 17:38:17 +00:00
Eli Uriegas
c963dedcd3 ci: Migrate macOS x86_64 binary builds to GHA (#71888)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/71888

Migrates binary builds for x86_64 for macOS from CircleCI to GHA.

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Test Plan: Imported from OSS

Reviewed By: janeyx99

Differential Revision: D34150398

Pulled By: seemethere

fbshipit-source-id: 1b439c397d3732418c0958aa1ec6d277ab878e99
(cherry picked from commit f5b1f66f6d)
2022-02-10 21:12:24 +00:00
wushirong
4d01789f69 Remove fx2trt from oss CI (#72595)
Summary:
Remove fx2trt test from oss CI

Pull Request resolved: https://github.com/pytorch/pytorch/pull/72595

Test Plan: CI

Reviewed By: houseroad

Differential Revision: D34112595

Pulled By: wushirong

fbshipit-source-id: 02376ef0f25381eff31b72dcbf964c1966af9793
(cherry picked from commit e3d698a942)
2022-02-10 18:49:31 +00:00
Nikita Shulga
b6df02bbbb Fix tagged build detection for binary builds (#72628)
Summary:
Should fix the following [error](https://github.com/pytorch/pytorch/runs/5058514346#step:13:88):
```
+ git --git-dir /pytorch/pytorch/.git describe --tags --match 'v[0-9]*.[0-9]*.[0-9]*' --exact
fatal: not a git repository: '/pytorch/pytorch/.git'
```
By setting `workdir` correctly for GHA linux and Windows builds

Also, abort `tagged_version` if GIT_DIR does not exist (as this script should only be executed in context of git folder.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/72628

Reviewed By: atalman

Differential Revision: D34120721

Pulled By: malfet

fbshipit-source-id: 035e93e243e601f9c24659cd247f9c029210fba5
(cherry picked from commit 3a6c97b6dd)
2022-02-10 04:41:18 +00:00
Nikita Shulga
3b1ef1fde8
[CircleCI] Deprecate gpu.medium class (#72613)
s/gpu.medium/gpu.nvidia.small/
2022-02-09 12:42:34 -08:00
Brian Muse
8bf3179f6e #71946 Remove Python 3.6 references (#72211)
Summary:
Fixes https://github.com/pytorch/pytorch/issues/71946

This commit removes some bits of code that were hard coded for Python 3.6 support from the `.circleci` and `torch` folders. It should only be merged if https://github.com/pytorch/pytorch/issues/66462 is complete.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/72211

Reviewed By: dagitses, seemethere

Differential Revision: D33982604

Pulled By: musebc

fbshipit-source-id: 8f453bf9909df615addd59538adb369c65484044
(cherry picked from commit 944a9970fe)
2022-02-08 03:46:20 +00:00
Jane Xu
a004f13567 Pin librosa
Should mitigate https://github.com/pytorch/pytorch/issues/72432
Pull Request resolved: https://github.com/pytorch/pytorch/pull/72433
2022-02-07 17:01:01 +00:00
Andrey Talman
0ca0e02685 Bump torch version to 1.12 (#72221)
Summary:
Bump torch version to 1.12

Pull Request resolved: https://github.com/pytorch/pytorch/pull/72221

Reviewed By: dagitses, atalman

Differential Revision: D33987446

Pulled By: seemethere

fbshipit-source-id: f5fc1c4954ff116baab9e4afe3955c0e7842e6cf
(cherry picked from commit 78d62aa293)
2022-02-04 00:02:28 +00:00
Jane Xu
2a391284fc Revert D33851316: ci: Migrate macOS x86_64 binary builds to GHA
Test Plan: revert-hammer

Differential Revision:
D33851316 (c2e63b43ce)

Original commit changeset: 3c953f0e4e4b

Original Phabricator Diff: D33851316 (c2e63b43ce)

fbshipit-source-id: d95670332bbe44725b589e6d895f99b6d8821024
(cherry picked from commit 5f1861d777)
2022-02-03 04:08:39 +00:00
Eli Uriegas
c2e63b43ce ci: Migrate macOS x86_64 binary builds to GHA (#71888)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/71888

Migrates binary builds for x86_64 for macOS from CircleCI to GHA.

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Test Plan: Imported from OSS

Reviewed By: malfet

Differential Revision: D33851316

Pulled By: seemethere

fbshipit-source-id: 3c953f0e4e4b434f4e0f95156d50484a5b56d0c7
(cherry picked from commit 15de76a6be)
2022-02-02 23:44:13 +00:00
mattip
e784808bc6 DOC: create 1.12 docs from a tag like v1.12.2rc1 (#71985)
Summary:
brianjo, malfet

The documentation team would prefer the [documentation versions] to only have a major.minor version, not major.minor.patch. See also pytorch/pytorch.github.io#921

The regex can be tested by this bash 1-liner (where $tag is something like `v10.1225.0rc1`)
```
echo $tag | sed -e 's/v*\([0-9]*\.[0-9]*\).*/\1/'
```

I have lost track a bit, is the CI run for a tag actually building and pushing documentation?

Pull Request resolved: https://github.com/pytorch/pytorch/pull/71985

Reviewed By: mrshenli

Differential Revision: D33845882

Pulled By: malfet

fbshipit-source-id: 3cb644d8b01f5ddf87c0ac7c43e23e9fd292d660
(cherry picked from commit f884bd8674)
2022-02-01 01:18:29 +00:00
Jane Xu
d46256bd7c [skip ci] Remove unused outdated .circleci bazel_definitions file (#71943)
Summary:
Small clean-up, realized this file isn't necessary after migrating to GHA, so removing this file

Pull Request resolved: https://github.com/pytorch/pytorch/pull/71943

Test Plan: running .circleci/regenerate.sh yields no config changes

Reviewed By: malfet

Differential Revision: D33901182

Pulled By: janeyx99

fbshipit-source-id: e8ff16395c81be25dae5b84619c6b4bfe749ada2
(cherry picked from commit e564c1ed5e)
2022-01-31 22:49:11 +00:00
Andrey Talman
e58d5b718a Remove code for using our own build cudnn image, use nvidia image (#71952)
Summary:
Remove code for using our own build cudnn image, use nvidia imag

Pull Request resolved: https://github.com/pytorch/pytorch/pull/71952

Reviewed By: mrshenli

Differential Revision: D33845873

Pulled By: atalman

fbshipit-source-id: 59806dedd925a13700ddf090f32c8c4dae10692d
(cherry picked from commit 90e4755658)
2022-01-28 16:48:21 +00:00
Andrey Talman
21d307cd22 CUDNN changes for cuda 11.5 (#71869)
Summary:
CUDNN changes for cuda 11.5

Pull Request resolved: https://github.com/pytorch/pytorch/pull/71869

Reviewed By: janeyx99

Differential Revision: D33817943

Pulled By: atalman

fbshipit-source-id: 5da5f8f45877ac12c0ee4d982082fd24e5f09adb
(cherry picked from commit 3f3d96af69)
2022-01-27 15:33:58 +00:00
Eli Uriegas
5ee629e50d .github: Enable windows binary builds (#71484)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/71484

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Test Plan: Imported from OSS

Reviewed By: malfet, atalman

Differential Revision: D33800904

Pulled By: seemethere

fbshipit-source-id: 56d0a6e34ac8023745e36ae341efec79384d1dde
(cherry picked from commit 0339a882c9)
2022-01-26 22:29:33 +00:00