OSSForks/pytorch
1
0
Fork 0
mirror of https://github.com/zebrajr/pytorch.git synced 2025-12-06 12:20:52 +01:00
Code Issues Actions 38 Packages Projects Releases Wiki Activity

fix possible pandas import error during tensorboard tests (#29650)

Browse Source 
Summary:
TensorBoard tests using SummaryWriter() may fail with a pandas import
complaint if TensorFlow packages are installed in the same python
environment as PyTorch:

Traceback (most recent call last):
  File "test_tensorboard.py", line 212, in test_writer
    with self.createSummaryWriter() as writer:
  File "test_tensorboard.py", line 64, in createSummaryWriter
    return SummaryWriter(temp_dir)
...
  File "[...]/site-packages/pandas/core/arrays/categorical.py", line 52, in <module>
    import pandas.core.algorithms as algorithms
AttributeError: module 'pandas' has no attribute 'core'

The exact failure may depend on the pandas version. We've also seen:

  File "[...]/site-packages/pandas/core/arrays/categorical.py", line 9, in <module>
    import pandas.compat as compat
AttributeError: module 'pandas' has no attribute 'compat'

The module import chain leading to the failure is tensorboard imports
tensorflow imports tensorflow_estimator imports pandas. pandas includes
a submodule named 'bottleneck', whose name collides with the PyTorch
'test/bottleneck/' subdirectory.

So IF tensorboard, tensorflow, tensorflow_estimator, and pandas are
installed in the python environment AND IF testing is run from within
PyTorch's 'test/' directory (or maybe just with 'test/' in PYTHONPATH,
etc.), then TensorBoard tests using SummaryWriter() will fail.

Rename the 'bottleneck/' directory slightly to avoid the name collision.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/29650

Differential Revision: D19698638

Pulled By: ezyang

fbshipit-source-id: cb59342ed407cb37aefc833d67f768a8809129ac
This commit is contained in:
Brian W. Hart 2020-02-04 14:21:17 -08:00 committed by Facebook Github Bot
parent 478356aeec
commit ea968f5cc3
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

0
test/bottleneck/test.py → test/bottleneck_test/test.py
View File

0
test/bottleneck/test_args.py → test/bottleneck_test/test_args.py
View File

0
test/bottleneck/test_cuda.py → test/bottleneck_test/test_cuda.py
View File

8
test/test_utils.py
View File

@ -356,11 +356,11 @@ class TestBottleneck(TestCase):
def _check_run_args(self): def _check_run_args(self):
# Check that this fails due to missing args # Check that this fails due to missing args
rc, out, err = self._run_bottleneck('bottleneck/test_args.py') rc, out, err = self._run_bottleneck('bottleneck_test/test_args.py')
self.assertEqual(rc, 2, None, self._fail_msg('Missing args should error', out + err)) self.assertEqual(rc, 2, None, self._fail_msg('Missing args should error', out + err))
# This should succeed # This should succeed
rc, out, err = self._run_bottleneck('bottleneck/test_args.py', '--foo foo --bar bar') rc, out, err = self._run_bottleneck('bottleneck_test/test_args.py', '--foo foo --bar bar')
self.assertEqual(rc, 0, None, self._fail_msg('Should pass args to script', out + err)) self.assertEqual(rc, 0, None, self._fail_msg('Should pass args to script', out + err))
def _fail_msg(self, msg, output): def _fail_msg(self, msg, output):
@ -404,7 +404,7 @@ class TestBottleneck(TestCase):
@unittest.skipIf(HAS_CUDA, 'CPU-only test') @unittest.skipIf(HAS_CUDA, 'CPU-only test')
def test_bottleneck_cpu_only(self): def test_bottleneck_cpu_only(self):
rc, out, err = self._run_bottleneck('bottleneck/test.py') rc, out, err = self._run_bottleneck('bottleneck_test/test.py')
self.assertEqual(rc, 0, 'Run failed with\n{}'.format(err)) self.assertEqual(rc, 0, 'Run failed with\n{}'.format(err))
self._check_run_args() self._check_run_args()
@ -416,7 +416,7 @@ class TestBottleneck(TestCase):
@unittest.skipIf(not HAS_CUDA, 'No CUDA') @unittest.skipIf(not HAS_CUDA, 'No CUDA')
@skipIfRocm @skipIfRocm
def test_bottleneck_cuda(self): def test_bottleneck_cuda(self):
rc, out, err = self._run_bottleneck('bottleneck/test_cuda.py') rc, out, err = self._run_bottleneck('bottleneck_test/test_cuda.py')
self.assertEqual(rc, 0, 'Run failed with\n{}'.format(err)) self.assertEqual(rc, 0, 'Run failed with\n{}'.format(err))
self._check_run_args() self._check_run_args()