From e6e75ebd0a41dcd9ace2a95f663ae988b5de7c97 Mon Sep 17 00:00:00 2001 From: Huy Do Date: Wed, 4 Dec 2024 23:43:29 +0000 Subject: [PATCH] Silent TD warnings when there is no td_results.json (#142083) Despite the fact that we have `continue-on-error: true` there, GH behaves noisily when `td_results.json` doesn't exist. For example, all benchmark jobs in https://github.com/pytorch/pytorch/actions/runs/12149624686 finished successfully but they all showed up as errors on GH UI. To make this worst, log classifier sometimes pick up the error https://github.com/pytorch/pytorch/actions/runs/12149624686/job/33882285001#step:16:37 Pull Request resolved: https://github.com/pytorch/pytorch/pull/142083 Approved by: https://github.com/clee2000 --- .github/actions/download-td-artifacts/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/download-td-artifacts/action.yml b/.github/actions/download-td-artifacts/action.yml index ebb5c65353a..18766bf670f 100644 --- a/.github/actions/download-td-artifacts/action.yml +++ b/.github/actions/download-td-artifacts/action.yml @@ -26,4 +26,4 @@ runs: shell: bash run: | mkdir -p .additional_ci_files - mv td_results.json .additional_ci_files/td_results.json + mv td_results.json .additional_ci_files/td_results.json || true