OSSForks/pytorch
1
0
Fork 0
mirror of https://github.com/zebrajr/pytorch.git synced 2025-12-06 12:20:52 +01:00
Code Issues Actions 38 Packages Projects Releases Wiki Activity

Upgrade ShellCheck to v0.7.2 (#56445)

Browse Source 
Summary:
[First ShellCheck release in over a year!](https://github.com/koalaman/shellcheck/releases/tag/v0.7.2) I'm thankful for doing https://github.com/pytorch/pytorch/issues/55109 at the beginning of this month, because otherwise `master` would have just suddenly started failing a few hours ago.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/56445

Test Plan:
CI. You can also run `shellcheck` locally; for instance, if you're on Mac and [installed it with Homebrew](https://github.com/koalaman/shellcheck/tree/v0.7.2#installing):
```sh
brew upgrade shellcheck
rm -r .extracted_scripts ; tools/extract_scripts.py --out=.extracted_scripts
tools/run_shellcheck.sh .jenkins/pytorch .extracted_scripts
```

Reviewed By: janeyx99

Differential Revision: D27874084

Pulled By: samestep

fbshipit-source-id: 3bd871a368fe03aecd559e2f55bce36af49cfa27
This commit is contained in:
Sam Estep 2021-04-20 07:56:57 -07:00 committed by Facebook GitHub Bot
parent 3d878dee45
commit c61778355c
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/auto_label.yml vendored
View File

@ -25,7 +25,7 @@ jobs:
ISSUE_NUMBER="${PR_NUMBER}" ISSUE_NUMBER="${PR_NUMBER}"
else else
TITLE="${ISSUE_TITLE}" TITLE="${ISSUE_TITLE}"
ISSUE_NUMBER="${ISSUE_NUMBER}" # ISSUE_NUMBER is already set
fi fi
echo ::set-output name=TITLE::"${TITLE}" echo ::set-output name=TITLE::"${TITLE}"
echo ::set-output name=ISSUE_NUMBER::"${ISSUE_NUMBER}" echo ::set-output name=ISSUE_NUMBER::"${ISSUE_NUMBER}"

4
.github/workflows/lint.yml vendored
View File

@ -34,10 +34,10 @@ jobs:
- name: Extract scripts from GitHub Actions workflows - name: Extract scripts from GitHub Actions workflows
run: tools/extract_scripts.py --out=.extracted_scripts run: tools/extract_scripts.py --out=.extracted_scripts
- name: ShellCheck - name: ShellCheck
# https://github.com/koalaman/shellcheck/tree/v0.7.1#installing-a-pre-compiled-binary # https://github.com/koalaman/shellcheck/tree/v0.7.2#installing-a-pre-compiled-binary
run: | run: |
set -x set -x
scversion="v0.7.1" scversion="v0.7.2"
wget -qO- "https://github.com/koalaman/shellcheck/releases/download/${scversion?}/shellcheck-${scversion?}.linux.x86_64.tar.xz" | tar -xJv wget -qO- "https://github.com/koalaman/shellcheck/releases/download/${scversion?}/shellcheck-${scversion?}.linux.x86_64.tar.xz" | tar -xJv
sudo cp "shellcheck-${scversion}/shellcheck" /usr/bin/ sudo cp "shellcheck-${scversion}/shellcheck" /usr/bin/
rm -r "shellcheck-${scversion}" rm -r "shellcheck-${scversion}"

2
.jenkins/pytorch/macos-common.sh
View File

@ -26,7 +26,7 @@ if [ ! -d "${WORKSPACE_DIR}/miniconda3" ]; then
retry bash "${WORKSPACE_DIR}"/miniconda3.sh -b -p "${WORKSPACE_DIR}"/miniconda3 retry bash "${WORKSPACE_DIR}"/miniconda3.sh -b -p "${WORKSPACE_DIR}"/miniconda3
fi fi
export PATH="${WORKSPACE_DIR}/miniconda3/bin:$PATH" export PATH="${WORKSPACE_DIR}/miniconda3/bin:$PATH"
# shellcheck disable=SC1090 # shellcheck disable=SC1091
source "${WORKSPACE_DIR}"/miniconda3/bin/activate source "${WORKSPACE_DIR}"/miniconda3/bin/activate
retry conda install -y mkl mkl-include numpy=1.18.5 pyyaml=5.3 setuptools=46.0.0 cmake cffi ninja typing_extensions dataclasses pip retry conda install -y mkl mkl-include numpy=1.18.5 pyyaml=5.3 setuptools=46.0.0 cmake cffi ninja typing_extensions dataclasses pip
# The torch.hub tests make requests to GitHub. # The torch.hub tests make requests to GitHub.