Added publishing of test results and minor fixes to Az DevOps Build Logic (#58436)

Summary:
This PR adds the ability to publish the xml test data of custom PyTorch PR tests. This PR also adds a few fixes to the custom PyTorch PR tests logic.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/58436

Reviewed By: seemethere, mruberry

Differential Revision: D28512958

Pulled By: malfet

fbshipit-source-id: d3a1a251d3d126c923d5f733dccfb31a4b701b7e

.azure_pipelines/job_templates/pytorch-template-unix.yml

@@ -48,4 +48,14 @@ jobs:
       _TS_CLONE_P: $(TS_CLONE_PASSWORD)
       _TS_P: $(TS_PAT)
       _TS_SM_P: $(TS_SM_PAT)
+      _AZUREML_CLONE_PASSWORD: $(AZUREML_CLONE_PASSWORD)
+      _SPPASSWORD: $(SPPASSWORD)
     displayName: Run PyTorch Unit Tests
+
+  # Tests results are available outside the docker container since
+  # the current directory is mounted as a volume of the container.
+  - task: PublishTestResults@2
+    condition: always()
+    inputs:
+      testResultsFiles: '**/test-*.xml'
+      testRunTitle: 'Publish test results for Python'

.azure_pipelines/job_templates/pytorch-template-win.yml

@@ -47,3 +47,11 @@ jobs:
       _TS_P: $(TS_PAT)
       _TS_SM_P: $(TS_SM_PAT)
     displayName: Run PyTorch Unit Tests
+
+  # Tests results are available outside the docker container since
+  # the current directory is mounted as a volume of the container.
+  - task: PublishTestResults@2
+    condition: always()
+    inputs:
+      testResultsFiles: '**\test-*.xml'
+      testRunTitle: 'Publish test results for Python'

.azure_pipelines/job_templates/wheel-wait-job-template.yml

@@ -8,7 +8,7 @@ steps:
     connectionType: 'connectedServiceName'
     serviceConnection: circleciconn
     method: 'POST'
-    headers: '{"Content-Type":"application/json", "BranchName":"$(TARGET_BRANCH_TO_CHECK_PR)", "JobName":"$(TARGET_CIRCLECI_PR)", "PlanUrl":"$(System.CollectionUri)", "ProjectId":"$(System.TeamProjectId)", "HubName":"$(System.HostType)", "PlanId":"$(System.PlanId)", "JobId":"$(System.JobId)", "TimelineId":"$(System.TimelineId)", "TaskInstanceId":"$(System.TaskInstanceId)", "AuthToken":"$(System.AccessToken)"}'
+    headers: '{"Content-Type":"application/json", "BranchName":"$(_TARGET_BRANCH_TO_CHECK)", "JobName":"$(TARGET_CIRCLECI_BUILD_PR)", "PlanUrl":"$(System.CollectionUri)", "ProjectId":"$(System.TeamProjectId)", "HubName":"$(System.HostType)", "PlanId":"$(System.PlanId)", "JobId":"$(System.JobId)", "TimelineId":"$(System.TimelineId)", "TaskInstanceId":"$(System.TaskInstanceId)", "AuthToken":"$(System.AccessToken)"}'
     body: ''
     urlSuffix: 'api/JobStatus'
     waitForCompletion: true

.azure_pipelines/job_templates/wheel-wait-template.yml

@@ -1,14 +1,23 @@
 # Initiate 5 agentless-server waiting jobs to check on the
 # status of PR artifact builds, for a maximum wait time of
-# 5 * 60 min =300 minutes. These jobs will pass immediately
+# 8*60 min=480 mins. These jobs will pass immediately
 # once targeted CircleCI build is ready.
 
 jobs:
+# Ensure that ample time is afforded to the PR CircleCI builds to start
+# building artifacts.
+- job: Delay5MinForCircleCI
+  pool: server
+  steps:
+  - task: Delay@1
+    inputs:
+      delayForMinutes: '5'
+
 - job: checkjob1
   pool: server
   timeoutInMinutes: 60
+  dependsOn: Delay5MinForCircleCI
   continueOnError: true
-
   steps:
   - template: wheel-wait-job-template.yml
 
@@ -17,7 +26,6 @@ jobs:
   timeoutInMinutes: 60
   dependsOn: checkjob1
   continueOnError: true
-
   steps:
   - template: wheel-wait-job-template.yml
 
@@ -26,7 +34,6 @@ jobs:
   timeoutInMinutes: 60
   dependsOn: checkjob2
   continueOnError: true
-
   steps:
   - template: wheel-wait-job-template.yml
 
@@ -35,7 +42,6 @@ jobs:
   timeoutInMinutes: 60
   dependsOn: checkjob3
   continueOnError: true
-
   steps:
   - template: wheel-wait-job-template.yml
 
@@ -44,6 +50,29 @@ jobs:
   timeoutInMinutes: 60
   dependsOn: checkjob4
   continueOnError: true
-
+  steps:
+  - template: wheel-wait-job-template.yml
+
+- job: checkjob6
+  pool: server
+  timeoutInMinutes: 60
+  dependsOn: checkjob5
+  continueOnError: true
+  steps:
+  - template: wheel-wait-job-template.yml
+
+- job: checkjob7
+  pool: server
+  timeoutInMinutes: 60
+  dependsOn: checkjob6
+  continueOnError: true
+  steps:
+  - template: wheel-wait-job-template.yml
+
+- job: checkjob8
+  pool: server
+  timeoutInMinutes: 60
+  dependsOn: checkjob7
+  continueOnError: true
   steps:
   - template: wheel-wait-job-template.yml

.azure_pipelines/pytorch-tests-pipeline.yml

@@ -7,14 +7,26 @@
 #   2) runs custom PyTorch unit-tests on PyTorch
 #      wheels generated during PR builds.
 
+resources:
+  webhooks:
+    - webhook: GitHubPyTorchPRTrigger
+      connection: GitHubPyTorchPRTriggerConnection
+      filters:
+        - path: repositoryName
+          value: pytorch_tests
+
 stages:
 - stage: 'EnsureArtifactsReady'
   displayName: 'Ensure PyTorch PR Artifacts are ready'
   jobs:
   - template: job_templates/wheel-wait-template.yml
+  variables:
+    _TARGET_BRANCH_TO_CHECK: ${{ parameters.GitHubPyTorchPRTrigger.TARGET_BRANCH_TO_CHECK_AZ_DEVOPS_PR}}
 
 - stage: 'PRCustomTests'
   displayName: 'Run custom unit tests on PyTorch wheels'
+  dependsOn: EnsureArtifactsReady
+  condition: succeeded()
   jobs:
   - template: job_templates/pytorch-template-unix.yml
     parameters:
@@ -24,7 +36,7 @@ stages:
         PR_Custom_Tests:
           _PYTHON_VERSION: $(PYTHON_VERSION_PR)
           _CUDA_BUILD_VERSION: $(CUDA_BUILD_VERSION_PR)
-          _TARGET_CIRCLECI_BUILD: $(TARGET_CIRCLECI_PR)
-          _TARGET_BRANCH_TO_CHECK: $(TARGET_BRANCH_TO_CHECK_PR)
+          _TARGET_CIRCLECI_BUILD: $(TARGET_CIRCLECI_BUILD_PR)
+          _TARGET_BRANCH_TO_CHECK: ${{ parameters.GitHubPyTorchPRTrigger.TARGET_BRANCH_TO_CHECK_AZ_DEVOPS_PR}}
           _DOCKER_IMAGE: $(DOCKER_IMAGE_PR)
           _RUN_TESTS: $(RUN_TESTS_PR)