OSSForks/pytorch
1
0
Fork 0
mirror of https://github.com/zebrajr/pytorch.git synced 2025-12-06 12:20:52 +01:00
Code Issues Actions 38 Packages Projects Releases Wiki Activity

[codemod] c10::string_view -> std::string_view in fields (#141736)

Browse Source 
Summary: `c10::string_view` is being removed, so we need to migrate.

Test Plan: Sandcastle

Reviewed By: palmje

Differential Revision: D65830276

Pull Request resolved: https://github.com/pytorch/pytorch/pull/141736
Approved by: https://github.com/Skylion007
This commit is contained in:
Richard Barnes 2024-11-28 21:35:53 +00:00 committed by PyTorch MergeBot
parent 09a3eddc07
commit ae6519cb74
5 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
aten/src/ATen/core/dynamic_type.cpp
View File

@ -258,7 +258,7 @@ TypePtr DynamicType::fallback() const {
fallbacks.push_back(elem.ty->fallback());
}
if (name_) {
std::vector<c10::string_view> fields;
std::vector<std::string_view> fields;
fields.reserve(arguments_.elems.size());
for (const auto& elem : arguments_.elems) {
// NOLINTNEXTLINE(bugprone-unchecked-optional-access)
@ -382,7 +382,7 @@ TORCH_API TupleTypePtr ivalue::TupleTypeFactory<TupleType>::fallback(
return nullptr;
#else
const auto& dyn = type.expectRef<DynamicType>();
std::vector<c10::string_view> fields;
std::vector<std::string_view> fields;
std::vector<TypePtr> types;
for (const auto& elem : dyn.arguments().elems) {

4
aten/src/ATen/core/jit_type.h
View File

@ -1154,7 +1154,7 @@ struct TORCH_API TupleType : public NamedType {
const std::vector<TypePtr>& field_types);
static TupleTypePtr createNamed(const std::optional<c10::QualifiedName>& name,
const std::vector<c10::string_view>& field_names,
const std::vector<std::string_view>& field_names,
const std::vector<TypePtr>& field_types);
static TupleTypePtr create(
@ -1190,7 +1190,7 @@ struct TORCH_API TupleType : public NamedType {
const std::shared_ptr<FunctionSchema>& schema() const {
return schema_;
}
std::optional<std::vector<c10::string_view>> names() const;
std::optional<std::vector<std::string_view>> names() const;
static const TypeKind Kind = TypeKind::TupleType;

6
aten/src/ATen/core/type.cpp
View File

@ -728,7 +728,7 @@ TupleTypePtr TupleType::createNamed(
TupleTypePtr TupleType::createNamed(
const std::optional<c10::QualifiedName>& qualName,
const std::vector<c10::string_view>& field_names,
const std::vector<std::string_view>& field_names,
const std::vector<TypePtr>& field_types) {
std::vector<IValue> empty_defaults;
return createWithSpec(qualName, field_names, field_types, empty_defaults);
@ -784,11 +784,11 @@ TupleTypePtr TupleType::createWithSpec(const std::optional<c10::QualifiedName>&
field_types, qualName, std::move(schema))); // NOLINT(modernize-make-shared)
}
std::optional<std::vector<c10::string_view>> TupleType::names() const {
std::optional<std::vector<std::string_view>> TupleType::names() const {
if (!schema_) {
return {};
}
std::vector<c10::string_view> ret;
std::vector<std::string_view> ret;
for (const auto& arg : schema_->arguments()) {
ret.emplace_back(arg.name());
}

2
aten/src/ATen/core/type_factory.cpp
View File

@ -61,7 +61,7 @@ const std::unordered_map<std::string, c10::TypePtr>& DefaultTypeFactory::
c10::TypePtr DefaultTypeFactory::createNamedTuple(
const std::string& name,
const std::vector<c10::string_view>& fields,
const std::vector<std::string_view>& fields,
const std::vector<c10::TypePtr>& types) {
return c10::TupleType::createNamed(name, fields, types);
}

2
aten/src/ATen/core/type_factory.h
View File

@ -80,7 +80,7 @@ struct TORCH_API TypeFactoryBase<c10::Type> {
}
static c10::TypePtr createNamedTuple(
const std::string& name,
const std::vector<c10::string_view>& fields,
const std::vector<std::string_view>& fields,
const std::vector<c10::TypePtr>& types);
template <typename T>
C10_ERASE static c10::TypePtr createNamed(const std::string& name) {