From a5f6b24d87bbf735376d5c6d4c8bb2a7abaf0c88 Mon Sep 17 00:00:00 2001 From: cyy Date: Tue, 11 Mar 2025 18:37:36 +0000 Subject: [PATCH] Remove outdated skipIfRocmVersionLessThan decorations (#148941) Fixes #ISSUE_NUMBER Pull Request resolved: https://github.com/pytorch/pytorch/pull/148941 Approved by: https://github.com/jeffdaily --- test/nn/test_convolution.py | 4 ---- test/test_cuda_primary_ctx.py | 8 +------- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/test/nn/test_convolution.py b/test/nn/test_convolution.py index 6e1d7ae5c70..78fcd9b5341 100644 --- a/test/nn/test_convolution.py +++ b/test/nn/test_convolution.py @@ -32,7 +32,6 @@ from torch.testing._internal.common_device_type import ( skipCUDAIfNoMiopen, skipCUDAIfNotMiopenSuggestNHWC, skipCUDAIfRocm, - skipCUDAIfRocmVersionLessThan, skipMeta, skipMPS, ) @@ -893,7 +892,6 @@ class TestConvolutionNN(NNTestCase): @unittest.skipIf(not TEST_CUDA, "CUDA unavailable") @unittest.skipIf(not TEST_CUDNN, "needs cudnn") - @skipIfRocmVersionLessThan((4, 3)) @skipIfNotMiopenSuggestNHWC def test_grouped_conv_cudnn_nhwc_support(self): # in order to catch the hols in grouped convolution in nhwc support for earlier cudnn version @@ -3640,7 +3638,6 @@ class TestConvolutionNNDeviceType(NNTestCase): ) @onlyCUDA - @skipCUDAIfRocmVersionLessThan((4, 3)) @skipCUDAIfNotMiopenSuggestNHWC @skipCUDAIfCudnnVersionLessThan(7603) @dtypes(torch.half, torch.float, torch.cfloat) @@ -3826,7 +3823,6 @@ class TestConvolutionNNDeviceType(NNTestCase): ) @onlyCUDA - @skipCUDAIfRocmVersionLessThan((4, 3)) @skipCUDAIfNotMiopenSuggestNHWC @skipCUDAIfCudnnVersionLessThan(7603) @tf32_on_and_off(0.05) diff --git a/test/test_cuda_primary_ctx.py b/test/test_cuda_primary_ctx.py index 8d5c6ea75b6..37a9c0aedbd 100644 --- a/test/test_cuda_primary_ctx.py +++ b/test/test_cuda_primary_ctx.py @@ -5,12 +5,7 @@ import unittest import torch from torch.testing._internal.common_cuda import TEST_CUDA, TEST_MULTIGPU -from torch.testing._internal.common_utils import ( - NoTest, - run_tests, - skipIfRocmVersionLessThan, - TestCase, -) +from torch.testing._internal.common_utils import NoTest, run_tests, TestCase # NOTE: this needs to be run in a brand new process @@ -28,7 +23,6 @@ class TestCudaPrimaryCtx(TestCase): "--subprocess to run each test in a different subprocess." ) - @skipIfRocmVersionLessThan((4, 4, 21504)) def setUp(self): for device in range(torch.cuda.device_count()): # Ensure context has not been created beforehand