OSSForks/pytorch
1
0
Fork 0
mirror of https://github.com/zebrajr/pytorch.git synced 2025-12-06 12:20:52 +01:00
Code Issues Actions 38 Packages Projects Releases Wiki Activity

Fix lstrip bug revealed by B005 lint (#18177)

Browse Source 
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/18177
ghimport-source-id: fbbf915b66762fc88bc5b541464e71ba27500958

Stack from [ghstack](https://github.com/ezyang/ghstack):
* #18184 Fix B903 lint: save memory for data classes with slots/namedtuple
* #18181 Fix B902 lint error: invalid first argument.
* #18178 Fix B006 lint errors: using mutable structure in default argument.
* **#18177 Fix lstrip bug revealed by B005 lint**

lstrip() doesn't strip a prefix; it strips all of the characters
in the passed in string.  B005 lint revealed this.  Replaced with
substring operation.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: D14530873

fbshipit-source-id: 13b3438fcc3cce13b5110730dc3d0b528a52930f
This commit is contained in:
Edward Yang 2019-03-21 07:50:45 -07:00 committed by Facebook Github Bot
parent e5cdd94324
commit 9bc8badbcb
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.flake8
View File

@ -6,5 +6,5 @@ max-line-length = 120
ignore = ignore =
E203,E305,E402,E501,E721,E741,F401,F403,F405,F821,F841,F999,W503,W504,C408, E203,E305,E402,E501,E721,E741,F401,F403,F405,F821,F841,F999,W503,W504,C408,
# ignores below are temporary, fix them and remove please! # ignores below are temporary, fix them and remove please!
B005,B006,B007,B008,B902,B903 B006,B007,B008,B902,B903
exclude = docs/src,venv,third_party,caffe2,scripts,docs/caffe2,tools/amd_build/pyHIPIFY,torch/lib/include,torch/lib/tmp_install,build,torch/include exclude = docs/src,venv,third_party,caffe2,scripts,docs/caffe2,tools/amd_build/pyHIPIFY,torch/lib/include,torch/lib/tmp_install,build,torch/include

4
aten/src/ATen/common_with_cwrap.py
View File

@ -187,14 +187,14 @@ def parse_header(path):
generic_functions = [] generic_functions = []
for l, c in lines: for l, c in lines:
if l.startswith('TH_API void THNN_'): if l.startswith('TH_API void THNN_'):
fn_name = l.lstrip('TH_API void THNN_') fn_name = l[len('TH_API void THNN_'):]
if fn_name[0] == '(' and fn_name[-2] == ')': if fn_name[0] == '(' and fn_name[-2] == ')':
fn_name = fn_name[1:-2] fn_name = fn_name[1:-2]
else: else:
fn_name = fn_name[:-1] fn_name = fn_name[:-1]
generic_functions.append(Function(fn_name)) generic_functions.append(Function(fn_name))
elif l.startswith('THC_API void THNN_'): elif l.startswith('THC_API void THNN_'):
fn_name = l.lstrip('THC_API void THNN_') fn_name = l[len('THC_API void THNN_'):]
if fn_name[0] == '(' and fn_name[-2] == ')': if fn_name[0] == '(' and fn_name[-2] == ')':
fn_name = fn_name[1:-2] fn_name = fn_name[1:-2]
else: else:

4
torch/_thnn/utils.py
View File

@ -95,14 +95,14 @@ def parse_header(path):
generic_functions = [] generic_functions = []
for l, c in lines: for l, c in lines:
if l.startswith('TH_API void THNN_'): if l.startswith('TH_API void THNN_'):
fn_name = l.lstrip('TH_API void THNN_') fn_name = l[len('TH_API void THNN_'):]
if fn_name[0] == '(' and fn_name[-2] == ')': if fn_name[0] == '(' and fn_name[-2] == ')':
fn_name = fn_name[1:-2] fn_name = fn_name[1:-2]
else: else:
fn_name = fn_name[:-1] fn_name = fn_name[:-1]
generic_functions.append(Function(fn_name)) generic_functions.append(Function(fn_name))
elif l.startswith('THC_API void THNN_'): elif l.startswith('THC_API void THNN_'):
fn_name = l.lstrip('THC_API void THNN_') fn_name = l[len('THC_API void THNN_'):]
if fn_name[0] == '(' and fn_name[-2] == ')': if fn_name[0] == '(' and fn_name[-2] == ')':
fn_name = fn_name[1:-2] fn_name = fn_name[1:-2]
else: else: