OSSForks/pytorch
1
0
Fork 0
mirror of https://github.com/zebrajr/pytorch.git synced 2025-12-06 12:20:52 +01:00
Code Issues Actions 38 Packages Projects Releases Wiki Activity

Conditionally build the TestApp benchmark based on lite interpreter (#86314)

Browse Source 
The TestApp benchmark was recently re-added, however it seems it only builds when pytorch is built with the lite interpreter. This diff adds a macro to compile out the benchmark when pytorch is built as full jit. This should fix our full jit simulator nightly builds.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/86314
Approved by: https://github.com/malfet
This commit is contained in:
John Detloff 2022-10-06 10:08:54 +00:00 committed by PyTorch MergeBot
parent 936e93058b
commit 85c3b745f6
4 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ios/TestApp/TestApp/Benchmark.h
View File

@ -1,3 +1,5 @@
#ifdef BUILD_LITE_INTERPRETER
#import <Foundation/Foundation.h> #import <Foundation/Foundation.h>
NS_ASSUME_NONNULL_BEGIN NS_ASSUME_NONNULL_BEGIN
@ -10,3 +12,4 @@ NS_ASSUME_NONNULL_BEGIN
@end @end
NS_ASSUME_NONNULL_END NS_ASSUME_NONNULL_END
#endif

3
ios/TestApp/TestApp/Benchmark.mm
View File

@ -1,3 +1,5 @@
#ifdef BUILD_LITE_INTERPRETER
#import "Benchmark.h" #import "Benchmark.h"
#include <string> #include <string>
#include <vector> #include <vector>
@ -103,3 +105,4 @@ static int iter = 10;
} }
@end @end
#endif

7
ios/TestApp/TestApp/ViewController.mm
View File

@ -1,6 +1,9 @@
#import "ViewController.h" #import "ViewController.h"
#ifdef BUILD_LITE_INTERPRETER
#import "Benchmark.h" #import "Benchmark.h"
#endif
@interface ViewController () @interface ViewController ()
@property(nonatomic, strong) UITextView* textView; @property(nonatomic, strong) UITextView* textView;
@ -11,6 +14,7 @@
- (void)viewDidLoad { - (void)viewDidLoad {
[super viewDidLoad]; [super viewDidLoad];
#ifdef BUILD_LITE_INTERPRETER
self.textView = [[UITextView alloc] initWithFrame:self.view.bounds]; self.textView = [[UITextView alloc] initWithFrame:self.view.bounds];
self.textView.autoresizingMask = UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight; self.textView.autoresizingMask = UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight;
[self.view addSubview:self.textView]; [self.view addSubview:self.textView];
@ -30,8 +34,10 @@
[Benchmark setup:config]; [Benchmark setup:config];
[self runBenchmark]; [self runBenchmark];
#endif
} }
#ifdef BUILD_LITE_INTERPRETER
- (void)runBenchmark { - (void)runBenchmark {
self.textView.text = @"Start benchmarking...\n"; self.textView.text = @"Start benchmarking...\n";
dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{ dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
@ -41,5 +47,6 @@
}); });
}); });
} }
#endif
@end @end

5
ios/TestApp/benchmark/setup.rb
View File

@ -36,6 +36,11 @@ targets.each do |target|
config.build_settings['LIBRARY_SEARCH_PATHS'] = libraries_search_path config.build_settings['LIBRARY_SEARCH_PATHS'] = libraries_search_path
config.build_settings['OTHER_LDFLAGS'] = other_linker_flags config.build_settings['OTHER_LDFLAGS'] = other_linker_flags
config.build_settings['ENABLE_BITCODE'] = 'No' config.build_settings['ENABLE_BITCODE'] = 'No'
if (options[:lite])
config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] = ['$(inherited)', "BUILD_LITE_INTERPRETER"]
else
config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] = ['$(inherited)']
end
dev_team_id = options[:team_id] dev_team_id = options[:team_id]
if dev_team_id if dev_team_id
config.build_settings['DEVELOPMENT_TEAM'] = dev_team_id config.build_settings['DEVELOPMENT_TEAM'] = dev_team_id