From 6db21a9cf8c42f372e88ac39c44a83fa085a9791 Mon Sep 17 00:00:00 2001 From: arunppsg Date: Wed, 14 Jun 2023 19:57:12 +0000 Subject: [PATCH] Update clang-tidy install in CONTRIBUTING.md (#101247) Updated clang-tidy install to reflect install command in github actions workflow https://github.com/pytorch/pytorch/blob/ce76670c6f7f64ac0f3dbe371fc64088fef47777/.github/workflows/lint.yml#L45 I was following steps to run clang-tidy and got into the above issue. I also think that the following line is outdated: https://github.com/pytorch/pytorch/blob/ce76670c6f7f64ac0f3dbe371fc64088fef47777/CONTRIBUTING.md?plain=1#L1077 but not sure what is the right solution there as there is no `clang_tidy/requirements.txt` file. Pull Request resolved: https://github.com/pytorch/pytorch/pull/101247 Approved by: https://github.com/subramen, https://github.com/kit1980 --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 353a2839fb4..e191f4b0fbf 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1078,7 +1078,7 @@ To run clang-tidy locally, follow these steps: 1. Install clang-tidy. We provide custom built binaries which have additional checks enabled. You can install it by running: ```bash -python3 -m tools.linter.install.clang_tidy +python3 -m tools.linter.clang_tidy.generate_build_files ``` We currently only support Linux and MacOS (x86).