From 6d5944c9f1fbdf167e312b18c112e04d82614b95 Mon Sep 17 00:00:00 2001 From: Xu Han Date: Wed, 30 Oct 2024 21:09:21 +0000 Subject: [PATCH] turn off USE_MIMALLOC_ON_MKL temporary. (#139204) Fixes #138994 We can turn off `USE_MIMALLOC_ON_MKL` temporary. Due to it caused https://github.com/pytorch/pytorch/issues/138994 For totally fixed, we need fix `USE_STATIC_MKL` lost functionality issue: https://github.com/pytorch/pytorch/pull/138996, and then get the correctly MKL linking type(shared/static). It still need some time to pass all CI and builder scripts. Pull Request resolved: https://github.com/pytorch/pytorch/pull/139204 Approved by: https://github.com/ezyang --- CMakeLists.txt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 30377996b3e..3b682eb96cf 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -384,7 +384,12 @@ option(USE_MIMALLOC "Use mimalloc" OFF) option(USE_MIMALLOC_ON_MKL "Use mimalloc on MKL" OFF) if(WIN32) set(USE_MIMALLOC ON) - set(USE_MIMALLOC_ON_MKL ON) + + # Not enable USE_MIMALLOC_ON_MKL due to it caused issue: + # https://github.com/pytorch/pytorch/issues/138994 + # Will turn on when we can fix USE_STATIC_MKL lost functionality: + # https://github.com/pytorch/pytorch/pull/138996 + # set(USE_MIMALLOC_ON_MKL ON) endif() if(USE_CCACHE)