OSSForks/pytorch
1
0
Fork 0
mirror of https://github.com/zebrajr/pytorch.git synced 2025-12-06 12:20:52 +01:00
Code Issues Actions 38 Packages Projects Releases Wiki Activity

Revert "[c10d][Logging] Remove args and kwargs from c10d logging (#140169)"

Browse Source 
This reverts commit e3b2f04f05.

Reverted https://github.com/pytorch/pytorch/pull/140169 on behalf of https://github.com/ZainRizvi due to Man, this test really wants to fail on trunk. Sorry. Details:  distributed/test_c10d_logger.py::C10dErrorLoggerTest::test_exception_logger [GH job link](https://github.com/pytorch/pytorch/actions/runs/11751023962/job/32740983427) [HUD commit link](e3b2f04f05) ([comment](https://github.com/pytorch/pytorch/pull/140169#issuecomment-2465933413))
This commit is contained in:
PyTorch MergeBot 2024-11-09 00:23:42 +00:00
parent 090b778b8a
commit 58b661cda2
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/distributed/test_c10d_logger.py
View File

@ -118,7 +118,7 @@ class C10dErrorLoggerTest(MultiProcessTestCase):
re.search("({.+})", captured.output[0]).group(0).replace("'", '"')
)
self.assertEqual(len(error_msg_dict), 9)
self.assertEqual(len(error_msg_dict), 10)
self.assertIn("pg_name", error_msg_dict.keys())
self.assertEqual("None", error_msg_dict["pg_name"])
@ -126,6 +126,8 @@ class C10dErrorLoggerTest(MultiProcessTestCase):
self.assertIn("func_name", error_msg_dict.keys())
self.assertEqual("broadcast", error_msg_dict["func_name"])
self.assertIn("args", error_msg_dict.keys())
self.assertIn("backend", error_msg_dict.keys())
self.assertEqual("nccl", error_msg_dict["backend"])
@ -160,7 +162,7 @@ class C10dErrorLoggerTest(MultiProcessTestCase):
msg_dict = json.loads(
re.search("({.+})", captured.output[0]).group(0).replace("'", '"')
)
self.assertEqual(len(msg_dict), 9)
self.assertEqual(len(msg_dict), 10)
self.assertIn("pg_name", msg_dict.keys())
self.assertEqual("None", msg_dict["pg_name"])
@ -168,6 +170,8 @@ class C10dErrorLoggerTest(MultiProcessTestCase):
self.assertIn("func_name", msg_dict.keys())
self.assertEqual("_dummy_sleep", msg_dict["func_name"])
self.assertIn("args", msg_dict.keys())
self.assertIn("backend", msg_dict.keys())
self.assertEqual("nccl", msg_dict["backend"])