OSSForks/pytorch
1
0
Fork 0
mirror of https://github.com/zebrajr/pytorch.git synced 2025-12-06 12:20:52 +01:00
Code Issues Actions 38 Packages Projects Releases Wiki Activity

Allow workflows to opt-out of experiments (#153085)

Browse Source 
This change adds support to allow workflows to opt-out of experiments.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/153085
Approved by: https://github.com/ZainRizvi

Co-authored-by: Zain Rizvi <ZainRizvi@users.noreply.github.com>
This commit is contained in:
Thanh Ha 2025-05-09 16:34:43 +00:00 committed by PyTorch MergeBot
parent 18e13a67ce
commit 50657120a0
2 changed files with 46 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
.github/scripts/runner_determinator.py vendored
View File

@ -198,6 +198,16 @@ def parse_args() -> Any:
default="",
help="comma separated list of experiments to check, if omitted all experiments marked with default=True are checked",
)
parser.add_argument(
"--opt-out-experiments",
type=_str_comma_separated_to_set,
required=False,
default="",
help=(
"comma separated list of experiments to opt-out of. If unset, no opt-outs will occur. "
"If the same experiment is listed both here and in '--eligible-experiments' opt-out will take priority."
),
)
parser.add_argument(
"--pr-number",
type=str,
@ -422,6 +432,7 @@ def get_runner_prefix(
workflow_requestors: Iterable[str],
branch: str,
eligible_experiments: frozenset[str] = frozenset(),
opt_out_experiments: frozenset[str] = frozenset(),
is_canary: bool = False,
) -> str:
settings = parse_settings(rollout_state)
@ -436,6 +447,14 @@ def get_runner_prefix(
)
continue
if opt_out_experiments:
if experiment_name in opt_out_experiments:
opt_out_exp_list = ", ".join(opt_out_experiments)
log.info(
f"Skipping experiment '{experiment_name}', as this workflow has opted-out (opted out experiments are: {opt_out_exp_list})"
)
continue
if eligible_experiments:
if experiment_name not in eligible_experiments:
exp_list = ", ".join(eligible_experiments)
@ -600,6 +619,7 @@ def main() -> None:
(args.github_issue_owner, username),
args.github_branch,
args.eligible_experiments,
args.opt_out_experiments,
is_canary,
)

26
.github/workflows/_runner-determinator.yml vendored
View File

@ -8,6 +8,10 @@ on:
type: string
description: |
List of experiments for this workfow. If not defined, all default experiments are included.
opt_out_experiments:
required: false
type: string
description: Comma-separated list of experiments this workflow will opt-out of.
triggering_actor:
required: true
type: string
@ -51,6 +55,7 @@ jobs:
TRIGGERING_ACTOR: ${{ inputs.triggering_actor }}
ISSUE_OWNER: ${{ inputs.issue_owner }}
CHECK_EXPERIMENTS: ${{ inputs.check_experiments }}
OPT_OUT_EXPERIMENTS: ${{ inputs.opt_out_experiments }}
PR_NUMBER: ${{ github.event.pull_request.number }}
steps:
# - name: Checkout PyTorch
@ -266,6 +271,16 @@ jobs:
default="",
help="comma separated list of experiments to check, if omitted all experiments marked with default=True are checked",
)
parser.add_argument(
"--opt-out-experiments",
type=_str_comma_separated_to_set,
required=False,
default="",
help=(
"comma separated list of experiments to opt-out of. If unset, no opt-outs will occur. "
"If the same experiment is listed both here and in '--eligible-experiments' opt-out will take priority."
),
)
parser.add_argument(
"--pr-number",
type=str,
@ -490,6 +505,7 @@ jobs:
workflow_requestors: Iterable[str],
branch: str,
eligible_experiments: frozenset[str] = frozenset(),
opt_out_experiments: frozenset[str] = frozenset(),
is_canary: bool = False,
) -> str:
settings = parse_settings(rollout_state)
@ -504,6 +520,14 @@ jobs:
)
continue
if opt_out_experiments:
if experiment_name in opt_out_experiments:
opt_out_exp_list = ", ".join(opt_out_experiments)
log.info(
f"Skipping experiment '{experiment_name}', as this workflow has opted-out (opted out experiments are: {opt_out_exp_list})"
)
continue
if eligible_experiments:
if experiment_name not in eligible_experiments:
exp_list = ", ".join(eligible_experiments)
@ -668,6 +692,7 @@ jobs:
(args.github_issue_owner, username),
args.github_branch,
args.eligible_experiments,
args.opt_out_experiments,
is_canary,
)
@ -705,4 +730,5 @@ jobs:
--github-ref-type "$curr_ref_type" \
--github-repo "$GITHUB_REPOSITORY" \
--eligible-experiments "$CHECK_EXPERIMENTS" \
--opt-out-experiments "$OPT_OUT_EXPERIMENTS" \
--pr-number "${PR_NUMBER}"