OSSForks/pytorch
1
0
Fork 0
mirror of https://github.com/zebrajr/pytorch.git synced 2025-12-06 12:20:52 +01:00
Code Issues Actions 38 Packages Projects Releases Wiki Activity

Have test classes extend from common_utils.TestCase, not unittest.TestCase (#66900)

Browse Source 
Summary:
This causes some functionality to not work, such as the disabling issues e.g., https://github.com/pytorch/pytorch/issues/66641

cc pietern mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse SciPioneer H-Huang

Pull Request resolved: https://github.com/pytorch/pytorch/pull/66900

Reviewed By: seemethere

Differential Revision: D31778293

Pulled By: janeyx99

fbshipit-source-id: df3023ddaf7969ffb60117d1e1d7e36d87bc6139
This commit is contained in:
Jane Xu 2021-10-19 16:52:27 -07:00 committed by Facebook GitHub Bot
parent de4fe7a38c
commit 32e3003726
4 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/distributed/nn/jit/test_instantiator.py
View File

@ -3,7 +3,6 @@
import pathlib
import sys
import unittest
from typing import Tuple
import torch
@ -15,7 +14,7 @@ if not dist.is_available():
sys.exit(0)
from torch.distributed.nn.jit import instantiator
from torch.testing._internal.common_utils import run_tests
from torch.testing._internal.common_utils import TestCase, run_tests
@torch.jit.interface
@ -34,7 +33,7 @@ def create_module():
return MyModule()
class TestInstantiator(unittest.TestCase):
class TestInstantiator(TestCase):
def test_get_arg_return_types_from_interface(self):
(
args_str,

5
test/test_determination.py
View File

@ -1,17 +1,16 @@
# Owner(s): ["module: ci"]
import os
import unittest
import run_test
from torch.testing._internal.common_utils import run_tests
from torch.testing._internal.common_utils import TestCase, run_tests
class DummyOptions(object):
verbose = False
class DeterminationTest(unittest.TestCase):
class DeterminationTest(TestCase):
# Test determination on a subset of tests
TESTS = [
"test_nn",

4
test/test_jit.py
View File

@ -86,7 +86,7 @@ import torch.nn.functional as F
from torch.testing._internal import jit_utils
from torch.testing._internal.common_jit import check_against_reference
from torch.testing._internal.common_utils import run_tests, IS_WINDOWS, TEST_WITH_UBSAN, \
suppress_warnings, IS_SANDCASTLE, GRAPH_EXECUTOR, ProfilingMode, \
suppress_warnings, IS_SANDCASTLE, GRAPH_EXECUTOR, ProfilingMode, TestCase, \
freeze_rng_state, slowTest, TemporaryFileName, skipIfCompiledWithoutNumpy, \
enable_profiling_mode_for_profiling_tests, TEST_MKL, set_default_dtype, num_profiled_runs
from torch.testing._internal.jit_utils import JitTestCase, enable_cpu_fuser, disable_autodiff_subgraph_inlining, \
@ -16337,7 +16337,7 @@ def normalize_check_ad(check_ad, name):
return check_ad
class TestProducerVersion(unittest.TestCase):
class TestProducerVersion(TestCase):
def test_version(self):
# issue gh-32561

5
test/test_public_bindings.py
View File

@ -1,11 +1,10 @@
# Owner(s): ["module: autograd"]
from torch.testing._internal.common_utils import run_tests
from torch.testing._internal.common_utils import TestCase, run_tests
import torch
import unittest
class TestPublicBindings(unittest.TestCase):
class TestPublicBindings(TestCase):
def test_no_new_bindings(self):
"""
This test aims to stop the introduction of new JIT bindings into torch._C