From 0b8889c724f52dd767564fcd51e8a0ee5e99b45f Mon Sep 17 00:00:00 2001 From: William Wen Date: Thu, 10 Nov 2022 01:48:04 +0000 Subject: [PATCH] Do not flag models in dashboard due to NaN values (#88792) Title. Tested by running `python benchmarks/dynamo/runner.py --output-dir ../test-dynamo-runner-logs-4 --training --visualize_logs` on a copy of a recent set of logs. Pull Request resolved: https://github.com/pytorch/pytorch/pull/88792 Approved by: https://github.com/anijain2305 --- benchmarks/dynamo/runner.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/benchmarks/dynamo/runner.py b/benchmarks/dynamo/runner.py index ea54bb94896..9c0538368b4 100755 --- a/benchmarks/dynamo/runner.py +++ b/benchmarks/dynamo/runner.py @@ -121,15 +121,15 @@ DASHBOARD_DEFAULTS = { def flag_speedup(x): - return pd.isna(x) or x < 0.95 + return x < 0.95 def flag_compilation_latency(x): - return pd.isna(x) or x == 0 or x > 120 + return x > 120 def flag_compression_ratio(x): - return pd.isna(x) or x < 0.9 + return x < 0.9 FLAG_FNS = {