OSSForks/pytorch
1
0
Fork 0
mirror of https://github.com/zebrajr/pytorch.git synced 2025-12-06 12:20:52 +01:00
Code Issues Actions 38 Packages Projects Releases Wiki Activity

Fix B006 lint errors: using mutable structure in default argument. (#18178)

Browse Source 
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/18178
ghimport-source-id: 667ee76b418f505fa64b863e52a603c508dcd1bf

Stack from [ghstack](https://github.com/ezyang/ghstack):
* #18184 Fix B903 lint: save memory for data classes with slots/namedtuple
* #18181 Fix B902 lint error: invalid first argument.
* **#18178 Fix B006 lint errors: using mutable structure in default argument.**
* #18177 Fix lstrip bug revealed by B005 lint

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Differential Revision: D14530874

fbshipit-source-id: 38f4456a085bfe55f2a96fff53028ebd0d621604
This commit is contained in:
Edward Yang 2019-03-21 09:06:30 -07:00 committed by Facebook Github Bot
parent 0122121176
commit 0654c7d4a7
3 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.flake8
View File

@ -6,5 +6,5 @@ max-line-length = 120
ignore = ignore =
E203,E305,E402,E501,E721,E741,F401,F403,F405,F821,F841,F999,W503,W504,C408, E203,E305,E402,E501,E721,E741,F401,F403,F405,F821,F841,F999,W503,W504,C408,
# ignores below are temporary, fix them and remove please! # ignores below are temporary, fix them and remove please!
B006,B007,B008,B902,B903 B007,B008,B902,B903
exclude = docs/src,venv,third_party,caffe2,scripts,docs/caffe2,tools/amd_build/pyHIPIFY,torch/lib/include,torch/lib/tmp_install,build,torch/include exclude = docs/src,venv,third_party,caffe2,scripts,docs/caffe2,tools/amd_build/pyHIPIFY,torch/lib/include,torch/lib/tmp_install,build,torch/include

5
aten/src/ATen/code_template.py
View File

@ -30,7 +30,10 @@ class CodeTemplate(object):
self.pattern = pattern self.pattern = pattern
self.filename = filename self.filename = filename
def substitute(self, env={}, **kwargs): def substitute(self, env=None, **kwargs):
if env is None:
env = {}
def lookup(v): def lookup(v):
return kwargs[v] if v in kwargs else env[v] return kwargs[v] if v in kwargs else env[v]

5
aten/src/ATen/common_with_cwrap.py
View File

@ -95,7 +95,10 @@ def filter_unique_options(options, allow_kwarg, type_to_signature, remove_self):
def enumerate_options_due_to_default(declaration, def enumerate_options_due_to_default(declaration,
allow_kwarg=True, type_to_signature=[], remove_self=True): allow_kwarg=True, type_to_signature=None, remove_self=True):
if type_to_signature is None:
type_to_signature = []
# Checks to see if an argument with a default keyword is a Tensor that # Checks to see if an argument with a default keyword is a Tensor that
# by default can be NULL. In this case, instead of generating another # by default can be NULL. In this case, instead of generating another