OSSForks/postgres
1
0
Fork 0
mirror of https://github.com/zebrajr/postgres.git synced 2025-12-07 12:20:31 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
cd5a6521fa
postgres/contrib
History
Tom Lane e1d88f983e Fix pg_upgrade to not fail when new-cluster TOAST rules differ from old. 
This patch essentially reverts commit 4c6780fd17, in favor of a much
simpler solution for the case where the new cluster would choose to create
a TOAST table but the old cluster doesn't have one: just don't create a
TOAST table.

The existing code failed in at least two different ways if the situation
arose: (1) ALTER TABLE RESET didn't grab an exclusive lock, so that the
lock sanity check in create_toast_table failed; (2) pg_upgrade did not
provide a pg_type OID for the new toast table, so that the crosscheck in
TypeCreate failed.  While both these problems were introduced by later
patches, they show that the hack being used to cause TOAST table creation
is overwhelmingly fragile (and untested).  I also note that before the
TypeCreate crosscheck was added, the code would have resulted in assigning
an indeterminate pg_type OID to the toast table, possibly causing a later
OID conflict in that catalog; so that it didn't really work even when
committed.

If we simply don't create a TOAST table, there will only be a problem if
the code tries to store a tuple that's wider than a page, and field
compression isn't sufficient to get it under a page.  Given that the TOAST
creation threshold is intended to be about a quarter of a page, it's very
hard to believe that cross-version differences in the do-we-need-a-toast-
table heuristic could result in an observable problem.  So let's just
follow the old version's conclusion about whether a TOAST table is needed.

(If we ever do change needs_toast_table() so much that this conclusion
doesn't apply, we can devise a solution at that time, and hopefully do
it in a less klugy way than 4c6780fd17 did.)

Back-patch to 9.3, like the previous patch.

Discussion: <8110.1462291671@sss.pgh.pa.us>
2016-05-06 22:05:51 -04:00
..
adminpack Update copyrights for 2013 2013-01-01 17:15:01 -05:00
auth_delay Limit values of archive_timeout, post_auth_delay, auth_delay.milliseconds. 2012-11-18 17:15:06 -05:00
auto_explain Fix failure of contrib/auto_explain to print per-node timing information. 2014-09-19 13:19:02 -04:00
btree_gin Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:46 +02:00
btree_gist Fix misc typos. 2015-09-05 11:37:22 +03:00
chkpass Fix volatility markings of some contrib I/O functions. 2014-11-05 11:34:19 -05:00
citext Fix incorrect declaration of citext's regexp_matches() functions. 2015-05-05 15:50:53 -04:00
cube Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:46 +02:00
dblink Fix volatile-safety issue in dblink's materializeQueryResult(). 2015-01-26 15:17:39 -05:00
dict_int Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:46 +02:00
dict_xsyn Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:46 +02:00
dummy_seclabel Update copyrights for 2013 2013-01-01 17:15:01 -05:00
earthdistance Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:46 +02:00
file_fdw Fix contrib/file_fdw's expected file 2015-03-06 11:47:09 -03:00
fuzzystrmatch Add missing va_end() call to a early exit in dmetaphone.c's StringAt(). 2015-01-04 15:35:47 +01:00
hstore Fix IsValidJsonNumber() to notice trailing non-alphanumeric garbage. 2016-02-03 01:39:08 -05:00
intagg Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:46 +02:00
intarray Prevent stack overflow in query-type functions. 2015-10-05 10:06:34 -04:00
isn contrib/isn now needs a .gitignore file. 2015-08-02 23:57:51 -04:00
lo Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:46 +02:00
ltree ltree: Zero padding bytes when allocating memory for externally visible data. 2016-03-08 14:59:29 -08:00
oid2name Remove tabs after spaces in C comments 2014-05-06 11:26:28 -04:00
pageinspect Remove unused macros. 2016-05-02 10:09:03 +03:00
passwordcheck Update copyrights for 2013 2013-01-01 17:15:01 -05:00
pg_archivecleanup Remove tabs after spaces in C comments 2014-05-06 11:26:28 -04:00
pg_buffercache Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:46 +02:00
pg_freespacemap Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:46 +02:00
pg_standby pg_standby: Avoid writing one byte beyond the end of the buffer. 2015-01-15 09:29:55 -05:00
pg_stat_statements Avoid unlikely data-loss scenarios due to rename() without fsync. 2016-03-09 18:53:54 -08:00
pg_test_fsync Avoid file descriptor leak in pg_test_fsync. 2014-11-19 12:14:22 -05:00
pg_test_timing Correctly handle test durations of more than 2147s in pg_test_timing. 2015-01-04 15:53:08 +01:00
pg_trgm Fix volatility markings of some contrib I/O functions. 2014-11-05 11:34:19 -05:00
pg_upgrade Fix pg_upgrade to not fail when new-cluster TOAST rules differ from old. 2016-05-06 22:05:51 -04:00
pg_upgrade_support Update copyrights for 2013 2013-01-01 17:15:01 -05:00
pg_xlogdump Sort $(wildcard) output where needed for reproducible build output. 2016-01-05 15:47:05 -05:00
pgbench Fix "pg_bench -C -M prepared". 2016-03-16 23:18:07 -04:00
pgcrypto Add forgotten CHECK_FOR_INTERRUPT calls in pgcrypto's crypt() 2015-12-27 13:03:19 -03:00
pgrowlocks Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:46 +02:00
pgstattuple Remove unused macros. 2016-05-02 10:09:03 +03:00
postgres_fdw Improve handling of collations in contrib/postgres_fdw. 2015-09-24 12:47:30 -04:00
seg Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:46 +02:00
sepgsql Fix sepgsql regression tests. 2015-08-30 11:11:08 -07:00
spi Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:46 +02:00
sslinfo Fix error message wording in previous sslinfo commit 2015-09-08 11:10:20 -03:00
start-scripts Remove dead URL mention in OSX startup script 2013-09-04 17:04:57 -04:00
tablefunc Handle unexpected query results, especially NULLs, safely in connectby(). 2015-01-29 20:18:40 -05:00
tcn Remove tabs after spaces in C comments 2014-05-06 11:26:28 -04:00
test_parser Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:46 +02:00
tsearch2 Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:46 +02:00
unaccent Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:46 +02:00
uuid-ossp Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:46 +02:00
vacuumlo pgindent run for release 9.3 2013-05-29 16:58:43 -04:00
worker_spi Remove tabs after spaces in C comments 2014-05-06 11:26:28 -04:00
xml2 Free libxml2/libxslt resources in a safer order. 2014-11-27 11:12:51 -05:00
contrib-global.mk Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
Makefile contrib/Makefile also needs updated 2013-02-22 18:56:42 -03:00
README Update contrib/README 2012-04-14 09:29:54 +03:00

README 

The PostgreSQL contrib tree
---------------------------

This subtree contains porting tools, analysis utilities, and plug-in
features that are not part of the core PostgreSQL system, mainly
because they address a limited audience or are too experimental to be
part of the main source tree.  This does not preclude their
usefulness.

User documentation for each module appears in the main SGML
documentation.

When building from the source distribution, these modules are not
built automatically, unless you build the "world" target.  You can
also build and install them all by running "gmake all" and "gmake
install" in this directory; or to build and install just one selected
module, do the same in that module's subdirectory.

Some directories supply new user-defined functions, operators, or
types.  To make use of one of these modules, after you have installed
the code you need to register the new SQL objects in the database
system by executing a CREATE EXTENSION command.  In a fresh database,
you can simply do

    CREATE EXTENSION module_name;

See the PostgreSQL documentation for more information about this
procedure.