postgres/contrib/file_fdw
Tom Lane aa87f69c00 Disallow "=" in names of reloptions and foreign-data options.
We store values for these options as array elements with the syntax
"name=value", hence a name containing "=" confuses matters when
it's time to read the array back in.  Since validation of the
options is often done (long) after this conversion to array format,
that leads to confusing and off-point error messages.  We can
improve matters by rejecting names containing "=" up-front.

(Probably a better design would have involved pairs of array
elements, but it's too late now --- and anyway, there's no
evident use-case for option names like this.  We already
reject such names in some other contexts such as GUCs.)

Reported-by: Chapman Flack <jcflack@acm.org>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Chapman Flack <jcflack@acm.org>
Discussion: https://postgr.es/m/6830EB30.8090904@acm.org
Backpatch-through: 13
2025-06-02 15:22:44 -04:00
..
data file_fdw: Add REJECT_LIMIT option to file_fdw. 2024-11-20 23:53:19 +09:00
expected Disallow "=" in names of reloptions and foreign-data options. 2025-06-02 15:22:44 -04:00
sql Disallow "=" in names of reloptions and foreign-data options. 2025-06-02 15:22:44 -04:00
.gitignore Support "make check" in contrib 2011-04-25 22:27:11 +03:00
file_fdw--1.0.sql Throw a useful error message if an extension script file is fed to psql. 2011-10-12 15:45:03 -04:00
file_fdw.c Use PRI?64 instead of "ll?" in format strings (continued). 2025-03-29 10:43:57 +01:00
file_fdw.control
Makefile Remove dynamic translation of regression test scripts, step 2. 2021-12-20 14:15:52 -05:00
meson.build Update copyright for 2025 2025-01-01 11:21:55 -05:00