mirror of
https://github.com/zebrajr/postgres.git
synced 2025-12-07 12:20:31 +01:00
370b28ccd4
contrib/pageinspect's tuple_data_split() function thought it could get away with opening the referenced relation with NoLock. In practice there's no guarantee that the current session holds any lock on that rel (even if we just read a page from it), so that this is unsafe. Switch to using AccessShareLock. Also, postpone closing the relation, so that we needn't copy its tupdesc. Also, fix unsafe use of att_isnull() for attributes past the end of the tuple. Per testing with a patch that complains if we open a relation without holding any lock on it. I don't plan to back-patch that patch, but we should close the holes it identifies in all supported branches. Discussion: https://postgr.es/m/2038.1538335244@sss.pgh.pa.us |
||
|---|---|---|
| .. | ||
| expected | ||
| sql | ||
| .gitignore | ||
| brinfuncs.c | ||
| btreefuncs.c | ||
| fsmfuncs.c | ||
| ginfuncs.c | ||
| hashfuncs.c | ||
| heapfuncs.c | ||
| Makefile | ||
| pageinspect--1.1--1.2.sql | ||
| pageinspect--1.2--1.3.sql | ||
| pageinspect--1.3--1.4.sql | ||
| pageinspect--1.4--1.5.sql | ||
| pageinspect--1.5--1.6.sql | ||
| pageinspect--1.5.sql | ||
| pageinspect--1.0--1.1.sql | ||
| pageinspect--unpackaged--1.0.sql | ||
| pageinspect.control | ||
| pageinspect.h | ||
| rawpage.c | ||