Tom Lane 6d30fb1f75 Make SPI_fnumber() reject dropped columns. ... There's basically no scenario where it's sensible for this to match dropped columns, so put a test for dropped-ness into SPI_fnumber() itself, and excise the test from the small number of callers that were paying attention to the case. (Most weren't :-(.) In passing, normalize tests at call sites: always reject attnum <= 0 if we're disallowing system columns. Previously there was a mixture of "< 0" and "<= 0" tests. This makes no practical difference since SPI_fnumber() never returns 0, but I'm feeling pedantic today. Also, in the places that are actually live user-facing code and not legacy cruft, distinguish "column not found" from "can't handle system column". Per discussion with Jim Nasby; thi supersedes his original patch that just changed the behavior at one call site. Discussion: <b2de8258-c4c0-1cb8-7b97-e8538e5c975c@BlueTreble.com>		2016-11-08 13:11:26 -05:00
..
autoinc--1.0.sql	Throw a useful error message if an extension script file is fed to psql.	2011-10-12 15:45:03 -04:00
autoinc--unpackaged--1.0.sql	Fix typos in some error messages thrown by extension scripts when fed to psql.	2014-08-25 18:30:37 +02:00
autoinc.c	Make SPI_fnumber() reject dropped columns.	2016-11-08 13:11:26 -05:00
autoinc.control	Convert contrib modules to use the extension facility.	2011-02-13 22:54:49 -05:00
autoinc.example	Remove useless whitespace at end of lines	2010-11-23 22:34:55 +02:00
insert_username--1.0.sql	Throw a useful error message if an extension script file is fed to psql.	2011-10-12 15:45:03 -04:00
insert_username--unpackaged--1.0.sql	Fix typos in some error messages thrown by extension scripts when fed to psql.	2014-08-25 18:30:37 +02:00
insert_username.c	Make SPI_fnumber() reject dropped columns.	2016-11-08 13:11:26 -05:00
insert_username.control	Convert contrib modules to use the extension facility.	2011-02-13 22:54:49 -05:00
insert_username.example	Remove useless whitespace at end of lines	2010-11-23 22:34:55 +02:00
Makefile	Add file version information to most installed Windows binaries.	2014-07-14 14:07:52 -04:00
moddatetime--1.0.sql	Throw a useful error message if an extension script file is fed to psql.	2011-10-12 15:45:03 -04:00
moddatetime--unpackaged--1.0.sql	Fix typos in some error messages thrown by extension scripts when fed to psql.	2014-08-25 18:30:37 +02:00
moddatetime.c	Make SPI_fnumber() reject dropped columns.	2016-11-08 13:11:26 -05:00
moddatetime.control	Convert contrib modules to use the extension facility.	2011-02-13 22:54:49 -05:00
moddatetime.example	Remove useless whitespace at end of lines	2010-11-23 22:34:55 +02:00
refint--1.0.sql	Throw a useful error message if an extension script file is fed to psql.	2011-10-12 15:45:03 -04:00
refint--unpackaged--1.0.sql	Fix typos in some error messages thrown by extension scripts when fed to psql.	2014-08-25 18:30:37 +02:00
refint.c	Make SPI_fnumber() reject dropped columns.	2016-11-08 13:11:26 -05:00
refint.control	Convert contrib modules to use the extension facility.	2011-02-13 22:54:49 -05:00
refint.example	Remove useless whitespace at end of lines	2010-11-23 22:34:55 +02:00
timetravel--1.0.sql	Throw a useful error message if an extension script file is fed to psql.	2011-10-12 15:45:03 -04:00
timetravel--unpackaged--1.0.sql	Fix typos in some error messages thrown by extension scripts when fed to psql.	2014-08-25 18:30:37 +02:00
timetravel.c	Make SPI_fnumber() reject dropped columns.	2016-11-08 13:11:26 -05:00
timetravel.control	Convert contrib modules to use the extension facility.	2011-02-13 22:54:49 -05:00
timetravel.example	Remove useless whitespace at end of lines	2010-11-23 22:34:55 +02:00