postgres/src
David Rowley 55b4966365 Fix misleading comment for get_cheapest_group_keys_order
The header comment for get_cheapest_group_keys_order() claimed that the
output arguments were set to a newly allocated list which may be freed by
the calling function, however, this was not always true as the function
would simply leave these arguments untouched in some cases.

This tripped me up when working on 1349d2790 as I mistakenly assumed I
could perform a list_concat with the output parameters.  That turned out
bad due to list_concat modifying the original input lists.

In passing, make it more clear that the number of distinct values is
important to reduce tiebreaks during sorts.  Also, explain what the
n_preordered parameter means.

Backpatch-through: 15, where get_cheapest_group_keys_order was introduced.
2022-09-20 10:03:26 +12:00
..
backend Fix misleading comment for get_cheapest_group_keys_order 2022-09-20 10:03:26 +12:00
bin walmethods.c/h: Make WalWriteMethod more object-oriented. 2022-09-19 12:53:46 -04:00
common Simplify handling of compression level with compression specifications 2022-09-14 12:16:57 +09:00
fe_utils Clean up inconsistent use of fflush(). 2022-08-29 13:55:41 -04:00
include Future-proof the recursion inside ExecShutdownNode(). 2022-09-19 12:16:07 -04:00
interfaces Fix possible omission of variable storage markers in ECPG. 2022-09-09 15:34:04 -04:00
makefiles aix: No need to use mkldexport when we want to export all symbols 2022-09-09 19:11:49 -07:00
pl Improve plpgsql's ability to handle arguments declared as RECORD. 2022-09-16 13:23:01 -04:00
port Include c.h instead of postgres.h in src/port/*p{read,write}*.c 2022-09-17 09:21:59 -07:00
template Move darwin sysroot determination into separate file 2022-09-01 16:54:19 -07:00
test Remove various duplicated words 2022-09-20 08:37:02 +12:00
timezone Expand the use of get_dirent_type(), shaving a few calls to stat()/lstat() 2022-09-02 16:58:06 +09:00
tools Fix failure to build gramparse.h standalone in vpath builds 2022-09-14 14:37:19 +07:00
tutorial Update copyright for 2022 2022-01-07 19:04:57 -05:00
.gitignore
DEVELOPERS
Makefile
Makefile.global.in Remove DLLTOOL, DLLWRAP from configure / Makefile.global.in 2022-09-17 09:15:12 -07:00
Makefile.shlib aix: No need to use mkldexport when we want to export all symbols 2022-09-09 19:11:49 -07:00
nls-global.mk Fix for make unportability 2022-07-13 09:15:01 +02:00