mirror of
https://github.com/zebrajr/postgres.git
synced 2025-12-06 12:20:15 +01:00
0da06d9faf
Writing a trailing semicolon in a macro is almost never the right thing, because you almost always want to write a semicolon after each macro call instead. (Even if there was some reason to prefer not to, pgindent would probably make a hash of code formatted that way; so within PG the rule should basically be "don't do it".) Thus, if we have a semi inside the macro, the compiler sees "something;;". Much of the time the extra empty statement is harmless, but it could lead to mysterious syntax errors at call sites. In perhaps an overabundance of neatnik-ism, let's run around and get rid of the excess semicolons whereever possible. The only thing worse than a mysterious syntax error is a mysterious syntax error that only happens in the back branches; therefore, backpatch these changes where relevant, which is most of them because most of these mistakes are old. (The lack of reported problems shows that this is largely a hypothetical issue, but still, it could bite us in some future patch.) John Naylor and Tom Lane Discussion: https://postgr.es/m/CACPNZCs0qWTqJ2QUSGJ07B7uvAvzMb-KbG2q+oo+J3tsWN5cqw@mail.gmail.com |
||
|---|---|---|
| .. | ||
| data | ||
| expected | ||
| sql | ||
| .gitignore | ||
| btree_bit.c | ||
| btree_bytea.c | ||
| btree_cash.c | ||
| btree_date.c | ||
| btree_enum.c | ||
| btree_float4.c | ||
| btree_float8.c | ||
| btree_gist--1.1--1.2.sql | ||
| btree_gist--1.2--1.3.sql | ||
| btree_gist--1.2.sql | ||
| btree_gist--1.3--1.4.sql | ||
| btree_gist--1.4--1.5.sql | ||
| btree_gist--1.0--1.1.sql | ||
| btree_gist.c | ||
| btree_gist.control | ||
| btree_gist.h | ||
| btree_inet.c | ||
| btree_int2.c | ||
| btree_int4.c | ||
| btree_int8.c | ||
| btree_interval.c | ||
| btree_macaddr.c | ||
| btree_macaddr8.c | ||
| btree_numeric.c | ||
| btree_oid.c | ||
| btree_text.c | ||
| btree_time.c | ||
| btree_ts.c | ||
| btree_utils_num.c | ||
| btree_utils_num.h | ||
| btree_utils_var.c | ||
| btree_utils_var.h | ||
| btree_uuid.c | ||
| Makefile | ||