David Rowley 2470ca435c Use CompactAttribute more often, when possible ... 5983a4cff added CompactAttribute for storing commonly used fields from FormData_pg_attribute. 5983a4cff didn't go to the trouble of adjusting every location where we can use CompactAttribute rather than FormData_pg_attribute, so here we change the remaining ones. There are some locations where I've left the code using FormData_pg_attribute. These are mostly in the ALTER TABLE code. Using CompactAttribute here seems more risky as often the TupleDesc is being changed and those changes may not have been flushed to the CompactAttribute yet. I've also left record_recv(), record_send(), record_cmp(), record_eq() and record_image_eq() alone as it's not clear to me that accessing the CompactAttribute is a win here due to the FormData_pg_attribute still having to be accessed for most cases. Switching the relevant parts to use CompactAttribute would result in having to access both for common cases. Careful benchmarking may reveal that something can be done to make this better, but in absence of that, the safer option is to leave these alone. In ReorderBufferToastReplace(), there was a check to skip attnums < 0 while looping over the TupleDesc. Doing this is redundant since TupleDescs don't store < 0 attnums. Removing that code allows us to move to using CompactAttribute. The change in validateDomainCheckConstraint() just moves fetching the FormData_pg_attribute into the ERROR path, which is cold due to calling errstart_cold() and results in code being moved out of the common path. Author: David Rowley <dgrowleyml@gmail.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/CAApHDvrMy90o1Lgkt31F82tcSuwRFHq3vyGewSRN=-QuSEEvyQ@mail.gmail.com		2025-10-22 11:36:26 +13:00
..
data	file_fdw: Add REJECT_LIMIT option to file_fdw.	2024-11-20 23:53:19 +09:00
expected	Keep track of what RTIs a Result node is scanning.	2025-09-23 09:07:55 -04:00
sql	Disallow "=" in names of reloptions and foreign-data options.	2025-06-02 15:22:44 -04:00
.gitignore	Support "make check" in contrib	2011-04-25 22:27:11 +03:00
file_fdw--1.0.sql	Throw a useful error message if an extension script file is fed to psql.	2011-10-12 15:45:03 -04:00
file_fdw.c	Use CompactAttribute more often, when possible	2025-10-22 11:36:26 +13:00
file_fdw.control
Makefile	Remove dynamic translation of regression test scripts, step 2.	2021-12-20 14:15:52 -05:00
meson.build	Update copyright for 2025	2025-01-01 11:21:55 -05:00