OSSForks/opencv
1
0
Fork 0
mirror of https://github.com/zebrajr/opencv.git synced 2025-12-06 12:19:50 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #27738 from arrzhev:fix_memoryleak_pybindings

Browse Source 
Fix memory leaks in pybindings
This commit is contained in:
Alexander Smorkalov 2025-09-09 14:46:50 +03:00 committed by GitHub
commit 3a21ed56e3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
modules/python/src2/cv2_convert.cpp
View File

@ -267,10 +267,12 @@ bool pyopencv_to(PyObject* o, Mat& m, const ArgInfo& info)
const int sz2 = 4; // Scalar has 4 elements.
m = Mat::zeros(sz2, 1, CV_64F);
// Fill the Mat with array elements
bool filled = true;
const char *base_ptr = PyArray_BYTES(oarr);
for(int i = 0; i < sz; i++ )
for(int i = 0; i < sz && filled; i++ )
{
PyObject* oi = PyArray_GETITEM(oarr, base_ptr + step[0] * i);
PyObject* oi = PyArray_GETITEM(oarr, base_ptr + step[0] * i); // new object
if( PyInt_Check(oi) )
m.at<double>(i) = (double)PyInt_AsLong(oi);
else if( PyFloat_Check(oi) )
@ -279,10 +281,16 @@ bool pyopencv_to(PyObject* o, Mat& m, const ArgInfo& info)
{
failmsg("%s has some non-numerical elements", info.name);
m.release();
return false;
filled = false;
}
Py_DECREF(oi);
}
return true;
if(needcopy)
Py_DECREF(o);
return filled;
}
// handle degenerate case