mirror of
https://github.com/zebrajr/node.git
synced 2025-12-06 12:20:27 +01:00
e41ccd4e2d
Added a new struct CallbackBundle to eliminate all GetInternalField() calls. The principle is to store all required data inside a C++ struct, and then store the pointer in the JavaScript object. Before this change, the required data are stored in the JavaScript object in 3 or 4 seperate pointers. For every napi fun call, 3 of them have to be fetched out, which are 3 GetInternalField() calls; after this change, the C++ struct will be directly fetched out by using v8::External::Value(), which is faster. Profiling data show that GetInternalField() is slow. On an i7-4770K (3.50GHz) box, a C++ V8-binding fun call is 8 ns, before this change, napi fun call is 36 ns; after this change, napi fun call is 20 ns. The above data are measured using a modified benchmark in 'benchmark/misc/function_call'. The modification adds an indicator of the average time of a "chatty" napi fun call (max 50M runs). This change will speed up chatty case 1.8x (overall), and will cut down the delay of napi mechanism to approx. 0.5x. Background: a simple C++ binding function (e.g. receiving little from JS, doing little and returning little to JS) is called 'chatty' case for JS<-->C++ fun call routine. This improvement also applies to getter/setter fun calls. PR-URL: https://github.com/nodejs/node/pull/21072 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
51 lines
1.2 KiB
JavaScript
51 lines
1.2 KiB
JavaScript
// show the difference between calling a short js function
|
|
// relative to a comparable C++ function.
|
|
// Reports n of calls per second.
|
|
// Note that JS speed goes up, while cxx speed stays about the same.
|
|
'use strict';
|
|
|
|
const assert = require('assert');
|
|
const common = require('../../common.js');
|
|
|
|
// this fails when we try to open with a different version of node,
|
|
// which is quite common for benchmarks. so in that case, just
|
|
// abort quietly.
|
|
|
|
try {
|
|
var binding = require('./build/Release/binding');
|
|
} catch (er) {
|
|
console.error('misc/function_call.js Binding failed to load');
|
|
process.exit(0);
|
|
}
|
|
const cxx = binding.hello;
|
|
|
|
let napi_binding;
|
|
try {
|
|
napi_binding = require('./build/Release/napi_binding');
|
|
} catch (er) {
|
|
console.error('misc/function_call/index.js NAPI-Binding failed to load');
|
|
process.exit(0);
|
|
}
|
|
const napi = napi_binding.hello;
|
|
|
|
var c = 0;
|
|
function js() {
|
|
return c++;
|
|
}
|
|
|
|
assert(js() === cxx());
|
|
|
|
const bench = common.createBenchmark(main, {
|
|
type: ['js', 'cxx', 'napi'],
|
|
n: [1e6, 1e7, 5e7]
|
|
});
|
|
|
|
function main({ n, type }) {
|
|
const fn = type === 'cxx' ? cxx : type === 'napi' ? napi : js;
|
|
bench.start();
|
|
for (var i = 0; i < n; i++) {
|
|
fn();
|
|
}
|
|
bench.end(n);
|
|
}
|