mirror of
https://github.com/zebrajr/node.git
synced 2025-12-06 12:20:27 +01:00
- Do not call `client.end()` to ensure that the socket is closed by the server. - Remove the timer and send the empty line when the response is received. Fixes: https://github.com/nodejs/node/issues/59577 PR-URL: https://github.com/nodejs/node/pull/59595 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
56 lines
1.4 KiB
JavaScript
56 lines
1.4 KiB
JavaScript
import * as common from '../common/index.mjs';
|
|
import assert from 'node:assert';
|
|
import { createServer } from 'node:http';
|
|
import { connect } from 'node:net';
|
|
|
|
// This test ensures that data like an empty line (`\r\n`) recevied by the
|
|
// server after a request, does not reset the keep-alive timeout. See
|
|
// https://github.com/nodejs/node/issues/58140.
|
|
|
|
const server = createServer({
|
|
connectionsCheckingInterval: 100,
|
|
headersTimeout: 100,
|
|
keepAliveTimeout: 300
|
|
}, (req, res) => {
|
|
res.writeHead(404);
|
|
res.end();
|
|
|
|
req.socket.on('close', common.mustCall(() => {
|
|
server.close();
|
|
}));
|
|
});
|
|
|
|
server.listen(0, () => {
|
|
const client = connect({
|
|
host: 'localhost',
|
|
port: server.address().port,
|
|
}, () => {
|
|
client.write(
|
|
'GET / HTTP/1.1\r\n' +
|
|
'Host: localhost:3000\r\n' +
|
|
'Content-Length: 0\r\n' +
|
|
'\r\n'
|
|
);
|
|
|
|
let response = '';
|
|
let responseReceived = false;
|
|
|
|
client.setEncoding('utf-8');
|
|
client.on('data', (chunk) => {
|
|
response += chunk;
|
|
|
|
// Check if we've received the full header (ending with \r\n\r\n)
|
|
if (response.includes('\r\n\r\n')) {
|
|
responseReceived = true;
|
|
const statusLine = response.split('\r\n')[0];
|
|
const status = statusLine.split(' ')[1];
|
|
assert.strictEqual(status, '404');
|
|
client.write('\r\n');
|
|
}
|
|
});
|
|
client.on('end', common.mustCall(() => {
|
|
assert.ok(responseReceived);
|
|
}));
|
|
});
|
|
});
|